[INFO] cloning repository https://github.com/adamj-w/movie-tracker [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/adamj-w/movie-tracker" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadamj-w%2Fmovie-tracker", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadamj-w%2Fmovie-tracker'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3bed43b0c584d7156060d649c94bb144fc020d38 [INFO] checking adamj-w/movie-tracker against try#4f260f0f20b3133d20cfb50353c0221943af5796+rustflags=-Dunmustuse_in_always_ok for pr-148577 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadamj-w%2Fmovie-tracker" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/adamj-w/movie-tracker [INFO] finished tweaking git repo https://github.com/adamj-w/movie-tracker [INFO] tweaked toml for git repo https://github.com/adamj-w/movie-tracker written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/adamj-w/movie-tracker on toolchain 4f260f0f20b3133d20cfb50353c0221943af5796 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/adamj-w/movie-tracker already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4848fb76d95f26979359cc7e45710b1dbc8f3acb7aeedee7c460d7702230f228" "/opt/rustwide/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 31c900ab6e279aa2067228a65d48ebc2d4fa8ad53964a50e097832cf2b9d027e [INFO] running `Command { std: "docker" "start" "-a" "31c900ab6e279aa2067228a65d48ebc2d4fa8ad53964a50e097832cf2b9d027e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "31c900ab6e279aa2067228a65d48ebc2d4fa8ad53964a50e097832cf2b9d027e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "31c900ab6e279aa2067228a65d48ebc2d4fa8ad53964a50e097832cf2b9d027e", kill_on_drop: false }` [INFO] [stdout] 31c900ab6e279aa2067228a65d48ebc2d4fa8ad53964a50e097832cf2b9d027e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dunmustuse_in_always_ok" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4848fb76d95f26979359cc7e45710b1dbc8f3acb7aeedee7c460d7702230f228" "/opt/rustwide/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ec713c8eff7d66c7db09816104e94eac838490f59b910b3360ee0626e50b6a2a [INFO] running `Command { std: "docker" "start" "-a" "ec713c8eff7d66c7db09816104e94eac838490f59b910b3360ee0626e50b6a2a", kill_on_drop: false }` [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking memchr v2.7.6 [INFO] [stderr] Checking unicode-width v0.2.2 [INFO] [stderr] Compiling cli-table-derive v0.5.0 [INFO] [stderr] Checking csv-core v0.1.13 [INFO] [stderr] Checking csv v1.4.0 [INFO] [stderr] Checking cli-table v0.5.0 [INFO] [stderr] Checking movie-tracker v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `title` [INFO] [stdout] --> src/storage.rs:123:28 [INFO] [stdout] | [INFO] [stdout] 123 | fn get_by_title(&self, title: &str) -> Result, StorageError> { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_title` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `query` [INFO] [stdout] --> src/storage.rs:127:22 [INFO] [stdout] | [INFO] [stdout] 127 | fn search(&self, query: &str) -> Result, StorageError> { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_query` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `movie` [INFO] [stdout] --> src/storage.rs:131:23 [INFO] [stdout] | [INFO] [stdout] 131 | fn add(&mut self, movie: Movie) -> Result<(), StorageError> { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_movie` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `movie` [INFO] [stdout] --> src/storage.rs:135:26 [INFO] [stdout] | [INFO] [stdout] 135 | fn update(&mut self, movie: &Movie) -> Result<(), StorageError> { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_movie` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `movie` [INFO] [stdout] --> src/storage.rs:139:32 [INFO] [stdout] | [INFO] [stdout] 139 | fn mark_watched(&mut self, movie: &Movie) -> Result<(), StorageError> { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_movie` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `movie` [INFO] [stdout] --> src/storage.rs:143:26 [INFO] [stdout] | [INFO] [stdout] 143 | fn remove(&mut self, movie: &Movie) -> Result<(), StorageError> { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_movie` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `movie` [INFO] [stdout] --> src/storage.rs:147:24 [INFO] [stdout] | [INFO] [stdout] 147 | fn save(&mut self, movie: &Movie) -> Result<(), StorageError> { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_movie` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `movie-tracker` (lib) due to 4 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `title` [INFO] [stdout] --> src/storage.rs:123:28 [INFO] [stdout] | [INFO] [stdout] 123 | fn get_by_title(&self, title: &str) -> Result, StorageError> { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_title` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `query` [INFO] [stdout] --> src/storage.rs:127:22 [INFO] [stdout] | [INFO] [stdout] 127 | fn search(&self, query: &str) -> Result, StorageError> { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_query` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `movie` [INFO] [stdout] --> src/storage.rs:131:23 [INFO] [stdout] | [INFO] [stdout] 131 | fn add(&mut self, movie: Movie) -> Result<(), StorageError> { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_movie` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `movie` [INFO] [stdout] --> src/storage.rs:135:26 [INFO] [stdout] | [INFO] [stdout] 135 | fn update(&mut self, movie: &Movie) -> Result<(), StorageError> { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_movie` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `movie` [INFO] [stdout] --> src/storage.rs:139:32 [INFO] [stdout] | [INFO] [stdout] 139 | fn mark_watched(&mut self, movie: &Movie) -> Result<(), StorageError> { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_movie` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result, StorageError> [INFO] [stdout] --> src/storage.rs:115:59 [INFO] [stdout] | [INFO] [stdout] 115 | fn get_all(&self) -> Result, StorageError> { [INFO] [stdout] | ___________________________________________________________^ [INFO] [stdout] 116 | | Ok(self [INFO] [stdout] 117 | | .movies [INFO] [stdout] 118 | | .values() [INFO] [stdout] 119 | | .map(|movie| movie.clone()) [INFO] [stdout] 120 | | .collect::>()) [INFO] [stdout] 121 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-D unmustuse-in-always-ok` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `movie` [INFO] [stdout] --> src/storage.rs:143:26 [INFO] [stdout] | [INFO] [stdout] 143 | fn remove(&mut self, movie: &Movie) -> Result<(), StorageError> { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_movie` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result, StorageError> [INFO] [stdout] --> src/storage.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 116 | / Ok(self [INFO] [stdout] 117 | | .movies [INFO] [stdout] 118 | | .values() [INFO] [stdout] 119 | | .map(|movie| movie.clone()) [INFO] [stdout] 120 | | .collect::>()) [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `movie` [INFO] [stdout] --> src/storage.rs:147:24 [INFO] [stdout] | [INFO] [stdout] 147 | fn save(&mut self, movie: &Movie) -> Result<(), StorageError> { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_movie` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result, StorageError> [INFO] [stdout] --> src/storage.rs:123:80 [INFO] [stdout] | [INFO] [stdout] 123 | fn get_by_title(&self, title: &str) -> Result, StorageError> { [INFO] [stdout] | ________________________________________________________________________________^ [INFO] [stdout] 124 | | todo!() [INFO] [stdout] 125 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result, StorageError> [INFO] [stdout] --> src/storage.rs:127:71 [INFO] [stdout] | [INFO] [stdout] 127 | fn search(&self, query: &str) -> Result, StorageError> { [INFO] [stdout] | _______________________________________________________________________^ [INFO] [stdout] 128 | | todo!() [INFO] [stdout] 129 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result, StorageError> [INFO] [stdout] --> src/storage.rs:115:59 [INFO] [stdout] | [INFO] [stdout] 115 | fn get_all(&self) -> Result, StorageError> { [INFO] [stdout] | ___________________________________________________________^ [INFO] [stdout] 116 | | Ok(self [INFO] [stdout] 117 | | .movies [INFO] [stdout] 118 | | .values() [INFO] [stdout] 119 | | .map(|movie| movie.clone()) [INFO] [stdout] 120 | | .collect::>()) [INFO] [stdout] 121 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-D unmustuse-in-always-ok` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result, StorageError> [INFO] [stdout] --> src/storage.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 116 | / Ok(self [INFO] [stdout] 117 | | .movies [INFO] [stdout] 118 | | .values() [INFO] [stdout] 119 | | .map(|movie| movie.clone()) [INFO] [stdout] 120 | | .collect::>()) [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result, StorageError> [INFO] [stdout] --> src/storage.rs:123:80 [INFO] [stdout] | [INFO] [stdout] 123 | fn get_by_title(&self, title: &str) -> Result, StorageError> { [INFO] [stdout] | ________________________________________________________________________________^ [INFO] [stdout] 124 | | todo!() [INFO] [stdout] 125 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result, StorageError> [INFO] [stdout] --> src/storage.rs:127:71 [INFO] [stdout] | [INFO] [stdout] 127 | fn search(&self, query: &str) -> Result, StorageError> { [INFO] [stdout] | _______________________________________________________________________^ [INFO] [stdout] 128 | | todo!() [INFO] [stdout] 129 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `movie-tracker` (lib test) due to 4 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "ec713c8eff7d66c7db09816104e94eac838490f59b910b3360ee0626e50b6a2a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ec713c8eff7d66c7db09816104e94eac838490f59b910b3360ee0626e50b6a2a", kill_on_drop: false }` [INFO] [stdout] ec713c8eff7d66c7db09816104e94eac838490f59b910b3360ee0626e50b6a2a