[INFO] cloning repository https://github.com/Roundabout1776/almanacx [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Roundabout1776/almanacx" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRoundabout1776%2Falmanacx", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRoundabout1776%2Falmanacx'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d2a9c776b2849c368fc3ae83075e5ae5d12c6981 [INFO] checking Roundabout1776/almanacx against try#4f260f0f20b3133d20cfb50353c0221943af5796+rustflags=-Dunmustuse_in_always_ok for pr-148577 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRoundabout1776%2Falmanacx" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Roundabout1776/almanacx [INFO] finished tweaking git repo https://github.com/Roundabout1776/almanacx [INFO] tweaked toml for git repo https://github.com/Roundabout1776/almanacx written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Roundabout1776/almanacx on toolchain 4f260f0f20b3133d20cfb50353c0221943af5796 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Roundabout1776/almanacx already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4848fb76d95f26979359cc7e45710b1dbc8f3acb7aeedee7c460d7702230f228" "/opt/rustwide/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 892f0dd98750628a4260cb4775ba28ae65012d04f02c814acf8b02aa59471647 [INFO] running `Command { std: "docker" "start" "-a" "892f0dd98750628a4260cb4775ba28ae65012d04f02c814acf8b02aa59471647", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "892f0dd98750628a4260cb4775ba28ae65012d04f02c814acf8b02aa59471647", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "892f0dd98750628a4260cb4775ba28ae65012d04f02c814acf8b02aa59471647", kill_on_drop: false }` [INFO] [stdout] 892f0dd98750628a4260cb4775ba28ae65012d04f02c814acf8b02aa59471647 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dunmustuse_in_always_ok" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4848fb76d95f26979359cc7e45710b1dbc8f3acb7aeedee7c460d7702230f228" "/opt/rustwide/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a49a3d272446dc035fc61eea0e6979b3dc0e25d59f40dc26af667284ec7b034e [INFO] running `Command { std: "docker" "start" "-a" "a49a3d272446dc035fc61eea0e6979b3dc0e25d59f40dc26af667284ec7b034e", kill_on_drop: false }` [INFO] [stderr] Compiling version-compare v0.1.0 [INFO] [stderr] Compiling libc v0.2.137 [INFO] [stderr] Compiling cgmath v0.18.0 [INFO] [stderr] Compiling sdl2 v0.35.2 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling sdl2-sys v0.35.2 [INFO] [stderr] Checking approx v0.4.0 [INFO] [stderr] Checking common v0.0.1 (/opt/rustwide/workdir/common) [INFO] [stdout] warning: unused imports: `ErrorKind` and `self` [INFO] [stdout] --> common/src/image/bmp.rs:3:10 [INFO] [stdout] | [INFO] [stdout] 3 | io::{self, ErrorKind, Read, Seek, SeekFrom}, [INFO] [stdout] | ^^^^ ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Vector4` and `Zero` [INFO] [stdout] --> common/src/math.rs:1:67 [INFO] [stdout] | [INFO] [stdout] 1 | use cgmath::{InnerSpace, Matrix4, SquareMatrix, Vector2, Vector3, Vector4, Zero}; [INFO] [stdout] | ^^^^^^^ ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `InnerSpace`, `Rad`, and `Zero` [INFO] [stdout] --> common/src/renderer/camera.rs:1:14 [INFO] [stdout] | [INFO] [stdout] 1 | use cgmath::{InnerSpace, Matrix4, Rad, SquareMatrix, Vector3, Zero}; [INFO] [stdout] | ^^^^^^^^^^ ^^^ ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `buffer2d::B2DT` [INFO] [stdout] --> common/src/renderer/utils.rs:3:13 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::{buffer2d::B2DT, utils::color_from_tuple}; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `ErrorKind` and `self` [INFO] [stdout] --> common/src/image/bmp.rs:3:10 [INFO] [stdout] | [INFO] [stdout] 3 | io::{self, ErrorKind, Read, Seek, SeekFrom}, [INFO] [stdout] | ^^^^ ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Vector4` and `Zero` [INFO] [stdout] --> common/src/math.rs:1:67 [INFO] [stdout] | [INFO] [stdout] 1 | use cgmath::{InnerSpace, Matrix4, SquareMatrix, Vector2, Vector3, Vector4, Zero}; [INFO] [stdout] | ^^^^^^^ ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `InnerSpace`, `Rad`, and `Zero` [INFO] [stdout] --> common/src/renderer/camera.rs:1:14 [INFO] [stdout] | [INFO] [stdout] 1 | use cgmath::{InnerSpace, Matrix4, Rad, SquareMatrix, Vector3, Zero}; [INFO] [stdout] | ^^^^^^^^^^ ^^^ ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `buffer2d::B2DT` [INFO] [stdout] --> common/src/renderer/utils.rs:3:13 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::{buffer2d::B2DT, utils::color_from_tuple}; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `z` is assigned to, but never used [INFO] [stdout] --> common/src/buffer2d/mod.rs:102:13 [INFO] [stdout] | [INFO] [stdout] 102 | let mut z = z0; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_z` instead [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `z` is never read [INFO] [stdout] --> common/src/buffer2d/mod.rs:105:13 [INFO] [stdout] | [INFO] [stdout] 105 | z += dz; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `origin_reference` [INFO] [stdout] --> common/src/renderer/utils.rs:10:43 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn draw_grid(renderer: &mut Renderer, origin_reference: Vector3, cell_size: f32) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_origin_reference` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> common/src/renderer/mod.rs:89:36 [INFO] [stdout] | [INFO] [stdout] 89 | fn perspective_division(&self, mut pos: &mut Vector4) { [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `shift32` is never used [INFO] [stdout] --> common/src/image/bmp.rs:126:4 [INFO] [stdout] | [INFO] [stdout] 126 | fn shift32(value: u32, shift: u32) -> u32 { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `shift_channels` is never used [INFO] [stdout] --> common/src/image/bmp.rs:130:4 [INFO] [stdout] | [INFO] [stdout] 130 | fn shift_channels( [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `near`, `far`, and `view` are never read [INFO] [stdout] --> common/src/renderer/camera.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct Camera { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 6 | near: f32, [INFO] [stdout] | ^^^^ [INFO] [stdout] 7 | far: f32, [INFO] [stdout] | ^^^ [INFO] [stdout] 8 | pub proj: Matrix4, [INFO] [stdout] 9 | view: Matrix4, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> common/src/buffer2d/mod.rs:42:20 [INFO] [stdout] | [INFO] [stdout] 42 | pub fn as_b2ds(&mut self) -> B2DS { [INFO] [stdout] | ^^^^^^^^^ ^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 42 | pub fn as_b2ds(&mut self) -> B2DS<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `z` is assigned to, but never used [INFO] [stdout] --> common/src/buffer2d/mod.rs:102:13 [INFO] [stdout] | [INFO] [stdout] 102 | let mut z = z0; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_z` instead [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `z` is never read [INFO] [stdout] --> common/src/buffer2d/mod.rs:105:13 [INFO] [stdout] | [INFO] [stdout] 105 | z += dz; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result, Infallible> [INFO] [stdout] --> common/src/utils.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | / buf[offset..offset + 4] [INFO] [stdout] 38 | | .try_into() [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-D unmustuse-in-always-ok` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result, Infallible> [INFO] [stdout] --> common/src/utils.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | / buf[offset..offset + 8] [INFO] [stdout] 48 | | .try_into() [INFO] [stdout] | |_______________________^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `origin_reference` [INFO] [stdout] --> common/src/renderer/utils.rs:10:43 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn draw_grid(renderer: &mut Renderer, origin_reference: Vector3, cell_size: f32) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_origin_reference` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `common` (lib test) due to 2 previous errors; 12 warnings emitted [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> common/src/renderer/mod.rs:89:36 [INFO] [stdout] | [INFO] [stdout] 89 | fn perspective_division(&self, mut pos: &mut Vector4) { [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: function `shift32` is never used [INFO] [stdout] --> common/src/image/bmp.rs:126:4 [INFO] [stdout] | [INFO] [stdout] 126 | fn shift32(value: u32, shift: u32) -> u32 { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `shift_channels` is never used [INFO] [stdout] --> common/src/image/bmp.rs:130:4 [INFO] [stdout] | [INFO] [stdout] 130 | fn shift_channels( [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `near`, `far`, and `view` are never read [INFO] [stdout] --> common/src/renderer/camera.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct Camera { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 6 | near: f32, [INFO] [stdout] | ^^^^ [INFO] [stdout] 7 | far: f32, [INFO] [stdout] | ^^^ [INFO] [stdout] 8 | pub proj: Matrix4, [INFO] [stdout] 9 | view: Matrix4, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> common/src/buffer2d/mod.rs:42:20 [INFO] [stdout] | [INFO] [stdout] 42 | pub fn as_b2ds(&mut self) -> B2DS { [INFO] [stdout] | ^^^^^^^^^ ^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 42 | pub fn as_b2ds(&mut self) -> B2DS<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result, Infallible> [INFO] [stdout] --> common/src/utils.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | / buf[offset..offset + 4] [INFO] [stdout] 38 | | .try_into() [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-D unmustuse-in-always-ok` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result, Infallible> [INFO] [stdout] --> common/src/utils.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | / buf[offset..offset + 8] [INFO] [stdout] 48 | | .try_into() [INFO] [stdout] | |_______________________^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `common` (lib) due to 2 previous errors; 12 warnings emitted [INFO] running `Command { std: "docker" "inspect" "a49a3d272446dc035fc61eea0e6979b3dc0e25d59f40dc26af667284ec7b034e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a49a3d272446dc035fc61eea0e6979b3dc0e25d59f40dc26af667284ec7b034e", kill_on_drop: false }` [INFO] [stdout] a49a3d272446dc035fc61eea0e6979b3dc0e25d59f40dc26af667284ec7b034e