[INFO] cloning repository https://github.com/samuwen/re_flog [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/samuwen/re_flog" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsamuwen%2Fre_flog", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsamuwen%2Fre_flog'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b6698709239e7d2607609f7087697a3c837d73d7 [INFO] checking samuwen/re_flog against master#642c19bfc3a5c1de985bf5d0cc8207ac9d22708a for pr-148577 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsamuwen%2Fre_flog" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/samuwen/re_flog [INFO] finished tweaking git repo https://github.com/samuwen/re_flog [INFO] tweaked toml for git repo https://github.com/samuwen/re_flog written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/samuwen/re_flog on toolchain 642c19bfc3a5c1de985bf5d0cc8207ac9d22708a [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+642c19bfc3a5c1de985bf5d0cc8207ac9d22708a" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/samuwen/re_flog already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+642c19bfc3a5c1de985bf5d0cc8207ac9d22708a" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rustversion v1.0.6 [INFO] [stderr] Downloaded num_threads v0.1.3 [INFO] [stderr] Downloaded derive-getters v0.2.0 [INFO] [stderr] Downloaded clap_derive v3.1.0 [INFO] [stderr] Downloaded quote v1.0.15 [INFO] [stderr] Downloaded time v0.3.7 [INFO] [stderr] Downloaded flexi_logger v0.22.3 [INFO] [stderr] Downloaded crypto-common v0.1.3 [INFO] [stderr] Downloaded time-macros v0.2.3 [INFO] [stderr] Downloaded clap v3.1.0 [INFO] [stderr] Downloaded libc v0.2.118 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4848fb76d95f26979359cc7e45710b1dbc8f3acb7aeedee7c460d7702230f228" "/opt/rustwide/cargo-home/bin/cargo" "+642c19bfc3a5c1de985bf5d0cc8207ac9d22708a" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a209224f6ed370302e5e6e9d90f884bf5949b59b024ed06de3d69b1376024f6c [INFO] running `Command { std: "docker" "start" "-a" "a209224f6ed370302e5e6e9d90f884bf5949b59b024ed06de3d69b1376024f6c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a209224f6ed370302e5e6e9d90f884bf5949b59b024ed06de3d69b1376024f6c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a209224f6ed370302e5e6e9d90f884bf5949b59b024ed06de3d69b1376024f6c", kill_on_drop: false }` [INFO] [stdout] a209224f6ed370302e5e6e9d90f884bf5949b59b024ed06de3d69b1376024f6c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4848fb76d95f26979359cc7e45710b1dbc8f3acb7aeedee7c460d7702230f228" "/opt/rustwide/cargo-home/bin/cargo" "+642c19bfc3a5c1de985bf5d0cc8207ac9d22708a" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6e257efd9d2d329a04aa9c941296aadd5bd0de49f7b8a9eeeb9b394e9f8dc0f4 [INFO] running `Command { std: "docker" "start" "-a" "6e257efd9d2d329a04aa9c941296aadd5bd0de49f7b8a9eeeb9b394e9f8dc0f4", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.86 [INFO] [stderr] Compiling libc v0.2.118 [INFO] [stderr] Compiling typenum v1.15.0 [INFO] [stderr] Compiling generic-array v0.14.5 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling rustversion v1.0.6 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling time-macros v0.2.3 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling indexmap v1.8.0 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Compiling quote v1.0.15 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking num_threads v0.1.3 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Checking textwrap v0.14.2 [INFO] [stderr] Checking cpufeatures v0.2.1 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking glob v0.3.0 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking time v0.3.7 [INFO] [stderr] Checking flate2 v1.0.22 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking crypto-common v0.1.3 [INFO] [stderr] Checking block-buffer v0.10.2 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking digest v0.10.3 [INFO] [stderr] Checking sha-1 v0.10.0 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Compiling clap_derive v3.1.0 [INFO] [stderr] Compiling derive-getters v0.2.0 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking flexi_logger v0.22.3 [INFO] [stderr] Checking clap v3.1.0 [INFO] [stderr] Checking re_flog v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `f` [INFO] [stdout] --> src/structures/index.rs:532:13 [INFO] [stdout] | [INFO] [stdout] 532 | let f = IndexFile::from_disk().unwrap(); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_f` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/commands/write_tree.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | write_tree(false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 30 | let _ = write_tree(false); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/structures/git_objects.rs:158:9 [INFO] [stdout] | [INFO] [stdout] 158 | read_from_disk(sha); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 158 | let _ = read_from_disk(sha); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/structures/sha.rs:100:34 [INFO] [stdout] | [INFO] [stdout] 100 | for dir_entry in read_dir(path) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 100 - for dir_entry in read_dir(path) { [INFO] [stdout] 100 + while let Ok(dir_entry) = read_dir(path) { [INFO] [stdout] | [INFO] [stdout] help: consider unwrapping the `Result` with `?` to iterate over its contents [INFO] [stdout] | [INFO] [stdout] 100 | for dir_entry in read_dir(path)? { [INFO] [stdout] | + [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 100 - for dir_entry in read_dir(path) { [INFO] [stdout] 100 + if let Ok(dir_entry) = read_dir(path) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/structures/sha.rs:100:34 [INFO] [stdout] | [INFO] [stdout] 100 | for dir_entry in read_dir(path) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 100 - for dir_entry in read_dir(path) { [INFO] [stdout] 100 + while let Ok(dir_entry) = read_dir(path) { [INFO] [stdout] | [INFO] [stdout] help: consider unwrapping the `Result` with `?` to iterate over its contents [INFO] [stdout] | [INFO] [stdout] 100 | for dir_entry in read_dir(path)? { [INFO] [stdout] | + [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 100 - for dir_entry in read_dir(path) { [INFO] [stdout] 100 + if let Ok(dir_entry) = read_dir(path) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 13.19s [INFO] running `Command { std: "docker" "inspect" "6e257efd9d2d329a04aa9c941296aadd5bd0de49f7b8a9eeeb9b394e9f8dc0f4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6e257efd9d2d329a04aa9c941296aadd5bd0de49f7b8a9eeeb9b394e9f8dc0f4", kill_on_drop: false }` [INFO] [stdout] 6e257efd9d2d329a04aa9c941296aadd5bd0de49f7b8a9eeeb9b394e9f8dc0f4