[INFO] cloning repository https://github.com/adamj-w/movie-tracker [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/adamj-w/movie-tracker" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadamj-w%2Fmovie-tracker", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadamj-w%2Fmovie-tracker'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3bed43b0c584d7156060d649c94bb144fc020d38 [INFO] checking adamj-w/movie-tracker against master#642c19bfc3a5c1de985bf5d0cc8207ac9d22708a for pr-148577 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadamj-w%2Fmovie-tracker" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/adamj-w/movie-tracker [INFO] finished tweaking git repo https://github.com/adamj-w/movie-tracker [INFO] tweaked toml for git repo https://github.com/adamj-w/movie-tracker written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/adamj-w/movie-tracker on toolchain 642c19bfc3a5c1de985bf5d0cc8207ac9d22708a [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+642c19bfc3a5c1de985bf5d0cc8207ac9d22708a" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/adamj-w/movie-tracker already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+642c19bfc3a5c1de985bf5d0cc8207ac9d22708a" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded csv-core v0.1.13 [INFO] [stderr] Downloaded cli-table-derive v0.5.0 [INFO] [stderr] Downloaded cli-table v0.5.0 [INFO] [stderr] Downloaded csv v1.4.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4848fb76d95f26979359cc7e45710b1dbc8f3acb7aeedee7c460d7702230f228" "/opt/rustwide/cargo-home/bin/cargo" "+642c19bfc3a5c1de985bf5d0cc8207ac9d22708a" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9178b9ce996b9b37fbbd5c36548336abf6a96b4401248632f0c0439e6b257c42 [INFO] running `Command { std: "docker" "start" "-a" "9178b9ce996b9b37fbbd5c36548336abf6a96b4401248632f0c0439e6b257c42", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9178b9ce996b9b37fbbd5c36548336abf6a96b4401248632f0c0439e6b257c42", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9178b9ce996b9b37fbbd5c36548336abf6a96b4401248632f0c0439e6b257c42", kill_on_drop: false }` [INFO] [stdout] 9178b9ce996b9b37fbbd5c36548336abf6a96b4401248632f0c0439e6b257c42 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4848fb76d95f26979359cc7e45710b1dbc8f3acb7aeedee7c460d7702230f228" "/opt/rustwide/cargo-home/bin/cargo" "+642c19bfc3a5c1de985bf5d0cc8207ac9d22708a" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2fd241b5a1d83ad4d6823606f9d9c0dda3f6fe0e6ee041abe769f36c36a95226 [INFO] running `Command { std: "docker" "start" "-a" "2fd241b5a1d83ad4d6823606f9d9c0dda3f6fe0e6ee041abe769f36c36a95226", kill_on_drop: false }` [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking memchr v2.7.6 [INFO] [stderr] Compiling cli-table-derive v0.5.0 [INFO] [stderr] Checking unicode-width v0.2.2 [INFO] [stderr] Checking csv-core v0.1.13 [INFO] [stderr] Checking csv v1.4.0 [INFO] [stderr] Checking cli-table v0.5.0 [INFO] [stderr] Checking movie-tracker v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `title` [INFO] [stdout] --> src/storage.rs:123:28 [INFO] [stdout] | [INFO] [stdout] 123 | fn get_by_title(&self, title: &str) -> Result, StorageError> { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_title` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `query` [INFO] [stdout] --> src/storage.rs:127:22 [INFO] [stdout] | [INFO] [stdout] 127 | fn search(&self, query: &str) -> Result, StorageError> { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_query` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `movie` [INFO] [stdout] --> src/storage.rs:131:23 [INFO] [stdout] | [INFO] [stdout] 131 | fn add(&mut self, movie: Movie) -> Result<(), StorageError> { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_movie` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `movie` [INFO] [stdout] --> src/storage.rs:135:26 [INFO] [stdout] | [INFO] [stdout] 135 | fn update(&mut self, movie: &Movie) -> Result<(), StorageError> { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_movie` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `movie` [INFO] [stdout] --> src/storage.rs:139:32 [INFO] [stdout] | [INFO] [stdout] 139 | fn mark_watched(&mut self, movie: &Movie) -> Result<(), StorageError> { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_movie` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `movie` [INFO] [stdout] --> src/storage.rs:143:26 [INFO] [stdout] | [INFO] [stdout] 143 | fn remove(&mut self, movie: &Movie) -> Result<(), StorageError> { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_movie` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `movie` [INFO] [stdout] --> src/storage.rs:147:24 [INFO] [stdout] | [INFO] [stdout] 147 | fn save(&mut self, movie: &Movie) -> Result<(), StorageError> { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_movie` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `title` [INFO] [stdout] --> src/storage.rs:123:28 [INFO] [stdout] | [INFO] [stdout] 123 | fn get_by_title(&self, title: &str) -> Result, StorageError> { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_title` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `query` [INFO] [stdout] --> src/storage.rs:127:22 [INFO] [stdout] | [INFO] [stdout] 127 | fn search(&self, query: &str) -> Result, StorageError> { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_query` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `movie` [INFO] [stdout] --> src/storage.rs:131:23 [INFO] [stdout] | [INFO] [stdout] 131 | fn add(&mut self, movie: Movie) -> Result<(), StorageError> { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_movie` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `movie` [INFO] [stdout] --> src/storage.rs:135:26 [INFO] [stdout] | [INFO] [stdout] 135 | fn update(&mut self, movie: &Movie) -> Result<(), StorageError> { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_movie` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `movie` [INFO] [stdout] --> src/storage.rs:139:32 [INFO] [stdout] | [INFO] [stdout] 139 | fn mark_watched(&mut self, movie: &Movie) -> Result<(), StorageError> { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_movie` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `movie` [INFO] [stdout] --> src/storage.rs:143:26 [INFO] [stdout] | [INFO] [stdout] 143 | fn remove(&mut self, movie: &Movie) -> Result<(), StorageError> { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_movie` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `movie` [INFO] [stdout] --> src/storage.rs:147:24 [INFO] [stdout] | [INFO] [stdout] 147 | fn save(&mut self, movie: &Movie) -> Result<(), StorageError> { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_movie` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `StorageError` [INFO] [stdout] --> src/commands.rs:19:37 [INFO] [stdout] | [INFO] [stdout] 19 | use movie_tracker::{Movie, Storage, StorageError}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `StorageError` [INFO] [stdout] --> src/commands.rs:19:37 [INFO] [stdout] | [INFO] [stdout] 19 | use movie_tracker::{Movie, Storage, StorageError}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `watched` [INFO] [stdout] --> src/commands.rs:46:40 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn list(storage: Box, watched: bool) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_watched` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:136:9 [INFO] [stdout] | [INFO] [stdout] 136 | let mut storage = Box::new(InMemoryStorage::new()); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `watched` [INFO] [stdout] --> src/commands.rs:46:40 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn list(storage: Box, watched: bool) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_watched` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:136:9 [INFO] [stdout] | [INFO] [stdout] 136 | let mut storage = Box::new(InMemoryStorage::new()); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.49s [INFO] running `Command { std: "docker" "inspect" "2fd241b5a1d83ad4d6823606f9d9c0dda3f6fe0e6ee041abe769f36c36a95226", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2fd241b5a1d83ad4d6823606f9d9c0dda3f6fe0e6ee041abe769f36c36a95226", kill_on_drop: false }` [INFO] [stdout] 2fd241b5a1d83ad4d6823606f9d9c0dda3f6fe0e6ee041abe769f36c36a95226