[INFO] cloning repository https://github.com/woubuc/project-cleanup
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/woubuc/project-cleanup" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwoubuc%2Fproject-cleanup", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwoubuc%2Fproject-cleanup'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 9da553dd4747a4af9dc12d116af87d357e8627b3
[INFO] checking woubuc/project-cleanup against try#4f260f0f20b3133d20cfb50353c0221943af5796+rustflags=-Dunmustuse_in_always_ok for pr-148577
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwoubuc%2Fproject-cleanup" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'...
[INFO] [stderr] done.
[INFO] removed /workspace/builds/worker-7-tc2/source/.cargo/config
[INFO] started tweaking git repo https://github.com/woubuc/project-cleanup
[INFO] finished tweaking git repo https://github.com/woubuc/project-cleanup
[INFO] tweaked toml for git repo https://github.com/woubuc/project-cleanup written to /workspace/builds/worker-7-tc2/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/woubuc/project-cleanup on toolchain 4f260f0f20b3133d20cfb50353c0221943af5796
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/woubuc/project-cleanup already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4848fb76d95f26979359cc7e45710b1dbc8f3acb7aeedee7c460d7702230f228" "/opt/rustwide/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] d3c02a9d858afa8f4ae79d5ec27c24a81dcdbfe75dfbbf968ae09536c650516b
[INFO] running `Command { std: "docker" "start" "-a" "d3c02a9d858afa8f4ae79d5ec27c24a81dcdbfe75dfbbf968ae09536c650516b", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "d3c02a9d858afa8f4ae79d5ec27c24a81dcdbfe75dfbbf968ae09536c650516b", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "d3c02a9d858afa8f4ae79d5ec27c24a81dcdbfe75dfbbf968ae09536c650516b", kill_on_drop: false }`
[INFO] [stdout] d3c02a9d858afa8f4ae79d5ec27c24a81dcdbfe75dfbbf968ae09536c650516b
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dunmustuse_in_always_ok" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4848fb76d95f26979359cc7e45710b1dbc8f3acb7aeedee7c460d7702230f228" "/opt/rustwide/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] c32a1821ba22061be98066a5e3346f4990a9fdc58406ae68d3ff39274d837ef2
[INFO] running `Command { std: "docker" "start" "-a" "c32a1821ba22061be98066a5e3346f4990a9fdc58406ae68d3ff39274d837ef2", kill_on_drop: false }`
[INFO] [stderr]    Compiling libc v0.2.77
[INFO] [stderr]    Compiling version_check v0.9.2
[INFO] [stderr]    Compiling proc-macro2 v1.0.21
[INFO] [stderr]    Compiling crossbeam-utils v0.7.2
[INFO] [stderr]    Compiling maybe-uninit v2.0.0
[INFO] [stderr]    Compiling memoffset v0.5.5
[INFO] [stderr]    Compiling syn v1.0.40
[INFO] [stderr]    Compiling crossbeam-epoch v0.8.2
[INFO] [stderr]    Compiling memchr v2.3.3
[INFO] [stderr]    Compiling unicode-segmentation v1.6.0
[INFO] [stderr]     Checking thread_local v1.0.1
[INFO] [stderr]     Checking regex-syntax v0.6.18
[INFO] [stderr]     Checking dunce v1.0.1
[INFO] [stderr]     Checking remove_dir_all v0.5.3
[INFO] [stderr]     Checking yansi v0.5.0
[INFO] [stderr]    Compiling proc-macro-error-attr v1.0.4
[INFO] [stderr]    Compiling proc-macro-error v1.0.4
[INFO] [stderr]     Checking aho-corasick v0.7.13
[INFO] [stderr]    Compiling heck v0.3.1
[INFO] [stderr]     Checking atty v0.2.14
[INFO] [stderr]     Checking term_size v0.3.2
[INFO] [stderr]     Checking num_cpus v1.13.0
[INFO] [stderr]     Checking rand v0.4.6
[INFO] [stderr]     Checking crossbeam-queue v0.2.3
[INFO] [stderr]     Checking crossbeam-channel v0.4.4
[INFO] [stderr]     Checking clap v2.33.3
[INFO] [stderr]     Checking crossbeam-deque v0.7.3
[INFO] [stderr]    Compiling quote v1.0.7
[INFO] [stderr]     Checking crossbeam v0.7.3
[INFO] [stderr]     Checking tempdir v0.3.7
[INFO] [stderr]     Checking regex v1.3.9
[INFO] [stderr]    Compiling structopt-derive v0.4.10
[INFO] [stderr]     Checking structopt v0.3.17
[INFO] [stderr]     Checking swp v1.0.3 (/opt/rustwide/workdir)
[INFO] [stdout] warning: field `last_modified` is never read
[INFO] [stdout]   --> src/project.rs:16:2
[INFO] [stdout]    |
[INFO] [stdout]  8 | pub struct Project {
[INFO] [stdout]    |            ------- field in this struct
[INFO] [stdout] ...
[INFO] [stdout] 16 |     last_modified: u64,
[INFO] [stdout]    |     ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `Project` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: panic message is not a string literal
[INFO] [stdout]   --> src/output.rs:31:10
[INFO] [stdout]    |
[INFO] [stdout] 31 |         panic!(format!("Label {} too long", label));
[INFO] [stdout]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021
[INFO] [stdout]    = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2021/panic-macro-consistency.html>
[INFO] [stdout]    = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here
[INFO] [stdout]    = note: `#[warn(non_fmt_panics)]` (part of `#[warn(rust_2021_compatibility)]`) on by default
[INFO] [stdout] help: remove the `format!(..)` macro call
[INFO] [stdout]    |
[INFO] [stdout] 31 -         panic!(format!("Label {} too long", label));
[INFO] [stdout] 31 +         panic!("Label {} too long", label);
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: this type will no longer be must used: std::result::Result<PathBuf, Infallible>
[INFO] [stdout]   --> src/settings.rs:20:2
[INFO] [stdout]    |
[INFO] [stdout] 20 | /     /// One or more directories where `swp` should start searching for projects.
[INFO] [stdout] 21 | |     /// Defaults to the current working directory if no paths are given.
[INFO] [stdout] 22 | |     #[structopt(name = "PATH...")]
[INFO] [stdout] 23 | |     pub paths: Vec<PathBuf>,
[INFO] [stdout]    | |___________________________^
[INFO] [stdout]    |
[INFO] [stdout]    = note: requested on the command line with `-D unmustuse-in-always-ok`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]   --> src/discover_projects/detect_cleanable_project.rs:21:37
[INFO] [stdout]    |
[INFO] [stdout] 21 |     let mut project = Project::new(path.clone());
[INFO] [stdout]    |                                        ^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed
[INFO] [stdout]    = note: `#[warn(noop_method_call)]` on by default
[INFO] [stdout] help: remove this redundant call
[INFO] [stdout]    |
[INFO] [stdout] 21 -     let mut project = Project::new(path.clone());
[INFO] [stdout] 21 +     let mut project = Project::new(path);
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]   --> src/utils/file_utils.rs:13:6
[INFO] [stdout]    |
[INFO] [stdout] 13 |     path.clone().join(filename).exists()
[INFO] [stdout]    |         ^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed
[INFO] [stdout] help: remove this redundant call
[INFO] [stdout]    |
[INFO] [stdout] 13 -     path.clone().join(filename).exists()
[INFO] [stdout] 13 +     path.join(filename).exists()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr] error: could not compile `swp` (bin "swp") due to 1 previous error; 4 warnings emitted
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stdout] warning: unreachable pattern
[INFO] [stdout]    --> src/settings.rs:135:4
[INFO] [stdout]     |
[INFO] [stdout] 134 |             SettingsError::InvalidPath(_) => (),
[INFO] [stdout]     |             ----------------------------- matches all the relevant values
[INFO] [stdout] 135 |             _ => panic!("Unexpected error returned"),
[INFO] [stdout]     |             ^ no value can reach this
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(unreachable_patterns)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `last_modified` is never read
[INFO] [stdout]   --> src/project.rs:16:2
[INFO] [stdout]    |
[INFO] [stdout]  8 | pub struct Project {
[INFO] [stdout]    |            ------- field in this struct
[INFO] [stdout] ...
[INFO] [stdout] 16 |     last_modified: u64,
[INFO] [stdout]    |     ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `Project` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: panic message is not a string literal
[INFO] [stdout]   --> src/output.rs:31:10
[INFO] [stdout]    |
[INFO] [stdout] 31 |         panic!(format!("Label {} too long", label));
[INFO] [stdout]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021
[INFO] [stdout]    = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2021/panic-macro-consistency.html>
[INFO] [stdout]    = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here
[INFO] [stdout]    = note: `#[warn(non_fmt_panics)]` (part of `#[warn(rust_2021_compatibility)]`) on by default
[INFO] [stdout] help: remove the `format!(..)` macro call
[INFO] [stdout]    |
[INFO] [stdout] 31 -         panic!(format!("Label {} too long", label));
[INFO] [stdout] 31 +         panic!("Label {} too long", label);
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: this type will no longer be must used: std::result::Result<PathBuf, Infallible>
[INFO] [stdout]   --> src/settings.rs:20:2
[INFO] [stdout]    |
[INFO] [stdout] 20 | /     /// One or more directories where `swp` should start searching for projects.
[INFO] [stdout] 21 | |     /// Defaults to the current working directory if no paths are given.
[INFO] [stdout] 22 | |     #[structopt(name = "PATH...")]
[INFO] [stdout] 23 | |     pub paths: Vec<PathBuf>,
[INFO] [stdout]    | |___________________________^
[INFO] [stdout]    |
[INFO] [stdout]    = note: requested on the command line with `-D unmustuse-in-always-ok`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]   --> src/discover_projects/detect_cleanable_project.rs:21:37
[INFO] [stdout]    |
[INFO] [stdout] 21 |     let mut project = Project::new(path.clone());
[INFO] [stdout]    |                                        ^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: the type `std::path::Path` does not implement `Clone`, so calling `clone` on `&std::path::Path` copies the reference, which does not do anything and can be removed
[INFO] [stdout]    = note: `#[warn(noop_method_call)]` on by default
[INFO] [stdout] help: remove this redundant call
[INFO] [stdout]    |
[INFO] [stdout] 21 -     let mut project = Project::new(path.clone());
[INFO] [stdout] 21 +     let mut project = Project::new(path);
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]   --> src/utils/file_utils.rs:13:6
[INFO] [stdout]    |
[INFO] [stdout] 13 |     path.clone().join(filename).exists()
[INFO] [stdout]    |         ^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: the type `std::path::Path` does not implement `Clone`, so calling `clone` on `&std::path::Path` copies the reference, which does not do anything and can be removed
[INFO] [stdout] help: remove this redundant call
[INFO] [stdout]    |
[INFO] [stdout] 13 -     path.clone().join(filename).exists()
[INFO] [stdout] 13 +     path.join(filename).exists()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr] error: could not compile `swp` (bin "swp" test) due to 1 previous error; 5 warnings emitted
[INFO] running `Command { std: "docker" "inspect" "c32a1821ba22061be98066a5e3346f4990a9fdc58406ae68d3ff39274d837ef2", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "c32a1821ba22061be98066a5e3346f4990a9fdc58406ae68d3ff39274d837ef2", kill_on_drop: false }`
[INFO] [stdout] c32a1821ba22061be98066a5e3346f4990a9fdc58406ae68d3ff39274d837ef2
