[INFO] cloning repository https://github.com/RobbieClarken/sloop
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/RobbieClarken/sloop" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRobbieClarken%2Fsloop", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRobbieClarken%2Fsloop'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 29955b94ab58498b78058c847c53dce9cfe67cde
[INFO] checking RobbieClarken/sloop against try#4f260f0f20b3133d20cfb50353c0221943af5796+rustflags=-Dunmustuse_in_always_ok for pr-148577
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRobbieClarken%2Fsloop" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/RobbieClarken/sloop
[INFO] finished tweaking git repo https://github.com/RobbieClarken/sloop
[INFO] tweaked toml for git repo https://github.com/RobbieClarken/sloop written to /workspace/builds/worker-1-tc2/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/RobbieClarken/sloop on toolchain 4f260f0f20b3133d20cfb50353c0221943af5796
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/RobbieClarken/sloop already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4848fb76d95f26979359cc7e45710b1dbc8f3acb7aeedee7c460d7702230f228" "/opt/rustwide/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 1eafef9c8775a6b618282473b771fb50bc92df44b64a4c1646e98db5155d3b7c
[INFO] running `Command { std: "docker" "start" "-a" "1eafef9c8775a6b618282473b771fb50bc92df44b64a4c1646e98db5155d3b7c", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "1eafef9c8775a6b618282473b771fb50bc92df44b64a4c1646e98db5155d3b7c", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "1eafef9c8775a6b618282473b771fb50bc92df44b64a4c1646e98db5155d3b7c", kill_on_drop: false }`
[INFO] [stdout] 1eafef9c8775a6b618282473b771fb50bc92df44b64a4c1646e98db5155d3b7c
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dunmustuse_in_always_ok" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4848fb76d95f26979359cc7e45710b1dbc8f3acb7aeedee7c460d7702230f228" "/opt/rustwide/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 85427284ed12caa920bb5d9923c4505f0bb7fdbf65a668466a9792f27c3a451a
[INFO] running `Command { std: "docker" "start" "-a" "85427284ed12caa920bb5d9923c4505f0bb7fdbf65a668466a9792f27c3a451a", kill_on_drop: false }`
[INFO] [stderr]    Compiling proc-macro2 v1.0.60
[INFO] [stderr]     Checking futures v0.1.31
[INFO] [stderr]    Compiling crossbeam-utils v0.7.2
[INFO] [stderr]    Compiling syn v1.0.109
[INFO] [stderr]    Compiling memoffset v0.5.6
[INFO] [stderr]    Compiling crossbeam-epoch v0.8.2
[INFO] [stderr]     Checking iovec v0.1.4
[INFO] [stderr]     Checking num_cpus v1.15.0
[INFO] [stderr]     Checking net2 v0.2.39
[INFO] [stderr]     Checking time v0.1.45
[INFO] [stderr]    Compiling parking_lot_core v0.6.3
[INFO] [stderr]    Compiling openssl-sys v0.9.90
[INFO] [stderr]    Compiling hyper v0.12.36
[INFO] [stderr]     Checking indexmap v1.9.3
[INFO] [stderr]    Compiling openssl v0.10.55
[INFO] [stderr]     Checking signal-hook-registry v1.4.1
[INFO] [stderr]     Checking crossbeam-utils v0.6.6
[INFO] [stderr]    Compiling serde_json v1.0.97
[INFO] [stderr]     Checking crypto-mac v0.7.0
[INFO] [stderr]     Checking encoding_rs v0.8.32
[INFO] [stderr]    Compiling rusoto_core v0.41.0
[INFO] [stderr]     Checking bytes v0.4.12
[INFO] [stderr]     Checking mio v0.6.23
[INFO] [stderr]     Checking dirs v1.0.5
[INFO] [stderr]     Checking shlex v0.1.1
[INFO] [stderr]     Checking sha2 v0.8.2
[INFO] [stderr]     Checking hmac v0.7.1
[INFO] [stderr]    Compiling heck v0.3.3
[INFO] [stderr]     Checking textwrap v0.11.0
[INFO] [stderr]     Checking crossbeam-queue v0.1.2
[INFO] [stderr]     Checking atty v0.2.14
[INFO] [stderr]     Checking base64 v0.10.1
[INFO] [stderr]     Checking parking_lot v0.9.0
[INFO] [stderr]     Checking strsim v0.8.0
[INFO] [stderr]     Checking xml-rs v0.8.14
[INFO] [stderr]     Checking md5 v0.6.1
[INFO] [stderr]    Compiling native-tls v0.2.11
[INFO] [stderr]     Checking hex v0.3.2
[INFO] [stderr]     Checking xmlparser v0.13.5
[INFO] [stderr]     Checking base64 v0.21.2
[INFO] [stderr]     Checking clap v2.34.0
[INFO] [stderr]     Checking http v0.1.21
[INFO] [stderr]     Checking string v0.2.1
[INFO] [stderr]     Checking mio-uds v0.6.8
[INFO] [stderr]     Checking tokio-io v0.1.13
[INFO] [stderr]     Checking tokio-sync v0.1.8
[INFO] [stderr]     Checking tokio-buf v0.1.1
[INFO] [stderr]     Checking futures-cpupool v0.1.8
[INFO] [stderr]     Checking want v0.2.0
[INFO] [stderr]     Checking roxmltree v0.18.0
[INFO] [stderr]     Checking tokio-executor v0.1.10
[INFO] [stderr]     Checking crossbeam-queue v0.2.3
[INFO] [stderr]    Compiling quote v1.0.28
[INFO] [stderr]     Checking tokio-timer v0.2.13
[INFO] [stderr]     Checking tokio-current-thread v0.1.7
[INFO] [stderr]    Compiling syn v2.0.18
[INFO] [stderr]     Checking crossbeam-deque v0.7.4
[INFO] [stderr]    Compiling proc-macro-error-attr v1.0.4
[INFO] [stderr]     Checking tokio-reactor v0.1.12
[INFO] [stderr]     Checking tokio-codec v0.1.2
[INFO] [stderr]     Checking tokio-threadpool v0.1.18
[INFO] [stderr]     Checking quick-xml v0.28.2
[INFO] [stderr]     Checking tokio-uds v0.2.7
[INFO] [stderr]     Checking tokio-tcp v0.1.4
[INFO] [stderr]     Checking tokio-udp v0.1.6
[INFO] [stderr]     Checking tokio-signal v0.2.9
[INFO] [stderr]     Checking tokio-fs v0.1.7
[INFO] [stderr]     Checking tokio-process v0.2.5
[INFO] [stderr]     Checking tokio v0.1.22
[INFO] [stderr]     Checking h2 v0.1.26
[INFO] [stderr]     Checking http-body v0.1.0
[INFO] [stderr]    Compiling serde_derive v1.0.164
[INFO] [stderr]    Compiling openssl-macros v0.1.1
[INFO] [stderr]    Compiling darling_core v0.14.4
[INFO] [stderr]    Compiling proc-macro-error v1.0.4
[INFO] [stderr]    Compiling structopt-derive v0.4.18
[INFO] [stderr]     Checking structopt v0.3.26
[INFO] [stderr]    Compiling darling_macro v0.14.4
[INFO] [stderr]    Compiling darling v0.14.4
[INFO] [stderr]    Compiling derive_builder_core v0.12.0
[INFO] [stderr]     Checking serde v1.0.164
[INFO] [stderr]    Compiling derive_builder_macro v0.12.0
[INFO] [stderr]     Checking derive_builder v0.12.0
[INFO] [stderr]     Checking hyper-tls v0.3.2
[INFO] [stderr]     Checking chrono v0.4.26
[INFO] [stderr]     Checking rusoto_credential v0.41.1
[INFO] [stderr]     Checking diligent-date-parser v0.1.4
[INFO] [stderr]     Checking atom_syndication v0.12.1
[INFO] [stderr]     Checking rss v2.0.4
[INFO] [stderr]     Checking rusoto_s3 v0.41.0
[INFO] [stderr]     Checking sloop v1.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] error: this type will no longer be must used: Result<std::string::String, Infallible>
[INFO] [stdout]   --> src/main.rs:13:9
[INFO] [stdout]    |
[INFO] [stdout] 13 | /         #[structopt(long)]
[INFO] [stdout] 14 | |         title: String,
[INFO] [stdout]    | |_____________________^
[INFO] [stdout]    |
[INFO] [stdout]    = note: requested on the command line with `-D unmustuse-in-always-ok`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr] error: could not compile `sloop` (bin "sloop" test) due to 7 previous errors; 1 warning emitted
[INFO] [stdout] error: this type will no longer be must used: Result<std::path::PathBuf, Infallible>
[INFO] [stdout]   --> src/main.rs:15:9
[INFO] [stdout]    |
[INFO] [stdout] 15 | /         #[structopt(long)]
[INFO] [stdout] 16 | |         image: Option<PathBuf>,
[INFO] [stdout]    | |______________________________^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stdout] error: this type will no longer be must used: Result<std::string::String, Infallible>
[INFO] [stdout]   --> src/main.rs:17:9
[INFO] [stdout]    |
[INFO] [stdout] 17 | /         #[structopt(long)]
[INFO] [stdout] 18 | |         region: String,
[INFO] [stdout]    | |______________________^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: this type will no longer be must used: Result<std::string::String, Infallible>
[INFO] [stdout]   --> src/main.rs:19:9
[INFO] [stdout]    |
[INFO] [stdout] 19 | /         #[structopt(long)]
[INFO] [stdout] 20 | |         bucket: String,
[INFO] [stdout]    | |______________________^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: this type will no longer be must used: Result<std::path::PathBuf, Infallible>
[INFO] [stdout]   --> src/main.rs:21:9
[INFO] [stdout]    |
[INFO] [stdout] 21 | /         #[structopt(short, long)]
[INFO] [stdout] 22 | |         out: PathBuf,
[INFO] [stdout]    | |____________________^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: this type will no longer be must used: Result<std::string::String, Infallible>
[INFO] [stdout]   --> src/main.rs:29:9
[INFO] [stdout]    |
[INFO] [stdout] 29 | /         #[structopt(long)]
[INFO] [stdout] 30 | |         region: String,
[INFO] [stdout]    | |______________________^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: this type will no longer be must used: Result<std::string::String, Infallible>
[INFO] [stdout]   --> src/main.rs:31:9
[INFO] [stdout]    |
[INFO] [stdout] 31 | /         #[structopt(long)]
[INFO] [stdout] 32 | |         bucket: String,
[INFO] [stdout]    | |______________________^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]    --> src/upload.rs:272:47
[INFO] [stdout]     |
[INFO] [stdout] 272 |         let request = requests.get(0).unwrap().clone();
[INFO] [stdout]     |                                               ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: the type `PutObjectData` does not implement `Clone`, so calling `clone` on `&PutObjectData` copies the reference, which does not do anything and can be removed
[INFO] [stdout]     = note: `#[warn(noop_method_call)]` on by default
[INFO] [stdout] help: remove this redundant call
[INFO] [stdout]     |
[INFO] [stdout] 272 -         let request = requests.get(0).unwrap().clone();
[INFO] [stdout] 272 +         let request = requests.get(0).unwrap();
[INFO] [stdout]     |
[INFO] [stdout] help: if you meant to clone `PutObjectData`, implement `Clone` for it
[INFO] [stdout]    --> src/upload/tests/s3_mock.rs:9:1
[INFO] [stdout]     |
[INFO] [stdout]   9 + #[derive(Clone)]
[INFO] [stdout]  10 | pub struct PutObjectData {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: this type will no longer be must used: Result<std::string::String, Infallible>
[INFO] [stdout]   --> src/main.rs:13:9
[INFO] [stdout]    |
[INFO] [stdout] 13 | /         #[structopt(long)]
[INFO] [stdout] 14 | |         title: String,
[INFO] [stdout]    | |_____________________^
[INFO] [stdout]    |
[INFO] [stdout]    = note: requested on the command line with `-D unmustuse-in-always-ok`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: this type will no longer be must used: Result<PathBuf, Infallible>
[INFO] [stdout]   --> src/main.rs:15:9
[INFO] [stdout]    |
[INFO] [stdout] 15 | /         #[structopt(long)]
[INFO] [stdout] 16 | |         image: Option<PathBuf>,
[INFO] [stdout]    | |______________________________^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: this type will no longer be must used: Result<std::string::String, Infallible>
[INFO] [stdout]   --> src/main.rs:17:9
[INFO] [stdout]    |
[INFO] [stdout] 17 | /         #[structopt(long)]
[INFO] [stdout] 18 | |         region: String,
[INFO] [stdout]    | |______________________^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: this type will no longer be must used: Result<std::string::String, Infallible>
[INFO] [stdout]   --> src/main.rs:19:9
[INFO] [stdout]    |
[INFO] [stdout] 19 | /         #[structopt(long)]
[INFO] [stdout] 20 | |         bucket: String,
[INFO] [stdout]    | |______________________^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: this type will no longer be must used: Result<PathBuf, Infallible>
[INFO] [stdout]   --> src/main.rs:21:9
[INFO] [stdout]    |
[INFO] [stdout] 21 | /         #[structopt(short, long)]
[INFO] [stdout] 22 | |         out: PathBuf,
[INFO] [stdout]    | |____________________^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: this type will no longer be must used: Result<std::string::String, Infallible>
[INFO] [stdout]   --> src/main.rs:29:9
[INFO] [stdout]    |
[INFO] [stdout] 29 | /         #[structopt(long)]
[INFO] [stdout] 30 | |         region: String,
[INFO] [stdout]    | |______________________^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: this type will no longer be must used: Result<std::string::String, Infallible>
[INFO] [stdout]   --> src/main.rs:31:9
[INFO] [stdout]    |
[INFO] [stdout] 31 | /         #[structopt(long)]
[INFO] [stdout] 32 | |         bucket: String,
[INFO] [stdout]    | |______________________^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr] error: could not compile `sloop` (bin "sloop") due to 7 previous errors
[INFO] running `Command { std: "docker" "inspect" "85427284ed12caa920bb5d9923c4505f0bb7fdbf65a668466a9792f27c3a451a", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "85427284ed12caa920bb5d9923c4505f0bb7fdbf65a668466a9792f27c3a451a", kill_on_drop: false }`
[INFO] [stdout] 85427284ed12caa920bb5d9923c4505f0bb7fdbf65a668466a9792f27c3a451a
