[INFO] cloning repository https://github.com/tirr-c/unityfs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/tirr-c/unityfs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftirr-c%2Funityfs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftirr-c%2Funityfs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8920c83eb4f8530c93917749b62796e4e62e62e6 [INFO] testing tirr-c/unityfs against try#a7ee93192a766fb0dafa23def7154fc03cfcfc3e for pr-146989 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftirr-c%2Funityfs" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/tirr-c/unityfs [INFO] finished tweaking git repo https://github.com/tirr-c/unityfs [INFO] tweaked toml for git repo https://github.com/tirr-c/unityfs written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/tirr-c/unityfs on toolchain a7ee93192a766fb0dafa23def7154fc03cfcfc3e [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a7ee93192a766fb0dafa23def7154fc03cfcfc3e" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/tirr-c/unityfs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a7ee93192a766fb0dafa23def7154fc03cfcfc3e" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded memchr v2.2.1 [INFO] [stderr] Downloaded quote v1.0.2 [INFO] [stderr] Downloaded proc-macro2 v1.0.8 [INFO] [stderr] Downloaded wasm-bindgen-macro-support v0.2.58 [INFO] [stderr] Downloaded wasm-bindgen-macro v0.2.58 [INFO] [stderr] Downloaded wasm-bindgen-shared v0.2.58 [INFO] [stderr] Downloaded wasm-bindgen-backend v0.2.58 [INFO] [stderr] Downloaded num-rational v0.2.3 [INFO] [stderr] Downloaded js-sys v0.3.35 [INFO] [stderr] Downloaded nom v5.0.0 [INFO] [stderr] Downloaded wasm-bindgen v0.2.58 [INFO] [stderr] Downloaded syn v1.0.14 [INFO] [stderr] Downloaded bumpalo v3.2.0 [INFO] [stderr] Downloaded image v0.23.0 [INFO] [stderr] Downloaded console_error_panic_hook v0.1.6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:98afbf2d16093dec2546ff8915fddc74e65664aa03fc460b3712b1c2c54a33e4" "/opt/rustwide/cargo-home/bin/cargo" "+a7ee93192a766fb0dafa23def7154fc03cfcfc3e" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a5aa27b0c3a4bf3d50ccc66031af20bd70c1aafac162e81485c1d1c33f46b7f7 [INFO] running `Command { std: "docker" "start" "-a" "a5aa27b0c3a4bf3d50ccc66031af20bd70c1aafac162e81485c1d1c33f46b7f7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a5aa27b0c3a4bf3d50ccc66031af20bd70c1aafac162e81485c1d1c33f46b7f7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a5aa27b0c3a4bf3d50ccc66031af20bd70c1aafac162e81485c1d1c33f46b7f7", kill_on_drop: false }` [INFO] [stdout] a5aa27b0c3a4bf3d50ccc66031af20bd70c1aafac162e81485c1d1c33f46b7f7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:98afbf2d16093dec2546ff8915fddc74e65664aa03fc460b3712b1c2c54a33e4" "/opt/rustwide/cargo-home/bin/cargo" "+a7ee93192a766fb0dafa23def7154fc03cfcfc3e" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 483004e0913ec915a9d3542cb9266906e3daecae479e4330c7db3ef33759ec15 [INFO] running `Command { std: "docker" "start" "-a" "483004e0913ec915a9d3542cb9266906e3daecae479e4330c7db3ef33759ec15", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.8 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.14 [INFO] [stderr] Compiling version_check v0.1.5 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Compiling serde v1.0.104 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling nom v5.0.0 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Compiling serde_derive v1.0.104 [INFO] [stderr] Compiling unityfs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/asset/type_tree.rs:227:10 [INFO] [stdout] | [INFO] [stdout] 227 | #[derive(Serialize)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Serialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple fields are never read [INFO] [stdout] --> src/asset.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 17 | pub struct Asset<'b> { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] 18 | name: String, [INFO] [stdout] 19 | metadata_size: u32, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 20 | file_size: u32, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 21 | format: u32, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 22 | data_offset: u32, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 23 | tree: TypeMetadata<'b>, [INFO] [stdout] | ^^^^ [INFO] [stdout] 24 | objects: Vec>, [INFO] [stdout] 25 | adds: Vec<(u64, i32)>, [INFO] [stdout] | ^^^^ [INFO] [stdout] 26 | refs: Vec>, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Asset` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `asset_path`, `guid`, `ty`, and `file_path` are never read [INFO] [stdout] --> src/asset.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 39 | pub struct AssetRef<'b> { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 40 | asset_path: Cow<'b, str>, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 41 | guid: &'b [u8], [INFO] [stdout] | ^^^^ [INFO] [stdout] 42 | ty: u32, [INFO] [stdout] | ^^ [INFO] [stdout] 43 | file_path: Cow<'b, str>, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `AssetRef` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `version` and `index` are never read [INFO] [stdout] --> src/asset/type_tree.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct TypeTree<'a> { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 14 | version: u32, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 19 | index: u32, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TypeTree` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `hash` is never read [INFO] [stdout] --> src/asset/type_tree.rs:341:5 [INFO] [stdout] | [INFO] [stdout] 339 | struct TypeMetadataEntry<'a> { [INFO] [stdout] | ----------------- field in this struct [INFO] [stdout] 340 | class_id: i32, [INFO] [stdout] 341 | hash: Option<&'a [u8]>, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TypeMetadataEntry` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `generator_version` and `target_platform` are never read [INFO] [stdout] --> src/asset/type_tree.rs:407:5 [INFO] [stdout] | [INFO] [stdout] 406 | pub struct TypeMetadata<'a> { [INFO] [stdout] | ------------ fields in this struct [INFO] [stdout] 407 | generator_version: Cow<'a, str>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 408 | target_platform: u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TypeMetadata` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `status` is never read [INFO] [stdout] --> src/metadata.rs:15:16 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct NodeInfo { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 15 | pub(crate) status: u32, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `NodeInfo` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: eliding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/lib.rs:44:46 [INFO] [stdout] | [INFO] [stdout] 44 | pub fn parse(input: &'a [u8]) -> IResult<&[u8], Self> { [INFO] [stdout] | -- ^^^^^ the same lifetime is elided here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is named here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 44 | pub fn parse(input: &'a [u8]) -> IResult<&'a [u8], Self> { [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: eliding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/asset.rs:47:80 [INFO] [stdout] | [INFO] [stdout] 47 | pub(crate) fn parse(name: String, input: &'b [u8], offset: u64) -> IResult<&[u8], Self> { [INFO] [stdout] | -- the lifetime is named here ^^^^^ the same lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: consistently use `'b` [INFO] [stdout] | [INFO] [stdout] 47 | pub(crate) fn parse(name: String, input: &'b [u8], offset: u64) -> IResult<&'b [u8], Self> { [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/asset/type_tree.rs:54:22 [INFO] [stdout] | [INFO] [stdout] 54 | fn parse_blob(input: &[u8], endianness: Endianness, format: u32) -> IResult<&[u8], TypeTree> { [INFO] [stdout] | ^^^^^ ^^^^^ ^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | | [INFO] [stdout] | the lifetime is elided here the same lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 54 | fn parse_blob(input: &[u8], endianness: Endianness, format: u32) -> IResult<&[u8], TypeTree<'_>> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: eliding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/asset/type_tree.rs:118:79 [INFO] [stdout] | [INFO] [stdout] 118 | fn parse(input: &'a [u8], endianness: Endianness, format: u32) -> IResult<&[u8], Self> { [INFO] [stdout] | -- the lifetime is named here ^^^^^ the same lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 118 | fn parse(input: &'a [u8], endianness: Endianness, format: u32) -> IResult<&'a [u8], Self> { [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/asset/type_tree.rs:227:10 [INFO] [stdout] | [INFO] [stdout] 227 | #[derive(Serialize)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_Data` [INFO] [stdout] 228 | #[serde(tag = "type", content = "data")] [INFO] [stdout] 229 | pub enum Data<'b> { [INFO] [stdout] | ---- `Data` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: implicit autoref creates a reference to the dereference of a raw pointer [INFO] [stdout] --> src/compression/mod.rs:100:14 [INFO] [stdout] | [INFO] [stdout] 100 | &mut (*self.buf.get())[start..end] [INFO] [stdout] | ^^--------------^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this raw pointer has type `*mut Box<[u8]>` [INFO] [stdout] | [INFO] [stdout] = note: creating a reference requires the pointer target to be valid and imposes aliasing requirements [INFO] [stdout] note: autoref is being applied to this expression, resulting in: `&mut [u8]` [INFO] [stdout] --> src/compression/mod.rs:100:14 [INFO] [stdout] | [INFO] [stdout] 100 | &mut (*self.buf.get())[start..end] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[deny(dangerous_implicit_autorefs)]` on by default [INFO] [stdout] help: try using a raw pointer method instead; or if this reference is intentional, make it explicit [INFO] [stdout] | [INFO] [stdout] 100 | &mut (&mut (*self.buf.get()))[start..end] [INFO] [stdout] | +++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: implicit autoref creates a reference to the dereference of a raw pointer [INFO] [stdout] --> src/compression/mod.rs:125:19 [INFO] [stdout] | [INFO] [stdout] 125 | unsafe { &(*self.buf.get())[start as usize..end as usize] } [INFO] [stdout] | ^^--------------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this raw pointer has type `*mut Box<[u8]>` [INFO] [stdout] | [INFO] [stdout] = note: creating a reference requires the pointer target to be valid and imposes aliasing requirements [INFO] [stdout] note: autoref is being applied to this expression, resulting in: `&[u8]` [INFO] [stdout] --> src/compression/mod.rs:125:19 [INFO] [stdout] | [INFO] [stdout] 125 | unsafe { &(*self.buf.get())[start as usize..end as usize] } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: try using a raw pointer method instead; or if this reference is intentional, make it explicit [INFO] [stdout] | [INFO] [stdout] 125 | unsafe { &(&(*self.buf.get()))[start as usize..end as usize] } [INFO] [stdout] | ++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/compression/lz4.rs:10:32 [INFO] [stdout] | [INFO] [stdout] 10 | fn new(input: &'a [u8]) -> Sequences { [INFO] [stdout] | -- ^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is named here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 10 | fn new(input: &'a [u8]) -> Sequences<'a> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `unityfs` (lib) due to 2 previous errors; 13 warnings emitted [INFO] running `Command { std: "docker" "inspect" "483004e0913ec915a9d3542cb9266906e3daecae479e4330c7db3ef33759ec15", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "483004e0913ec915a9d3542cb9266906e3daecae479e4330c7db3ef33759ec15", kill_on_drop: false }` [INFO] [stdout] 483004e0913ec915a9d3542cb9266906e3daecae479e4330c7db3ef33759ec15