[INFO] fetching crate upstream-ontologist 0.2.11... [INFO] checking upstream-ontologist-0.2.11 against try#4e55a504843955c97eb06907c71f6f3e99208021 for pr-146978 [INFO] extracting crate upstream-ontologist 0.2.11 into /workspace/builds/worker-7-tc2/source [INFO] started tweaking crates.io crate upstream-ontologist 0.2.11 [INFO] finished tweaking crates.io crate upstream-ontologist 0.2.11 [INFO] tweaked toml for crates.io crate upstream-ontologist 0.2.11 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] validating manifest of crates.io crate upstream-ontologist 0.2.11 on toolchain 4e55a504843955c97eb06907c71f6f3e99208021 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4e55a504843955c97eb06907c71f6f3e99208021" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate upstream-ontologist 0.2.11 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4e55a504843955c97eb06907c71f6f3e99208021" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:e90291280db7d1fac5b66fc6dad9f9662629e7365a55743daf9bdf73ebc4ea79" "/opt/rustwide/cargo-home/bin/cargo" "+4e55a504843955c97eb06907c71f6f3e99208021" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a736683f10aa0df49b0cf24441fc9941e25acbaf4ee51b869f77e1eb813813f8 [INFO] running `Command { std: "docker" "start" "-a" "a736683f10aa0df49b0cf24441fc9941e25acbaf4ee51b869f77e1eb813813f8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a736683f10aa0df49b0cf24441fc9941e25acbaf4ee51b869f77e1eb813813f8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a736683f10aa0df49b0cf24441fc9941e25acbaf4ee51b869f77e1eb813813f8", kill_on_drop: false }` [INFO] [stdout] a736683f10aa0df49b0cf24441fc9941e25acbaf4ee51b869f77e1eb813813f8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:e90291280db7d1fac5b66fc6dad9f9662629e7365a55743daf9bdf73ebc4ea79" "/opt/rustwide/cargo-home/bin/cargo" "+4e55a504843955c97eb06907c71f6f3e99208021" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b4231bdf494b1d871c29a0d9a4ea53b2ca943b4b934c9e69f3c3187f4f18a18a [INFO] running `Command { std: "docker" "start" "-a" "b4231bdf494b1d871c29a0d9a4ea53b2ca943b4b934c9e69f3c3187f4f18a18a", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Compiling cfg-if v1.0.3 [INFO] [stderr] Compiling libc v0.2.175 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling memchr v2.7.5 [INFO] [stderr] Checking bitflags v2.9.4 [INFO] [stderr] Compiling find-msvc-tools v0.1.1 [INFO] [stderr] Compiling phf_shared v0.11.3 [INFO] [stderr] Compiling ppv-lite86 v0.2.21 [INFO] [stderr] Checking hashbrown v0.15.5 [INFO] [stderr] Compiling regex-syntax v0.8.6 [INFO] [stderr] Compiling target-lexicon v0.13.2 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Checking allocator-api2 v0.2.21 [INFO] [stderr] Checking unicode-normalization v0.1.24 [INFO] [stderr] Checking parking_lot_core v0.9.11 [INFO] [stderr] Checking gix-trace v0.1.13 [INFO] [stderr] Checking iana-time-zone v0.1.63 [INFO] [stderr] Compiling cc v1.2.36 [INFO] [stderr] Compiling crunchy v0.2.4 [INFO] [stderr] Checking chrono v0.4.41 [INFO] [stderr] Checking signal-hook-registry v1.4.6 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking gix-utils v0.3.0 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Checking new_debug_unreachable v1.0.6 [INFO] [stderr] Compiling getrandom v0.2.16 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Checking rustix v1.0.8 [INFO] [stderr] Checking winnow v0.7.13 [INFO] [stderr] Checking prodash v30.0.1 [INFO] [stderr] Compiling phf_shared v0.10.0 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Checking precomputed-hash v0.1.1 [INFO] [stderr] Checking mac v0.1.1 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Checking text-size v1.1.1 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking futf v0.1.5 [INFO] [stderr] Checking countme v3.0.1 [INFO] [stderr] Compiling heapless v0.8.0 [INFO] [stderr] Checking hash32 v0.3.1 [INFO] [stderr] Checking regex-automata v0.4.10 [INFO] [stderr] Checking rowan v0.16.1 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking tendril v0.4.3 [INFO] [stderr] Compiling pyo3-build-config v0.25.1 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling dirs-sys-next v0.1.2 [INFO] [stderr] Checking tracing-core v0.1.34 [INFO] [stderr] Compiling openssl v0.10.73 [INFO] [stderr] Checking unicode-width v0.2.1 [INFO] [stderr] Compiling scopeguard v1.2.0 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Compiling dirs-next v2.0.0 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Compiling openssl-sys v0.9.109 [INFO] [stderr] Compiling psm v0.1.26 [INFO] [stderr] Compiling lock_api v0.4.13 [INFO] [stderr] Checking getrandom v0.3.3 [INFO] [stderr] Compiling phf_generator v0.11.3 [INFO] [stderr] Compiling phf_generator v0.10.0 [INFO] [stderr] Checking encoding_rs v0.8.35 [INFO] [stderr] Compiling phf_codegen v0.10.0 [INFO] [stderr] Compiling string_cache_codegen v0.5.4 [INFO] [stderr] Compiling phf_codegen v0.11.3 [INFO] [stderr] Checking tempfile v3.21.0 [INFO] [stderr] Checking faster-hex v0.10.0 [INFO] [stderr] Checking phf v0.10.1 [INFO] [stderr] Checking sha1-checked v0.10.0 [INFO] [stderr] Compiling term v0.7.0 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Compiling stacker v0.1.21 [INFO] [stderr] Compiling memoffset v0.9.1 [INFO] [stderr] Compiling markup5ever v0.11.0 [INFO] [stderr] Compiling fixedbitset v0.4.2 [INFO] [stderr] Compiling indexmap v2.11.0 [INFO] [stderr] Compiling bit-vec v0.6.3 [INFO] [stderr] Compiling either v1.15.0 [INFO] [stderr] Compiling string_cache v0.8.9 [INFO] [stderr] Compiling ena v0.14.3 [INFO] [stderr] Compiling bit-set v0.5.3 [INFO] [stderr] Compiling itertools v0.10.5 [INFO] [stderr] Compiling ascii-canvas v3.0.0 [INFO] [stderr] Compiling web_atoms v0.1.3 [INFO] [stderr] Checking charset v0.1.5 [INFO] [stderr] Compiling const-random-macro v0.1.16 [INFO] [stderr] Compiling is-terminal v0.4.16 [INFO] [stderr] Checking regex v1.11.2 [INFO] [stderr] Checking bstr v1.12.0 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Compiling diff v0.1.13 [INFO] [stderr] Compiling regex-syntax v0.6.29 [INFO] [stderr] Checking quoted_printable v0.5.1 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Checking const-random v0.1.18 [INFO] [stderr] Checking object v0.36.7 [INFO] [stderr] Checking phf v0.11.3 [INFO] [stderr] Checking version-ranges v0.1.1 [INFO] [stderr] Compiling fs-err v3.1.1 [INFO] [stderr] Compiling indoc v2.0.6 [INFO] [stderr] Compiling petgraph v0.6.5 [INFO] [stderr] Checking unindent v0.2.4 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Compiling dtor-proc-macro v0.0.6 [INFO] [stderr] Compiling zip v2.4.2 [INFO] [stderr] Compiling pyo3-macros-backend v0.25.1 [INFO] [stderr] Compiling pyo3-ffi v0.25.1 [INFO] [stderr] Compiling pyo3 v0.25.1 [INFO] [stderr] Checking bumpalo v3.19.0 [INFO] [stderr] Checking rustc-demangle v0.1.26 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking dtor v0.1.0 [INFO] [stderr] Compiling lalrpop-util v0.19.12 [INFO] [stderr] Checking zopfli v0.8.2 [INFO] [stderr] Checking mailparse v0.15.0 [INFO] [stderr] Checking dlv-list v0.5.2 [INFO] [stderr] Checking chumsky v0.9.3 [INFO] [stderr] Checking xattr v1.5.1 [INFO] [stderr] Checking filetime v0.2.26 [INFO] [stderr] Checking memmap2 v0.9.8 [INFO] [stderr] Checking csv-core v0.1.12 [INFO] [stderr] Compiling pulldown-cmark v0.13.0 [INFO] [stderr] Checking boxcar v0.2.14 [INFO] [stderr] Checking smawk v0.3.2 [INFO] [stderr] Compiling semver v1.0.26 [INFO] [stderr] Checking unicode-linebreak v0.1.5 [INFO] [stderr] Compiling ctor-proc-macro v0.0.6 [INFO] [stderr] Checking tar v0.4.44 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Checking ordered-multimap v0.7.3 [INFO] [stderr] Checking textwrap v0.16.2 [INFO] [stderr] Checking ctor v0.5.0 [INFO] [stderr] Checking m_lexer v0.0.4 [INFO] [stderr] Checking xmltree v0.11.0 [INFO] [stderr] Checking toml_parser v1.0.2 [INFO] [stderr] Checking getopts v0.2.24 [INFO] [stderr] Checking gix-sec v0.12.0 [INFO] [stderr] Compiling upstream-ontologist v0.2.11 (/opt/rustwide/workdir) [INFO] [stderr] Checking pulldown-cmark-escape v0.11.0 [INFO] [stderr] Checking whoami v1.6.1 [INFO] [stderr] Compiling lalrpop v0.19.12 [INFO] [stderr] Checking toml_writer v1.0.2 [INFO] [stderr] Checking unicode-bom v2.0.3 [INFO] [stderr] Checking rust-ini v0.21.3 [INFO] [stderr] Checking makefile-lossless v0.2.1 [INFO] [stderr] Checking configparser v3.1.0 [INFO] [stderr] Checking yansi v1.0.1 [INFO] [stderr] Checking shlex v1.3.0 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling thiserror-impl v2.0.16 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling lazy-regex-proc_macros v3.4.1 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Checking tokio v1.47.1 [INFO] [stderr] Checking lazy-regex v3.4.1 [INFO] [stderr] Checking debversion v0.4.7 [INFO] [stderr] Compiling deb822-derive v0.3.0 [INFO] [stderr] Compiling html5ever v0.26.0 [INFO] [stderr] Checking patchkit v0.2.1 [INFO] [stderr] Compiling match_token v0.35.0 [INFO] [stderr] Checking debian-changelog v0.2.1 [INFO] [stderr] Checking deb822-fast v0.2.0 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Checking pretty_assertions v1.4.1 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking thiserror v2.0.16 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Compiling pest v2.8.1 [INFO] [stderr] Checking gix-validate v0.10.0 [INFO] [stderr] Checking zerovec v0.11.4 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Checking gix-date v0.10.5 [INFO] [stderr] Checking gix-path v0.10.20 [INFO] [stderr] Checking backtrace v0.3.75 [INFO] [stderr] Checking rfc2047-decoder v1.0.6 [INFO] [stderr] Compiling pyo3-macros v0.25.1 [INFO] [stderr] Checking gix-actor v0.35.4 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Checking gix-features v0.43.1 [INFO] [stderr] Checking gix-config-value v0.15.1 [INFO] [stderr] Checking gix-fs v0.16.1 [INFO] [stderr] Checking gix-hash v0.19.0 [INFO] [stderr] Checking gix-glob v0.21.0 [INFO] [stderr] Checking gix-tempfile v18.0.0 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking potential_utf v0.1.3 [INFO] [stderr] Checking gix-hashtable v0.9.0 [INFO] [stderr] Compiling pest_meta v2.8.1 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Checking gix-object v0.50.2 [INFO] [stderr] Checking gix-lock v18.0.0 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Compiling pest_generator v2.8.1 [INFO] [stderr] Checking gix-ref v0.53.1 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking tokio-util v0.7.16 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Compiling pest_derive v2.8.1 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking tower-http v0.6.6 [INFO] [stderr] Checking gix-config v0.46.0 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking deb822-lossless v0.3.2 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking serde_json v1.0.143 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking pep440_rs v0.7.3 [INFO] [stderr] Checking toml_datetime v0.7.0 [INFO] [stderr] Checking serde_spanned v1.0.0 [INFO] [stderr] Checking serde-xml-rs v0.5.1 [INFO] [stderr] Checking csv v1.3.1 [INFO] [stderr] Checking debian-copyright v0.1.28 [INFO] [stderr] Checking toml v0.9.5 [INFO] [stderr] Checking distro-info v0.4.0 [INFO] [stderr] Checking markup5ever v0.35.0 [INFO] [stderr] Checking h2 v0.4.12 [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking html5ever v0.35.0 [INFO] [stderr] Checking document_tree v0.4.2 [INFO] [stderr] Checking pep508_rs v0.9.2 [INFO] [stderr] Checking debian-control v0.1.48 [INFO] [stderr] Checking debian-watch v0.2.8 [INFO] [stderr] Checking r-description v0.3.5 [INFO] [stderr] Checking xml5ever v0.17.0 [INFO] [stderr] Checking rst_renderer v0.4.2 [INFO] [stderr] Checking uo_rst_parser v0.4.3 [INFO] [stderr] Checking python-pkginfo v0.6.5 [INFO] [stderr] Checking toml v0.8.23 [INFO] [stderr] Checking markup5ever_rcdom v0.2.0 [INFO] [stderr] Checking select v0.6.1 [INFO] [stderr] Checking pyproject-toml v0.13.5 [INFO] [stderr] Compiling opam-file-rs v0.1.5 [INFO] [stderr] Checking hyper v1.7.0 [INFO] [stderr] Checking pyo3-filelike v0.5.0 [INFO] [stderr] Checking breezyshim v0.6.5 [INFO] [stderr] Checking hyper-util v0.1.16 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.23 [INFO] [stderr] Checking debbugs v0.1.5 [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/providers/debian.rs:607:21 [INFO] [stdout] | [INFO] [stdout] 607 | lazy_regex::regex_captures!(r"(http|https)://([^ ,]+)", source.as_str()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 606 - for (m, _, _) in [INFO] [stdout] 606 + while let Some((m, _, _)) = lazy_regex::regex_captures!(r"(http|https)://([^ ,]+)", source.as_str()) [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 606 - for (m, _, _) in [INFO] [stdout] 606 + if let Some((m, _, _)) = lazy_regex::regex_captures!(r"(http|https)://([^ ,]+)", source.as_str()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/readme.rs:380:18 [INFO] [stdout] | [INFO] [stdout] 380 | for m in lazy_regex::regex_find!("https://([^]/]+)/([^]\\s()\"#]+)", line) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 380 - for m in lazy_regex::regex_find!("https://([^]/]+)/([^]\\s()\"#]+)", line) { [INFO] [stdout] 380 + while let Some(m) = lazy_regex::regex_find!("https://([^]/]+)/([^]\\s()\"#]+)", line) { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 380 - for m in lazy_regex::regex_find!("https://([^]/]+)/([^]\\s()\"#]+)", line) { [INFO] [stdout] 380 + if let Some(m) = lazy_regex::regex_find!("https://([^]/]+)/([^]\\s()\"#]+)", line) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/providers/debian.rs:607:21 [INFO] [stdout] | [INFO] [stdout] 607 | lazy_regex::regex_captures!(r"(http|https)://([^ ,]+)", source.as_str()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 606 - for (m, _, _) in [INFO] [stdout] 606 + while let Some((m, _, _)) = lazy_regex::regex_captures!(r"(http|https)://([^ ,]+)", source.as_str()) [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 606 - for (m, _, _) in [INFO] [stdout] 606 + if let Some((m, _, _)) = lazy_regex::regex_captures!(r"(http|https)://([^ ,]+)", source.as_str()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/readme.rs:380:18 [INFO] [stdout] | [INFO] [stdout] 380 | for m in lazy_regex::regex_find!("https://([^]/]+)/([^]\\s()\"#]+)", line) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 380 - for m in lazy_regex::regex_find!("https://([^]/]+)/([^]\\s()\"#]+)", line) { [INFO] [stdout] 380 + while let Some(m) = lazy_regex::regex_find!("https://([^]/]+)/([^]\\s()\"#]+)", line) { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 380 - for m in lazy_regex::regex_find!("https://([^]/]+)/([^]\\s()\"#]+)", line) { [INFO] [stdout] 380 + if let Some(m) = lazy_regex::regex_find!("https://([^]/]+)/([^]\\s()\"#]+)", line) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/readme.rs:1193:18 [INFO] [stdout] | [INFO] [stdout] 1193 | fn root(doc: &Document) -> Node { [INFO] [stdout] | ^^^^^^^^^ ^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 1193 | fn root(doc: &Document) -> Node<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 02s [INFO] running `Command { std: "docker" "inspect" "b4231bdf494b1d871c29a0d9a4ea53b2ca943b4b934c9e69f3c3187f4f18a18a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b4231bdf494b1d871c29a0d9a4ea53b2ca943b4b934c9e69f3c3187f4f18a18a", kill_on_drop: false }` [INFO] [stdout] b4231bdf494b1d871c29a0d9a4ea53b2ca943b4b934c9e69f3c3187f4f18a18a