[INFO] cloning repository https://github.com/rcurtis/hexagonal [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/rcurtis/hexagonal" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frcurtis%2Fhexagonal", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frcurtis%2Fhexagonal'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 31f71ed4be9904aa0b8eb969dbdd69b6facc6917 [INFO] checking rcurtis/hexagonal against try#969026c535f4240ff7866ef11207dfda18a26af6 for pr-146504 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frcurtis%2Fhexagonal" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/rcurtis/hexagonal [INFO] finished tweaking git repo https://github.com/rcurtis/hexagonal [INFO] tweaked toml for git repo https://github.com/rcurtis/hexagonal written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/rcurtis/hexagonal on toolchain 969026c535f4240ff7866ef11207dfda18a26af6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+969026c535f4240ff7866ef11207dfda18a26af6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/rcurtis/hexagonal already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+969026c535f4240ff7866ef11207dfda18a26af6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded ascii v1.0.0 [INFO] [stderr] Downloaded chunked_transfer v1.4.0 [INFO] [stderr] Downloaded gzip-header v0.3.0 [INFO] [stderr] Downloaded deflate v0.9.1 [INFO] [stderr] Downloaded tiny_http v0.8.2 [INFO] [stderr] Downloaded time v0.3.2 [INFO] [stderr] Downloaded rouille v3.3.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:e90291280db7d1fac5b66fc6dad9f9662629e7365a55743daf9bdf73ebc4ea79" "/opt/rustwide/cargo-home/bin/cargo" "+969026c535f4240ff7866ef11207dfda18a26af6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 535dca4136dabdd9e2775ed19c4ec75e44bab12c9e8ecb45ff41c190224ac462 [INFO] running `Command { std: "docker" "start" "-a" "535dca4136dabdd9e2775ed19c4ec75e44bab12c9e8ecb45ff41c190224ac462", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "535dca4136dabdd9e2775ed19c4ec75e44bab12c9e8ecb45ff41c190224ac462", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "535dca4136dabdd9e2775ed19c4ec75e44bab12c9e8ecb45ff41c190224ac462", kill_on_drop: false }` [INFO] [stdout] 535dca4136dabdd9e2775ed19c4ec75e44bab12c9e8ecb45ff41c190224ac462 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:e90291280db7d1fac5b66fc6dad9f9662629e7365a55743daf9bdf73ebc4ea79" "/opt/rustwide/cargo-home/bin/cargo" "+969026c535f4240ff7866ef11207dfda18a26af6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 031e5c8565dbcb101906678e50ceba1256ffa5aac1bca8a5904a08cfcd197724 [INFO] running `Command { std: "docker" "start" "-a" "031e5c8565dbcb101906678e50ceba1256ffa5aac1bca8a5904a08cfcd197724", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.101 [INFO] [stderr] Compiling syn v1.0.76 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Checking tinyvec v1.3.1 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Compiling crc32fast v1.2.1 [INFO] [stderr] Compiling brotli-sys v0.3.2 [INFO] [stderr] Checking unicode-bidi v0.3.6 [INFO] [stderr] Compiling serde_json v1.0.67 [INFO] [stderr] Checking gzip-header v0.3.0 [INFO] [stderr] Checking ascii v1.0.0 [INFO] [stderr] Checking chunked_transfer v1.4.0 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Checking deflate v0.9.1 [INFO] [stderr] Checking time v0.3.2 [INFO] [stderr] Checking twoway v0.1.8 [INFO] [stderr] Checking buf_redux v0.8.4 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking filetime v0.2.15 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking threadpool v1.8.1 [INFO] [stderr] Checking sha1 v0.6.0 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking tempfile v3.2.0 [INFO] [stderr] Checking multipart v0.18.0 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking tiny_http v0.8.2 [INFO] [stderr] Compiling serde_derive v1.0.130 [INFO] [stderr] Checking serde v1.0.130 [INFO] [stderr] Checking brotli2 v0.3.2 [INFO] [stderr] Checking rouille v3.3.0 [INFO] [stderr] Checking hexagonal v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::fmt::Error` [INFO] [stdout] --> src/domain/entities.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::fmt::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::domain::entities::Pokemon` [INFO] [stdout] --> src/domain/fetch_all_pokemon.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::domain::entities::Pokemon; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Pokemon` [INFO] [stdout] --> src/domain/fetch_pokemon.rs:1:46 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::domain::entities::{PokemonNumber, Pokemon}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Pokemon` [INFO] [stdout] --> src/domain/fetch_pokemon.rs:41:35 [INFO] [stdout] | [INFO] [stdout] 41 | use crate::domain::entities::{Pokemon, PokemonTypes, PokemonName}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Pokemon` [INFO] [stdout] --> src/domain/delete_pokemon.rs:1:46 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::domain::entities::{PokemonNumber, Pokemon}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `FetchOneError` [INFO] [stdout] --> src/domain/delete_pokemon.rs:3:48 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::repositories::pokemon::{Repository, FetchOneError, DeleteError}; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `InMemoryRepository` [INFO] [stdout] --> src/api/mod.rs:1:36 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::repositories::pokemon::{InMemoryRepository, Repository}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::domain::entities::PokemonNumber` [INFO] [stdout] --> src/api/fetch_pokemon.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::domain::entities::PokemonNumber; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::domain::fetch_pokemon::Error` [INFO] [stdout] --> src/api/fetch_pokemon.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use crate::domain::fetch_pokemon::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `serde::Serialize` [INFO] [stdout] --> src/api/delete_pokemon.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use serde::Serialize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::domain::entities::PokemonNumber` [INFO] [stdout] --> src/api/delete_pokemon.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::domain::entities::PokemonNumber; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/domain/create_pokemon.rs:99:13 [INFO] [stdout] | [INFO] [stdout] 99 | let mut repo = Arc::new(InMemoryRepository::new().with_error()); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/domain/fetch_pokemon.rs:25:66 [INFO] [stdout] | [INFO] [stdout] 25 | let valid_num = PokemonNumber::try_from(req.number).map_err(|e|Error::BadRequest)?; [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: if this is intentional, prefix it with an underscore [INFO] [stdout] | [INFO] [stdout] 25 | let valid_num = PokemonNumber::try_from(req.number).map_err(|_e|Error::BadRequest)?; [INFO] [stdout] | + [INFO] [stdout] help: you might have meant to pattern match on the similarly named constant `_` [INFO] [stdout] | [INFO] [stdout] 25 - let valid_num = PokemonNumber::try_from(req.number).map_err(|e|Error::BadRequest)?; [INFO] [stdout] 25 + let valid_num = PokemonNumber::try_from(req.number).map_err(|api::fetch_pokemon::_|Error::BadRequest)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `InMemoryRepository` [INFO] [stdout] --> src/domain/create_pokemon.rs:2:36 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::repositories::pokemon::{InMemoryRepository, Repository, InsertError}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt::Error` [INFO] [stdout] --> src/domain/entities.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::fmt::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `InMemoryRepository` [INFO] [stdout] --> src/domain/fetch_all_pokemon.rs:1:36 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::repositories::pokemon::{InMemoryRepository, Repository, FetchAllError}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::domain::entities::Pokemon` [INFO] [stdout] --> src/domain/fetch_all_pokemon.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::domain::entities::Pokemon; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Pokemon` [INFO] [stdout] --> src/domain/fetch_pokemon.rs:1:46 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::domain::entities::{PokemonNumber, Pokemon}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Pokemon` [INFO] [stdout] --> src/domain/delete_pokemon.rs:1:46 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::domain::entities::{PokemonNumber, Pokemon}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `FetchOneError` [INFO] [stdout] --> src/domain/delete_pokemon.rs:3:48 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::repositories::pokemon::{Repository, FetchOneError, DeleteError}; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `InMemoryRepository` [INFO] [stdout] --> src/api/mod.rs:1:36 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::repositories::pokemon::{InMemoryRepository, Repository}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::domain::entities::PokemonNumber` [INFO] [stdout] --> src/api/fetch_pokemon.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::domain::entities::PokemonNumber; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::domain::fetch_pokemon::Error` [INFO] [stdout] --> src/api/fetch_pokemon.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use crate::domain::fetch_pokemon::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `serde::Serialize` [INFO] [stdout] --> src/api/delete_pokemon.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use serde::Serialize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::domain::entities::PokemonNumber` [INFO] [stdout] --> src/api/delete_pokemon.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::domain::entities::PokemonNumber; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/domain/create_pokemon.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | repo.insert(number, name, types); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 81 | let _ = repo.insert(number, name, types); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/domain/fetch_pokemon.rs:25:66 [INFO] [stdout] | [INFO] [stdout] 25 | let valid_num = PokemonNumber::try_from(req.number).map_err(|e|Error::BadRequest)?; [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: if this is intentional, prefix it with an underscore [INFO] [stdout] | [INFO] [stdout] 25 | let valid_num = PokemonNumber::try_from(req.number).map_err(|_e|Error::BadRequest)?; [INFO] [stdout] | + [INFO] [stdout] help: you might have meant to pattern match on the similarly named constant `_` [INFO] [stdout] | [INFO] [stdout] 25 - let valid_num = PokemonNumber::try_from(req.number).map_err(|e|Error::BadRequest)?; [INFO] [stdout] 25 + let valid_num = PokemonNumber::try_from(req.number).map_err(|api::fetch_pokemon::_|Error::BadRequest)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 19.42s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: buf_redux v0.8.4, multipart v0.18.0 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 3` [INFO] running `Command { std: "docker" "inspect" "031e5c8565dbcb101906678e50ceba1256ffa5aac1bca8a5904a08cfcd197724", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "031e5c8565dbcb101906678e50ceba1256ffa5aac1bca8a5904a08cfcd197724", kill_on_drop: false }` [INFO] [stdout] 031e5c8565dbcb101906678e50ceba1256ffa5aac1bca8a5904a08cfcd197724