[INFO] cloning repository https://github.com/JosephBrooksbank/advent_of_code_2024 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/JosephBrooksbank/advent_of_code_2024" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJosephBrooksbank%2Fadvent_of_code_2024", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJosephBrooksbank%2Fadvent_of_code_2024'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2dbac428cc64d50f423fcc390930098751231fbd [INFO] checking JosephBrooksbank/advent_of_code_2024 against try#0611f7de057c584b8771102fde7aed6c70c71d3b for pr-146440 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJosephBrooksbank%2Fadvent_of_code_2024" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/JosephBrooksbank/advent_of_code_2024 [INFO] finished tweaking git repo https://github.com/JosephBrooksbank/advent_of_code_2024 [INFO] tweaked toml for git repo https://github.com/JosephBrooksbank/advent_of_code_2024 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/JosephBrooksbank/advent_of_code_2024 on toolchain 0611f7de057c584b8771102fde7aed6c70c71d3b [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+0611f7de057c584b8771102fde7aed6c70c71d3b" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/JosephBrooksbank/advent_of_code_2024 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+0611f7de057c584b8771102fde7aed6c70c71d3b" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+0611f7de057c584b8771102fde7aed6c70c71d3b" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 781096f97c18facfca29b24db9ca2c51b0972451e7a02cee2b17e14d80f6b772 [INFO] running `Command { std: "docker" "start" "-a" "781096f97c18facfca29b24db9ca2c51b0972451e7a02cee2b17e14d80f6b772", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "781096f97c18facfca29b24db9ca2c51b0972451e7a02cee2b17e14d80f6b772", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "781096f97c18facfca29b24db9ca2c51b0972451e7a02cee2b17e14d80f6b772", kill_on_drop: false }` [INFO] [stdout] 781096f97c18facfca29b24db9ca2c51b0972451e7a02cee2b17e14d80f6b772 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+0611f7de057c584b8771102fde7aed6c70c71d3b" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b08ad9bc3b39f0a33c00bc9536a567c105d0f4f2da7b0aaa69bfe5de5aa5b0b6 [INFO] running `Command { std: "docker" "start" "-a" "b08ad9bc3b39f0a33c00bc9536a567c105d0f4f2da7b0aaa69bfe5de5aa5b0b6", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.92 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.90 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Checking advent_of_code_2024 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::cmp::max` [INFO] [stdout] --> src/days/day_4.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::cmp::max; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/days/day_4.rs:135:12 [INFO] [stdout] | [INFO] [stdout] 135 | if (upper == 'M' && lower == 'S') { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 135 - if (upper == 'M' && lower == 'S') { [INFO] [stdout] 135 + if upper == 'M' && lower == 'S' { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/days/day_4.rs:138:12 [INFO] [stdout] | [INFO] [stdout] 138 | if (upper == 'S' && lower == 'M') { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 138 - if (upper == 'S' && lower == 'M') { [INFO] [stdout] 138 + if upper == 'S' && lower == 'M' { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/days/day_4.rs:146:12 [INFO] [stdout] | [INFO] [stdout] 146 | if (self.check_diagonal(s, &Direction::UpRight, &Direction::DownLeft)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 146 - if (self.check_diagonal(s, &Direction::UpRight, &Direction::DownLeft)) { [INFO] [stdout] 146 + if self.check_diagonal(s, &Direction::UpRight, &Direction::DownLeft) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/days/day_4.rs:150:12 [INFO] [stdout] | [INFO] [stdout] 150 | if (self.check_diagonal(s, &Direction::UpLeft, &Direction::DownRight)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 150 - if (self.check_diagonal(s, &Direction::UpLeft, &Direction::DownRight)) { [INFO] [stdout] 150 + if self.check_diagonal(s, &Direction::UpLeft, &Direction::DownRight) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cmp::max` [INFO] [stdout] --> src/days/day_4.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::cmp::max; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/days/day_4.rs:135:12 [INFO] [stdout] | [INFO] [stdout] 135 | if (upper == 'M' && lower == 'S') { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 135 - if (upper == 'M' && lower == 'S') { [INFO] [stdout] 135 + if upper == 'M' && lower == 'S' { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/days/day_4.rs:138:12 [INFO] [stdout] | [INFO] [stdout] 138 | if (upper == 'S' && lower == 'M') { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 138 - if (upper == 'S' && lower == 'M') { [INFO] [stdout] 138 + if upper == 'S' && lower == 'M' { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/days/day_4.rs:146:12 [INFO] [stdout] | [INFO] [stdout] 146 | if (self.check_diagonal(s, &Direction::UpRight, &Direction::DownLeft)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 146 - if (self.check_diagonal(s, &Direction::UpRight, &Direction::DownLeft)) { [INFO] [stdout] 146 + if self.check_diagonal(s, &Direction::UpRight, &Direction::DownLeft) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/days/day_4.rs:150:12 [INFO] [stdout] | [INFO] [stdout] 150 | if (self.check_diagonal(s, &Direction::UpLeft, &Direction::DownRight)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 150 - if (self.check_diagonal(s, &Direction::UpLeft, &Direction::DownRight)) { [INFO] [stdout] 150 + if self.check_diagonal(s, &Direction::UpLeft, &Direction::DownRight) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/days/day_2.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | let mut numbers = string_to_numbers::(&line, " "); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `index` [INFO] [stdout] --> src/days/day_2.rs:26:17 [INFO] [stdout] | [INFO] [stdout] 26 | Err(index) => { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_index` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `index` [INFO] [stdout] --> src/days/day_2.rs:48:13 [INFO] [stdout] | [INFO] [stdout] 48 | Err(index) => { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_index` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/days/day_2.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | let mut numbers = string_to_numbers::(&line, " "); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `index` [INFO] [stdout] --> src/days/day_2.rs:26:17 [INFO] [stdout] | [INFO] [stdout] 26 | Err(index) => { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_index` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `index` [INFO] [stdout] --> src/days/day_2.rs:48:13 [INFO] [stdout] | [INFO] [stdout] 48 | Err(index) => { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_index` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `Grid` is more private than the item `day_4::Day4::find_xmas` [INFO] [stdout] --> src/days/day_4.rs:191:5 [INFO] [stdout] | [INFO] [stdout] 191 | pub fn find_xmas(&self, grid: Grid) -> Day4Data { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ method `day_4::Day4::find_xmas` is reachable at visibility `pub` [INFO] [stdout] | [INFO] [stdout] note: but type `Grid` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/days/day_4.rs:36:1 [INFO] [stdout] | [INFO] [stdout] 36 | struct Grid { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_interfaces)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `similarity` is never read [INFO] [stdout] --> src/days/day_1.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct Day1Data { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 6 | total_distance: usize, [INFO] [stdout] 7 | similarity: usize, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Day1Data` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `Grid` is more private than the item `Day4::find_xmas` [INFO] [stdout] --> src/days/day_4.rs:191:5 [INFO] [stdout] | [INFO] [stdout] 191 | pub fn find_xmas(&self, grid: Grid) -> Day4Data { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ method `Day4::find_xmas` is reachable at visibility `pub` [INFO] [stdout] | [INFO] [stdout] note: but type `Grid` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/days/day_4.rs:36:1 [INFO] [stdout] | [INFO] [stdout] 36 | struct Grid { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_interfaces)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `total_distance` and `similarity` are never read [INFO] [stdout] --> src/days/day_1.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct Day1Data { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 6 | total_distance: usize, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 7 | similarity: usize, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Day1Data` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `part1` and `part2` are never read [INFO] [stdout] --> src/days/day_4.rs:187:5 [INFO] [stdout] | [INFO] [stdout] 186 | pub struct Day4Data { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 187 | part1: usize, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 188 | part2: usize, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Day4Data` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `read_full_file` is never used [INFO] [stdout] --> src/utils/file_helpers.rs:28:8 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn read_full_file(day: &str) -> Result, io::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `string_to_numbers` is never used [INFO] [stdout] --> src/utils/string_helpers.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn string_to_numbers(line: &str, delim: &str) -> Vec where ::Err: Debug { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `read_file_line_by_line` is never used [INFO] [stdout] --> src/utils/file_helpers.rs:3:8 [INFO] [stdout] | [INFO] [stdout] 3 | pub fn read_file_line_by_line(file_path: &str) -> Result, io::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `read_sample_file` is never used [INFO] [stdout] --> src/utils/file_helpers.rs:23:8 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn read_sample_file(day: &str) -> Result, io::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `read_full_file` is never used [INFO] [stdout] --> src/utils/file_helpers.rs:28:8 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn read_full_file(day: &str) -> Result, io::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `string_to_numbers` is never used [INFO] [stdout] --> src/utils/string_helpers.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn string_to_numbers(line: &str, delim: &str) -> Vec where ::Err: Debug { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.79s [INFO] running `Command { std: "docker" "inspect" "b08ad9bc3b39f0a33c00bc9536a567c105d0f4f2da7b0aaa69bfe5de5aa5b0b6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b08ad9bc3b39f0a33c00bc9536a567c105d0f4f2da7b0aaa69bfe5de5aa5b0b6", kill_on_drop: false }` [INFO] [stdout] b08ad9bc3b39f0a33c00bc9536a567c105d0f4f2da7b0aaa69bfe5de5aa5b0b6