[INFO] fetching crate rate_my_professor_api_rs 0.1.5... [INFO] building rate_my_professor_api_rs-0.1.5 against master#c7f6aa2869acdbf014d094c6e427e554e160b6db for pr-146237-2 [INFO] extracting crate rate_my_professor_api_rs 0.1.5 into /workspace/builds/worker-5-tc1/source [INFO] started tweaking crates.io crate rate_my_professor_api_rs 0.1.5 [INFO] finished tweaking crates.io crate rate_my_professor_api_rs 0.1.5 [INFO] tweaked toml for crates.io crate rate_my_professor_api_rs 0.1.5 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate rate_my_professor_api_rs 0.1.5 on toolchain c7f6aa2869acdbf014d094c6e427e554e160b6db [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c7f6aa2869acdbf014d094c6e427e554e160b6db" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate rate_my_professor_api_rs 0.1.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c7f6aa2869acdbf014d094c6e427e554e160b6db" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded filepath v0.2.0 [INFO] [stderr] Downloaded miniz_oxide v0.8.2 [INFO] [stderr] Downloaded wasm-bindgen-futures v0.4.49 [INFO] [stderr] Downloaded actix_derive v0.6.2 [INFO] [stderr] Downloaded zstd-safe v7.2.1 [INFO] [stderr] Downloaded actix-server v2.5.0 [INFO] [stderr] Downloaded awc v3.5.1 [INFO] [stderr] Downloaded actix v0.13.5 [INFO] [stderr] Downloaded rustls-pki-types v1.10.1 [INFO] [stderr] Downloaded actix-http v3.9.0 [INFO] [stderr] Downloaded hyper v1.5.2 [INFO] [stderr] Downloaded actix-web v4.9.0 [INFO] [stderr] Downloaded rustls v0.23.20 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:e90291280db7d1fac5b66fc6dad9f9662629e7365a55743daf9bdf73ebc4ea79" "/opt/rustwide/cargo-home/bin/cargo" "+c7f6aa2869acdbf014d094c6e427e554e160b6db" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 37c8e69dc65e8af8b8255aac045318fe13a1ec4ad660d48fe2c555831fb682f6 [INFO] running `Command { std: "docker" "start" "-a" "37c8e69dc65e8af8b8255aac045318fe13a1ec4ad660d48fe2c555831fb682f6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "37c8e69dc65e8af8b8255aac045318fe13a1ec4ad660d48fe2c555831fb682f6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "37c8e69dc65e8af8b8255aac045318fe13a1ec4ad660d48fe2c555831fb682f6", kill_on_drop: false }` [INFO] [stdout] 37c8e69dc65e8af8b8255aac045318fe13a1ec4ad660d48fe2c555831fb682f6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:e90291280db7d1fac5b66fc6dad9f9662629e7365a55743daf9bdf73ebc4ea79" "/opt/rustwide/cargo-home/bin/cargo" "+c7f6aa2869acdbf014d094c6e427e554e160b6db" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ba92b09a5ab5881b60805371c69ef84064cc42dca2c7f23b117679cd68565f58 [INFO] running `Command { std: "docker" "start" "-a" "ba92b09a5ab5881b60805371c69ef84064cc42dca2c7f23b117679cd68565f58", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.169 [INFO] [stderr] Compiling smallvec v1.13.2 [INFO] [stderr] Compiling pkg-config v0.3.31 [INFO] [stderr] Compiling itoa v1.0.14 [INFO] [stderr] Compiling tracing-core v0.1.33 [INFO] [stderr] Compiling quote v1.0.38 [INFO] [stderr] Compiling futures-util v0.3.31 [INFO] [stderr] Compiling openssl v0.10.68 [INFO] [stderr] Compiling serde v1.0.217 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling zstd-safe v7.2.1 [INFO] [stderr] Compiling actix-service v2.0.2 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Compiling serde_json v1.0.135 [INFO] [stderr] Compiling http v1.2.0 [INFO] [stderr] Compiling http v0.2.12 [INFO] [stderr] Compiling time-macros v0.2.19 [INFO] [stderr] Compiling miniz_oxide v0.8.2 [INFO] [stderr] Compiling brotli-decompressor v4.0.1 [INFO] [stderr] Compiling bytestring v1.4.0 [INFO] [stderr] Compiling tokio-openssl v0.6.5 [INFO] [stderr] Compiling cpufeatures v0.2.16 [INFO] [stderr] Compiling syn v2.0.95 [INFO] [stderr] Compiling bytes v1.9.0 [INFO] [stderr] Compiling flate2 v1.0.35 [INFO] [stderr] Compiling tracing v0.1.41 [INFO] [stderr] Compiling rustls-pki-types v1.10.1 [INFO] [stderr] Compiling crossbeam-channel v0.5.14 [INFO] [stderr] Compiling float-cmp v0.10.0 [INFO] [stderr] Compiling http-body v1.0.1 [INFO] [stderr] Compiling rustls-pemfile v2.2.0 [INFO] [stderr] Compiling brotli v6.0.0 [INFO] [stderr] Compiling crypto-common v0.1.6 [INFO] [stderr] Compiling block-buffer v0.10.4 [INFO] [stderr] Compiling difflib v0.4.0 [INFO] [stderr] Compiling digest v0.10.7 [INFO] [stderr] Compiling normalize-line-endings v0.3.0 [INFO] [stderr] Compiling predicates-core v1.0.9 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling signal-hook-registry v1.4.2 [INFO] [stderr] Compiling mio v1.0.3 [INFO] [stderr] Compiling socket2 v0.5.8 [INFO] [stderr] Compiling getrandom v0.2.15 [INFO] [stderr] Compiling sha1 v0.10.6 [INFO] [stderr] Compiling filepath v0.2.0 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling predicates v3.1.3 [INFO] [stderr] Compiling parking_lot v0.12.3 [INFO] [stderr] Compiling cc v1.2.7 [INFO] [stderr] Compiling time v0.3.37 [INFO] [stderr] Compiling http-body-util v0.1.2 [INFO] [stderr] Compiling openssl-sys v0.9.104 [INFO] [stderr] Compiling zstd-sys v2.0.13+zstd.1.5.6 [INFO] [stderr] Compiling cookie v0.16.2 [INFO] [stderr] Compiling actix-router v0.5.3 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.217 [INFO] [stderr] Compiling actix-macros v0.2.4 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Compiling actix-web-codegen v4.3.0 [INFO] [stderr] Compiling actix_derive v0.6.2 [INFO] [stderr] Compiling zerofrom-derive v0.1.5 [INFO] [stderr] Compiling yoke-derive v0.7.5 [INFO] [stderr] Compiling tokio v1.43.0 [INFO] [stderr] Compiling zerocopy v0.7.35 [INFO] [stderr] Compiling zerofrom v0.1.5 [INFO] [stderr] Compiling yoke v0.7.5 [INFO] [stderr] Compiling ppv-lite86 v0.2.20 [INFO] [stderr] Compiling zerovec v0.10.4 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling zstd v0.13.2 [INFO] [stderr] Compiling tinystr v0.7.6 [INFO] [stderr] Compiling icu_collections v1.5.0 [INFO] [stderr] Compiling icu_locid v1.5.0 [INFO] [stderr] Compiling icu_provider v1.5.0 [INFO] [stderr] Compiling icu_locid_transform v1.5.0 [INFO] [stderr] Compiling icu_properties v1.5.1 [INFO] [stderr] Compiling icu_normalizer v1.5.0 [INFO] [stderr] Compiling tokio-util v0.7.13 [INFO] [stderr] Compiling actix-rt v2.10.0 [INFO] [stderr] Compiling tokio-native-tls v0.3.1 [INFO] [stderr] Compiling tower v0.5.2 [INFO] [stderr] Compiling idna_adapter v1.2.0 [INFO] [stderr] Compiling actix-server v2.5.0 [INFO] [stderr] Compiling idna v1.0.3 [INFO] [stderr] Compiling url v2.5.4 [INFO] [stderr] Compiling serde_urlencoded v0.7.1 [INFO] [stderr] Compiling h2 v0.4.7 [INFO] [stderr] Compiling actix-codec v0.5.2 [INFO] [stderr] Compiling h2 v0.3.26 [INFO] [stderr] Compiling actix-tls v3.4.0 [INFO] [stderr] Compiling actix v0.13.5 [INFO] [stderr] Compiling hyper v1.5.2 [INFO] [stderr] Compiling actix-http v3.9.0 [INFO] [stderr] Compiling hyper-util v0.1.10 [INFO] [stderr] Compiling hyper-tls v0.6.0 [INFO] [stderr] Compiling reqwest v0.12.12 [INFO] [stderr] Compiling awc v3.5.1 [INFO] [stderr] Compiling actix-web v4.9.0 [INFO] [stderr] Compiling rate_my_professor_api_rs v0.1.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::any::type_name` [INFO] [stdout] --> src/features.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use std::any::type_name; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `core::cmp::Ord` [INFO] [stdout] --> src/features.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use core::cmp::Ord; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/features.rs:727:5 [INFO] [stdout] | [INFO] [stdout] 727 | / /** [INFO] [stdout] 728 | | * for "variables", it would be the same as writting [INFO] [stdout] 729 | | * "variables" : "query" : { "text" : school_name } [INFO] [stdout] 730 | | */ [INFO] [stdout] | |_______^ [INFO] [stdout] 731 | / let body = serde_json::json!({ [INFO] [stdout] 732 | | "query": SCHOOL_BODY_QUERY, [INFO] [stdout] 733 | | "variables": variables [INFO] [stdout] 734 | | }); [INFO] [stdout] | |_______- rustdoc does not generate documentation for statements [INFO] [stdout] | [INFO] [stdout] = help: use `/* */` for a plain comment [INFO] [stdout] = note: `#[warn(unused_doc_comments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `predicates::prelude::*` [INFO] [stdout] --> src/methods.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use predicates::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `comments_data` [INFO] [stdout] --> src/features.rs:188:9 [INFO] [stdout] | [INFO] [stdout] 188 | let comments_data : String = serde_json::from_str(&comments_subsection[index]["node"]["comment"].to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_comments_data` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `would_take_again` [INFO] [stdout] --> src/features.rs:190:9 [INFO] [stdout] | [INFO] [stdout] 190 | let would_take_again : &serde_json::Value = &comments_subsection[index]["node"]["wouldTakeAgain"]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_would_take_again` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/features.rs:180:7 [INFO] [stdout] | [INFO] [stdout] 180 | let mut comments_data : serde_json::Value = response.json().await.unwrap(); [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/features.rs:181:7 [INFO] [stdout] | [INFO] [stdout] 181 | let mut comments_subsection = comments_data["data"]["node"]["ratings"]["edges"].clone(); [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `school_id` [INFO] [stdout] --> src/features.rs:758:9 [INFO] [stdout] | [INFO] [stdout] 758 | let school_id : String = serde_json::from_str(&edges[0]["cursor"].clone().to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_school_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `file_path` [INFO] [stdout] --> src/features.rs:769:34 [INFO] [stdout] | [INFO] [stdout] 769 | let (all_search_result_file, file_path) = create_file("all_search_result.json").await; [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_file_path` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `file_path` [INFO] [stdout] --> src/features.rs:770:28 [INFO] [stdout] | [INFO] [stdout] 770 | let (school_name_file, file_path) = create_file(&(school_name.clone().to_owned() + ".json")).await; [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_file_path` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `index` [INFO] [stdout] --> src/features.rs:773:10 [INFO] [stdout] | [INFO] [stdout] 773 | for (index, data) in results.clone().into_iter().enumerate() { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_index` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/features.rs:811:7 [INFO] [stdout] | [INFO] [stdout] 811 | let mut file = fs::File::create(fileName).unwrap(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/features.rs:874:7 [INFO] [stdout] | [INFO] [stdout] 874 | let mut professor_list_raw : serde_json::Value = response.json().await?; [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `file_path` [INFO] [stdout] --> src/methods.rs:249:20 [INFO] [stdout] | [INFO] [stdout] 249 | let (file, file_path) = create_file(file_name).await; [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_file_path` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `professor_list_returned` [INFO] [stdout] --> src/features.rs:626:13 [INFO] [stdout] | [INFO] [stdout] 626 | let professor_list_returned = get_professor_list_by_school(school_id).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_professor_list_returned` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `main` is never used [INFO] [stdout] --> src/features.rs:610:10 [INFO] [stdout] | [INFO] [stdout] 610 | async fn main() -> Result<()> { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `print_type_of` is never used [INFO] [stdout] --> src/features.rs:792:4 [INFO] [stdout] | [INFO] [stdout] 792 | fn print_type_of(_ : &T) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: crate `rateMyProfessorApi_rs` should have a snake case name [INFO] [stdout] | [INFO] [stdout] = help: convert the identifier to snake case: `rate_my_professor_api_rs` [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `professorID` should have a snake case name [INFO] [stdout] --> src/features.rs:165:40 [INFO] [stdout] | [INFO] [stdout] 165 | pub async fn search_professor_comments(professorID : ProfessorId) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `professor_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `ProfessorCommentsVector` should have a snake case name [INFO] [stdout] --> src/features.rs:183:11 [INFO] [stdout] | [INFO] [stdout] 183 | let mut ProfessorCommentsVector : Vec = Vec::with_capacity(length.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `professor_comments_vector` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Id` should have a snake case name [INFO] [stdout] --> src/features.rs:235:7 [INFO] [stdout] | [INFO] [stdout] 235 | pub Id : String [INFO] [stdout] | ^^ help: convert the identifier to snake case (notice the capitalization): `id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/features.rs:770:66 [INFO] [stdout] | [INFO] [stdout] 770 | let (school_name_file, file_path) = create_file(&(school_name.clone().to_owned() + ".json")).await; [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `fileName` should have a snake case name [INFO] [stdout] --> src/features.rs:810:26 [INFO] [stdout] | [INFO] [stdout] 810 | pub async fn create_file(fileName : &str) -> (fs::File, PathBuf) { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `file_name` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `filePath` should have a snake case name [INFO] [stdout] --> src/features.rs:812:7 [INFO] [stdout] | [INFO] [stdout] 812 | let filePath = file.path().unwrap(); // Ok("/path/to/file") -> "/path/to/file" [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `file_path` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `CollegeName` should have a snake case name [INFO] [stdout] --> src/methods.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub CollegeName : String, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `college_name` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `ProfessorName` should have a snake case name [INFO] [stdout] --> src/methods.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | pub ProfessorName : Option [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `professor_name` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Deserialize` and `Serialize` [INFO] [stdout] --> src/bin/execute_features.rs:3:13 [INFO] [stdout] | [INFO] [stdout] 3 | use serde::{Deserialize, Serialize}; [INFO] [stdout] | ^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Deserialize` and `Serialize` [INFO] [stdout] --> src/bin/execute_methods.rs:4:13 [INFO] [stdout] | [INFO] [stdout] 4 | use serde::{Deserialize, Serialize}; [INFO] [stdout] | ^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `predicates::prelude::*` [INFO] [stdout] --> src/bin/execute_methods.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use predicates::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/execute_methods.rs:100:9 [INFO] [stdout] | [INFO] [stdout] 100 | let mut rate_my_professor_instance = RateMyProfessor::construct_college("Queens College"); [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/execute_methods.rs:111:9 [INFO] [stdout] | [INFO] [stdout] 111 | let mut rate_my_professor_instance_version2 = RateMyProfessor::construct_college_and_professor("City College of New York", "Douglas T... [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `predicates::prelude` [INFO] [stdout] --> src/bin/execute_features.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use predicates::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `professor_list_returned` [INFO] [stdout] --> src/bin/execute_features.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | let professor_list_returned = get_professor_list_by_school(school_id).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_professor_list_returned` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_constructor_methods` is never used [INFO] [stdout] --> src/bin/execute_methods.rs:98:10 [INFO] [stdout] | [INFO] [stdout] 98 | async fn test_constructor_methods() -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 08s [INFO] running `Command { std: "docker" "inspect" "ba92b09a5ab5881b60805371c69ef84064cc42dca2c7f23b117679cd68565f58", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ba92b09a5ab5881b60805371c69ef84064cc42dca2c7f23b117679cd68565f58", kill_on_drop: false }` [INFO] [stdout] ba92b09a5ab5881b60805371c69ef84064cc42dca2c7f23b117679cd68565f58 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:e90291280db7d1fac5b66fc6dad9f9662629e7365a55743daf9bdf73ebc4ea79" "/opt/rustwide/cargo-home/bin/cargo" "+c7f6aa2869acdbf014d094c6e427e554e160b6db" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 873558d41f6f6cd020ff1771154b04f52ffcb2f3dfc27872055108d3ee8953cb [INFO] running `Command { std: "docker" "start" "-a" "873558d41f6f6cd020ff1771154b04f52ffcb2f3dfc27872055108d3ee8953cb", kill_on_drop: false }` [INFO] [stdout] warning: unused import: `std::any::type_name` [INFO] [stdout] --> src/features.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use std::any::type_name; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `core::cmp::Ord` [INFO] [stdout] --> src/features.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use core::cmp::Ord; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/features.rs:727:5 [INFO] [stdout] | [INFO] [stdout] 727 | / /** [INFO] [stdout] 728 | | * for "variables", it would be the same as writting [INFO] [stdout] 729 | | * "variables" : "query" : { "text" : school_name } [INFO] [stdout] 730 | | */ [INFO] [stdout] | |_______^ [INFO] [stdout] 731 | / let body = serde_json::json!({ [INFO] [stdout] 732 | | "query": SCHOOL_BODY_QUERY, [INFO] [stdout] 733 | | "variables": variables [INFO] [stdout] 734 | | }); [INFO] [stdout] | |_______- rustdoc does not generate documentation for statements [INFO] [stdout] | [INFO] [stdout] = help: use `/* */` for a plain comment [INFO] [stdout] = note: `#[warn(unused_doc_comments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `predicates::prelude::*` [INFO] [stdout] --> src/methods.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use predicates::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `comments_data` [INFO] [stdout] --> src/features.rs:188:9 [INFO] [stdout] | [INFO] [stdout] 188 | let comments_data : String = serde_json::from_str(&comments_subsection[index]["node"]["comment"].to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_comments_data` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `would_take_again` [INFO] [stdout] --> src/features.rs:190:9 [INFO] [stdout] | [INFO] [stdout] 190 | let would_take_again : &serde_json::Value = &comments_subsection[index]["node"]["wouldTakeAgain"]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_would_take_again` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/features.rs:180:7 [INFO] [stdout] | [INFO] [stdout] 180 | let mut comments_data : serde_json::Value = response.json().await.unwrap(); [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/features.rs:181:7 [INFO] [stdout] | [INFO] [stdout] 181 | let mut comments_subsection = comments_data["data"]["node"]["ratings"]["edges"].clone(); [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `school_id` [INFO] [stdout] --> src/features.rs:758:9 [INFO] [stdout] | [INFO] [stdout] 758 | let school_id : String = serde_json::from_str(&edges[0]["cursor"].clone().to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_school_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `file_path` [INFO] [stdout] --> src/features.rs:769:34 [INFO] [stdout] | [INFO] [stdout] 769 | let (all_search_result_file, file_path) = create_file("all_search_result.json").await; [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_file_path` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `file_path` [INFO] [stdout] --> src/features.rs:770:28 [INFO] [stdout] | [INFO] [stdout] 770 | let (school_name_file, file_path) = create_file(&(school_name.clone().to_owned() + ".json")).await; [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_file_path` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `index` [INFO] [stdout] --> src/features.rs:773:10 [INFO] [stdout] | [INFO] [stdout] 773 | for (index, data) in results.clone().into_iter().enumerate() { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_index` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/features.rs:811:7 [INFO] [stdout] | [INFO] [stdout] 811 | let mut file = fs::File::create(fileName).unwrap(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/features.rs:874:7 [INFO] [stdout] | [INFO] [stdout] 874 | let mut professor_list_raw : serde_json::Value = response.json().await?; [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `file_path` [INFO] [stdout] --> src/methods.rs:249:20 [INFO] [stdout] | [INFO] [stdout] 249 | let (file, file_path) = create_file(file_name).await; [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_file_path` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling rate_my_professor_api_rs v0.1.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `professor_list_returned` [INFO] [stdout] --> src/features.rs:626:13 [INFO] [stdout] | [INFO] [stdout] 626 | let professor_list_returned = get_professor_list_by_school(school_id).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_professor_list_returned` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `main` is never used [INFO] [stdout] --> src/features.rs:610:10 [INFO] [stdout] | [INFO] [stdout] 610 | async fn main() -> Result<()> { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `print_type_of` is never used [INFO] [stdout] --> src/features.rs:792:4 [INFO] [stdout] | [INFO] [stdout] 792 | fn print_type_of(_ : &T) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: crate `rateMyProfessorApi_rs` should have a snake case name [INFO] [stdout] | [INFO] [stdout] = help: convert the identifier to snake case: `rate_my_professor_api_rs` [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `professorID` should have a snake case name [INFO] [stdout] --> src/features.rs:165:40 [INFO] [stdout] | [INFO] [stdout] 165 | pub async fn search_professor_comments(professorID : ProfessorId) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `professor_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `ProfessorCommentsVector` should have a snake case name [INFO] [stdout] --> src/features.rs:183:11 [INFO] [stdout] | [INFO] [stdout] 183 | let mut ProfessorCommentsVector : Vec = Vec::with_capacity(length.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `professor_comments_vector` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Id` should have a snake case name [INFO] [stdout] --> src/features.rs:235:7 [INFO] [stdout] | [INFO] [stdout] 235 | pub Id : String [INFO] [stdout] | ^^ help: convert the identifier to snake case (notice the capitalization): `id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/features.rs:770:66 [INFO] [stdout] | [INFO] [stdout] 770 | let (school_name_file, file_path) = create_file(&(school_name.clone().to_owned() + ".json")).await; [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `fileName` should have a snake case name [INFO] [stdout] --> src/features.rs:810:26 [INFO] [stdout] | [INFO] [stdout] 810 | pub async fn create_file(fileName : &str) -> (fs::File, PathBuf) { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `file_name` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `filePath` should have a snake case name [INFO] [stdout] --> src/features.rs:812:7 [INFO] [stdout] | [INFO] [stdout] 812 | let filePath = file.path().unwrap(); // Ok("/path/to/file") -> "/path/to/file" [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `file_path` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `CollegeName` should have a snake case name [INFO] [stdout] --> src/methods.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub CollegeName : String, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `college_name` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `ProfessorName` should have a snake case name [INFO] [stdout] --> src/methods.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | pub ProfessorName : Option [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `professor_name` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Deserialize` and `Serialize` [INFO] [stdout] --> src/bin/execute_features.rs:3:13 [INFO] [stdout] | [INFO] [stdout] 3 | use serde::{Deserialize, Serialize}; [INFO] [stdout] | ^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Deserialize` and `Serialize` [INFO] [stdout] --> src/bin/execute_methods.rs:4:13 [INFO] [stdout] | [INFO] [stdout] 4 | use serde::{Deserialize, Serialize}; [INFO] [stdout] | ^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `predicates::prelude::*` [INFO] [stdout] --> src/bin/execute_methods.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use predicates::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/execute_methods.rs:100:9 [INFO] [stdout] | [INFO] [stdout] 100 | let mut rate_my_professor_instance = RateMyProfessor::construct_college("Queens College"); [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/execute_methods.rs:111:9 [INFO] [stdout] | [INFO] [stdout] 111 | let mut rate_my_professor_instance_version2 = RateMyProfessor::construct_college_and_professor("City College of New York", "Douglas T... [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `predicates::prelude` [INFO] [stdout] --> src/bin/execute_features.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use predicates::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `professor_list_returned` [INFO] [stdout] --> src/bin/execute_features.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | let professor_list_returned = get_professor_list_by_school(school_id).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_professor_list_returned` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/bin/execute_methods.rs:119:5 [INFO] [stdout] | [INFO] [stdout] 119 | test_constructor_methods().await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 119 | let _ = test_constructor_methods().await; [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::any::type_name` [INFO] [stdout] --> src/features.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use std::any::type_name; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `core::cmp::Ord` [INFO] [stdout] --> src/features.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use core::cmp::Ord; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/features.rs:727:5 [INFO] [stdout] | [INFO] [stdout] 727 | / /** [INFO] [stdout] 728 | | * for "variables", it would be the same as writting [INFO] [stdout] 729 | | * "variables" : "query" : { "text" : school_name } [INFO] [stdout] 730 | | */ [INFO] [stdout] | |_______^ [INFO] [stdout] 731 | / let body = serde_json::json!({ [INFO] [stdout] 732 | | "query": SCHOOL_BODY_QUERY, [INFO] [stdout] 733 | | "variables": variables [INFO] [stdout] 734 | | }); [INFO] [stdout] | |_______- rustdoc does not generate documentation for statements [INFO] [stdout] | [INFO] [stdout] = help: use `/* */` for a plain comment [INFO] [stdout] = note: `#[warn(unused_doc_comments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `predicates::prelude::*` [INFO] [stdout] --> src/methods.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use predicates::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `comments_data` [INFO] [stdout] --> src/features.rs:188:9 [INFO] [stdout] | [INFO] [stdout] 188 | let comments_data : String = serde_json::from_str(&comments_subsection[index]["node"]["comment"].to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_comments_data` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `would_take_again` [INFO] [stdout] --> src/features.rs:190:9 [INFO] [stdout] | [INFO] [stdout] 190 | let would_take_again : &serde_json::Value = &comments_subsection[index]["node"]["wouldTakeAgain"]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_would_take_again` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/features.rs:180:7 [INFO] [stdout] | [INFO] [stdout] 180 | let mut comments_data : serde_json::Value = response.json().await.unwrap(); [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/features.rs:181:7 [INFO] [stdout] | [INFO] [stdout] 181 | let mut comments_subsection = comments_data["data"]["node"]["ratings"]["edges"].clone(); [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `school_id` [INFO] [stdout] --> src/features.rs:758:9 [INFO] [stdout] | [INFO] [stdout] 758 | let school_id : String = serde_json::from_str(&edges[0]["cursor"].clone().to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_school_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `file_path` [INFO] [stdout] --> src/features.rs:769:34 [INFO] [stdout] | [INFO] [stdout] 769 | let (all_search_result_file, file_path) = create_file("all_search_result.json").await; [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_file_path` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `file_path` [INFO] [stdout] --> src/features.rs:770:28 [INFO] [stdout] | [INFO] [stdout] 770 | let (school_name_file, file_path) = create_file(&(school_name.clone().to_owned() + ".json")).await; [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_file_path` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `index` [INFO] [stdout] --> src/features.rs:773:10 [INFO] [stdout] | [INFO] [stdout] 773 | for (index, data) in results.clone().into_iter().enumerate() { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_index` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/features.rs:811:7 [INFO] [stdout] | [INFO] [stdout] 811 | let mut file = fs::File::create(fileName).unwrap(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/features.rs:874:7 [INFO] [stdout] | [INFO] [stdout] 874 | let mut professor_list_raw : serde_json::Value = response.json().await?; [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `file_path` [INFO] [stdout] --> src/methods.rs:249:20 [INFO] [stdout] | [INFO] [stdout] 249 | let (file, file_path) = create_file(file_name).await; [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_file_path` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `professor_list_returned` [INFO] [stdout] --> src/features.rs:626:13 [INFO] [stdout] | [INFO] [stdout] 626 | let professor_list_returned = get_professor_list_by_school(school_id).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_professor_list_returned` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `main` is never used [INFO] [stdout] --> src/features.rs:610:10 [INFO] [stdout] | [INFO] [stdout] 610 | async fn main() -> Result<()> { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `print_type_of` is never used [INFO] [stdout] --> src/features.rs:792:4 [INFO] [stdout] | [INFO] [stdout] 792 | fn print_type_of(_ : &T) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `professorID` should have a snake case name [INFO] [stdout] --> src/features.rs:165:40 [INFO] [stdout] | [INFO] [stdout] 165 | pub async fn search_professor_comments(professorID : ProfessorId) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `professor_id` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `ProfessorCommentsVector` should have a snake case name [INFO] [stdout] --> src/features.rs:183:11 [INFO] [stdout] | [INFO] [stdout] 183 | let mut ProfessorCommentsVector : Vec = Vec::with_capacity(length.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `professor_comments_vector` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Id` should have a snake case name [INFO] [stdout] --> src/features.rs:235:7 [INFO] [stdout] | [INFO] [stdout] 235 | pub Id : String [INFO] [stdout] | ^^ help: convert the identifier to snake case (notice the capitalization): `id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/features.rs:770:66 [INFO] [stdout] | [INFO] [stdout] 770 | let (school_name_file, file_path) = create_file(&(school_name.clone().to_owned() + ".json")).await; [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `fileName` should have a snake case name [INFO] [stdout] --> src/features.rs:810:26 [INFO] [stdout] | [INFO] [stdout] 810 | pub async fn create_file(fileName : &str) -> (fs::File, PathBuf) { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `file_name` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `filePath` should have a snake case name [INFO] [stdout] --> src/features.rs:812:7 [INFO] [stdout] | [INFO] [stdout] 812 | let filePath = file.path().unwrap(); // Ok("/path/to/file") -> "/path/to/file" [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `file_path` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `CollegeName` should have a snake case name [INFO] [stdout] --> src/methods.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub CollegeName : String, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `college_name` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `ProfessorName` should have a snake case name [INFO] [stdout] --> src/methods.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | pub ProfessorName : Option [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `professor_name` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `test` profile [unoptimized + debuginfo] target(s) in 3.33s [INFO] running `Command { std: "docker" "inspect" "873558d41f6f6cd020ff1771154b04f52ffcb2f3dfc27872055108d3ee8953cb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "873558d41f6f6cd020ff1771154b04f52ffcb2f3dfc27872055108d3ee8953cb", kill_on_drop: false }` [INFO] [stdout] 873558d41f6f6cd020ff1771154b04f52ffcb2f3dfc27872055108d3ee8953cb