[INFO] cloning repository https://github.com/r1cebank/rgb [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/r1cebank/rgb" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fr1cebank%2Frgb", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fr1cebank%2Frgb'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e4dc4148c5acca4bdaa48c391f72f0a983eb67b1 [INFO] building r1cebank/rgb against master#c7f6aa2869acdbf014d094c6e427e554e160b6db for pr-146237-2 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fr1cebank%2Frgb" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/r1cebank/rgb [INFO] finished tweaking git repo https://github.com/r1cebank/rgb [INFO] tweaked toml for git repo https://github.com/r1cebank/rgb written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/r1cebank/rgb on toolchain c7f6aa2869acdbf014d094c6e427e554e160b6db [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c7f6aa2869acdbf014d094c6e427e554e160b6db" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/r1cebank/rgb already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c7f6aa2869acdbf014d094c6e427e554e160b6db" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded standback v0.2.11 [INFO] [stderr] Downloaded time v0.2.22 [INFO] [stderr] Downloaded rustc-demangle v0.1.18 [INFO] [stderr] Downloaded adler v0.2.3 [INFO] [stderr] Downloaded net2 v0.2.35 [INFO] [stderr] Downloaded glutin_glx_sys v0.1.7 [INFO] [stderr] Downloaded base-x v0.2.7 [INFO] [stderr] Downloaded syn v1.0.48 [INFO] [stderr] Downloaded crossterm_winapi v0.5.1 [INFO] [stderr] Downloaded image v0.22.5 [INFO] [stderr] Downloaded png v0.15.3 [INFO] [stderr] Downloaded yaml-rust v0.3.5 [INFO] [stderr] Downloaded bytemuck v1.4.1 [INFO] [stderr] Downloaded piston2d-gfx_graphics v0.72.0 [INFO] [stderr] Downloaded enum-map-derive v0.4.6 [INFO] [stderr] Downloaded pistoncore-input v1.0.0 [INFO] [stderr] Downloaded num-derive v0.2.5 [INFO] [stderr] Downloaded futures-sink v0.3.7 [INFO] [stderr] Downloaded crossterm v0.14.2 [INFO] [stderr] Downloaded const-random-macro v0.1.11 [INFO] [stderr] Downloaded pistoncore-glutin_window v0.67.1 [INFO] [stderr] Downloaded owned_ttf_parser v0.6.0 [INFO] [stderr] Downloaded glutin_egl_sys v0.1.5 [INFO] [stderr] Downloaded wasm-bindgen v0.2.68 [INFO] [stderr] Downloaded jpeg-decoder v0.1.20 [INFO] [stderr] Downloaded blake2b_simd v0.5.11 [INFO] [stderr] Downloaded redox_users v0.3.5 [INFO] [stderr] Downloaded piston v0.52.0 [INFO] [stderr] Downloaded addr2line v0.14.0 [INFO] [stderr] Downloaded ordered-float v1.1.0 [INFO] [stderr] Downloaded sha1 v0.6.0 [INFO] [stderr] Downloaded cpal v0.8.2 [INFO] [stderr] Downloaded getrandom v0.2.0 [INFO] [stderr] Downloaded image v0.23.11 [INFO] [stderr] Downloaded signal-hook-registry v1.2.2 [INFO] [stderr] Downloaded flume v0.9.1 [INFO] [stderr] Downloaded weezl v0.1.2 [INFO] [stderr] Downloaded strum_macros v0.19.4 [INFO] [stderr] Downloaded wasm-bindgen-shared v0.2.68 [INFO] [stderr] Downloaded time-macros-impl v0.1.1 [INFO] [stderr] Downloaded owning_ref v0.4.1 [INFO] [stderr] Downloaded cursive v0.14.1 [INFO] [stderr] Downloaded itertools v0.8.2 [INFO] [stderr] Downloaded tiff v0.6.0 [INFO] [stderr] Downloaded ttf-parser v0.6.2 [INFO] [stderr] Downloaded ab_glyph_rasterizer v0.1.4 [INFO] [stderr] Downloaded piston2d-graphics v0.39.0 [INFO] [stderr] Downloaded pistoncore-window v0.47.0 [INFO] [stderr] Downloaded libc v0.2.80 [INFO] [stderr] Downloaded pistoncore-event_loop v0.52.0 [INFO] [stderr] Downloaded object v0.22.0 [INFO] [stderr] Downloaded backtrace v0.3.54 [INFO] [stderr] Downloaded getrandom v0.1.15 [INFO] [stderr] Downloaded rust-argon2 v0.8.2 [INFO] [stderr] Downloaded term v0.6.1 [INFO] [stderr] Downloaded simplelog v0.7.6 [INFO] [stderr] Downloaded strum v0.19.5 [INFO] [stderr] Downloaded wasm-bindgen-backend v0.2.68 [INFO] [stderr] Downloaded wasm-bindgen-macro v0.2.68 [INFO] [stderr] Downloaded tiff v0.3.1 [INFO] [stderr] Downloaded blockish v0.0.8 [INFO] [stderr] Downloaded const-random v0.1.11 [INFO] [stderr] Downloaded crossbeam-channel v0.4.4 [INFO] [stderr] Downloaded smallvec v1.5.0 [INFO] [stderr] Downloaded enum-map v0.6.4 [INFO] [stderr] Downloaded enumset v0.4.5 [INFO] [stderr] Downloaded futures-core v0.3.7 [INFO] [stderr] Downloaded spinning_top v0.2.2 [INFO] [stderr] Downloaded gif v0.11.1 [INFO] [stderr] Downloaded crossbeam-epoch v0.9.0 [INFO] [stderr] Downloaded hermit-abi v0.1.17 [INFO] [stderr] Downloaded libloading v0.6.5 [INFO] [stderr] Downloaded piston_window v0.116.0 [INFO] [stderr] Downloaded cursive_hexview v0.3.0 [INFO] [stderr] Downloaded rusttype v0.9.2 [INFO] [stderr] Downloaded miniz_oxide v0.4.3 [INFO] [stderr] Downloaded piston-graphics_api_version v1.0.0 [INFO] [stderr] Downloaded array-macro v1.0.5 [INFO] [stderr] Downloaded enumset_derive v0.4.4 [INFO] [stderr] Downloaded signal-hook v0.1.16 [INFO] [stderr] Downloaded num-iter v0.1.42 [INFO] [stderr] Downloaded crossbeam-utils v0.8.0 [INFO] [stderr] Downloaded const_fn v0.4.3 [INFO] [stderr] Downloaded cc v1.0.61 [INFO] [stderr] Downloaded wasm-bindgen-macro-support v0.2.68 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:e90291280db7d1fac5b66fc6dad9f9662629e7365a55743daf9bdf73ebc4ea79" "/opt/rustwide/cargo-home/bin/cargo" "+c7f6aa2869acdbf014d094c6e427e554e160b6db" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d35e9af444443caef1be588e0f1b1b1cb4433f639402ade84e668a342592e892 [INFO] running `Command { std: "docker" "start" "-a" "d35e9af444443caef1be588e0f1b1b1cb4433f639402ade84e668a342592e892", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d35e9af444443caef1be588e0f1b1b1cb4433f639402ade84e668a342592e892", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d35e9af444443caef1be588e0f1b1b1cb4433f639402ade84e668a342592e892", kill_on_drop: false }` [INFO] [stdout] d35e9af444443caef1be588e0f1b1b1cb4433f639402ade84e668a342592e892 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:e90291280db7d1fac5b66fc6dad9f9662629e7365a55743daf9bdf73ebc4ea79" "/opt/rustwide/cargo-home/bin/cargo" "+c7f6aa2869acdbf014d094c6e427e554e160b6db" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1e2123b730a7490a498b6c1d3341cba569d05e43cac356636fc70fb81e6f2d4b [INFO] running `Command { std: "docker" "start" "-a" "1e2123b730a7490a498b6c1d3341cba569d05e43cac356636fc70fb81e6f2d4b", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling libc v0.2.80 [INFO] [stderr] Compiling xml-rs v0.8.3 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling khronos_api v3.1.0 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling const_fn v0.4.3 [INFO] [stderr] Compiling syn v1.0.48 [INFO] [stderr] Compiling pkg-config v0.3.19 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling libloading v0.6.5 [INFO] [stderr] Compiling piston-float v1.0.0 [INFO] [stderr] Compiling rayon-core v1.9.0 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling nix v0.14.1 [INFO] [stderr] Compiling void v1.0.2 [INFO] [stderr] Compiling serde_derive v1.0.117 [INFO] [stderr] Compiling dlib v0.4.2 [INFO] [stderr] Compiling piston-viewport v1.0.0 [INFO] [stderr] Compiling wayland-sys v0.21.13 [INFO] [stderr] Compiling serde v1.0.117 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Compiling piston-graphics_api_version v1.0.0 [INFO] [stderr] Compiling either v1.6.1 [INFO] [stderr] Compiling downcast-rs v1.2.0 [INFO] [stderr] Compiling crc32fast v1.2.1 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling crossbeam-utils v0.8.0 [INFO] [stderr] Compiling memoffset v0.5.6 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling rayon v1.5.0 [INFO] [stderr] Compiling miniz_oxide v0.4.3 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Compiling wayland-scanner v0.21.13 [INFO] [stderr] Compiling stb_truetype v0.3.1 [INFO] [stderr] Compiling parking_lot_core v0.6.2 [INFO] [stderr] Compiling parking_lot v0.9.0 [INFO] [stderr] Compiling num_cpus v1.13.0 [INFO] [stderr] Compiling x11-dl v2.18.5 [INFO] [stderr] Compiling num-rational v0.3.2 [INFO] [stderr] Compiling num-iter v0.1.42 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Compiling walkdir v2.3.1 [INFO] [stderr] Compiling draw_state v0.8.0 [INFO] [stderr] Compiling smallvec v0.6.13 [INFO] [stderr] Compiling cc v1.0.61 [INFO] [stderr] Compiling adler v0.2.3 [INFO] [stderr] Compiling xdg v2.2.0 [INFO] [stderr] Compiling weezl v0.1.2 [INFO] [stderr] Compiling getrandom v0.1.15 [INFO] [stderr] Compiling gfx_core v0.9.2 [INFO] [stderr] Compiling crossbeam-epoch v0.9.0 [INFO] [stderr] Compiling crossbeam-channel v0.5.0 [INFO] [stderr] Compiling standback v0.2.11 [INFO] [stderr] Compiling memmap v0.7.0 [INFO] [stderr] Compiling crossbeam-deque v0.8.0 [INFO] [stderr] Compiling glutin_egl_sys v0.1.5 [INFO] [stderr] Compiling glutin_glx_sys v0.1.7 [INFO] [stderr] Compiling miniz_oxide v0.3.7 [INFO] [stderr] Compiling deflate v0.8.6 [INFO] [stderr] Compiling gl_generator v0.10.0 [INFO] [stderr] Compiling lock_api v0.3.4 [INFO] [stderr] Compiling color_quant v1.1.0 [INFO] [stderr] Compiling approx v0.3.2 [INFO] [stderr] Compiling ordered-float v1.1.0 [INFO] [stderr] Compiling wayland-client v0.21.13 [INFO] [stderr] Compiling wayland-protocols v0.21.13 [INFO] [stderr] Compiling rusttype v0.8.3 [INFO] [stderr] Compiling line_drawing v0.7.0 [INFO] [stderr] Compiling libloading v0.5.2 [INFO] [stderr] Compiling ttf-parser v0.6.2 [INFO] [stderr] Compiling png v0.16.7 [INFO] [stderr] Compiling gif v0.11.1 [INFO] [stderr] Compiling rusttype v0.7.9 [INFO] [stderr] Compiling andrew v0.2.1 [INFO] [stderr] Compiling gl v0.11.0 [INFO] [stderr] Compiling gfx_gl v0.6.1 [INFO] [stderr] Compiling raw-window-handle v0.3.3 [INFO] [stderr] Compiling shared_library v0.1.9 [INFO] [stderr] Compiling bytemuck v1.4.1 [INFO] [stderr] Compiling ab_glyph_rasterizer v0.1.4 [INFO] [stderr] Compiling piston-texture v0.8.0 [INFO] [stderr] Compiling scoped_threadpool v0.1.9 [INFO] [stderr] Compiling osmesa-sys v0.1.2 [INFO] [stderr] Compiling rand_core v0.5.1 [INFO] [stderr] Compiling gfx v0.18.2 [INFO] [stderr] Compiling alsa-sys v0.1.2 [INFO] [stderr] Compiling dirs-sys v0.3.5 [INFO] [stderr] Compiling owned_ttf_parser v0.6.0 [INFO] [stderr] Compiling shader_version v0.7.0 [INFO] [stderr] Compiling vecmath v1.0.0 [INFO] [stderr] Compiling ppv-lite86 v0.2.10 [INFO] [stderr] Compiling rusttype v0.9.2 [INFO] [stderr] Compiling interpolation v0.2.0 [INFO] [stderr] Compiling read_color v1.0.0 [INFO] [stderr] Compiling dirs v2.0.2 [INFO] [stderr] Compiling time v0.2.22 [INFO] [stderr] Compiling time v0.1.44 [INFO] [stderr] Compiling lock_api v0.4.1 [INFO] [stderr] Compiling unicode-segmentation v1.6.0 [INFO] [stderr] Compiling unicode-width v0.1.8 [INFO] [stderr] Compiling piston-shaders_graphics2d v0.4.0 [INFO] [stderr] Compiling rand_chacha v0.2.2 [INFO] [stderr] Compiling textwrap v0.11.0 [INFO] [stderr] Compiling term v0.6.1 [INFO] [stderr] Compiling atty v0.2.14 [INFO] [stderr] Compiling spinning_top v0.2.2 [INFO] [stderr] Compiling piston2d-graphics v0.39.0 [INFO] [stderr] Compiling vec_map v0.8.2 [INFO] [stderr] Compiling ansi_term v0.11.0 [INFO] [stderr] Compiling futures-core v0.3.7 [INFO] [stderr] Compiling chrono v0.4.19 [INFO] [stderr] Compiling rand v0.7.3 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Compiling wayland-commons v0.21.13 [INFO] [stderr] Compiling strsim v0.8.0 [INFO] [stderr] Compiling futures-sink v0.3.7 [INFO] [stderr] Compiling cpal v0.8.2 [INFO] [stderr] Compiling clap v2.33.3 [INFO] [stderr] Compiling find_folder v0.3.0 [INFO] [stderr] Compiling strum v0.19.5 [INFO] [stderr] Compiling jpeg-decoder v0.1.20 [INFO] [stderr] Compiling simplelog v0.7.6 [INFO] [stderr] Compiling tiff v0.6.0 [INFO] [stderr] Compiling flume v0.9.1 [INFO] [stderr] Compiling time-macros-impl v0.1.1 [INFO] [stderr] Compiling strum_macros v0.19.4 [INFO] [stderr] Compiling gfx_device_gl v0.16.2 [INFO] [stderr] Compiling time-macros v0.1.1 [INFO] [stderr] Compiling image v0.23.11 [INFO] [stderr] Compiling piston-gfx_texture v0.41.0 [INFO] [stderr] Compiling piston2d-gfx_graphics v0.72.0 [INFO] [stderr] Compiling pistoncore-input v1.0.0 [INFO] [stderr] Compiling pistoncore-window v0.47.0 [INFO] [stderr] Compiling pistoncore-event_loop v0.52.0 [INFO] [stderr] Compiling piston v0.52.0 [INFO] [stderr] Compiling smithay-client-toolkit v0.4.6 [INFO] [stderr] Compiling winit v0.19.5 [INFO] [stderr] Compiling glutin v0.21.2 [INFO] [stderr] Compiling pistoncore-glutin_window v0.67.1 [INFO] [stderr] Compiling piston_window v0.116.0 [INFO] [stderr] Compiling rgb v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Error` [INFO] [stdout] --> src/cartridge/mbc3.rs:6:15 [INFO] [stdout] | [INFO] [stdout] 6 | use std::io::{Error, Read, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Error` [INFO] [stdout] --> src/cartridge/rtc.rs:6:15 [INFO] [stdout] | [INFO] [stdout] 6 | use std::io::{Error, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::debug::message::DebugMessage` [INFO] [stdout] --> src/debug.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use crate::debug::message::DebugMessage; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::emulator::Emulator` [INFO] [stdout] --> src/debug.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use crate::emulator::Emulator; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Receiver` and `TryRecvError` [INFO] [stdout] --> src/debug.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | use flume::{Receiver, TryRecvError}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Builder` and `JoinHandle` [INFO] [stdout] --> src/debug.rs:20:19 [INFO] [stdout] | [INFO] [stdout] 20 | use std::thread::{Builder, JoinHandle}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cartridge::load_cartridge` [INFO] [stdout] --> src/emulator.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::cartridge::load_cartridge; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cpu::instruction::InstructionSet` [INFO] [stdout] --> src/emulator.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::cpu::instruction::InstructionSet; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `random_framebuffer` [INFO] [stdout] --> src/emulator.rs:10:18 [INFO] [stdout] | [INFO] [stdout] 10 | use crate::ppu::{random_framebuffer, Mode, PPUFramebuffer}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io` [INFO] [stdout] --> src/memory/mmu.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use std::io; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Write` [INFO] [stdout] --> src/memory/mmu.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use std::io::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory/mmu.rs:122:19 [INFO] [stdout] | [INFO] [stdout] 122 | 0x0000...0x7fff => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(ellipsis_inclusive_range_patterns)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory/mmu.rs:155:18 [INFO] [stdout] | [INFO] [stdout] 155 | 0xf40...0xff4b => self.ppu.borrow().get(address), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory/mmu.rs:208:19 [INFO] [stdout] | [INFO] [stdout] 208 | 0xff80...0xfffe => self.high_ram[address as usize - 0xff80] = value, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/ppu.rs:492:19 [INFO] [stdout] | [INFO] [stdout] 492 | 0xfe00...0xfe9f => self.oam[address as usize - 0xfe00], [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Path` [INFO] [stdout] --> src/save.rs:1:17 [INFO] [stdout] | [INFO] [stdout] 1 | use std::path::{Path, PathBuf}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/cartridge/rom.rs:21:23 [INFO] [stdout] | [INFO] [stdout] 21 | fn set(&mut self, address: u16, value: u8) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: if this is intentional, prefix it with an underscore [INFO] [stdout] | [INFO] [stdout] 21 | fn set(&mut self, _address: u16, value: u8) { [INFO] [stdout] | + [INFO] [stdout] help: you might have meant to pattern match on the similarly named constant `OAM_START_ADDRESS` [INFO] [stdout] | [INFO] [stdout] 21 - fn set(&mut self, address: u16, value: u8) { [INFO] [stdout] 21 + fn set(&mut self, memory::mmu::MMU::oam_dma::OAM_START_ADDRESS: u16, value: u8) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/cartridge/rom.rs:21:37 [INFO] [stdout] | [INFO] [stdout] 21 | fn set(&mut self, address: u16, value: u8) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] help: if this is intentional, prefix it with an underscore [INFO] [stdout] | [INFO] [stdout] 21 | fn set(&mut self, address: u16, _value: u8) { [INFO] [stdout] | + [INFO] [stdout] help: you might have meant to pattern match on the similarly named constant `D_PAD` [INFO] [stdout] | [INFO] [stdout] 21 - fn set(&mut self, address: u16, value: u8) { [INFO] [stdout] 21 + fn set(&mut self, address: u16, cpu::D_PAD: u8) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `config` [INFO] [stdout] --> src/debug/debug_logger.rs:34:31 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn should_skip(&self, config: &Config, record: &Record<'_>) -> bool { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless assignment of field of type `u8` to itself [INFO] [stdout] --> src/cpu/instruction.rs:3388:5 [INFO] [stdout] | [INFO] [stdout] 3388 | core.registers.a = core.registers.a; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless assignment of field of type `u8` to itself [INFO] [stdout] --> src/cpu/instruction.rs:3440:5 [INFO] [stdout] | [INFO] [stdout] 3440 | core.registers.l = core.registers.l; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless assignment of field of type `u8` to itself [INFO] [stdout] --> src/cpu/instruction.rs:3464:5 [INFO] [stdout] | [INFO] [stdout] 3464 | core.registers.h = core.registers.h; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless assignment of field of type `u8` to itself [INFO] [stdout] --> src/cpu/instruction.rs:3488:5 [INFO] [stdout] | [INFO] [stdout] 3488 | core.registers.e = core.registers.e; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless assignment of field of type `u8` to itself [INFO] [stdout] --> src/cpu/instruction.rs:3512:5 [INFO] [stdout] | [INFO] [stdout] 3512 | core.registers.d = core.registers.d; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless assignment of field of type `u8` to itself [INFO] [stdout] --> src/cpu/instruction.rs:3536:5 [INFO] [stdout] | [INFO] [stdout] 3536 | core.registers.c = core.registers.c; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless assignment of field of type `u8` to itself [INFO] [stdout] --> src/cpu/instruction.rs:3588:5 [INFO] [stdout] | [INFO] [stdout] 3588 | core.registers.b = core.registers.b; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INTERRUPT_ENABLE_REG` is never used [INFO] [stdout] --> src/cpu.rs:22:7 [INFO] [stdout] | [INFO] [stdout] 22 | const INTERRUPT_ENABLE_REG: u16 = 0xFFFF; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INTERRUPT_FLAG_REG` is never used [INFO] [stdout] --> src/cpu.rs:23:7 [INFO] [stdout] | [INFO] [stdout] 23 | const INTERRUPT_FLAG_REG: u16 = 0xFF0F; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `V_BLANK` is never used [INFO] [stdout] --> src/cpu.rs:25:7 [INFO] [stdout] | [INFO] [stdout] 25 | const V_BLANK: u8 = 0x01; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `LCD_STAT` is never used [INFO] [stdout] --> src/cpu.rs:26:7 [INFO] [stdout] | [INFO] [stdout] 26 | const LCD_STAT: u8 = 0x02; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `TIMER` is never used [INFO] [stdout] --> src/cpu.rs:27:7 [INFO] [stdout] | [INFO] [stdout] 27 | const TIMER: u8 = 0x04; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `SERIAL` is never used [INFO] [stdout] --> src/cpu.rs:28:7 [INFO] [stdout] | [INFO] [stdout] 28 | const SERIAL: u8 = 0x08; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `D_PAD` is never used [INFO] [stdout] --> src/cpu.rs:29:7 [INFO] [stdout] | [INFO] [stdout] 29 | const D_PAD: u8 = 0x10; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `last_serial` is never read [INFO] [stdout] --> src/memory/mmu.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct MMU { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 21 | last_serial: u8, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `index` is never read [INFO] [stdout] --> src/ppu.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 80 | pub struct Sprite { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 88 | index: usize, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Sprite` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `S` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | S: u8, [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `s` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `M` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | M: u8, [INFO] [stdout] | ^ help: convert the identifier to snake case: `m` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `H` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | H: u8, [INFO] [stdout] | ^ help: convert the identifier to snake case: `h` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `DL` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | DL: u8, [INFO] [stdout] | ^^ help: convert the identifier to snake case: `dl` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `DH` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | DH: u8, [INFO] [stdout] | ^^ help: convert the identifier to snake case: `dh` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Error` [INFO] [stdout] --> src/cartridge/mbc3.rs:6:15 [INFO] [stdout] | [INFO] [stdout] 6 | use std::io::{Error, Read, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Error` [INFO] [stdout] --> src/cartridge/rtc.rs:6:15 [INFO] [stdout] | [INFO] [stdout] 6 | use std::io::{Error, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::debug::message::DebugMessage` [INFO] [stdout] --> src/debug.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use crate::debug::message::DebugMessage; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::emulator::Emulator` [INFO] [stdout] --> src/debug.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use crate::emulator::Emulator; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Receiver` and `TryRecvError` [INFO] [stdout] --> src/debug.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | use flume::{Receiver, TryRecvError}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Builder` and `JoinHandle` [INFO] [stdout] --> src/debug.rs:20:19 [INFO] [stdout] | [INFO] [stdout] 20 | use std::thread::{Builder, JoinHandle}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cpu::interrupt::Flag::Joypad` [INFO] [stdout] --> src/display.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::cpu::interrupt::Flag::Joypad; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cpu::registers::Flag` [INFO] [stdout] --> src/display/debug_canvas.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::cpu::registers::Flag; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `FB_H` and `FB_W` [INFO] [stdout] --> src/display/game_canvas.rs:1:34 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::ppu::{PPUFramebuffer, FB_H, FB_W}; [INFO] [stdout] | ^^^^ ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `piston_window::*` [INFO] [stdout] --> src/display/game_canvas.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use piston_window::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cartridge::load_cartridge` [INFO] [stdout] --> src/emulator.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::cartridge::load_cartridge; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cpu::instruction::InstructionSet` [INFO] [stdout] --> src/emulator.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::cpu::instruction::InstructionSet; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `random_framebuffer` [INFO] [stdout] --> src/emulator.rs:10:18 [INFO] [stdout] | [INFO] [stdout] 10 | use crate::ppu::{random_framebuffer, Mode, PPUFramebuffer}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io` [INFO] [stdout] --> src/memory/mmu.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use std::io; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Write` [INFO] [stdout] --> src/memory/mmu.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use std::io::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory/mmu.rs:122:19 [INFO] [stdout] | [INFO] [stdout] 122 | 0x0000...0x7fff => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(ellipsis_inclusive_range_patterns)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory/mmu.rs:155:18 [INFO] [stdout] | [INFO] [stdout] 155 | 0xf40...0xff4b => self.ppu.borrow().get(address), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory/mmu.rs:208:19 [INFO] [stdout] | [INFO] [stdout] 208 | 0xff80...0xfffe => self.high_ram[address as usize - 0xff80] = value, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/ppu.rs:492:19 [INFO] [stdout] | [INFO] [stdout] 492 | 0xfe00...0xfe9f => self.oam[address as usize - 0xfe00], [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Path` [INFO] [stdout] --> src/save.rs:1:17 [INFO] [stdout] | [INFO] [stdout] 1 | use std::path::{Path, PathBuf}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `format` [INFO] [stdout] --> src/apu.rs:11:17 [INFO] [stdout] | [INFO] [stdout] 11 | let format = cpal::Format { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_format` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/cartridge/rom.rs:21:23 [INFO] [stdout] | [INFO] [stdout] 21 | fn set(&mut self, address: u16, value: u8) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: if this is intentional, prefix it with an underscore [INFO] [stdout] | [INFO] [stdout] 21 | fn set(&mut self, _address: u16, value: u8) { [INFO] [stdout] | + [INFO] [stdout] help: you might have meant to pattern match on the similarly named constant `OAM_START_ADDRESS` [INFO] [stdout] | [INFO] [stdout] 21 - fn set(&mut self, address: u16, value: u8) { [INFO] [stdout] 21 + fn set(&mut self, memory::mmu::MMU::oam_dma::OAM_START_ADDRESS: u16, value: u8) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/cartridge/rom.rs:21:37 [INFO] [stdout] | [INFO] [stdout] 21 | fn set(&mut self, address: u16, value: u8) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] help: if this is intentional, prefix it with an underscore [INFO] [stdout] | [INFO] [stdout] 21 | fn set(&mut self, address: u16, _value: u8) { [INFO] [stdout] | + [INFO] [stdout] help: you might have meant to pattern match on the similarly named constant `D_PAD` [INFO] [stdout] | [INFO] [stdout] 21 - fn set(&mut self, address: u16, value: u8) { [INFO] [stdout] 21 + fn set(&mut self, address: u16, cpu::D_PAD: u8) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `config` [INFO] [stdout] --> src/debug/debug_logger.rs:34:31 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn should_skip(&self, config: &Config, record: &Record<'_>) -> bool { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/display.rs:90:25 [INFO] [stdout] | [INFO] [stdout] 90 | let mut key_pressed = match key { [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/display.rs:130:33 [INFO] [stdout] | [INFO] [stdout] 130 | ... let mut key_pressed = match key { [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless assignment of field of type `u8` to itself [INFO] [stdout] --> src/cpu/instruction.rs:3388:5 [INFO] [stdout] | [INFO] [stdout] 3388 | core.registers.a = core.registers.a; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless assignment of field of type `u8` to itself [INFO] [stdout] --> src/cpu/instruction.rs:3440:5 [INFO] [stdout] | [INFO] [stdout] 3440 | core.registers.l = core.registers.l; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless assignment of field of type `u8` to itself [INFO] [stdout] --> src/cpu/instruction.rs:3464:5 [INFO] [stdout] | [INFO] [stdout] 3464 | core.registers.h = core.registers.h; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless assignment of field of type `u8` to itself [INFO] [stdout] --> src/cpu/instruction.rs:3488:5 [INFO] [stdout] | [INFO] [stdout] 3488 | core.registers.e = core.registers.e; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless assignment of field of type `u8` to itself [INFO] [stdout] --> src/cpu/instruction.rs:3512:5 [INFO] [stdout] | [INFO] [stdout] 3512 | core.registers.d = core.registers.d; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless assignment of field of type `u8` to itself [INFO] [stdout] --> src/cpu/instruction.rs:3536:5 [INFO] [stdout] | [INFO] [stdout] 3536 | core.registers.c = core.registers.c; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless assignment of field of type `u8` to itself [INFO] [stdout] --> src/cpu/instruction.rs:3588:5 [INFO] [stdout] | [INFO] [stdout] 3588 | core.registers.b = core.registers.b; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INTERRUPT_ENABLE_REG` is never used [INFO] [stdout] --> src/cpu.rs:22:7 [INFO] [stdout] | [INFO] [stdout] 22 | const INTERRUPT_ENABLE_REG: u16 = 0xFFFF; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INTERRUPT_FLAG_REG` is never used [INFO] [stdout] --> src/cpu.rs:23:7 [INFO] [stdout] | [INFO] [stdout] 23 | const INTERRUPT_FLAG_REG: u16 = 0xFF0F; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `V_BLANK` is never used [INFO] [stdout] --> src/cpu.rs:25:7 [INFO] [stdout] | [INFO] [stdout] 25 | const V_BLANK: u8 = 0x01; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `LCD_STAT` is never used [INFO] [stdout] --> src/cpu.rs:26:7 [INFO] [stdout] | [INFO] [stdout] 26 | const LCD_STAT: u8 = 0x02; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `TIMER` is never used [INFO] [stdout] --> src/cpu.rs:27:7 [INFO] [stdout] | [INFO] [stdout] 27 | const TIMER: u8 = 0x04; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `SERIAL` is never used [INFO] [stdout] --> src/cpu.rs:28:7 [INFO] [stdout] | [INFO] [stdout] 28 | const SERIAL: u8 = 0x08; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `D_PAD` is never used [INFO] [stdout] --> src/cpu.rs:29:7 [INFO] [stdout] | [INFO] [stdout] 29 | const D_PAD: u8 = 0x10; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `flip` is never used [INFO] [stdout] --> src/cpu.rs:249:12 [INFO] [stdout] | [INFO] [stdout] 94 | impl ClockedCPU { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 249 | pub fn flip(&mut self) -> bool { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `opcode` is never read [INFO] [stdout] --> src/cpu/instruction.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct Instruction { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 12 | pub name: &'static str, [INFO] [stdout] 13 | pub opcode: u8, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Serial` is never constructed [INFO] [stdout] --> src/cpu/interrupt.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 3 | pub enum Flag { [INFO] [stdout] | ---- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 7 | Serial = 3, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Flag` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `FB_W` is never used [INFO] [stdout] --> src/debug.rs:22:11 [INFO] [stdout] | [INFO] [stdout] 22 | pub const FB_W: usize = 160; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `FB_H` is never used [INFO] [stdout] --> src/debug.rs:23:11 [INFO] [stdout] | [INFO] [stdout] 23 | pub const FB_H: usize = 144; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `PeekValue` is never constructed [INFO] [stdout] --> src/debug/command.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 2 | pub enum DebugCommand { [INFO] [stdout] | ------------ variant in this enum [INFO] [stdout] 3 | PeekValue(u16), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `DebugCommand` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `Debuggable` is never used [INFO] [stdout] --> src/debug/debuggable.rs:4:11 [INFO] [stdout] | [INFO] [stdout] 4 | pub trait Debuggable { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/debug/message.rs:9:18 [INFO] [stdout] | [INFO] [stdout] 9 | MemoryUpdate(Vec), [INFO] [stdout] | ------------ ^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `DebugMessage` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 9 - MemoryUpdate(Vec), [INFO] [stdout] 9 + MemoryUpdate(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `DebugCommand` is never constructed [INFO] [stdout] --> src/debug/message.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub enum DebugMessage { [INFO] [stdout] | ------------ variant in this enum [INFO] [stdout] 7 | LogUpdate(String), [INFO] [stdout] 8 | DebugCommand(DebugCommand), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `DebugMessage` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `update_tile_canvas` is never used [INFO] [stdout] --> src/display/debug_canvas.rs:161:8 [INFO] [stdout] | [INFO] [stdout] 161 | pub fn update_tile_canvas( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PIXEL_COLOUR_STRIDE` is never used [INFO] [stdout] --> src/display/debug_canvas.rs:189:11 [INFO] [stdout] | [INFO] [stdout] 189 | const PIXEL_COLOUR_STRIDE: usize = 4; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `last_serial` is never read [INFO] [stdout] --> src/memory/mmu.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct MMU { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 21 | last_serial: u8, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `index` is never read [INFO] [stdout] --> src/ppu.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 80 | pub struct Sprite { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 88 | index: usize, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Sprite` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `random_framebuffer` is never used [INFO] [stdout] --> src/ppu.rs:624:8 [INFO] [stdout] | [INFO] [stdout] 624 | pub fn random_framebuffer() -> PPUFramebuffer { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `S` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | S: u8, [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `s` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `M` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | M: u8, [INFO] [stdout] | ^ help: convert the identifier to snake case: `m` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `H` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | H: u8, [INFO] [stdout] | ^ help: convert the identifier to snake case: `h` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `DL` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | DL: u8, [INFO] [stdout] | ^^ help: convert the identifier to snake case: `dl` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `DH` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | DH: u8, [INFO] [stdout] | ^^ help: convert the identifier to snake case: `dh` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 49s [INFO] running `Command { std: "docker" "inspect" "1e2123b730a7490a498b6c1d3341cba569d05e43cac356636fc70fb81e6f2d4b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1e2123b730a7490a498b6c1d3341cba569d05e43cac356636fc70fb81e6f2d4b", kill_on_drop: false }` [INFO] [stdout] 1e2123b730a7490a498b6c1d3341cba569d05e43cac356636fc70fb81e6f2d4b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:e90291280db7d1fac5b66fc6dad9f9662629e7365a55743daf9bdf73ebc4ea79" "/opt/rustwide/cargo-home/bin/cargo" "+c7f6aa2869acdbf014d094c6e427e554e160b6db" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a5f26406fc8ac40af5cfd5d60aba6c654ad34d72d7cbce9df72e0b3b9186e04e [INFO] running `Command { std: "docker" "start" "-a" "a5f26406fc8ac40af5cfd5d60aba6c654ad34d72d7cbce9df72e0b3b9186e04e", kill_on_drop: false }` [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling serde_json v1.0.59 [INFO] [stderr] Compiling itoa v0.4.6 [INFO] [stdout] warning: unused import: `Error` [INFO] [stdout] --> src/cartridge/mbc3.rs:6:15 [INFO] [stdout] | [INFO] [stdout] 6 | use std::io::{Error, Read, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Error` [INFO] [stdout] --> src/cartridge/rtc.rs:6:15 [INFO] [stdout] | [INFO] [stdout] 6 | use std::io::{Error, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::debug::message::DebugMessage` [INFO] [stdout] --> src/debug.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use crate::debug::message::DebugMessage; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::emulator::Emulator` [INFO] [stdout] --> src/debug.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use crate::emulator::Emulator; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Receiver` and `TryRecvError` [INFO] [stdout] --> src/debug.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | use flume::{Receiver, TryRecvError}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Builder` and `JoinHandle` [INFO] [stdout] --> src/debug.rs:20:19 [INFO] [stdout] | [INFO] [stdout] 20 | use std::thread::{Builder, JoinHandle}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cartridge::load_cartridge` [INFO] [stdout] --> src/emulator.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::cartridge::load_cartridge; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cpu::instruction::InstructionSet` [INFO] [stdout] --> src/emulator.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::cpu::instruction::InstructionSet; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `random_framebuffer` [INFO] [stdout] --> src/emulator.rs:10:18 [INFO] [stdout] | [INFO] [stdout] 10 | use crate::ppu::{random_framebuffer, Mode, PPUFramebuffer}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io` [INFO] [stdout] --> src/memory/mmu.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use std::io; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Write` [INFO] [stdout] --> src/memory/mmu.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use std::io::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory/mmu.rs:122:19 [INFO] [stdout] | [INFO] [stdout] 122 | 0x0000...0x7fff => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(ellipsis_inclusive_range_patterns)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory/mmu.rs:155:18 [INFO] [stdout] | [INFO] [stdout] 155 | 0xf40...0xff4b => self.ppu.borrow().get(address), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory/mmu.rs:208:19 [INFO] [stdout] | [INFO] [stdout] 208 | 0xff80...0xfffe => self.high_ram[address as usize - 0xff80] = value, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/ppu.rs:492:19 [INFO] [stdout] | [INFO] [stdout] 492 | 0xfe00...0xfe9f => self.oam[address as usize - 0xfe00], [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Path` [INFO] [stdout] --> src/save.rs:1:17 [INFO] [stdout] | [INFO] [stdout] 1 | use std::path::{Path, PathBuf}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/cartridge/rom.rs:21:23 [INFO] [stdout] | [INFO] [stdout] 21 | fn set(&mut self, address: u16, value: u8) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: if this is intentional, prefix it with an underscore [INFO] [stdout] | [INFO] [stdout] 21 | fn set(&mut self, _address: u16, value: u8) { [INFO] [stdout] | + [INFO] [stdout] help: you might have meant to pattern match on the similarly named constant `OAM_START_ADDRESS` [INFO] [stdout] | [INFO] [stdout] 21 - fn set(&mut self, address: u16, value: u8) { [INFO] [stdout] 21 + fn set(&mut self, memory::mmu::MMU::oam_dma::OAM_START_ADDRESS: u16, value: u8) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/cartridge/rom.rs:21:37 [INFO] [stdout] | [INFO] [stdout] 21 | fn set(&mut self, address: u16, value: u8) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] help: if this is intentional, prefix it with an underscore [INFO] [stdout] | [INFO] [stdout] 21 | fn set(&mut self, address: u16, _value: u8) { [INFO] [stdout] | + [INFO] [stdout] help: you might have meant to pattern match on the similarly named constant `D_PAD` [INFO] [stdout] | [INFO] [stdout] 21 - fn set(&mut self, address: u16, value: u8) { [INFO] [stdout] 21 + fn set(&mut self, address: u16, cpu::D_PAD: u8) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `config` [INFO] [stdout] --> src/debug/debug_logger.rs:34:31 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn should_skip(&self, config: &Config, record: &Record<'_>) -> bool { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless assignment of field of type `u8` to itself [INFO] [stdout] --> src/cpu/instruction.rs:3388:5 [INFO] [stdout] | [INFO] [stdout] 3388 | core.registers.a = core.registers.a; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless assignment of field of type `u8` to itself [INFO] [stdout] --> src/cpu/instruction.rs:3440:5 [INFO] [stdout] | [INFO] [stdout] 3440 | core.registers.l = core.registers.l; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless assignment of field of type `u8` to itself [INFO] [stdout] --> src/cpu/instruction.rs:3464:5 [INFO] [stdout] | [INFO] [stdout] 3464 | core.registers.h = core.registers.h; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless assignment of field of type `u8` to itself [INFO] [stdout] --> src/cpu/instruction.rs:3488:5 [INFO] [stdout] | [INFO] [stdout] 3488 | core.registers.e = core.registers.e; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless assignment of field of type `u8` to itself [INFO] [stdout] --> src/cpu/instruction.rs:3512:5 [INFO] [stdout] | [INFO] [stdout] 3512 | core.registers.d = core.registers.d; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless assignment of field of type `u8` to itself [INFO] [stdout] --> src/cpu/instruction.rs:3536:5 [INFO] [stdout] | [INFO] [stdout] 3536 | core.registers.c = core.registers.c; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless assignment of field of type `u8` to itself [INFO] [stdout] --> src/cpu/instruction.rs:3588:5 [INFO] [stdout] | [INFO] [stdout] 3588 | core.registers.b = core.registers.b; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INTERRUPT_ENABLE_REG` is never used [INFO] [stdout] --> src/cpu.rs:22:7 [INFO] [stdout] | [INFO] [stdout] 22 | const INTERRUPT_ENABLE_REG: u16 = 0xFFFF; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INTERRUPT_FLAG_REG` is never used [INFO] [stdout] --> src/cpu.rs:23:7 [INFO] [stdout] | [INFO] [stdout] 23 | const INTERRUPT_FLAG_REG: u16 = 0xFF0F; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `V_BLANK` is never used [INFO] [stdout] --> src/cpu.rs:25:7 [INFO] [stdout] | [INFO] [stdout] 25 | const V_BLANK: u8 = 0x01; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `LCD_STAT` is never used [INFO] [stdout] --> src/cpu.rs:26:7 [INFO] [stdout] | [INFO] [stdout] 26 | const LCD_STAT: u8 = 0x02; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `TIMER` is never used [INFO] [stdout] --> src/cpu.rs:27:7 [INFO] [stdout] | [INFO] [stdout] 27 | const TIMER: u8 = 0x04; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `SERIAL` is never used [INFO] [stdout] --> src/cpu.rs:28:7 [INFO] [stdout] | [INFO] [stdout] 28 | const SERIAL: u8 = 0x08; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `D_PAD` is never used [INFO] [stdout] --> src/cpu.rs:29:7 [INFO] [stdout] | [INFO] [stdout] 29 | const D_PAD: u8 = 0x10; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `last_serial` is never read [INFO] [stdout] --> src/memory/mmu.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct MMU { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 21 | last_serial: u8, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `index` is never read [INFO] [stdout] --> src/ppu.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 80 | pub struct Sprite { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 88 | index: usize, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Sprite` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `S` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | S: u8, [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `s` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `M` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | M: u8, [INFO] [stdout] | ^ help: convert the identifier to snake case: `m` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `H` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | H: u8, [INFO] [stdout] | ^ help: convert the identifier to snake case: `h` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `DL` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | DL: u8, [INFO] [stdout] | ^^ help: convert the identifier to snake case: `dl` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `DH` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | DH: u8, [INFO] [stdout] | ^^ help: convert the identifier to snake case: `dh` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Error` [INFO] [stdout] --> src/cartridge/mbc3.rs:6:15 [INFO] [stdout] | [INFO] [stdout] 6 | use std::io::{Error, Read, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Error` [INFO] [stdout] --> src/cartridge/rtc.rs:6:15 [INFO] [stdout] | [INFO] [stdout] 6 | use std::io::{Error, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::debug::message::DebugMessage` [INFO] [stdout] --> src/debug.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use crate::debug::message::DebugMessage; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::emulator::Emulator` [INFO] [stdout] --> src/debug.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use crate::emulator::Emulator; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Receiver` and `TryRecvError` [INFO] [stdout] --> src/debug.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | use flume::{Receiver, TryRecvError}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Builder` and `JoinHandle` [INFO] [stdout] --> src/debug.rs:20:19 [INFO] [stdout] | [INFO] [stdout] 20 | use std::thread::{Builder, JoinHandle}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cpu::interrupt::Flag::Joypad` [INFO] [stdout] --> src/display.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::cpu::interrupt::Flag::Joypad; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cpu::registers::Flag` [INFO] [stdout] --> src/display/debug_canvas.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::cpu::registers::Flag; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `FB_H` and `FB_W` [INFO] [stdout] --> src/display/game_canvas.rs:1:34 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::ppu::{PPUFramebuffer, FB_H, FB_W}; [INFO] [stdout] | ^^^^ ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `piston_window::*` [INFO] [stdout] --> src/display/game_canvas.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use piston_window::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cartridge::load_cartridge` [INFO] [stdout] --> src/emulator.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::cartridge::load_cartridge; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cpu::instruction::InstructionSet` [INFO] [stdout] --> src/emulator.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::cpu::instruction::InstructionSet; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `random_framebuffer` [INFO] [stdout] --> src/emulator.rs:10:18 [INFO] [stdout] | [INFO] [stdout] 10 | use crate::ppu::{random_framebuffer, Mode, PPUFramebuffer}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io` [INFO] [stdout] --> src/memory/mmu.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use std::io; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Write` [INFO] [stdout] --> src/memory/mmu.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use std::io::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory/mmu.rs:122:19 [INFO] [stdout] | [INFO] [stdout] 122 | 0x0000...0x7fff => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(ellipsis_inclusive_range_patterns)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory/mmu.rs:155:18 [INFO] [stdout] | [INFO] [stdout] 155 | 0xf40...0xff4b => self.ppu.borrow().get(address), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory/mmu.rs:208:19 [INFO] [stdout] | [INFO] [stdout] 208 | 0xff80...0xfffe => self.high_ram[address as usize - 0xff80] = value, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/ppu.rs:492:19 [INFO] [stdout] | [INFO] [stdout] 492 | 0xfe00...0xfe9f => self.oam[address as usize - 0xfe00], [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Path` [INFO] [stdout] --> src/save.rs:1:17 [INFO] [stdout] | [INFO] [stdout] 1 | use std::path::{Path, PathBuf}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `format` [INFO] [stdout] --> src/apu.rs:11:17 [INFO] [stdout] | [INFO] [stdout] 11 | let format = cpal::Format { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_format` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/cartridge/rom.rs:21:23 [INFO] [stdout] | [INFO] [stdout] 21 | fn set(&mut self, address: u16, value: u8) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: if this is intentional, prefix it with an underscore [INFO] [stdout] | [INFO] [stdout] 21 | fn set(&mut self, _address: u16, value: u8) { [INFO] [stdout] | + [INFO] [stdout] help: you might have meant to pattern match on the similarly named constant `OAM_START_ADDRESS` [INFO] [stdout] | [INFO] [stdout] 21 - fn set(&mut self, address: u16, value: u8) { [INFO] [stdout] 21 + fn set(&mut self, memory::mmu::MMU::oam_dma::OAM_START_ADDRESS: u16, value: u8) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/cartridge/rom.rs:21:37 [INFO] [stdout] | [INFO] [stdout] 21 | fn set(&mut self, address: u16, value: u8) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] help: if this is intentional, prefix it with an underscore [INFO] [stdout] | [INFO] [stdout] 21 | fn set(&mut self, address: u16, _value: u8) { [INFO] [stdout] | + [INFO] [stdout] help: you might have meant to pattern match on the similarly named constant `D_PAD` [INFO] [stdout] | [INFO] [stdout] 21 - fn set(&mut self, address: u16, value: u8) { [INFO] [stdout] 21 + fn set(&mut self, address: u16, cpu::D_PAD: u8) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `config` [INFO] [stdout] --> src/debug/debug_logger.rs:34:31 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn should_skip(&self, config: &Config, record: &Record<'_>) -> bool { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/display.rs:90:25 [INFO] [stdout] | [INFO] [stdout] 90 | let mut key_pressed = match key { [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/display.rs:130:33 [INFO] [stdout] | [INFO] [stdout] 130 | ... let mut key_pressed = match key { [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless assignment of field of type `u8` to itself [INFO] [stdout] --> src/cpu/instruction.rs:3388:5 [INFO] [stdout] | [INFO] [stdout] 3388 | core.registers.a = core.registers.a; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless assignment of field of type `u8` to itself [INFO] [stdout] --> src/cpu/instruction.rs:3440:5 [INFO] [stdout] | [INFO] [stdout] 3440 | core.registers.l = core.registers.l; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless assignment of field of type `u8` to itself [INFO] [stdout] --> src/cpu/instruction.rs:3464:5 [INFO] [stdout] | [INFO] [stdout] 3464 | core.registers.h = core.registers.h; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless assignment of field of type `u8` to itself [INFO] [stdout] --> src/cpu/instruction.rs:3488:5 [INFO] [stdout] | [INFO] [stdout] 3488 | core.registers.e = core.registers.e; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless assignment of field of type `u8` to itself [INFO] [stdout] --> src/cpu/instruction.rs:3512:5 [INFO] [stdout] | [INFO] [stdout] 3512 | core.registers.d = core.registers.d; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless assignment of field of type `u8` to itself [INFO] [stdout] --> src/cpu/instruction.rs:3536:5 [INFO] [stdout] | [INFO] [stdout] 3536 | core.registers.c = core.registers.c; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless assignment of field of type `u8` to itself [INFO] [stdout] --> src/cpu/instruction.rs:3588:5 [INFO] [stdout] | [INFO] [stdout] 3588 | core.registers.b = core.registers.b; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INTERRUPT_ENABLE_REG` is never used [INFO] [stdout] --> src/cpu.rs:22:7 [INFO] [stdout] | [INFO] [stdout] 22 | const INTERRUPT_ENABLE_REG: u16 = 0xFFFF; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INTERRUPT_FLAG_REG` is never used [INFO] [stdout] --> src/cpu.rs:23:7 [INFO] [stdout] | [INFO] [stdout] 23 | const INTERRUPT_FLAG_REG: u16 = 0xFF0F; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `V_BLANK` is never used [INFO] [stdout] --> src/cpu.rs:25:7 [INFO] [stdout] | [INFO] [stdout] 25 | const V_BLANK: u8 = 0x01; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `LCD_STAT` is never used [INFO] [stdout] --> src/cpu.rs:26:7 [INFO] [stdout] | [INFO] [stdout] 26 | const LCD_STAT: u8 = 0x02; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `TIMER` is never used [INFO] [stdout] --> src/cpu.rs:27:7 [INFO] [stdout] | [INFO] [stdout] 27 | const TIMER: u8 = 0x04; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `SERIAL` is never used [INFO] [stdout] --> src/cpu.rs:28:7 [INFO] [stdout] | [INFO] [stdout] 28 | const SERIAL: u8 = 0x08; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `D_PAD` is never used [INFO] [stdout] --> src/cpu.rs:29:7 [INFO] [stdout] | [INFO] [stdout] 29 | const D_PAD: u8 = 0x10; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `flip` is never used [INFO] [stdout] --> src/cpu.rs:249:12 [INFO] [stdout] | [INFO] [stdout] 94 | impl ClockedCPU { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 249 | pub fn flip(&mut self) -> bool { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `opcode` is never read [INFO] [stdout] --> src/cpu/instruction.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct Instruction { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 12 | pub name: &'static str, [INFO] [stdout] 13 | pub opcode: u8, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Serial` is never constructed [INFO] [stdout] --> src/cpu/interrupt.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 3 | pub enum Flag { [INFO] [stdout] | ---- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 7 | Serial = 3, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Flag` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `FB_W` is never used [INFO] [stdout] --> src/debug.rs:22:11 [INFO] [stdout] | [INFO] [stdout] 22 | pub const FB_W: usize = 160; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `FB_H` is never used [INFO] [stdout] --> src/debug.rs:23:11 [INFO] [stdout] | [INFO] [stdout] 23 | pub const FB_H: usize = 144; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `PeekValue` is never constructed [INFO] [stdout] --> src/debug/command.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 2 | pub enum DebugCommand { [INFO] [stdout] | ------------ variant in this enum [INFO] [stdout] 3 | PeekValue(u16), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `DebugCommand` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `Debuggable` is never used [INFO] [stdout] --> src/debug/debuggable.rs:4:11 [INFO] [stdout] | [INFO] [stdout] 4 | pub trait Debuggable { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/debug/message.rs:9:18 [INFO] [stdout] | [INFO] [stdout] 9 | MemoryUpdate(Vec), [INFO] [stdout] | ------------ ^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `DebugMessage` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 9 - MemoryUpdate(Vec), [INFO] [stdout] 9 + MemoryUpdate(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `DebugCommand` is never constructed [INFO] [stdout] --> src/debug/message.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub enum DebugMessage { [INFO] [stdout] | ------------ variant in this enum [INFO] [stdout] 7 | LogUpdate(String), [INFO] [stdout] 8 | DebugCommand(DebugCommand), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `DebugMessage` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `update_tile_canvas` is never used [INFO] [stdout] --> src/display/debug_canvas.rs:161:8 [INFO] [stdout] | [INFO] [stdout] 161 | pub fn update_tile_canvas( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PIXEL_COLOUR_STRIDE` is never used [INFO] [stdout] --> src/display/debug_canvas.rs:189:11 [INFO] [stdout] | [INFO] [stdout] 189 | const PIXEL_COLOUR_STRIDE: usize = 4; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `last_serial` is never read [INFO] [stdout] --> src/memory/mmu.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct MMU { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 21 | last_serial: u8, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `index` is never read [INFO] [stdout] --> src/ppu.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 80 | pub struct Sprite { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 88 | index: usize, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Sprite` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `random_framebuffer` is never used [INFO] [stdout] --> src/ppu.rs:624:8 [INFO] [stdout] | [INFO] [stdout] 624 | pub fn random_framebuffer() -> PPUFramebuffer { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `S` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | S: u8, [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `s` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `M` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | M: u8, [INFO] [stdout] | ^ help: convert the identifier to snake case: `m` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `H` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | H: u8, [INFO] [stdout] | ^ help: convert the identifier to snake case: `h` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `DL` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | DL: u8, [INFO] [stdout] | ^^ help: convert the identifier to snake case: `dl` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `DH` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | DH: u8, [INFO] [stdout] | ^^ help: convert the identifier to snake case: `dh` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling rgb v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Error` [INFO] [stdout] --> src/cartridge/mbc3.rs:6:15 [INFO] [stdout] | [INFO] [stdout] 6 | use std::io::{Error, Read, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Error` [INFO] [stdout] --> src/cartridge/rtc.rs:6:15 [INFO] [stdout] | [INFO] [stdout] 6 | use std::io::{Error, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `rgb::emulator::Emulator` [INFO] [stdout] --> tests/cpu_test.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use rgb::emulator::Emulator; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::debug::message::DebugMessage` [INFO] [stdout] --> src/debug.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use crate::debug::message::DebugMessage; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::emulator::Emulator` [INFO] [stdout] --> src/debug.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use crate::emulator::Emulator; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Receiver` and `TryRecvError` [INFO] [stdout] --> src/debug.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | use flume::{Receiver, TryRecvError}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Builder` and `JoinHandle` [INFO] [stdout] --> src/debug.rs:20:19 [INFO] [stdout] | [INFO] [stdout] 20 | use std::thread::{Builder, JoinHandle}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cartridge::load_cartridge` [INFO] [stdout] --> src/emulator.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::cartridge::load_cartridge; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cpu::instruction::InstructionSet` [INFO] [stdout] --> src/emulator.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::cpu::instruction::InstructionSet; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `random_framebuffer` [INFO] [stdout] --> src/emulator.rs:10:18 [INFO] [stdout] | [INFO] [stdout] 10 | use crate::ppu::{random_framebuffer, Mode, PPUFramebuffer}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io` [INFO] [stdout] --> src/memory/mmu.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use std::io; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Write` [INFO] [stdout] --> src/memory/mmu.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use std::io::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory/mmu.rs:122:19 [INFO] [stdout] | [INFO] [stdout] 122 | 0x0000...0x7fff => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(ellipsis_inclusive_range_patterns)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory/mmu.rs:155:18 [INFO] [stdout] | [INFO] [stdout] 155 | 0xf40...0xff4b => self.ppu.borrow().get(address), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory/mmu.rs:208:19 [INFO] [stdout] | [INFO] [stdout] 208 | 0xff80...0xfffe => self.high_ram[address as usize - 0xff80] = value, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/ppu.rs:492:19 [INFO] [stdout] | [INFO] [stdout] 492 | 0xfe00...0xfe9f => self.oam[address as usize - 0xfe00], [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Path` [INFO] [stdout] --> src/save.rs:1:17 [INFO] [stdout] | [INFO] [stdout] 1 | use std::path::{Path, PathBuf}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Error` [INFO] [stdout] --> src/cartridge/mbc3.rs:6:15 [INFO] [stdout] | [INFO] [stdout] 6 | use std::io::{Error, Read, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Error` [INFO] [stdout] --> src/cartridge/rtc.rs:6:15 [INFO] [stdout] | [INFO] [stdout] 6 | use std::io::{Error, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::debug::message::DebugMessage` [INFO] [stdout] --> src/debug.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use crate::debug::message::DebugMessage; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::emulator::Emulator` [INFO] [stdout] --> src/debug.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use crate::emulator::Emulator; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Receiver` and `TryRecvError` [INFO] [stdout] --> src/debug.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | use flume::{Receiver, TryRecvError}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Builder` and `JoinHandle` [INFO] [stdout] --> src/debug.rs:20:19 [INFO] [stdout] | [INFO] [stdout] 20 | use std::thread::{Builder, JoinHandle}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cpu::interrupt::Flag::Joypad` [INFO] [stdout] --> src/display.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::cpu::interrupt::Flag::Joypad; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cpu::registers::Flag` [INFO] [stdout] --> src/display/debug_canvas.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::cpu::registers::Flag; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `FB_H` and `FB_W` [INFO] [stdout] --> src/display/game_canvas.rs:1:34 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::ppu::{PPUFramebuffer, FB_H, FB_W}; [INFO] [stdout] | ^^^^ ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `piston_window::*` [INFO] [stdout] --> src/display/game_canvas.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use piston_window::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cartridge::load_cartridge` [INFO] [stdout] --> src/emulator.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::cartridge::load_cartridge; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cpu::instruction::InstructionSet` [INFO] [stdout] --> src/emulator.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::cpu::instruction::InstructionSet; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `random_framebuffer` [INFO] [stdout] --> src/emulator.rs:10:18 [INFO] [stdout] | [INFO] [stdout] 10 | use crate::ppu::{random_framebuffer, Mode, PPUFramebuffer}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io` [INFO] [stdout] --> src/memory/mmu.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use std::io; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Write` [INFO] [stdout] --> src/memory/mmu.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use std::io::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory/mmu.rs:122:19 [INFO] [stdout] | [INFO] [stdout] 122 | 0x0000...0x7fff => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(ellipsis_inclusive_range_patterns)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory/mmu.rs:155:18 [INFO] [stdout] | [INFO] [stdout] 155 | 0xf40...0xff4b => self.ppu.borrow().get(address), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory/mmu.rs:208:19 [INFO] [stdout] | [INFO] [stdout] 208 | 0xff80...0xfffe => self.high_ram[address as usize - 0xff80] = value, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/ppu.rs:492:19 [INFO] [stdout] | [INFO] [stdout] 492 | 0xfe00...0xfe9f => self.oam[address as usize - 0xfe00], [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Path` [INFO] [stdout] --> src/save.rs:1:17 [INFO] [stdout] | [INFO] [stdout] 1 | use std::path::{Path, PathBuf}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/cartridge/rom.rs:21:23 [INFO] [stdout] | [INFO] [stdout] 21 | fn set(&mut self, address: u16, value: u8) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: if this is intentional, prefix it with an underscore [INFO] [stdout] | [INFO] [stdout] 21 | fn set(&mut self, _address: u16, value: u8) { [INFO] [stdout] | + [INFO] [stdout] help: you might have meant to pattern match on the similarly named constant `OAM_START_ADDRESS` [INFO] [stdout] | [INFO] [stdout] 21 - fn set(&mut self, address: u16, value: u8) { [INFO] [stdout] 21 + fn set(&mut self, memory::mmu::MMU::oam_dma::OAM_START_ADDRESS: u16, value: u8) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/cartridge/rom.rs:21:37 [INFO] [stdout] | [INFO] [stdout] 21 | fn set(&mut self, address: u16, value: u8) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] help: if this is intentional, prefix it with an underscore [INFO] [stdout] | [INFO] [stdout] 21 | fn set(&mut self, address: u16, _value: u8) { [INFO] [stdout] | + [INFO] [stdout] help: you might have meant to pattern match on the similarly named constant `D_PAD` [INFO] [stdout] | [INFO] [stdout] 21 - fn set(&mut self, address: u16, value: u8) { [INFO] [stdout] 21 + fn set(&mut self, address: u16, cpu::D_PAD: u8) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `format` [INFO] [stdout] --> src/apu.rs:11:17 [INFO] [stdout] | [INFO] [stdout] 11 | let format = cpal::Format { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_format` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/cartridge/rom.rs:21:23 [INFO] [stdout] | [INFO] [stdout] 21 | fn set(&mut self, address: u16, value: u8) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: if this is intentional, prefix it with an underscore [INFO] [stdout] | [INFO] [stdout] 21 | fn set(&mut self, _address: u16, value: u8) { [INFO] [stdout] | + [INFO] [stdout] help: you might have meant to pattern match on the similarly named constant `OAM_START_ADDRESS` [INFO] [stdout] | [INFO] [stdout] 21 - fn set(&mut self, address: u16, value: u8) { [INFO] [stdout] 21 + fn set(&mut self, memory::mmu::MMU::oam_dma::OAM_START_ADDRESS: u16, value: u8) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/cartridge/rom.rs:21:37 [INFO] [stdout] | [INFO] [stdout] 21 | fn set(&mut self, address: u16, value: u8) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] help: if this is intentional, prefix it with an underscore [INFO] [stdout] | [INFO] [stdout] 21 | fn set(&mut self, address: u16, _value: u8) { [INFO] [stdout] | + [INFO] [stdout] help: you might have meant to pattern match on the similarly named constant `D_PAD` [INFO] [stdout] | [INFO] [stdout] 21 - fn set(&mut self, address: u16, value: u8) { [INFO] [stdout] 21 + fn set(&mut self, address: u16, cpu::D_PAD: u8) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `config` [INFO] [stdout] --> src/debug/debug_logger.rs:34:31 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn should_skip(&self, config: &Config, record: &Record<'_>) -> bool { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless assignment of field of type `u8` to itself [INFO] [stdout] --> src/cpu/instruction.rs:3388:5 [INFO] [stdout] | [INFO] [stdout] 3388 | core.registers.a = core.registers.a; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless assignment of field of type `u8` to itself [INFO] [stdout] --> src/cpu/instruction.rs:3440:5 [INFO] [stdout] | [INFO] [stdout] 3440 | core.registers.l = core.registers.l; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless assignment of field of type `u8` to itself [INFO] [stdout] --> src/cpu/instruction.rs:3464:5 [INFO] [stdout] | [INFO] [stdout] 3464 | core.registers.h = core.registers.h; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless assignment of field of type `u8` to itself [INFO] [stdout] --> src/cpu/instruction.rs:3488:5 [INFO] [stdout] | [INFO] [stdout] 3488 | core.registers.e = core.registers.e; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless assignment of field of type `u8` to itself [INFO] [stdout] --> src/cpu/instruction.rs:3512:5 [INFO] [stdout] | [INFO] [stdout] 3512 | core.registers.d = core.registers.d; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless assignment of field of type `u8` to itself [INFO] [stdout] --> src/cpu/instruction.rs:3536:5 [INFO] [stdout] | [INFO] [stdout] 3536 | core.registers.c = core.registers.c; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless assignment of field of type `u8` to itself [INFO] [stdout] --> src/cpu/instruction.rs:3588:5 [INFO] [stdout] | [INFO] [stdout] 3588 | core.registers.b = core.registers.b; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INTERRUPT_ENABLE_REG` is never used [INFO] [stdout] --> src/cpu.rs:22:7 [INFO] [stdout] | [INFO] [stdout] 22 | const INTERRUPT_ENABLE_REG: u16 = 0xFFFF; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INTERRUPT_FLAG_REG` is never used [INFO] [stdout] --> src/cpu.rs:23:7 [INFO] [stdout] | [INFO] [stdout] 23 | const INTERRUPT_FLAG_REG: u16 = 0xFF0F; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `V_BLANK` is never used [INFO] [stdout] --> src/cpu.rs:25:7 [INFO] [stdout] | [INFO] [stdout] 25 | const V_BLANK: u8 = 0x01; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `LCD_STAT` is never used [INFO] [stdout] --> src/cpu.rs:26:7 [INFO] [stdout] | [INFO] [stdout] 26 | const LCD_STAT: u8 = 0x02; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `TIMER` is never used [INFO] [stdout] --> src/cpu.rs:27:7 [INFO] [stdout] | [INFO] [stdout] 27 | const TIMER: u8 = 0x04; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `SERIAL` is never used [INFO] [stdout] --> src/cpu.rs:28:7 [INFO] [stdout] | [INFO] [stdout] 28 | const SERIAL: u8 = 0x08; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `D_PAD` is never used [INFO] [stdout] --> src/cpu.rs:29:7 [INFO] [stdout] | [INFO] [stdout] 29 | const D_PAD: u8 = 0x10; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `last_serial` is never read [INFO] [stdout] --> src/memory/mmu.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct MMU { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 21 | last_serial: u8, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `index` is never read [INFO] [stdout] --> src/ppu.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 80 | pub struct Sprite { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 88 | index: usize, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Sprite` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `S` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | S: u8, [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `s` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `M` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | M: u8, [INFO] [stdout] | ^ help: convert the identifier to snake case: `m` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `H` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | H: u8, [INFO] [stdout] | ^ help: convert the identifier to snake case: `h` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `DL` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | DL: u8, [INFO] [stdout] | ^^ help: convert the identifier to snake case: `dl` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `DH` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | DH: u8, [INFO] [stdout] | ^^ help: convert the identifier to snake case: `dh` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `config` [INFO] [stdout] --> src/debug/debug_logger.rs:34:31 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn should_skip(&self, config: &Config, record: &Record<'_>) -> bool { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/display.rs:90:25 [INFO] [stdout] | [INFO] [stdout] 90 | let mut key_pressed = match key { [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/display.rs:130:33 [INFO] [stdout] | [INFO] [stdout] 130 | ... let mut key_pressed = match key { [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless assignment of field of type `u8` to itself [INFO] [stdout] --> src/cpu/instruction.rs:3388:5 [INFO] [stdout] | [INFO] [stdout] 3388 | core.registers.a = core.registers.a; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless assignment of field of type `u8` to itself [INFO] [stdout] --> src/cpu/instruction.rs:3440:5 [INFO] [stdout] | [INFO] [stdout] 3440 | core.registers.l = core.registers.l; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless assignment of field of type `u8` to itself [INFO] [stdout] --> src/cpu/instruction.rs:3464:5 [INFO] [stdout] | [INFO] [stdout] 3464 | core.registers.h = core.registers.h; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless assignment of field of type `u8` to itself [INFO] [stdout] --> src/cpu/instruction.rs:3488:5 [INFO] [stdout] | [INFO] [stdout] 3488 | core.registers.e = core.registers.e; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless assignment of field of type `u8` to itself [INFO] [stdout] --> src/cpu/instruction.rs:3512:5 [INFO] [stdout] | [INFO] [stdout] 3512 | core.registers.d = core.registers.d; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless assignment of field of type `u8` to itself [INFO] [stdout] --> src/cpu/instruction.rs:3536:5 [INFO] [stdout] | [INFO] [stdout] 3536 | core.registers.c = core.registers.c; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless assignment of field of type `u8` to itself [INFO] [stdout] --> src/cpu/instruction.rs:3588:5 [INFO] [stdout] | [INFO] [stdout] 3588 | core.registers.b = core.registers.b; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INTERRUPT_ENABLE_REG` is never used [INFO] [stdout] --> src/cpu.rs:22:7 [INFO] [stdout] | [INFO] [stdout] 22 | const INTERRUPT_ENABLE_REG: u16 = 0xFFFF; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INTERRUPT_FLAG_REG` is never used [INFO] [stdout] --> src/cpu.rs:23:7 [INFO] [stdout] | [INFO] [stdout] 23 | const INTERRUPT_FLAG_REG: u16 = 0xFF0F; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `V_BLANK` is never used [INFO] [stdout] --> src/cpu.rs:25:7 [INFO] [stdout] | [INFO] [stdout] 25 | const V_BLANK: u8 = 0x01; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `LCD_STAT` is never used [INFO] [stdout] --> src/cpu.rs:26:7 [INFO] [stdout] | [INFO] [stdout] 26 | const LCD_STAT: u8 = 0x02; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `TIMER` is never used [INFO] [stdout] --> src/cpu.rs:27:7 [INFO] [stdout] | [INFO] [stdout] 27 | const TIMER: u8 = 0x04; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `SERIAL` is never used [INFO] [stdout] --> src/cpu.rs:28:7 [INFO] [stdout] | [INFO] [stdout] 28 | const SERIAL: u8 = 0x08; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `D_PAD` is never used [INFO] [stdout] --> src/cpu.rs:29:7 [INFO] [stdout] | [INFO] [stdout] 29 | const D_PAD: u8 = 0x10; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `flip` is never used [INFO] [stdout] --> src/cpu.rs:249:12 [INFO] [stdout] | [INFO] [stdout] 94 | impl ClockedCPU { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 249 | pub fn flip(&mut self) -> bool { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `opcode` is never read [INFO] [stdout] --> src/cpu/instruction.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct Instruction { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 12 | pub name: &'static str, [INFO] [stdout] 13 | pub opcode: u8, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Serial` is never constructed [INFO] [stdout] --> src/cpu/interrupt.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 3 | pub enum Flag { [INFO] [stdout] | ---- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 7 | Serial = 3, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Flag` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `FB_W` is never used [INFO] [stdout] --> src/debug.rs:22:11 [INFO] [stdout] | [INFO] [stdout] 22 | pub const FB_W: usize = 160; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `FB_H` is never used [INFO] [stdout] --> src/debug.rs:23:11 [INFO] [stdout] | [INFO] [stdout] 23 | pub const FB_H: usize = 144; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `PeekValue` is never constructed [INFO] [stdout] --> src/debug/command.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 2 | pub enum DebugCommand { [INFO] [stdout] | ------------ variant in this enum [INFO] [stdout] 3 | PeekValue(u16), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `DebugCommand` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `Debuggable` is never used [INFO] [stdout] --> src/debug/debuggable.rs:4:11 [INFO] [stdout] | [INFO] [stdout] 4 | pub trait Debuggable { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/debug/message.rs:9:18 [INFO] [stdout] | [INFO] [stdout] 9 | MemoryUpdate(Vec), [INFO] [stdout] | ------------ ^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `DebugMessage` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 9 - MemoryUpdate(Vec), [INFO] [stdout] 9 + MemoryUpdate(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `DebugCommand` is never constructed [INFO] [stdout] --> src/debug/message.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub enum DebugMessage { [INFO] [stdout] | ------------ variant in this enum [INFO] [stdout] 7 | LogUpdate(String), [INFO] [stdout] 8 | DebugCommand(DebugCommand), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `DebugMessage` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `update_tile_canvas` is never used [INFO] [stdout] --> src/display/debug_canvas.rs:161:8 [INFO] [stdout] | [INFO] [stdout] 161 | pub fn update_tile_canvas( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PIXEL_COLOUR_STRIDE` is never used [INFO] [stdout] --> src/display/debug_canvas.rs:189:11 [INFO] [stdout] | [INFO] [stdout] 189 | const PIXEL_COLOUR_STRIDE: usize = 4; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `last_serial` is never read [INFO] [stdout] --> src/memory/mmu.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct MMU { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 21 | last_serial: u8, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `index` is never read [INFO] [stdout] --> src/ppu.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 80 | pub struct Sprite { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 88 | index: usize, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Sprite` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `random_framebuffer` is never used [INFO] [stdout] --> src/ppu.rs:624:8 [INFO] [stdout] | [INFO] [stdout] 624 | pub fn random_framebuffer() -> PPUFramebuffer { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `S` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | S: u8, [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `s` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `M` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | M: u8, [INFO] [stdout] | ^ help: convert the identifier to snake case: `m` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `H` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | H: u8, [INFO] [stdout] | ^ help: convert the identifier to snake case: `h` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `DL` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | DL: u8, [INFO] [stdout] | ^^ help: convert the identifier to snake case: `dl` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `DH` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | DH: u8, [INFO] [stdout] | ^^ help: convert the identifier to snake case: `dh` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `test` profile [unoptimized + debuginfo] target(s) in 3.94s [INFO] running `Command { std: "docker" "inspect" "a5f26406fc8ac40af5cfd5d60aba6c654ad34d72d7cbce9df72e0b3b9186e04e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a5f26406fc8ac40af5cfd5d60aba6c654ad34d72d7cbce9df72e0b3b9186e04e", kill_on_drop: false }` [INFO] [stdout] a5f26406fc8ac40af5cfd5d60aba6c654ad34d72d7cbce9df72e0b3b9186e04e