[INFO] fetching crate sodium 0.1.3... [INFO] building sodium-0.1.3 against master#ad85bc524b1ad696e42061ad8338d382dffbdbe5 for pr-146237-1 [INFO] extracting crate sodium 0.1.3 into /workspace/builds/worker-5-tc1/source [INFO] started tweaking crates.io crate sodium 0.1.3 [INFO] finished tweaking crates.io crate sodium 0.1.3 [INFO] tweaked toml for crates.io crate sodium 0.1.3 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate sodium 0.1.3 on toolchain ad85bc524b1ad696e42061ad8338d382dffbdbe5 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ad85bc524b1ad696e42061ad8338d382dffbdbe5" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ad85bc524b1ad696e42061ad8338d382dffbdbe5" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 88 packages to latest compatible versions [INFO] [stderr] Adding criterion v0.4.0 (available: v0.7.0) [INFO] [stderr] Adding env_logger v0.9.3 (available: v0.11.8) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ad85bc524b1ad696e42061ad8338d382dffbdbe5" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:e90291280db7d1fac5b66fc6dad9f9662629e7365a55743daf9bdf73ebc4ea79" "/opt/rustwide/cargo-home/bin/cargo" "+ad85bc524b1ad696e42061ad8338d382dffbdbe5" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3a31a5642598953bda66d974e0bf8a4dcc955baa1a62a4b99574fa47bd6ba59a [INFO] running `Command { std: "docker" "start" "-a" "3a31a5642598953bda66d974e0bf8a4dcc955baa1a62a4b99574fa47bd6ba59a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3a31a5642598953bda66d974e0bf8a4dcc955baa1a62a4b99574fa47bd6ba59a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3a31a5642598953bda66d974e0bf8a4dcc955baa1a62a4b99574fa47bd6ba59a", kill_on_drop: false }` [INFO] [stdout] 3a31a5642598953bda66d974e0bf8a4dcc955baa1a62a4b99574fa47bd6ba59a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:e90291280db7d1fac5b66fc6dad9f9662629e7365a55743daf9bdf73ebc4ea79" "/opt/rustwide/cargo-home/bin/cargo" "+ad85bc524b1ad696e42061ad8338d382dffbdbe5" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 91a5261a441ebde7ae804eee64bba542cc2d13ed8c91d25235b043b3b9de8f82 [INFO] running `Command { std: "docker" "start" "-a" "91a5261a441ebde7ae804eee64bba542cc2d13ed8c91d25235b043b3b9de8f82", kill_on_drop: false }` [INFO] [stderr] Compiling parking_lot_core v0.9.11 [INFO] [stderr] Compiling parking_lot v0.12.4 [INFO] [stderr] Compiling sodium v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/impl_/stream.rs:531:39 [INFO] [stdout] | [INFO] [stdout] 531 | for firing in &data.firing_op { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 531 - for firing in &data.firing_op { [INFO] [stdout] 531 + while let Some(firing) = &data.firing_op { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 531 - for firing in &data.firing_op { [INFO] [stdout] 531 + if let Some(firing) = &data.firing_op { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.28s [INFO] running `Command { std: "docker" "inspect" "91a5261a441ebde7ae804eee64bba542cc2d13ed8c91d25235b043b3b9de8f82", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "91a5261a441ebde7ae804eee64bba542cc2d13ed8c91d25235b043b3b9de8f82", kill_on_drop: false }` [INFO] [stdout] 91a5261a441ebde7ae804eee64bba542cc2d13ed8c91d25235b043b3b9de8f82 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:e90291280db7d1fac5b66fc6dad9f9662629e7365a55743daf9bdf73ebc4ea79" "/opt/rustwide/cargo-home/bin/cargo" "+ad85bc524b1ad696e42061ad8338d382dffbdbe5" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c5a28efc532cf5c18e06985f8ed50178539cf9f0e9012d5cdc90dcb66cdcd012 [INFO] running `Command { std: "docker" "start" "-a" "c5a28efc532cf5c18e06985f8ed50178539cf9f0e9012d5cdc90dcb66cdcd012", kill_on_drop: false }` [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling os_str_bytes v6.6.1 [INFO] [stderr] Compiling textwrap v0.16.2 [INFO] [stderr] Compiling env_logger v0.9.3 [INFO] [stderr] Compiling sodium v0.1.3 (/opt/rustwide/workdir) [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling clap_lex v0.2.4 [INFO] [stderr] Compiling clap v3.2.25 [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/impl_/stream.rs:531:39 [INFO] [stdout] | [INFO] [stdout] 531 | for firing in &data.firing_op { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 531 - for firing in &data.firing_op { [INFO] [stdout] 531 + while let Some(firing) = &data.firing_op { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 531 - for firing in &data.firing_op { [INFO] [stdout] 531 + if let Some(firing) = &data.firing_op { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling ciborium v0.2.2 [INFO] [stderr] Compiling tinytemplate v1.2.1 [INFO] [stderr] Compiling criterion v0.4.0 [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/impl_/stream.rs:531:39 [INFO] [stdout] | [INFO] [stdout] 531 | for firing in &data.firing_op { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 531 - for firing in &data.firing_op { [INFO] [stdout] 531 + while let Some(firing) = &data.firing_op { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 531 - for firing in &data.firing_op { [INFO] [stdout] 531 + if let Some(firing) = &data.firing_op { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `test` profile [unoptimized + debuginfo] target(s) in 23.88s [INFO] running `Command { std: "docker" "inspect" "c5a28efc532cf5c18e06985f8ed50178539cf9f0e9012d5cdc90dcb66cdcd012", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c5a28efc532cf5c18e06985f8ed50178539cf9f0e9012d5cdc90dcb66cdcd012", kill_on_drop: false }` [INFO] [stdout] c5a28efc532cf5c18e06985f8ed50178539cf9f0e9012d5cdc90dcb66cdcd012