[INFO] cloning repository https://github.com/reisub0/tftp [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/reisub0/tftp" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Freisub0%2Ftftp", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Freisub0%2Ftftp'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7c591390f05e5ba77f27c9291c478ce5fcacce79 [INFO] building reisub0/tftp against master#ad85bc524b1ad696e42061ad8338d382dffbdbe5 for pr-146237-1 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Freisub0%2Ftftp" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/reisub0/tftp [INFO] finished tweaking git repo https://github.com/reisub0/tftp [INFO] tweaked toml for git repo https://github.com/reisub0/tftp written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/reisub0/tftp on toolchain ad85bc524b1ad696e42061ad8338d382dffbdbe5 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ad85bc524b1ad696e42061ad8338d382dffbdbe5" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/reisub0/tftp already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ad85bc524b1ad696e42061ad8338d382dffbdbe5" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded byteorder v1.2.7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:e90291280db7d1fac5b66fc6dad9f9662629e7365a55743daf9bdf73ebc4ea79" "/opt/rustwide/cargo-home/bin/cargo" "+ad85bc524b1ad696e42061ad8338d382dffbdbe5" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3a1265baac6a3c283b5ea531621548774a08e9bf232a3826a4e539ba1b97f5f4 [INFO] running `Command { std: "docker" "start" "-a" "3a1265baac6a3c283b5ea531621548774a08e9bf232a3826a4e539ba1b97f5f4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3a1265baac6a3c283b5ea531621548774a08e9bf232a3826a4e539ba1b97f5f4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3a1265baac6a3c283b5ea531621548774a08e9bf232a3826a4e539ba1b97f5f4", kill_on_drop: false }` [INFO] [stdout] 3a1265baac6a3c283b5ea531621548774a08e9bf232a3826a4e539ba1b97f5f4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:e90291280db7d1fac5b66fc6dad9f9662629e7365a55743daf9bdf73ebc4ea79" "/opt/rustwide/cargo-home/bin/cargo" "+ad85bc524b1ad696e42061ad8338d382dffbdbe5" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 033f39f1e4019161e290eb6ea0330690cf651e92b961104d12d1c7a17d7d3a67 [INFO] running `Command { std: "docker" "start" "-a" "033f39f1e4019161e290eb6ea0330690cf651e92b961104d12d1c7a17d7d3a67", kill_on_drop: false }` [INFO] [stderr] Compiling byteorder v1.2.7 [INFO] [stderr] Compiling tftp-server v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: type `reader` should have an upper camel case name [INFO] [stdout] --> src/reader.rs:12:12 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct reader<'a> { [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper camel case: `Reader` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `writer` should have an upper camel case name [INFO] [stdout] --> src/writer.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 38 | pub struct writer<'a> { [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper camel case (notice the capitalization): `Writer` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/reader.rs:37:32 [INFO] [stdout] | [INFO] [stdout] 37 | fn cause(&self) -> Option<&error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 37 | fn cause(&self) -> Option<&dyn error::Error> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/tftp.rs:272:32 [INFO] [stdout] | [INFO] [stdout] 272 | fn cause(&self) -> Option<&error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 272 | fn cause(&self) -> Option<&dyn error::Error> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/writer.rs:30:32 [INFO] [stdout] | [INFO] [stdout] 30 | fn cause(&self) -> Option<&std::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 30 | fn cause(&self) -> Option<&dyn std::error::Error> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr` [INFO] [stdout] --> src/main.rs:37:15 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn handle(addr: SocketAddr, src: SocketAddr, packet: tftp::Packet) -> Option { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `src` [INFO] [stdout] --> src/main.rs:37:33 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn handle(addr: SocketAddr, src: SocketAddr, packet: tftp::Packet) -> Option { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_src` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `len` and `take_all` are never used [INFO] [stdout] --> src/reader.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 44 | impl<'a> reader<'a> { [INFO] [stdout] | ------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 48 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 78 | pub fn take_all(&mut self) -> Result<&'a [u8]> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `read` is never used [INFO] [stdout] --> src/tftp.rs:166:8 [INFO] [stdout] | [INFO] [stdout] 165 | impl<'a> Data<'a> { [INFO] [stdout] | ----------------- associated function in this implementation [INFO] [stdout] 166 | fn read(buff: &mut reader::reader<'a>) -> Result { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.36s [INFO] running `Command { std: "docker" "inspect" "033f39f1e4019161e290eb6ea0330690cf651e92b961104d12d1c7a17d7d3a67", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "033f39f1e4019161e290eb6ea0330690cf651e92b961104d12d1c7a17d7d3a67", kill_on_drop: false }` [INFO] [stdout] 033f39f1e4019161e290eb6ea0330690cf651e92b961104d12d1c7a17d7d3a67 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:e90291280db7d1fac5b66fc6dad9f9662629e7365a55743daf9bdf73ebc4ea79" "/opt/rustwide/cargo-home/bin/cargo" "+ad85bc524b1ad696e42061ad8338d382dffbdbe5" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ef067672e8bf616fdcbaea5c662fed0ddb17104b85bf230fd74598f4e95d9355 [INFO] running `Command { std: "docker" "start" "-a" "ef067672e8bf616fdcbaea5c662fed0ddb17104b85bf230fd74598f4e95d9355", kill_on_drop: false }` [INFO] [stderr] Compiling tftp-server v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: type `reader` should have an upper camel case name [INFO] [stdout] --> src/reader.rs:12:12 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct reader<'a> { [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper camel case: `Reader` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/tftp.rs:301:9 [INFO] [stdout] | [INFO] [stdout] 301 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `writer` should have an upper camel case name [INFO] [stdout] --> src/writer.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 38 | pub struct writer<'a> { [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper camel case (notice the capitalization): `Writer` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/writer.rs:101:9 [INFO] [stdout] | [INFO] [stdout] 101 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/main.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/reader.rs:37:32 [INFO] [stdout] | [INFO] [stdout] 37 | fn cause(&self) -> Option<&error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 37 | fn cause(&self) -> Option<&dyn error::Error> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/tftp.rs:272:32 [INFO] [stdout] | [INFO] [stdout] 272 | fn cause(&self) -> Option<&error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 272 | fn cause(&self) -> Option<&dyn error::Error> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/writer.rs:30:32 [INFO] [stdout] | [INFO] [stdout] 30 | fn cause(&self) -> Option<&std::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 30 | fn cause(&self) -> Option<&dyn std::error::Error> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr` [INFO] [stdout] --> src/main.rs:37:15 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn handle(addr: SocketAddr, src: SocketAddr, packet: tftp::Packet) -> Option { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `src` [INFO] [stdout] --> src/main.rs:37:33 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn handle(addr: SocketAddr, src: SocketAddr, packet: tftp::Packet) -> Option { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_src` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `len` and `take_all` are never used [INFO] [stdout] --> src/reader.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 44 | impl<'a> reader<'a> { [INFO] [stdout] | ------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 48 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 78 | pub fn take_all(&mut self) -> Result<&'a [u8]> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `read` is never used [INFO] [stdout] --> src/tftp.rs:166:8 [INFO] [stdout] | [INFO] [stdout] 165 | impl<'a> Data<'a> { [INFO] [stdout] | ----------------- associated function in this implementation [INFO] [stdout] 166 | fn read(buff: &mut reader::reader<'a>) -> Result { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `test` profile [unoptimized + debuginfo] target(s) in 0.31s [INFO] running `Command { std: "docker" "inspect" "ef067672e8bf616fdcbaea5c662fed0ddb17104b85bf230fd74598f4e95d9355", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ef067672e8bf616fdcbaea5c662fed0ddb17104b85bf230fd74598f4e95d9355", kill_on_drop: false }` [INFO] [stdout] ef067672e8bf616fdcbaea5c662fed0ddb17104b85bf230fd74598f4e95d9355