[INFO] cloning repository https://github.com/rainlab-inc/nbd-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/rainlab-inc/nbd-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frainlab-inc%2Fnbd-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frainlab-inc%2Fnbd-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ddcbda18a2bd41b93610b8cb19bb0f47ce831465 [INFO] building rainlab-inc/nbd-rs against master#ad85bc524b1ad696e42061ad8338d382dffbdbe5 for pr-146237-1 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frainlab-inc%2Fnbd-rs" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/rainlab-inc/nbd-rs [INFO] finished tweaking git repo https://github.com/rainlab-inc/nbd-rs [INFO] tweaked toml for git repo https://github.com/rainlab-inc/nbd-rs written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/rainlab-inc/nbd-rs on toolchain ad85bc524b1ad696e42061ad8338d382dffbdbe5 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ad85bc524b1ad696e42061ad8338d382dffbdbe5" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/rainlab-inc/nbd-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ad85bc524b1ad696e42061ad8338d382dffbdbe5" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Updating git repository `https://git.rlab.io/forks/rust-crates/rust-s3.git` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded serde-xml-rs v0.5.1 [INFO] [stderr] Downloaded minidom v0.13.0 [INFO] [stderr] Downloaded tokio-stream v0.1.8 [INFO] [stderr] Downloaded os_str_bytes v6.0.0 [INFO] [stderr] Downloaded dirs-sys v0.3.6 [INFO] [stderr] Downloaded dirs v4.0.0 [INFO] [stderr] Downloaded dlv-list v0.2.3 [INFO] [stderr] Downloaded attohttpc v0.18.0 [INFO] [stderr] Downloaded security-framework v2.4.2 [INFO] [stderr] Downloaded serde_json v1.0.69 [INFO] [stderr] Downloaded hyper v0.14.14 [INFO] [stderr] Downloaded clap v3.1.17 [INFO] [stderr] Downloaded openssl-sys v0.9.70 [INFO] [stderr] Downloaded anyhow v1.0.45 [INFO] [stderr] Downloaded maybe-async v0.2.6 [INFO] [stderr] Downloaded itertools v0.10.3 [INFO] [stderr] Downloaded quick-xml v0.20.0 [INFO] [stderr] Downloaded tokio v1.13.0 [INFO] [stderr] Downloaded ordered-multimap v0.3.1 [INFO] [stderr] Downloaded rust-ini v0.17.0 [INFO] [stderr] Downloaded sha2 v0.9.8 [INFO] [stderr] Downloaded clap_lex v0.2.0 [INFO] [stderr] Downloaded async-trait v0.1.51 [INFO] [stderr] Downloaded wildmatch v2.1.0 [INFO] [stderr] Downloaded aws-creds v0.27.1 [INFO] [stderr] Downloaded block_on_proc v0.2.0 [INFO] [stderr] Downloaded aws-region v0.23.3 [INFO] [stderr] Downloaded mmap-safe v0.0.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:e90291280db7d1fac5b66fc6dad9f9662629e7365a55743daf9bdf73ebc4ea79" "/opt/rustwide/cargo-home/bin/cargo" "+ad85bc524b1ad696e42061ad8338d382dffbdbe5" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0e7ae9c7894ea755d7396bef14a53d83c425ed044bcc5eb9b827da6710aed0c0 [INFO] running `Command { std: "docker" "start" "-a" "0e7ae9c7894ea755d7396bef14a53d83c425ed044bcc5eb9b827da6710aed0c0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0e7ae9c7894ea755d7396bef14a53d83c425ed044bcc5eb9b827da6710aed0c0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0e7ae9c7894ea755d7396bef14a53d83c425ed044bcc5eb9b827da6710aed0c0", kill_on_drop: false }` [INFO] [stdout] 0e7ae9c7894ea755d7396bef14a53d83c425ed044bcc5eb9b827da6710aed0c0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:e90291280db7d1fac5b66fc6dad9f9662629e7365a55743daf9bdf73ebc4ea79" "/opt/rustwide/cargo-home/bin/cargo" "+ad85bc524b1ad696e42061ad8338d382dffbdbe5" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8d8c4f571b103b503d6fac0976fb86708cac97e7ea33a1b805b75fb47f57f6f0 [INFO] running `Command { std: "docker" "start" "-a" "8d8c4f571b103b503d6fac0976fb86708cac97e7ea33a1b805b75fb47f57f6f0", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.107 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling pkg-config v0.3.22 [INFO] [stderr] Compiling bytes v1.1.0 [INFO] [stderr] Compiling proc-macro2 v1.0.32 [INFO] [stderr] Compiling cc v1.0.72 [INFO] [stderr] Compiling pin-project-lite v0.2.7 [INFO] [stderr] Compiling futures-core v0.3.17 [INFO] [stderr] Compiling syn v1.0.81 [INFO] [stderr] Compiling itoa v0.4.8 [INFO] [stderr] Compiling openssl v0.10.38 [INFO] [stderr] Compiling serde v1.0.130 [INFO] [stderr] Compiling typenum v1.14.0 [INFO] [stderr] Compiling generic-array v0.14.4 [INFO] [stderr] Compiling native-tls v0.2.8 [INFO] [stderr] Compiling once_cell v1.8.0 [INFO] [stderr] Compiling matches v0.1.9 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling tinyvec_macros v0.1.0 [INFO] [stderr] Compiling futures-task v0.3.17 [INFO] [stderr] Compiling tinyvec v1.5.1 [INFO] [stderr] Compiling hashbrown v0.11.2 [INFO] [stderr] Compiling ppv-lite86 v0.2.15 [INFO] [stderr] Compiling tokio v1.13.0 [INFO] [stderr] Compiling indexmap v1.7.0 [INFO] [stderr] Compiling futures-util v0.3.17 [INFO] [stderr] Compiling percent-encoding v2.1.0 [INFO] [stderr] Compiling openssl-probe v0.1.4 [INFO] [stderr] Compiling form_urlencoded v1.0.1 [INFO] [stderr] Compiling tracing-core v0.1.21 [INFO] [stderr] Compiling httparse v1.5.1 [INFO] [stderr] Compiling serde_json v1.0.69 [INFO] [stderr] Compiling unicode-bidi v0.3.7 [INFO] [stderr] Compiling http v0.2.5 [INFO] [stderr] Compiling futures-channel v0.3.17 [INFO] [stderr] Compiling futures-sink v0.3.17 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Compiling tracing v0.1.29 [INFO] [stderr] Compiling ahash v0.4.7 [INFO] [stderr] Compiling mio v0.7.14 [INFO] [stderr] Compiling num_cpus v1.13.0 [INFO] [stderr] Compiling getrandom v0.2.3 [INFO] [stderr] Compiling anyhow v1.0.45 [INFO] [stderr] Compiling unicode-normalization v0.1.19 [INFO] [stderr] Compiling rand_core v0.6.3 [INFO] [stderr] Compiling try-lock v0.2.3 [INFO] [stderr] Compiling slab v0.4.5 [INFO] [stderr] Compiling want v0.3.0 [INFO] [stderr] Compiling hashbrown v0.9.1 [INFO] [stderr] Compiling socket2 v0.4.2 [INFO] [stderr] Compiling openssl-sys v0.9.70 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Compiling rand v0.8.4 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling tower-service v0.3.1 [INFO] [stderr] Compiling httpdate v1.0.1 [INFO] [stderr] Compiling encoding_rs v0.8.29 [INFO] [stderr] Compiling digest v0.9.0 [INFO] [stderr] Compiling dirs-sys v0.3.6 [INFO] [stderr] Compiling xml-rs v0.8.4 [INFO] [stderr] Compiling wildmatch v2.1.0 [INFO] [stderr] Compiling async-trait v0.1.51 [INFO] [stderr] Compiling crypto-mac v0.11.1 [INFO] [stderr] Compiling block-buffer v0.9.0 [INFO] [stderr] Compiling dirs v4.0.0 [INFO] [stderr] Compiling atty v0.2.14 [INFO] [stderr] Compiling time v0.1.43 [INFO] [stderr] Compiling aho-corasick v0.7.18 [INFO] [stderr] Compiling quick-xml v0.20.0 [INFO] [stderr] Compiling regex-syntax v0.6.25 [INFO] [stderr] Compiling mime v0.3.16 [INFO] [stderr] Compiling idna v0.2.3 [INFO] [stderr] Compiling dlv-list v0.2.3 [INFO] [stderr] Compiling ordered-multimap v0.3.1 [INFO] [stderr] Compiling cpufeatures v0.2.1 [INFO] [stderr] Compiling termcolor v1.1.2 [INFO] [stderr] Compiling url v2.2.2 [INFO] [stderr] Compiling ipnet v2.3.1 [INFO] [stderr] Compiling rust-ini v0.17.0 [INFO] [stderr] Compiling os_str_bytes v6.0.0 [INFO] [stderr] Compiling http-body v0.4.4 [INFO] [stderr] Compiling serde_urlencoded v0.7.0 [INFO] [stderr] Compiling base64 v0.13.0 [INFO] [stderr] Compiling clap_lex v0.2.0 [INFO] [stderr] Compiling sha2 v0.9.8 [INFO] [stderr] Compiling minidom v0.13.0 [INFO] [stderr] Compiling chrono v0.4.19 [INFO] [stderr] Compiling hmac v0.11.0 [INFO] [stderr] Compiling aws-region v0.23.3 [INFO] [stderr] Compiling fs2 v0.4.3 [INFO] [stderr] Compiling memmap v0.7.0 [INFO] [stderr] Compiling md5 v0.7.0 [INFO] [stderr] Compiling either v1.6.1 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Compiling hex v0.4.3 [INFO] [stderr] Compiling textwrap v0.15.0 [INFO] [stderr] Compiling itertools v0.10.3 [INFO] [stderr] Compiling mmap-safe v0.0.2 [INFO] [stderr] Compiling clap v3.1.17 [INFO] [stderr] Compiling regex v1.5.4 [INFO] [stderr] Compiling attohttpc v0.18.0 [INFO] [stderr] Compiling tokio-util v0.6.9 [INFO] [stderr] Compiling tokio-native-tls v0.3.0 [INFO] [stderr] Compiling tokio-stream v0.1.8 [INFO] [stderr] Compiling env_logger v0.9.0 [INFO] [stderr] Compiling h2 v0.3.7 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Compiling serde_derive v1.0.130 [INFO] [stderr] Compiling maybe-async v0.2.6 [INFO] [stderr] Compiling block_on_proc v0.2.0 [INFO] [stderr] Compiling thiserror v1.0.30 [INFO] [stderr] Compiling serde-xml-rs v0.5.1 [INFO] [stderr] Compiling hyper v0.14.14 [INFO] [stderr] Compiling aws-creds v0.27.1 [INFO] [stderr] Compiling hyper-tls v0.5.0 [INFO] [stderr] Compiling reqwest v0.11.6 [INFO] [stderr] Compiling rust-s3 v0.28.0 (https://git.rlab.io/forks/rust-crates/rust-s3.git?branch=rlab%2F0.28-dev#714325be) [INFO] [stderr] Compiling nbd-rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/object/s3.rs:223:50 [INFO] [stdout] | [INFO] [stdout] 223 | access_key: parsed_url.username().clone().to_string(), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/object/s3.rs:224:37 [INFO] [stdout] | [INFO] [stdout] 224 | secret_key: password.clone().to_string(), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/object/cache.rs:172:25 [INFO] [stdout] | [INFO] [stdout] 172 | drop(oldest_unwritten_page); [INFO] [stdout] | ^^^^^---------------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `Option<(&std::string::String, &CacheValRef)>` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_copy_types)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 172 - drop(oldest_unwritten_page); [INFO] [stdout] 172 + let _ = oldest_unwritten_page; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/object/cache.rs:186:21 [INFO] [stdout] | [INFO] [stdout] 186 | drop(cache_kp); [INFO] [stdout] | ^^^^^--------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `(&std::string::String, &CacheValRef)` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 186 - drop(cache_kp); [INFO] [stdout] 186 + let _ = cache_kp; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/object/cache.rs:339:9 [INFO] [stdout] | [INFO] [stdout] 339 | drop(cached_obj_ref); [INFO] [stdout] | ^^^^^--------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `Option<(&std::string::String, &CacheValRef)>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 339 - drop(cached_obj_ref); [INFO] [stdout] 339 + let _ = cached_obj_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/object/cache.rs:581:9 [INFO] [stdout] | [INFO] [stdout] 581 | drop(cached_obj_ref); [INFO] [stdout] | ^^^^^--------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `Option<(&std::string::String, &CacheValRef)>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 581 - drop(cached_obj_ref); [INFO] [stdout] 581 + let _ = cached_obj_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/util.rs:157:16 [INFO] [stdout] | [INFO] [stdout] 157 | for cap in re.captures(size_str) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 157 - for cap in re.captures(size_str) { [INFO] [stdout] 157 + while let Some(cap) = re.captures(size_str) { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 157 - for cap in re.captures(size_str) { [INFO] [stdout] 157 + if let Some(cap) = re.captures(size_str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 55.18s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: quick-xml v0.20.0 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1` [INFO] running `Command { std: "docker" "inspect" "8d8c4f571b103b503d6fac0976fb86708cac97e7ea33a1b805b75fb47f57f6f0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8d8c4f571b103b503d6fac0976fb86708cac97e7ea33a1b805b75fb47f57f6f0", kill_on_drop: false }` [INFO] [stdout] 8d8c4f571b103b503d6fac0976fb86708cac97e7ea33a1b805b75fb47f57f6f0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:e90291280db7d1fac5b66fc6dad9f9662629e7365a55743daf9bdf73ebc4ea79" "/opt/rustwide/cargo-home/bin/cargo" "+ad85bc524b1ad696e42061ad8338d382dffbdbe5" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6355da1527d1292c50df142b02c3a519392861bd5e41efeed9f35f104913b8c1 [INFO] running `Command { std: "docker" "start" "-a" "6355da1527d1292c50df142b02c3a519392861bd5e41efeed9f35f104913b8c1", kill_on_drop: false }` [INFO] [stderr] Compiling nbd-rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/object/s3.rs:223:50 [INFO] [stdout] | [INFO] [stdout] 223 | access_key: parsed_url.username().clone().to_string(), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/object/s3.rs:224:37 [INFO] [stdout] | [INFO] [stdout] 224 | secret_key: password.clone().to_string(), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/object/cache.rs:172:25 [INFO] [stdout] | [INFO] [stdout] 172 | drop(oldest_unwritten_page); [INFO] [stdout] | ^^^^^---------------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `Option<(&std::string::String, &CacheValRef)>` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_copy_types)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 172 - drop(oldest_unwritten_page); [INFO] [stdout] 172 + let _ = oldest_unwritten_page; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/object/cache.rs:186:21 [INFO] [stdout] | [INFO] [stdout] 186 | drop(cache_kp); [INFO] [stdout] | ^^^^^--------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `(&std::string::String, &CacheValRef)` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 186 - drop(cache_kp); [INFO] [stdout] 186 + let _ = cache_kp; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/object/cache.rs:339:9 [INFO] [stdout] | [INFO] [stdout] 339 | drop(cached_obj_ref); [INFO] [stdout] | ^^^^^--------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `Option<(&std::string::String, &CacheValRef)>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 339 - drop(cached_obj_ref); [INFO] [stdout] 339 + let _ = cached_obj_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/object/cache.rs:581:9 [INFO] [stdout] | [INFO] [stdout] 581 | drop(cached_obj_ref); [INFO] [stdout] | ^^^^^--------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `Option<(&std::string::String, &CacheValRef)>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 581 - drop(cached_obj_ref); [INFO] [stdout] 581 + let _ = cached_obj_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/util.rs:157:16 [INFO] [stdout] | [INFO] [stdout] 157 | for cap in re.captures(size_str) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 157 - for cap in re.captures(size_str) { [INFO] [stdout] 157 + while let Some(cap) = re.captures(size_str) { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 157 - for cap in re.captures(size_str) { [INFO] [stdout] 157 + if let Some(cap) = re.captures(size_str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `test` profile [unoptimized + debuginfo] target(s) in 3.03s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: quick-xml v0.20.0 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1` [INFO] running `Command { std: "docker" "inspect" "6355da1527d1292c50df142b02c3a519392861bd5e41efeed9f35f104913b8c1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6355da1527d1292c50df142b02c3a519392861bd5e41efeed9f35f104913b8c1", kill_on_drop: false }` [INFO] [stdout] 6355da1527d1292c50df142b02c3a519392861bd5e41efeed9f35f104913b8c1