[INFO] cloning repository https://github.com/kduncan99/space_trader
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/kduncan99/space_trader" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkduncan99%2Fspace_trader", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkduncan99%2Fspace_trader'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 16e5771921487fbd72cc2a426f0734ec5cf04251
[INFO] building kduncan99/space_trader against master#ad85bc524b1ad696e42061ad8338d382dffbdbe5 for pr-146237-1
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkduncan99%2Fspace_trader" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/kduncan99/space_trader
[INFO] finished tweaking git repo https://github.com/kduncan99/space_trader
[INFO] tweaked toml for git repo https://github.com/kduncan99/space_trader written to /workspace/builds/worker-1-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/kduncan99/space_trader on toolchain ad85bc524b1ad696e42061ad8338d382dffbdbe5
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ad85bc524b1ad696e42061ad8338d382dffbdbe5" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/kduncan99/space_trader already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ad85bc524b1ad696e42061ad8338d382dffbdbe5" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Updating crates.io index
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded uuid v1.17.0
[INFO] [stderr]   Downloaded potential_utf v0.1.2
[INFO] [stderr]   Downloaded ctrlc v3.4.7
[INFO] [stderr]   Downloaded slab v0.4.10
[INFO] [stderr]   Downloaded rustc-demangle v0.1.25
[INFO] [stderr]   Downloaded bumpalo v3.18.1
[INFO] [stderr]   Downloaded rustls-webpki v0.103.3
[INFO] [stderr]   Downloaded crossbeam-channel v0.5.15
[INFO] [stderr]   Downloaded hyper-util v0.1.14
[INFO] [stderr]   Downloaded cc v1.2.27
[INFO] [stderr]   Downloaded zerovec v0.11.2
[INFO] [stderr]   Downloaded reqwest v0.12.21
[INFO] [stderr]   Downloaded rusqlite v0.36.0
[INFO] [stderr]   Downloaded h2 v0.4.11
[INFO] [stderr]   Downloaded syn v2.0.102
[INFO] [stderr]   Downloaded nix v0.30.1
[INFO] [stderr]   Downloaded rustls v0.23.28
[INFO] [stderr]   Downloaded libsqlite3-sys v0.34.0
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:e90291280db7d1fac5b66fc6dad9f9662629e7365a55743daf9bdf73ebc4ea79" "/opt/rustwide/cargo-home/bin/cargo" "+ad85bc524b1ad696e42061ad8338d382dffbdbe5" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 21858b37b7d596c9734ee95c54e99770e807c9f364aeb4b744e8065438f99fd2
[INFO] running `Command { std: "docker" "start" "-a" "21858b37b7d596c9734ee95c54e99770e807c9f364aeb4b744e8065438f99fd2", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "21858b37b7d596c9734ee95c54e99770e807c9f364aeb4b744e8065438f99fd2", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "21858b37b7d596c9734ee95c54e99770e807c9f364aeb4b744e8065438f99fd2", kill_on_drop: false }`
[INFO] [stdout] 21858b37b7d596c9734ee95c54e99770e807c9f364aeb4b744e8065438f99fd2
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:e90291280db7d1fac5b66fc6dad9f9662629e7365a55743daf9bdf73ebc4ea79" "/opt/rustwide/cargo-home/bin/cargo" "+ad85bc524b1ad696e42061ad8338d382dffbdbe5" "build" "--frozen" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] c91cd077adb7bb88b8b0a6c1988b9bf20b2d44cc89c941993140dfda273fe56e
[INFO] running `Command { std: "docker" "start" "-a" "c91cd077adb7bb88b8b0a6c1988b9bf20b2d44cc89c941993140dfda273fe56e", kill_on_drop: false }`
[INFO] [stderr]    Compiling proc-macro2 v1.0.95
[INFO] [stderr]    Compiling unicode-ident v1.0.18
[INFO] [stderr]    Compiling libc v0.2.172
[INFO] [stderr]    Compiling pkg-config v0.3.32
[INFO] [stderr]    Compiling stable_deref_trait v1.2.0
[INFO] [stderr]    Compiling vcpkg v0.2.15
[INFO] [stderr]    Compiling pin-project-lite v0.2.16
[INFO] [stderr]    Compiling cfg-if v1.0.1
[INFO] [stderr]    Compiling bytes v1.10.1
[INFO] [stderr]    Compiling futures-core v0.3.31
[INFO] [stderr]    Compiling cc v1.2.27
[INFO] [stderr]    Compiling once_cell v1.21.3
[INFO] [stderr]    Compiling itoa v1.0.15
[INFO] [stderr]    Compiling futures-sink v0.3.31
[INFO] [stderr]    Compiling foldhash v0.1.5
[INFO] [stderr]    Compiling bitflags v2.9.1
[INFO] [stderr]    Compiling smallvec v1.15.1
[INFO] [stderr]    Compiling hashbrown v0.15.4
[INFO] [stderr]    Compiling http v1.3.1
[INFO] [stderr]    Compiling writeable v0.6.1
[INFO] [stderr]    Compiling slab v0.4.10
[INFO] [stderr]    Compiling quote v1.0.40
[INFO] [stderr]    Compiling litemap v0.8.0
[INFO] [stderr]    Compiling syn v2.0.102
[INFO] [stderr]    Compiling pin-utils v0.1.0
[INFO] [stderr]    Compiling icu_properties_data v2.0.1
[INFO] [stderr]    Compiling memchr v2.7.5
[INFO] [stderr]    Compiling futures-io v0.3.31
[INFO] [stderr]    Compiling icu_normalizer_data v2.0.0
[INFO] [stderr]    Compiling futures-task v0.3.31
[INFO] [stderr]    Compiling tracing-core v0.1.34
[INFO] [stderr]    Compiling getrandom v0.3.3
[INFO] [stderr]    Compiling openssl v0.10.73
[INFO] [stderr]    Compiling http-body v1.0.1
[INFO] [stderr]    Compiling foreign-types-shared v0.1.1
[INFO] [stderr]    Compiling httparse v1.10.1
[INFO] [stderr]    Compiling equivalent v1.0.2
[INFO] [stderr]    Compiling indexmap v2.10.0
[INFO] [stderr]    Compiling futures-util v0.3.31
[INFO] [stderr]    Compiling foreign-types v0.3.2
[INFO] [stderr]    Compiling tracing v0.1.41
[INFO] [stderr]    Compiling openssl-sys v0.9.109
[INFO] [stderr]    Compiling native-tls v0.2.14
[INFO] [stderr]    Compiling atomic-waker v1.1.2
[INFO] [stderr]    Compiling try-lock v0.2.5
[INFO] [stderr]    Compiling tower-service v0.3.3
[INFO] [stderr]    Compiling zerocopy v0.8.25
[INFO] [stderr]    Compiling want v0.3.1
[INFO] [stderr]    Compiling futures-channel v0.3.31
[INFO] [stderr]    Compiling openssl-probe v0.1.6
[INFO] [stderr]    Compiling socket2 v0.5.10
[INFO] [stderr]    Compiling mio v1.0.4
[INFO] [stderr]    Compiling serde v1.0.219
[INFO] [stderr]    Compiling autocfg v1.5.0
[INFO] [stderr]    Compiling log v0.4.27
[INFO] [stderr]    Compiling tokio v1.45.1
[INFO] [stderr]    Compiling num-traits v0.2.19
[INFO] [stderr]    Compiling nix v0.30.1
[INFO] [stderr]    Compiling form_urlencoded v1.2.1
[INFO] [stderr]    Compiling libsqlite3-sys v0.34.0
[INFO] [stderr]    Compiling sync_wrapper v1.0.2
[INFO] [stderr]    Compiling base64 v0.22.1
[INFO] [stderr]    Compiling tower-layer v0.3.3
[INFO] [stderr]    Compiling crossbeam-utils v0.8.21
[INFO] [stderr]    Compiling utf8_iter v1.0.4
[INFO] [stderr]    Compiling ipnet v2.11.0
[INFO] [stderr]    Compiling rand_core v0.9.3
[INFO] [stderr]    Compiling http-body-util v0.1.3
[INFO] [stderr]    Compiling iri-string v0.7.8
[INFO] [stderr]    Compiling zeroize v1.8.1
[INFO] [stderr]    Compiling ryu v1.0.20
[INFO] [stderr]    Compiling rustls-pki-types v1.12.0
[INFO] [stderr]    Compiling ppv-lite86 v0.2.21
[INFO] [stderr]    Compiling synstructure v0.13.2
[INFO] [stderr]    Compiling rand_chacha v0.9.0
[INFO] [stderr]    Compiling hashlink v0.10.0
[INFO] [stderr]    Compiling encoding_rs v0.8.35
[INFO] [stderr]    Compiling iana-time-zone v0.1.63
[INFO] [stderr]    Compiling mime v0.3.17
[INFO] [stderr]    Compiling fallible-iterator v0.3.0
[INFO] [stderr]    Compiling fallible-streaming-iterator v0.1.9
[INFO] [stderr]    Compiling chrono v0.4.41
[INFO] [stderr]    Compiling crossbeam-channel v0.5.15
[INFO] [stderr]    Compiling rusqlite v0.36.0
[INFO] [stderr]    Compiling ctrlc v3.4.7
[INFO] [stderr]    Compiling zerofrom-derive v0.1.6
[INFO] [stderr]    Compiling yoke-derive v0.8.0
[INFO] [stderr]    Compiling zerovec-derive v0.11.1
[INFO] [stderr]    Compiling displaydoc v0.2.5
[INFO] [stderr]    Compiling openssl-macros v0.1.1
[INFO] [stderr]    Compiling tokio-util v0.7.15
[INFO] [stderr]    Compiling tower v0.5.2
[INFO] [stderr]    Compiling serde_urlencoded v0.7.1
[INFO] [stderr]    Compiling rand v0.9.1
[INFO] [stderr]    Compiling uuid v1.17.0
[INFO] [stderr]    Compiling h2 v0.4.11
[INFO] [stderr]    Compiling zerofrom v0.1.6
[INFO] [stderr]    Compiling tower-http v0.6.6
[INFO] [stderr]    Compiling yoke v0.8.0
[INFO] [stderr]    Compiling zerovec v0.11.2
[INFO] [stderr]    Compiling zerotrie v0.2.2
[INFO] [stderr]    Compiling tinystr v0.8.1
[INFO] [stderr]    Compiling potential_utf v0.1.2
[INFO] [stderr]    Compiling icu_collections v2.0.0
[INFO] [stderr]    Compiling icu_locale_core v2.0.0
[INFO] [stderr]    Compiling icu_provider v2.0.0
[INFO] [stderr]    Compiling icu_normalizer v2.0.0
[INFO] [stderr]    Compiling icu_properties v2.0.1
[INFO] [stderr]    Compiling hyper v1.6.0
[INFO] [stderr]    Compiling tokio-native-tls v0.3.1
[INFO] [stderr]    Compiling idna_adapter v1.2.1
[INFO] [stderr]    Compiling idna v1.0.3
[INFO] [stderr]    Compiling url v2.5.4
[INFO] [stderr]    Compiling hyper-util v0.1.14
[INFO] [stderr]    Compiling hyper-tls v0.6.0
[INFO] [stderr]    Compiling reqwest v0.12.21
[INFO] [stderr]    Compiling space_trader v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unnecessary parentheses around type
[INFO] [stdout]    --> src/arg_handler.rs:333:66
[INFO] [stdout]     |
[INFO] [stdout] 333 |     pub fn process(&self) -> Result<HashMap<i32, Option<Value>>, (Vec<String>)> {
[INFO] [stdout]     |                                                                  ^           ^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 333 -     pub fn process(&self) -> Result<HashMap<i32, Option<Value>>, (Vec<String>)> {
[INFO] [stdout] 333 +     pub fn process(&self) -> Result<HashMap<i32, Option<Value>>, Vec<String>> {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unreachable pattern
[INFO] [stdout]   --> src/http_response.rs:48:13
[INFO] [stdout]    |
[INFO] [stdout] 44 |             HTTP_NO_CONTENT => "No Content",
[INFO] [stdout]    |             --------------- matches all the relevant values
[INFO] [stdout] ...
[INFO] [stdout] 48 |             HTTP_NOT_FOUND => "Not Found",
[INFO] [stdout]    |             ^^^^^^^^^^^^^^ no value can reach this
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unreachable_patterns)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `session`
[INFO] [stdout]    --> src/server.rs:157:22
[INFO] [stdout]     |
[INFO] [stdout] 157 | fn handle_admin_quit(session: &Session) -> HttpResponse {
[INFO] [stdout]     |                      ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_session`
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `session`
[INFO] [stdout]    --> src/server.rs:163:24
[INFO] [stdout]     |
[INFO] [stdout] 163 | fn handle_message_poll(session: &Session) -> HttpResponse {
[INFO] [stdout]     |                        ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_session`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `session`
[INFO] [stdout]    --> src/server.rs:171:24
[INFO] [stdout]     |
[INFO] [stdout] 171 | fn handle_no_operation(session: &Session) -> HttpResponse {
[INFO] [stdout]     |                        ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_session`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `arg_type` is never read
[INFO] [stdout]    --> src/arg_handler.rs:123:5
[INFO] [stdout]     |
[INFO] [stdout] 121 | pub struct ArgumentDescriptor {
[INFO] [stdout]     |            ------------------ field in this struct
[INFO] [stdout] 122 |     entity_id: i32,
[INFO] [stdout] 123 |     arg_type: ValueType,
[INFO] [stdout]     |     ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function `create_planet` is never used
[INFO] [stdout]   --> src/planet.rs:24:4
[INFO] [stdout]    |
[INFO] [stdout] 24 | fn create_planet(planet_name: String, location: SectorId, owner: PlayerId) -> Result<PlanetId, String> {
[INFO] [stdout]    |    ^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constant `SESSION_TIMEOUT_SECONDS` is never used
[INFO] [stdout]   --> src/session.rs:11:7
[INFO] [stdout]    |
[INFO] [stdout] 11 | const SESSION_TIMEOUT_SECONDS: u64 = 60; // TODO should be 5 minutes, maybe?
[INFO] [stdout]    |       ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function `update_user_timestamp` is never used
[INFO] [stdout]    --> src/user.rs:144:4
[INFO] [stdout]     |
[INFO] [stdout] 144 | fn update_user_timestamp(user_id: UserId) -> Result<(), String> {
[INFO] [stdout]     |    ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `rusqlite::fallible_iterator::FallibleIterator`
[INFO] [stdout]  --> src/bin/cli.rs:5:5
[INFO] [stdout]   |
[INFO] [stdout] 5 | use rusqlite::fallible_iterator::FallibleIterator;
[INFO] [stdout]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]    --> src/bin/cli.rs:194:68
[INFO] [stdout]     |
[INFO] [stdout] 194 |                 let addr_val = values.get(&ADDR_SWITCH_ID).unwrap().clone();
[INFO] [stdout]     |                                                                    ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: the type `Option<space_trader::arg_handler::Value>` does not implement `Clone`, so calling `clone` on `&Option<space_trader::arg_handler::Value>` copies the reference, which does not do anything and can be removed
[INFO] [stdout]     = note: `#[warn(noop_method_call)]` on by default
[INFO] [stdout] help: remove this redundant call
[INFO] [stdout]     |
[INFO] [stdout] 194 -                 let addr_val = values.get(&ADDR_SWITCH_ID).unwrap().clone();
[INFO] [stdout] 194 +                 let addr_val = values.get(&ADDR_SWITCH_ID).unwrap();
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]    --> src/bin/cli.rs:195:68
[INFO] [stdout]     |
[INFO] [stdout] 195 |                 let port_val = values.get(&PORT_SWITCH_ID).unwrap().clone();
[INFO] [stdout]     |                                                                    ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: the type `Option<space_trader::arg_handler::Value>` does not implement `Clone`, so calling `clone` on `&Option<space_trader::arg_handler::Value>` copies the reference, which does not do anything and can be removed
[INFO] [stdout] help: remove this redundant call
[INFO] [stdout]     |
[INFO] [stdout] 195 -                 let port_val = values.get(&PORT_SWITCH_ID).unwrap().clone();
[INFO] [stdout] 195 +                 let port_val = values.get(&PORT_SWITCH_ID).unwrap();
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]    --> src/bin/cli.rs:196:80
[INFO] [stdout]     |
[INFO] [stdout] 196 |                 let user_name_val = values.get(&USER_NAME_ARGUMENT_ID).unwrap().clone();
[INFO] [stdout]     |                                                                                ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: the type `Option<space_trader::arg_handler::Value>` does not implement `Clone`, so calling `clone` on `&Option<space_trader::arg_handler::Value>` copies the reference, which does not do anything and can be removed
[INFO] [stdout] help: remove this redundant call
[INFO] [stdout]     |
[INFO] [stdout] 196 -                 let user_name_val = values.get(&USER_NAME_ARGUMENT_ID).unwrap().clone();
[INFO] [stdout] 196 +                 let user_name_val = values.get(&USER_NAME_ARGUMENT_ID).unwrap();
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]    --> src/bin/cli.rs:197:78
[INFO] [stdout]     |
[INFO] [stdout] 197 |                 let password_val = values.get(&PASSWORD_ARGUMENT_ID).unwrap().clone();
[INFO] [stdout]     |                                                                              ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: the type `Option<space_trader::arg_handler::Value>` does not implement `Clone`, so calling `clone` on `&Option<space_trader::arg_handler::Value>` copies the reference, which does not do anything and can be removed
[INFO] [stdout] help: remove this redundant call
[INFO] [stdout]     |
[INFO] [stdout] 197 -                 let password_val = values.get(&PASSWORD_ARGUMENT_ID).unwrap().clone();
[INFO] [stdout] 197 +                 let password_val = values.get(&PASSWORD_ARGUMENT_ID).unwrap();
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `std::process::exit`
[INFO] [stdout]  --> src/bin/init.rs:1:5
[INFO] [stdout]   |
[INFO] [stdout] 1 | use std::process::exit;
[INFO] [stdout]   |     ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `db`
[INFO] [stdout]   --> src/bin/init.rs:13:12
[INFO] [stdout]    |
[INFO] [stdout] 13 |         Ok(db) => {}
[INFO] [stdout]    |            ^^ help: if this is intentional, prefix it with an underscore: `_db`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused imports: `galaxy`, `message`, `planet`, `port`, `sector`, and `user`
[INFO] [stdout]  --> src/bin/trader.rs:6:30
[INFO] [stdout]   |
[INFO] [stdout] 6 | use space_trader::{database, galaxy, message, planet, port, sector, server, user};
[INFO] [stdout]   |                              ^^^^^^  ^^^^^^^  ^^^^^^  ^^^^  ^^^^^^          ^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `db`
[INFO] [stdout]   --> src/bin/trader.rs:38:9
[INFO] [stdout]    |
[INFO] [stdout] 38 |     let db = database::open(&ctx.unwrap().database_file_name);
[INFO] [stdout]    |         ^^ help: if this is intentional, prefix it with an underscore: `_db`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: fields `do_secure` and `address` are never read
[INFO] [stdout]   --> src/bin/trader.rs:12:5
[INFO] [stdout]    |
[INFO] [stdout] 11 | struct Context {
[INFO] [stdout]    |        ------- fields in this struct
[INFO] [stdout] 12 |     do_secure: bool,
[INFO] [stdout]    |     ^^^^^^^^^
[INFO] [stdout] 13 |     address: String,
[INFO] [stdout]    |     ^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `compose_url` is never used
[INFO] [stdout]   --> src/bin/trader.rs:18:8
[INFO] [stdout]    |
[INFO] [stdout] 17 | impl Context {
[INFO] [stdout]    | ------------ method in this implementation
[INFO] [stdout] 18 |     fn compose_url(&self, path: &str) -> String {
[INFO] [stdout]    |        ^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function `ctrl_channel` is never used
[INFO] [stdout]   --> src/bin/trader.rs:42:4
[INFO] [stdout]    |
[INFO] [stdout] 42 | fn ctrl_channel() -> Result<Receiver<()>, ctrlc::Error> {
[INFO] [stdout]    |    ^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function `process` is never used
[INFO] [stdout]   --> src/bin/trader.rs:51:4
[INFO] [stdout]    |
[INFO] [stdout] 51 | fn process() {
[INFO] [stdout]    |    ^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]    --> src/bin/trader.rs:143:68
[INFO] [stdout]     |
[INFO] [stdout] 143 |                 let addr_val = values.get(&ADDR_SWITCH_ID).unwrap().clone();
[INFO] [stdout]     |                                                                    ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: the type `Option<Value>` does not implement `Clone`, so calling `clone` on `&Option<Value>` copies the reference, which does not do anything and can be removed
[INFO] [stdout]     = note: `#[warn(noop_method_call)]` on by default
[INFO] [stdout] help: remove this redundant call
[INFO] [stdout]     |
[INFO] [stdout] 143 -                 let addr_val = values.get(&ADDR_SWITCH_ID).unwrap().clone();
[INFO] [stdout] 143 +                 let addr_val = values.get(&ADDR_SWITCH_ID).unwrap();
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]    --> src/bin/trader.rs:144:68
[INFO] [stdout]     |
[INFO] [stdout] 144 |                 let port_val = values.get(&PORT_SWITCH_ID).unwrap().clone();
[INFO] [stdout]     |                                                                    ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: the type `Option<Value>` does not implement `Clone`, so calling `clone` on `&Option<Value>` copies the reference, which does not do anything and can be removed
[INFO] [stdout] help: remove this redundant call
[INFO] [stdout]     |
[INFO] [stdout] 144 -                 let port_val = values.get(&PORT_SWITCH_ID).unwrap().clone();
[INFO] [stdout] 144 +                 let port_val = values.get(&PORT_SWITCH_ID).unwrap();
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]    --> src/bin/trader.rs:145:82
[INFO] [stdout]     |
[INFO] [stdout] 145 |                 let dbfn_val = values.get(&DATABASE_FILE_NAME_SWITCH_ID).unwrap().clone();
[INFO] [stdout]     |                                                                                  ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: the type `Option<Value>` does not implement `Clone`, so calling `clone` on `&Option<Value>` copies the reference, which does not do anything and can be removed
[INFO] [stdout] help: remove this redundant call
[INFO] [stdout]     |
[INFO] [stdout] 145 -                 let dbfn_val = values.get(&DATABASE_FILE_NAME_SWITCH_ID).unwrap().clone();
[INFO] [stdout] 145 +                 let dbfn_val = values.get(&DATABASE_FILE_NAME_SWITCH_ID).unwrap();
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 34s
[INFO] running `Command { std: "docker" "inspect" "c91cd077adb7bb88b8b0a6c1988b9bf20b2d44cc89c941993140dfda273fe56e", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "c91cd077adb7bb88b8b0a6c1988b9bf20b2d44cc89c941993140dfda273fe56e", kill_on_drop: false }`
[INFO] [stdout] c91cd077adb7bb88b8b0a6c1988b9bf20b2d44cc89c941993140dfda273fe56e
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:e90291280db7d1fac5b66fc6dad9f9662629e7365a55743daf9bdf73ebc4ea79" "/opt/rustwide/cargo-home/bin/cargo" "+ad85bc524b1ad696e42061ad8338d382dffbdbe5" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] cdee8baf46d161ae5af167be8b225f00c37c61df613325b156bf366dbed3a8ba
[INFO] running `Command { std: "docker" "start" "-a" "cdee8baf46d161ae5af167be8b225f00c37c61df613325b156bf366dbed3a8ba", kill_on_drop: false }`
[INFO] [stderr]    Compiling space_trader v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unnecessary parentheses around type
[INFO] [stdout]    --> src/arg_handler.rs:333:66
[INFO] [stdout]     |
[INFO] [stdout] 333 |     pub fn process(&self) -> Result<HashMap<i32, Option<Value>>, (Vec<String>)> {
[INFO] [stdout]     |                                                                  ^           ^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 333 -     pub fn process(&self) -> Result<HashMap<i32, Option<Value>>, (Vec<String>)> {
[INFO] [stdout] 333 +     pub fn process(&self) -> Result<HashMap<i32, Option<Value>>, Vec<String>> {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unreachable pattern
[INFO] [stdout]   --> src/http_response.rs:48:13
[INFO] [stdout]    |
[INFO] [stdout] 44 |             HTTP_NO_CONTENT => "No Content",
[INFO] [stdout]    |             --------------- matches all the relevant values
[INFO] [stdout] ...
[INFO] [stdout] 48 |             HTTP_NOT_FOUND => "Not Found",
[INFO] [stdout]    |             ^^^^^^^^^^^^^^ no value can reach this
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unreachable_patterns)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `session`
[INFO] [stdout]    --> src/server.rs:157:22
[INFO] [stdout]     |
[INFO] [stdout] 157 | fn handle_admin_quit(session: &Session) -> HttpResponse {
[INFO] [stdout]     |                      ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_session`
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `session`
[INFO] [stdout]    --> src/server.rs:163:24
[INFO] [stdout]     |
[INFO] [stdout] 163 | fn handle_message_poll(session: &Session) -> HttpResponse {
[INFO] [stdout]     |                        ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_session`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `session`
[INFO] [stdout]    --> src/server.rs:171:24
[INFO] [stdout]     |
[INFO] [stdout] 171 | fn handle_no_operation(session: &Session) -> HttpResponse {
[INFO] [stdout]     |                        ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_session`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `arg_type` is never read
[INFO] [stdout]    --> src/arg_handler.rs:123:5
[INFO] [stdout]     |
[INFO] [stdout] 121 | pub struct ArgumentDescriptor {
[INFO] [stdout]     |            ------------------ field in this struct
[INFO] [stdout] 122 |     entity_id: i32,
[INFO] [stdout] 123 |     arg_type: ValueType,
[INFO] [stdout]     |     ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function `create_planet` is never used
[INFO] [stdout]   --> src/planet.rs:24:4
[INFO] [stdout]    |
[INFO] [stdout] 24 | fn create_planet(planet_name: String, location: SectorId, owner: PlayerId) -> Result<PlanetId, String> {
[INFO] [stdout]    |    ^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constant `SESSION_TIMEOUT_SECONDS` is never used
[INFO] [stdout]   --> src/session.rs:11:7
[INFO] [stdout]    |
[INFO] [stdout] 11 | const SESSION_TIMEOUT_SECONDS: u64 = 60; // TODO should be 5 minutes, maybe?
[INFO] [stdout]    |       ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function `update_user_timestamp` is never used
[INFO] [stdout]    --> src/user.rs:144:4
[INFO] [stdout]     |
[INFO] [stdout] 144 | fn update_user_timestamp(user_id: UserId) -> Result<(), String> {
[INFO] [stdout]     |    ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `std::process::exit`
[INFO] [stdout]  --> src/bin/init.rs:1:5
[INFO] [stdout]   |
[INFO] [stdout] 1 | use std::process::exit;
[INFO] [stdout]   |     ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `db`
[INFO] [stdout]   --> src/bin/init.rs:13:12
[INFO] [stdout]    |
[INFO] [stdout] 13 |         Ok(db) => {}
[INFO] [stdout]    |            ^^ help: if this is intentional, prefix it with an underscore: `_db`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around type
[INFO] [stdout]    --> src/arg_handler.rs:333:66
[INFO] [stdout]     |
[INFO] [stdout] 333 |     pub fn process(&self) -> Result<HashMap<i32, Option<Value>>, (Vec<String>)> {
[INFO] [stdout]     |                                                                  ^           ^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 333 -     pub fn process(&self) -> Result<HashMap<i32, Option<Value>>, (Vec<String>)> {
[INFO] [stdout] 333 +     pub fn process(&self) -> Result<HashMap<i32, Option<Value>>, Vec<String>> {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused imports: `galaxy`, `message`, `planet`, `port`, `sector`, and `user`
[INFO] [stdout]  --> src/bin/trader.rs:6:30
[INFO] [stdout]   |
[INFO] [stdout] 6 | use space_trader::{database, galaxy, message, planet, port, sector, server, user};
[INFO] [stdout]   |                              ^^^^^^  ^^^^^^^  ^^^^^^  ^^^^  ^^^^^^          ^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `rusqlite::fallible_iterator::FallibleIterator`
[INFO] [stdout]  --> src/bin/cli.rs:5:5
[INFO] [stdout]   |
[INFO] [stdout] 5 | use rusqlite::fallible_iterator::FallibleIterator;
[INFO] [stdout]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `db`
[INFO] [stdout]   --> src/bin/trader.rs:38:9
[INFO] [stdout]    |
[INFO] [stdout] 38 |     let db = database::open(&ctx.unwrap().database_file_name);
[INFO] [stdout]    |         ^^ help: if this is intentional, prefix it with an underscore: `_db`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]    --> src/bin/cli.rs:194:68
[INFO] [stdout]     |
[INFO] [stdout] 194 |                 let addr_val = values.get(&ADDR_SWITCH_ID).unwrap().clone();
[INFO] [stdout]     |                                                                    ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: the type `Option<space_trader::arg_handler::Value>` does not implement `Clone`, so calling `clone` on `&Option<space_trader::arg_handler::Value>` copies the reference, which does not do anything and can be removed
[INFO] [stdout]     = note: `#[warn(noop_method_call)]` on by default
[INFO] [stdout] help: remove this redundant call
[INFO] [stdout]     |
[INFO] [stdout] 194 -                 let addr_val = values.get(&ADDR_SWITCH_ID).unwrap().clone();
[INFO] [stdout] 194 +                 let addr_val = values.get(&ADDR_SWITCH_ID).unwrap();
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]    --> src/bin/cli.rs:195:68
[INFO] [stdout]     |
[INFO] [stdout] 195 |                 let port_val = values.get(&PORT_SWITCH_ID).unwrap().clone();
[INFO] [stdout]     |                                                                    ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: the type `Option<space_trader::arg_handler::Value>` does not implement `Clone`, so calling `clone` on `&Option<space_trader::arg_handler::Value>` copies the reference, which does not do anything and can be removed
[INFO] [stdout] help: remove this redundant call
[INFO] [stdout]     |
[INFO] [stdout] 195 -                 let port_val = values.get(&PORT_SWITCH_ID).unwrap().clone();
[INFO] [stdout] 195 +                 let port_val = values.get(&PORT_SWITCH_ID).unwrap();
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]    --> src/bin/cli.rs:196:80
[INFO] [stdout]     |
[INFO] [stdout] 196 |                 let user_name_val = values.get(&USER_NAME_ARGUMENT_ID).unwrap().clone();
[INFO] [stdout]     |                                                                                ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: the type `Option<space_trader::arg_handler::Value>` does not implement `Clone`, so calling `clone` on `&Option<space_trader::arg_handler::Value>` copies the reference, which does not do anything and can be removed
[INFO] [stdout] help: remove this redundant call
[INFO] [stdout]     |
[INFO] [stdout] 196 -                 let user_name_val = values.get(&USER_NAME_ARGUMENT_ID).unwrap().clone();
[INFO] [stdout] 196 +                 let user_name_val = values.get(&USER_NAME_ARGUMENT_ID).unwrap();
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]    --> src/bin/cli.rs:197:78
[INFO] [stdout]     |
[INFO] [stdout] 197 |                 let password_val = values.get(&PASSWORD_ARGUMENT_ID).unwrap().clone();
[INFO] [stdout]     |                                                                              ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: the type `Option<space_trader::arg_handler::Value>` does not implement `Clone`, so calling `clone` on `&Option<space_trader::arg_handler::Value>` copies the reference, which does not do anything and can be removed
[INFO] [stdout] help: remove this redundant call
[INFO] [stdout]     |
[INFO] [stdout] 197 -                 let password_val = values.get(&PASSWORD_ARGUMENT_ID).unwrap().clone();
[INFO] [stdout] 197 +                 let password_val = values.get(&PASSWORD_ARGUMENT_ID).unwrap();
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: fields `do_secure` and `address` are never read
[INFO] [stdout]   --> src/bin/trader.rs:12:5
[INFO] [stdout]    |
[INFO] [stdout] 11 | struct Context {
[INFO] [stdout]    |        ------- fields in this struct
[INFO] [stdout] 12 |     do_secure: bool,
[INFO] [stdout]    |     ^^^^^^^^^
[INFO] [stdout] 13 |     address: String,
[INFO] [stdout]    |     ^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `compose_url` is never used
[INFO] [stdout]   --> src/bin/trader.rs:18:8
[INFO] [stdout]    |
[INFO] [stdout] 17 | impl Context {
[INFO] [stdout]    | ------------ method in this implementation
[INFO] [stdout] 18 |     fn compose_url(&self, path: &str) -> String {
[INFO] [stdout]    |        ^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function `ctrl_channel` is never used
[INFO] [stdout]   --> src/bin/trader.rs:42:4
[INFO] [stdout]    |
[INFO] [stdout] 42 | fn ctrl_channel() -> Result<Receiver<()>, ctrlc::Error> {
[INFO] [stdout]    |    ^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function `process` is never used
[INFO] [stdout]   --> src/bin/trader.rs:51:4
[INFO] [stdout]    |
[INFO] [stdout] 51 | fn process() {
[INFO] [stdout]    |    ^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]    --> src/bin/trader.rs:143:68
[INFO] [stdout]     |
[INFO] [stdout] 143 |                 let addr_val = values.get(&ADDR_SWITCH_ID).unwrap().clone();
[INFO] [stdout]     |                                                                    ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: the type `Option<Value>` does not implement `Clone`, so calling `clone` on `&Option<Value>` copies the reference, which does not do anything and can be removed
[INFO] [stdout]     = note: `#[warn(noop_method_call)]` on by default
[INFO] [stdout] help: remove this redundant call
[INFO] [stdout]     |
[INFO] [stdout] 143 -                 let addr_val = values.get(&ADDR_SWITCH_ID).unwrap().clone();
[INFO] [stdout] 143 +                 let addr_val = values.get(&ADDR_SWITCH_ID).unwrap();
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]    --> src/bin/trader.rs:144:68
[INFO] [stdout]     |
[INFO] [stdout] 144 |                 let port_val = values.get(&PORT_SWITCH_ID).unwrap().clone();
[INFO] [stdout]     |                                                                    ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: the type `Option<Value>` does not implement `Clone`, so calling `clone` on `&Option<Value>` copies the reference, which does not do anything and can be removed
[INFO] [stdout] help: remove this redundant call
[INFO] [stdout]     |
[INFO] [stdout] 144 -                 let port_val = values.get(&PORT_SWITCH_ID).unwrap().clone();
[INFO] [stdout] 144 +                 let port_val = values.get(&PORT_SWITCH_ID).unwrap();
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]    --> src/bin/trader.rs:145:82
[INFO] [stdout]     |
[INFO] [stdout] 145 |                 let dbfn_val = values.get(&DATABASE_FILE_NAME_SWITCH_ID).unwrap().clone();
[INFO] [stdout]     |                                                                                  ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: the type `Option<Value>` does not implement `Clone`, so calling `clone` on `&Option<Value>` copies the reference, which does not do anything and can be removed
[INFO] [stdout] help: remove this redundant call
[INFO] [stdout]     |
[INFO] [stdout] 145 -                 let dbfn_val = values.get(&DATABASE_FILE_NAME_SWITCH_ID).unwrap().clone();
[INFO] [stdout] 145 +                 let dbfn_val = values.get(&DATABASE_FILE_NAME_SWITCH_ID).unwrap();
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unreachable pattern
[INFO] [stdout]   --> src/http_response.rs:48:13
[INFO] [stdout]    |
[INFO] [stdout] 44 |             HTTP_NO_CONTENT => "No Content",
[INFO] [stdout]    |             --------------- matches all the relevant values
[INFO] [stdout] ...
[INFO] [stdout] 48 |             HTTP_NOT_FOUND => "Not Found",
[INFO] [stdout]    |             ^^^^^^^^^^^^^^ no value can reach this
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unreachable_patterns)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `session`
[INFO] [stdout]    --> src/server.rs:157:22
[INFO] [stdout]     |
[INFO] [stdout] 157 | fn handle_admin_quit(session: &Session) -> HttpResponse {
[INFO] [stdout]     |                      ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_session`
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `session`
[INFO] [stdout]    --> src/server.rs:163:24
[INFO] [stdout]     |
[INFO] [stdout] 163 | fn handle_message_poll(session: &Session) -> HttpResponse {
[INFO] [stdout]     |                        ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_session`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `session`
[INFO] [stdout]    --> src/server.rs:171:24
[INFO] [stdout]     |
[INFO] [stdout] 171 | fn handle_no_operation(session: &Session) -> HttpResponse {
[INFO] [stdout]     |                        ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_session`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `arg_type` is never read
[INFO] [stdout]    --> src/arg_handler.rs:123:5
[INFO] [stdout]     |
[INFO] [stdout] 121 | pub struct ArgumentDescriptor {
[INFO] [stdout]     |            ------------------ field in this struct
[INFO] [stdout] 122 |     entity_id: i32,
[INFO] [stdout] 123 |     arg_type: ValueType,
[INFO] [stdout]     |     ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function `create_planet` is never used
[INFO] [stdout]   --> src/planet.rs:24:4
[INFO] [stdout]    |
[INFO] [stdout] 24 | fn create_planet(planet_name: String, location: SectorId, owner: PlayerId) -> Result<PlanetId, String> {
[INFO] [stdout]    |    ^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constant `SESSION_TIMEOUT_SECONDS` is never used
[INFO] [stdout]   --> src/session.rs:11:7
[INFO] [stdout]    |
[INFO] [stdout] 11 | const SESSION_TIMEOUT_SECONDS: u64 = 60; // TODO should be 5 minutes, maybe?
[INFO] [stdout]    |       ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function `update_user_timestamp` is never used
[INFO] [stdout]    --> src/user.rs:144:4
[INFO] [stdout]     |
[INFO] [stdout] 144 | fn update_user_timestamp(user_id: UserId) -> Result<(), String> {
[INFO] [stdout]     |    ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `test` profile [unoptimized + debuginfo] target(s) in 1.75s
[INFO] running `Command { std: "docker" "inspect" "cdee8baf46d161ae5af167be8b225f00c37c61df613325b156bf366dbed3a8ba", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "cdee8baf46d161ae5af167be8b225f00c37c61df613325b156bf366dbed3a8ba", kill_on_drop: false }`
[INFO] [stdout] cdee8baf46d161ae5af167be8b225f00c37c61df613325b156bf366dbed3a8ba
