[INFO] cloning repository https://github.com/LuizMqs/quake-game-log [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/LuizMqs/quake-game-log" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLuizMqs%2Fquake-game-log", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLuizMqs%2Fquake-game-log'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4928caab1760c77d2395bc5c526c034051d23619 [INFO] checking LuizMqs/quake-game-log against try#e90f1ff63e694965281f833819a486da29772bdf for pr-146167 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLuizMqs%2Fquake-game-log" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/LuizMqs/quake-game-log [INFO] finished tweaking git repo https://github.com/LuizMqs/quake-game-log [INFO] tweaked toml for git repo https://github.com/LuizMqs/quake-game-log written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/LuizMqs/quake-game-log on toolchain e90f1ff63e694965281f833819a486da29772bdf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+e90f1ff63e694965281f833819a486da29772bdf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/LuizMqs/quake-game-log already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+e90f1ff63e694965281f833819a486da29772bdf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+e90f1ff63e694965281f833819a486da29772bdf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6d613b5dc6a9766f2c8090763ffe502bfb2325a5874f2f0b2ec7401a6e70eb12 [INFO] running `Command { std: "docker" "start" "-a" "6d613b5dc6a9766f2c8090763ffe502bfb2325a5874f2f0b2ec7401a6e70eb12", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6d613b5dc6a9766f2c8090763ffe502bfb2325a5874f2f0b2ec7401a6e70eb12", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6d613b5dc6a9766f2c8090763ffe502bfb2325a5874f2f0b2ec7401a6e70eb12", kill_on_drop: false }` [INFO] [stdout] 6d613b5dc6a9766f2c8090763ffe502bfb2325a5874f2f0b2ec7401a6e70eb12 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+e90f1ff63e694965281f833819a486da29772bdf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 566c1b81109efba9486263b98211334b847458b205bba5d5612df8e66dedf47b [INFO] running `Command { std: "docker" "start" "-a" "566c1b81109efba9486263b98211334b847458b205bba5d5612df8e66dedf47b", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Compiling eyre v0.6.8 [INFO] [stderr] Checking regex-syntax v0.7.5 [INFO] [stderr] Compiling thiserror v1.0.49 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Checking aho-corasick v1.1.1 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling syn v2.0.38 [INFO] [stderr] Checking regex-automata v0.3.9 [INFO] [stderr] Compiling thiserror-impl v1.0.49 [INFO] [stderr] Checking regex v1.9.6 [INFO] [stderr] Checking quake_game_log v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: for loop over a `&Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/tournament/tournament_manager.rs:26:21 [INFO] [stdout] | [INFO] [stdout] 26 | for game in &self [INFO] [stdout] | _____________________^ [INFO] [stdout] 27 | | .games [INFO] [stdout] 28 | | .last() [INFO] [stdout] 29 | | .ok_or(TournamentError::TournamentNotStarted) [INFO] [stdout] | |_________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 26 - for game in &self [INFO] [stdout] 26 + while let Ok(game) = &self [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 26 - for game in &self [INFO] [stdout] 26 + if let Ok(game) = &self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/tournament/tournament_manager.rs:26:21 [INFO] [stdout] | [INFO] [stdout] 26 | for game in &self [INFO] [stdout] | _____________________^ [INFO] [stdout] 27 | | .games [INFO] [stdout] 28 | | .last() [INFO] [stdout] 29 | | .ok_or(TournamentError::TournamentNotStarted) [INFO] [stdout] | |_________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 26 - for game in &self [INFO] [stdout] 26 + while let Ok(game) = &self [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 26 - for game in &self [INFO] [stdout] 26 + if let Ok(game) = &self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.72s [INFO] running `Command { std: "docker" "inspect" "566c1b81109efba9486263b98211334b847458b205bba5d5612df8e66dedf47b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "566c1b81109efba9486263b98211334b847458b205bba5d5612df8e66dedf47b", kill_on_drop: false }` [INFO] [stdout] 566c1b81109efba9486263b98211334b847458b205bba5d5612df8e66dedf47b