[INFO] cloning repository https://github.com/io3dev/space-invaders-emulator
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/io3dev/space-invaders-emulator" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fio3dev%2Fspace-invaders-emulator", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fio3dev%2Fspace-invaders-emulator'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 0efa547e46ad6da3d427f698bd4e9dccc90080cf
[INFO] testing io3dev/space-invaders-emulator against try#2440211fe03bc45c89b6dc1a3df18382ce91e32b for pr-146098-1
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fio3dev%2Fspace-invaders-emulator" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/io3dev/space-invaders-emulator
[INFO] finished tweaking git repo https://github.com/io3dev/space-invaders-emulator
[INFO] tweaked toml for git repo https://github.com/io3dev/space-invaders-emulator written to /workspace/builds/worker-7-tc2/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/io3dev/space-invaders-emulator on toolchain 2440211fe03bc45c89b6dc1a3df18382ce91e32b
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+2440211fe03bc45c89b6dc1a3df18382ce91e32b" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/io3dev/space-invaders-emulator already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+2440211fe03bc45c89b6dc1a3df18382ce91e32b" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:e90291280db7d1fac5b66fc6dad9f9662629e7365a55743daf9bdf73ebc4ea79" "/opt/rustwide/cargo-home/bin/cargo" "+2440211fe03bc45c89b6dc1a3df18382ce91e32b" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 37c25e12900f5c5ecbc5b29b9d83ee4133db47687933050715a03c64547d61d9
[INFO] running `Command { std: "docker" "start" "-a" "37c25e12900f5c5ecbc5b29b9d83ee4133db47687933050715a03c64547d61d9", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "37c25e12900f5c5ecbc5b29b9d83ee4133db47687933050715a03c64547d61d9", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "37c25e12900f5c5ecbc5b29b9d83ee4133db47687933050715a03c64547d61d9", kill_on_drop: false }`
[INFO] [stdout] 37c25e12900f5c5ecbc5b29b9d83ee4133db47687933050715a03c64547d61d9
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:e90291280db7d1fac5b66fc6dad9f9662629e7365a55743daf9bdf73ebc4ea79" "/opt/rustwide/cargo-home/bin/cargo" "+2440211fe03bc45c89b6dc1a3df18382ce91e32b" "build" "--frozen" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] e7eb8ab5c66de31bfb2a73bb0ea49bbcb185fa3cbfebdff895995d9c2f250c31
[INFO] running `Command { std: "docker" "start" "-a" "e7eb8ab5c66de31bfb2a73bb0ea49bbcb185fa3cbfebdff895995d9c2f250c31", kill_on_drop: false }`
[INFO] [stderr]    Compiling space_invaders v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unnecessary parentheses around assigned value
[INFO] [stdout]    --> src/cpu/mod.rs:481:35
[INFO] [stdout]     |
[INFO] [stdout] 481 |                 self.flags.zero = (0x01 == (psw & 0x01));
[INFO] [stdout]     |                                   ^                    ^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 481 -                 self.flags.zero = (0x01 == (psw & 0x01));
[INFO] [stdout] 481 +                 self.flags.zero = 0x01 == (psw & 0x01) ;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around assigned value
[INFO] [stdout]    --> src/cpu/mod.rs:482:35
[INFO] [stdout]     |
[INFO] [stdout] 482 |                 self.flags.sign = (0x02 == (psw & 0x02));
[INFO] [stdout]     |                                   ^                    ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 482 -                 self.flags.sign = (0x02 == (psw & 0x02));
[INFO] [stdout] 482 +                 self.flags.sign = 0x02 == (psw & 0x02) ;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around assigned value
[INFO] [stdout]    --> src/cpu/mod.rs:483:37
[INFO] [stdout]     |
[INFO] [stdout] 483 |                 self.flags.parity = (0x04 == (psw & 0x04));
[INFO] [stdout]     |                                     ^                    ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 483 -                 self.flags.parity = (0x04 == (psw & 0x04));
[INFO] [stdout] 483 +                 self.flags.parity = 0x04 == (psw & 0x04) ;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around assigned value
[INFO] [stdout]    --> src/cpu/mod.rs:484:37
[INFO] [stdout]     |
[INFO] [stdout] 484 |                 self.flags.carry =  (0x05 == (psw & 0x08));
[INFO] [stdout]     |                                     ^                    ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 484 -                 self.flags.carry =  (0x05 == (psw & 0x08));
[INFO] [stdout] 484 +                 self.flags.carry =  0x05 == (psw & 0x08) ;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around assigned value
[INFO] [stdout]    --> src/cpu/mod.rs:485:40
[INFO] [stdout]     |
[INFO] [stdout] 485 |                 self.flags.aux_carry = (0x10 == (psw & 0x10));
[INFO] [stdout]     |                                        ^                    ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 485 -                 self.flags.aux_carry = (0x10 == (psw & 0x10));
[INFO] [stdout] 485 +                 self.flags.aux_carry = 0x10 == (psw & 0x10) ;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around assigned value
[INFO] [stdout]    --> src/cpu/mod.rs:525:36
[INFO] [stdout]     |
[INFO] [stdout] 525 |                 self.flags.carry = (1 == (x&1));
[INFO] [stdout]     |                                    ^          ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 525 -                 self.flags.carry = (1 == (x&1));
[INFO] [stdout] 525 +                 self.flags.carry = 1 == (x&1) ;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> src/cpu/mod.rs:589:12
[INFO] [stdout]     |
[INFO] [stdout] 589 |         if (condition == true) {
[INFO] [stdout]     |            ^                 ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 589 -         if (condition == true) {
[INFO] [stdout] 589 +         if condition == true  {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> src/cpu/mod.rs:602:12
[INFO] [stdout]     |
[INFO] [stdout] 602 |         if (condition == true) {
[INFO] [stdout]     |            ^                 ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 602 -         if (condition == true) {
[INFO] [stdout] 602 +         if condition == true  {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around assigned value
[INFO] [stdout]    --> src/cpu/mod.rs:830:28
[INFO] [stdout]     |
[INFO] [stdout] 830 |         self.flags.carry = (r1 > 0xff);
[INFO] [stdout]     |                            ^         ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 830 -         self.flags.carry = (r1 > 0xff);
[INFO] [stdout] 830 +         self.flags.carry = r1 > 0xff ;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around assigned value
[INFO] [stdout]    --> src/cpu/mod.rs:844:28
[INFO] [stdout]     |
[INFO] [stdout] 844 |         self.flags.carry = (r1 > 0xff);
[INFO] [stdout]     |                            ^         ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 844 -         self.flags.carry = (r1 > 0xff);
[INFO] [stdout] 844 +         self.flags.carry = r1 > 0xff ;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around assigned value
[INFO] [stdout]    --> src/cpu/mod.rs:856:28
[INFO] [stdout]     |
[INFO] [stdout] 856 |         self.flags.carry = (r1 > 0xff);
[INFO] [stdout]     |                            ^         ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 856 -         self.flags.carry = (r1 > 0xff);
[INFO] [stdout] 856 +         self.flags.carry = r1 > 0xff ;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around assigned value
[INFO] [stdout]    --> src/cpu/mod.rs:885:28
[INFO] [stdout]     |
[INFO] [stdout] 885 |         self.flags.carry = (self.regs.a < val as u8);
[INFO] [stdout]     |                            ^                       ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 885 -         self.flags.carry = (self.regs.a < val as u8);
[INFO] [stdout] 885 +         self.flags.carry = self.regs.a < val as u8 ;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `args`
[INFO] [stdout]   --> src/platform/mod.rs:20:21
[INFO] [stdout]    |
[INFO] [stdout] 20 |                 let args: Vec<String> = env::args().collect();
[INFO] [stdout]    |                     ^^^^ help: if this is intentional, prefix it with an underscore: `_args`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `res`
[INFO] [stdout]   --> src/cpu/flags.rs:46:31
[INFO] [stdout]    |
[INFO] [stdout] 46 |     pub fn calc_sub_cy(&self, res: u16) -> bool {
[INFO] [stdout]    |                               ^^^
[INFO] [stdout]    |
[INFO] [stdout] help: if this is intentional, prefix it with an underscore
[INFO] [stdout]    |
[INFO] [stdout] 46 |     pub fn calc_sub_cy(&self, _res: u16) -> bool {
[INFO] [stdout]    |                               +
[INFO] [stdout] help: you might have meant to pattern match on the similarly named constant `BDOS`
[INFO] [stdout]    |
[INFO] [stdout] 46 -     pub fn calc_sub_cy(&self, res: u16) -> bool {
[INFO] [stdout] 46 +     pub fn calc_sub_cy(&self, cpu::Cpu::cpm_call::BDOS: u16) -> bool {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable `num_of_on_bits` is assigned to, but never used
[INFO] [stdout]   --> src/cpu/flags.rs:54:17
[INFO] [stdout]    |
[INFO] [stdout] 54 |         let mut num_of_on_bits: u8 = 0;
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: consider using `_num_of_on_bits` instead
[INFO] [stdout] help: you might have meant to pattern match on the similarly named constant `WRITESTR`
[INFO] [stdout]    |
[INFO] [stdout] 54 -         let mut num_of_on_bits: u8 = 0;
[INFO] [stdout] 54 +         let mut cpu::Cpu::cpm_call::WRITESTR: u8 = 0;
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `de32`
[INFO] [stdout]    --> src/cpu/mod.rs:310:21
[INFO] [stdout]     |
[INFO] [stdout] 310 |                 let de32: u32 = self.cmb_be(self.regs.b, self.regs.c).into();
[INFO] [stdout]     |                     ^^^^ help: if this is intentional, prefix it with an underscore: `_de32`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `get_frame` is never used
[INFO] [stdout]   --> src/platform/mod.rs:44:12
[INFO] [stdout]    |
[INFO] [stdout] 10 | impl InvadersCabinet {
[INFO] [stdout]    | -------------------- method in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 44 |     pub fn get_frame(&self) -> Vec<u8> {
[INFO] [stdout]    |            ^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `read_1` is never read
[INFO] [stdout]  --> src/platform/io.rs:7:5
[INFO] [stdout]   |
[INFO] [stdout] 2 | pub struct IO {
[INFO] [stdout]   |            -- field in this struct
[INFO] [stdout] ...
[INFO] [stdout] 7 |     read_1: u8,
[INFO] [stdout]   |     ^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: methods `cpu_read`, `set_port_1`, and `insert_coin` are never used
[INFO] [stdout]   --> src/platform/io.rs:20:12
[INFO] [stdout]    |
[INFO] [stdout] 10 | impl IO {
[INFO] [stdout]    | ------- methods in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 20 |     pub fn cpu_read(&self, port: u8) -> u8 {
[INFO] [stdout]    |            ^^^^^^^^
[INFO] [stdout] ...
[INFO] [stdout] 27 |     pub fn set_port_1(&mut self, bit: u8) {
[INFO] [stdout]    |            ^^^^^^^^^^
[INFO] [stdout] ...
[INFO] [stdout] 31 |     pub fn insert_coin(&mut self) {
[INFO] [stdout]    |            ^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `output` is never read
[INFO] [stdout]   --> src/cpu/mod.rs:77:9
[INFO] [stdout]    |
[INFO] [stdout] 60 | pub struct Cpu {
[INFO] [stdout]    |            --- field in this struct
[INFO] [stdout] ...
[INFO] [stdout] 77 |     pub output: String,
[INFO] [stdout]    |         ^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: methods `debug`, `cpm_call`, `get_add`, `get_sub`, and `get_regs` are never used
[INFO] [stdout]    --> src/cpu/mod.rs:565:12
[INFO] [stdout]     |
[INFO] [stdout]  80 | impl Cpu {
[INFO] [stdout]     | -------- methods in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 565 |     pub fn debug(&self) {
[INFO] [stdout]     |            ^^^^^
[INFO] [stdout] ...
[INFO] [stdout] 671 |     fn cpm_call(&mut self, advance: *mut u16) {
[INFO] [stdout]     |        ^^^^^^^^
[INFO] [stdout] ...
[INFO] [stdout] 814 |     fn get_add(&mut self, val: u16) -> u8 {
[INFO] [stdout]     |        ^^^^^^^
[INFO] [stdout] ...
[INFO] [stdout] 839 |     fn get_sub(&mut self, val: u8) -> u8 {
[INFO] [stdout]     |        ^^^^^^^
[INFO] [stdout] ...
[INFO] [stdout] 892 |     pub fn get_regs(&self) -> ([&str; 9], [u8; 7], [u16; 2]) {
[INFO] [stdout]     |            ^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: methods `calc_sub_cy` and `set_all_flags` are never used
[INFO] [stdout]   --> src/cpu/flags.rs:46:12
[INFO] [stdout]    |
[INFO] [stdout] 28 | impl Flags {
[INFO] [stdout]    | ---------- methods in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 46 |     pub fn calc_sub_cy(&self, res: u16) -> bool {
[INFO] [stdout]    |            ^^^^^^^^^^^
[INFO] [stdout] ...
[INFO] [stdout] 82 |     pub fn set_all_flags(&mut self, res: u8) {
[INFO] [stdout]    |            ^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused `Result` that must be used
[INFO] [stdout]    --> src/cpu/mod.rs:119:9
[INFO] [stdout]     |
[INFO] [stdout] 119 |         c.load_into_memory(program, pc as usize);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stdout]     = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] help: use `let _ = ...` to ignore the resulting value
[INFO] [stdout]     |
[INFO] [stdout] 119 |         let _ = c.load_into_memory(program, pc as usize);
[INFO] [stdout]     |         +++++++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constant `parity_table` should have an upper case name
[INFO] [stdout]  --> src/cpu/flags.rs:1:7
[INFO] [stdout]   |
[INFO] [stdout] 1 | const parity_table: [u8; 256] = [
[INFO] [stdout]   |       ^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(non_upper_case_globals)]` (part of `#[warn(nonstandard_style)]`) on by default
[INFO] [stdout] help: convert the identifier to upper case
[INFO] [stdout]   |
[INFO] [stdout] 1 - const parity_table: [u8; 256] = [
[INFO] [stdout] 1 + const PARITY_TABLE: [u8; 256] = [
[INFO] [stdout]   |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.21s
[INFO] running `Command { std: "docker" "inspect" "e7eb8ab5c66de31bfb2a73bb0ea49bbcb185fa3cbfebdff895995d9c2f250c31", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "e7eb8ab5c66de31bfb2a73bb0ea49bbcb185fa3cbfebdff895995d9c2f250c31", kill_on_drop: false }`
[INFO] [stdout] e7eb8ab5c66de31bfb2a73bb0ea49bbcb185fa3cbfebdff895995d9c2f250c31
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:e90291280db7d1fac5b66fc6dad9f9662629e7365a55743daf9bdf73ebc4ea79" "/opt/rustwide/cargo-home/bin/cargo" "+2440211fe03bc45c89b6dc1a3df18382ce91e32b" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 86cc3b9d7d05fb52b123ca6281347be1f73999d3ffe99fa88cdb359d57a081b6
[INFO] running `Command { std: "docker" "start" "-a" "86cc3b9d7d05fb52b123ca6281347be1f73999d3ffe99fa88cdb359d57a081b6", kill_on_drop: false }`
[INFO] [stderr]    Compiling space_invaders v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unnecessary parentheses around assigned value
[INFO] [stdout]    --> src/cpu/mod.rs:481:35
[INFO] [stdout]     |
[INFO] [stdout] 481 |                 self.flags.zero = (0x01 == (psw & 0x01));
[INFO] [stdout]     |                                   ^                    ^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 481 -                 self.flags.zero = (0x01 == (psw & 0x01));
[INFO] [stdout] 481 +                 self.flags.zero = 0x01 == (psw & 0x01) ;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around assigned value
[INFO] [stdout]    --> src/cpu/mod.rs:482:35
[INFO] [stdout]     |
[INFO] [stdout] 482 |                 self.flags.sign = (0x02 == (psw & 0x02));
[INFO] [stdout]     |                                   ^                    ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 482 -                 self.flags.sign = (0x02 == (psw & 0x02));
[INFO] [stdout] 482 +                 self.flags.sign = 0x02 == (psw & 0x02) ;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around assigned value
[INFO] [stdout]    --> src/cpu/mod.rs:483:37
[INFO] [stdout]     |
[INFO] [stdout] 483 |                 self.flags.parity = (0x04 == (psw & 0x04));
[INFO] [stdout]     |                                     ^                    ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 483 -                 self.flags.parity = (0x04 == (psw & 0x04));
[INFO] [stdout] 483 +                 self.flags.parity = 0x04 == (psw & 0x04) ;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around assigned value
[INFO] [stdout]    --> src/cpu/mod.rs:484:37
[INFO] [stdout]     |
[INFO] [stdout] 484 |                 self.flags.carry =  (0x05 == (psw & 0x08));
[INFO] [stdout]     |                                     ^                    ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 484 -                 self.flags.carry =  (0x05 == (psw & 0x08));
[INFO] [stdout] 484 +                 self.flags.carry =  0x05 == (psw & 0x08) ;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around assigned value
[INFO] [stdout]    --> src/cpu/mod.rs:485:40
[INFO] [stdout]     |
[INFO] [stdout] 485 |                 self.flags.aux_carry = (0x10 == (psw & 0x10));
[INFO] [stdout]     |                                        ^                    ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 485 -                 self.flags.aux_carry = (0x10 == (psw & 0x10));
[INFO] [stdout] 485 +                 self.flags.aux_carry = 0x10 == (psw & 0x10) ;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around assigned value
[INFO] [stdout]    --> src/cpu/mod.rs:525:36
[INFO] [stdout]     |
[INFO] [stdout] 525 |                 self.flags.carry = (1 == (x&1));
[INFO] [stdout]     |                                    ^          ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 525 -                 self.flags.carry = (1 == (x&1));
[INFO] [stdout] 525 +                 self.flags.carry = 1 == (x&1) ;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> src/cpu/mod.rs:589:12
[INFO] [stdout]     |
[INFO] [stdout] 589 |         if (condition == true) {
[INFO] [stdout]     |            ^                 ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 589 -         if (condition == true) {
[INFO] [stdout] 589 +         if condition == true  {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `if` condition
[INFO] [stdout]    --> src/cpu/mod.rs:602:12
[INFO] [stdout]     |
[INFO] [stdout] 602 |         if (condition == true) {
[INFO] [stdout]     |            ^                 ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 602 -         if (condition == true) {
[INFO] [stdout] 602 +         if condition == true  {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around assigned value
[INFO] [stdout]    --> src/cpu/mod.rs:830:28
[INFO] [stdout]     |
[INFO] [stdout] 830 |         self.flags.carry = (r1 > 0xff);
[INFO] [stdout]     |                            ^         ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 830 -         self.flags.carry = (r1 > 0xff);
[INFO] [stdout] 830 +         self.flags.carry = r1 > 0xff ;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around assigned value
[INFO] [stdout]    --> src/cpu/mod.rs:844:28
[INFO] [stdout]     |
[INFO] [stdout] 844 |         self.flags.carry = (r1 > 0xff);
[INFO] [stdout]     |                            ^         ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 844 -         self.flags.carry = (r1 > 0xff);
[INFO] [stdout] 844 +         self.flags.carry = r1 > 0xff ;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around assigned value
[INFO] [stdout]    --> src/cpu/mod.rs:856:28
[INFO] [stdout]     |
[INFO] [stdout] 856 |         self.flags.carry = (r1 > 0xff);
[INFO] [stdout]     |                            ^         ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 856 -         self.flags.carry = (r1 > 0xff);
[INFO] [stdout] 856 +         self.flags.carry = r1 > 0xff ;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around assigned value
[INFO] [stdout]    --> src/cpu/mod.rs:885:28
[INFO] [stdout]     |
[INFO] [stdout] 885 |         self.flags.carry = (self.regs.a < val as u8);
[INFO] [stdout]     |                            ^                       ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 885 -         self.flags.carry = (self.regs.a < val as u8);
[INFO] [stdout] 885 +         self.flags.carry = self.regs.a < val as u8 ;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `args`
[INFO] [stdout]   --> src/platform/mod.rs:20:21
[INFO] [stdout]    |
[INFO] [stdout] 20 |                 let args: Vec<String> = env::args().collect();
[INFO] [stdout]    |                     ^^^^ help: if this is intentional, prefix it with an underscore: `_args`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `res`
[INFO] [stdout]   --> src/cpu/flags.rs:46:31
[INFO] [stdout]    |
[INFO] [stdout] 46 |     pub fn calc_sub_cy(&self, res: u16) -> bool {
[INFO] [stdout]    |                               ^^^
[INFO] [stdout]    |
[INFO] [stdout] help: if this is intentional, prefix it with an underscore
[INFO] [stdout]    |
[INFO] [stdout] 46 |     pub fn calc_sub_cy(&self, _res: u16) -> bool {
[INFO] [stdout]    |                               +
[INFO] [stdout] help: you might have meant to pattern match on the similarly named constant `BDOS`
[INFO] [stdout]    |
[INFO] [stdout] 46 -     pub fn calc_sub_cy(&self, res: u16) -> bool {
[INFO] [stdout] 46 +     pub fn calc_sub_cy(&self, cpu::Cpu::cpm_call::BDOS: u16) -> bool {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable `num_of_on_bits` is assigned to, but never used
[INFO] [stdout]   --> src/cpu/flags.rs:54:17
[INFO] [stdout]    |
[INFO] [stdout] 54 |         let mut num_of_on_bits: u8 = 0;
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: consider using `_num_of_on_bits` instead
[INFO] [stdout] help: you might have meant to pattern match on the similarly named constant `WRITESTR`
[INFO] [stdout]    |
[INFO] [stdout] 54 -         let mut num_of_on_bits: u8 = 0;
[INFO] [stdout] 54 +         let mut cpu::Cpu::cpm_call::WRITESTR: u8 = 0;
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `de32`
[INFO] [stdout]    --> src/cpu/mod.rs:310:21
[INFO] [stdout]     |
[INFO] [stdout] 310 |                 let de32: u32 = self.cmb_be(self.regs.b, self.regs.c).into();
[INFO] [stdout]     |                     ^^^^ help: if this is intentional, prefix it with an underscore: `_de32`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `i`
[INFO] [stdout]    --> src/cpu/mod.rs:983:13
[INFO] [stdout]     |
[INFO] [stdout] 983 |         for i in 0..2 {
[INFO] [stdout]     |             ^ help: if this is intentional, prefix it with an underscore: `_i`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `get_frame` is never used
[INFO] [stdout]   --> src/platform/mod.rs:44:12
[INFO] [stdout]    |
[INFO] [stdout] 10 | impl InvadersCabinet {
[INFO] [stdout]    | -------------------- method in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 44 |     pub fn get_frame(&self) -> Vec<u8> {
[INFO] [stdout]    |            ^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `cpu_read` is never used
[INFO] [stdout]   --> src/platform/io.rs:20:12
[INFO] [stdout]    |
[INFO] [stdout] 10 | impl IO {
[INFO] [stdout]    | ------- method in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 20 |     pub fn cpu_read(&self, port: u8) -> u8 {
[INFO] [stdout]    |            ^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `output` is never read
[INFO] [stdout]   --> src/cpu/mod.rs:77:9
[INFO] [stdout]    |
[INFO] [stdout] 60 | pub struct Cpu {
[INFO] [stdout]    |            --- field in this struct
[INFO] [stdout] ...
[INFO] [stdout] 77 |     pub output: String,
[INFO] [stdout]    |         ^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: methods `debug`, `cpm_call`, `get_add`, `get_sub`, and `get_regs` are never used
[INFO] [stdout]    --> src/cpu/mod.rs:565:12
[INFO] [stdout]     |
[INFO] [stdout]  80 | impl Cpu {
[INFO] [stdout]     | -------- methods in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 565 |     pub fn debug(&self) {
[INFO] [stdout]     |            ^^^^^
[INFO] [stdout] ...
[INFO] [stdout] 671 |     fn cpm_call(&mut self, advance: *mut u16) {
[INFO] [stdout]     |        ^^^^^^^^
[INFO] [stdout] ...
[INFO] [stdout] 814 |     fn get_add(&mut self, val: u16) -> u8 {
[INFO] [stdout]     |        ^^^^^^^
[INFO] [stdout] ...
[INFO] [stdout] 839 |     fn get_sub(&mut self, val: u8) -> u8 {
[INFO] [stdout]     |        ^^^^^^^
[INFO] [stdout] ...
[INFO] [stdout] 892 |     pub fn get_regs(&self) -> ([&str; 9], [u8; 7], [u16; 2]) {
[INFO] [stdout]     |            ^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: methods `calc_sub_cy` and `set_all_flags` are never used
[INFO] [stdout]   --> src/cpu/flags.rs:46:12
[INFO] [stdout]    |
[INFO] [stdout] 28 | impl Flags {
[INFO] [stdout]    | ---------- methods in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 46 |     pub fn calc_sub_cy(&self, res: u16) -> bool {
[INFO] [stdout]    |            ^^^^^^^^^^^
[INFO] [stdout] ...
[INFO] [stdout] 82 |     pub fn set_all_flags(&mut self, res: u8) {
[INFO] [stdout]    |            ^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused `Result` that must be used
[INFO] [stdout]    --> src/cpu/mod.rs:119:9
[INFO] [stdout]     |
[INFO] [stdout] 119 |         c.load_into_memory(program, pc as usize);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stdout]     = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] help: use `let _ = ...` to ignore the resulting value
[INFO] [stdout]     |
[INFO] [stdout] 119 |         let _ = c.load_into_memory(program, pc as usize);
[INFO] [stdout]     |         +++++++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constant `parity_table` should have an upper case name
[INFO] [stdout]  --> src/cpu/flags.rs:1:7
[INFO] [stdout]   |
[INFO] [stdout] 1 | const parity_table: [u8; 256] = [
[INFO] [stdout]   |       ^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(non_upper_case_globals)]` (part of `#[warn(nonstandard_style)]`) on by default
[INFO] [stdout] help: convert the identifier to upper case
[INFO] [stdout]   |
[INFO] [stdout] 1 - const parity_table: [u8; 256] = [
[INFO] [stdout] 1 + const PARITY_TABLE: [u8; 256] = [
[INFO] [stdout]   |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `test` profile [unoptimized + debuginfo] target(s) in 0.23s
[INFO] running `Command { std: "docker" "inspect" "86cc3b9d7d05fb52b123ca6281347be1f73999d3ffe99fa88cdb359d57a081b6", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "86cc3b9d7d05fb52b123ca6281347be1f73999d3ffe99fa88cdb359d57a081b6", kill_on_drop: false }`
[INFO] [stdout] 86cc3b9d7d05fb52b123ca6281347be1f73999d3ffe99fa88cdb359d57a081b6
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:e90291280db7d1fac5b66fc6dad9f9662629e7365a55743daf9bdf73ebc4ea79" "/opt/rustwide/cargo-home/bin/cargo" "+2440211fe03bc45c89b6dc1a3df18382ce91e32b" "test" "--frozen", kill_on_drop: false }`
[INFO] [stdout] 319ee7e0fc9bd2cbd78af1687057e515ae6fc90729da7093416424b9e609c576
[INFO] running `Command { std: "docker" "start" "-a" "319ee7e0fc9bd2cbd78af1687057e515ae6fc90729da7093416424b9e609c576", kill_on_drop: false }`
[INFO] [stderr] warning: unnecessary parentheses around assigned value
[INFO] [stderr]    --> src/cpu/mod.rs:481:35
[INFO] [stderr]     |
[INFO] [stderr] 481 |                 self.flags.zero = (0x01 == (psw & 0x01));
[INFO] [stderr]     |                                   ^                    ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default
[INFO] [stderr] help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr] 481 -                 self.flags.zero = (0x01 == (psw & 0x01));
[INFO] [stderr] 481 +                 self.flags.zero = 0x01 == (psw & 0x01) ;
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around assigned value
[INFO] [stderr]    --> src/cpu/mod.rs:482:35
[INFO] [stderr]     |
[INFO] [stderr] 482 |                 self.flags.sign = (0x02 == (psw & 0x02));
[INFO] [stderr]     |                                   ^                    ^
[INFO] [stderr]     |
[INFO] [stderr] help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr] 482 -                 self.flags.sign = (0x02 == (psw & 0x02));
[INFO] [stderr] 482 +                 self.flags.sign = 0x02 == (psw & 0x02) ;
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around assigned value
[INFO] [stderr]    --> src/cpu/mod.rs:483:37
[INFO] [stderr]     |
[INFO] [stderr] 483 |                 self.flags.parity = (0x04 == (psw & 0x04));
[INFO] [stderr]     |                                     ^                    ^
[INFO] [stderr]     |
[INFO] [stderr] help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr] 483 -                 self.flags.parity = (0x04 == (psw & 0x04));
[INFO] [stderr] 483 +                 self.flags.parity = 0x04 == (psw & 0x04) ;
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around assigned value
[INFO] [stderr]    --> src/cpu/mod.rs:484:37
[INFO] [stderr]     |
[INFO] [stderr] 484 |                 self.flags.carry =  (0x05 == (psw & 0x08));
[INFO] [stderr]     |                                     ^                    ^
[INFO] [stderr]     |
[INFO] [stderr] help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr] 484 -                 self.flags.carry =  (0x05 == (psw & 0x08));
[INFO] [stderr] 484 +                 self.flags.carry =  0x05 == (psw & 0x08) ;
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around assigned value
[INFO] [stderr]    --> src/cpu/mod.rs:485:40
[INFO] [stderr]     |
[INFO] [stderr] 485 |                 self.flags.aux_carry = (0x10 == (psw & 0x10));
[INFO] [stderr]     |                                        ^                    ^
[INFO] [stderr]     |
[INFO] [stderr] help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr] 485 -                 self.flags.aux_carry = (0x10 == (psw & 0x10));
[INFO] [stderr] 485 +                 self.flags.aux_carry = 0x10 == (psw & 0x10) ;
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around assigned value
[INFO] [stderr]    --> src/cpu/mod.rs:525:36
[INFO] [stderr]     |
[INFO] [stderr] 525 |                 self.flags.carry = (1 == (x&1));
[INFO] [stderr]     |                                    ^          ^
[INFO] [stderr]     |
[INFO] [stderr] help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr] 525 -                 self.flags.carry = (1 == (x&1));
[INFO] [stderr] 525 +                 self.flags.carry = 1 == (x&1) ;
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]    --> src/cpu/mod.rs:589:12
[INFO] [stderr]     |
[INFO] [stderr] 589 |         if (condition == true) {
[INFO] [stderr]     |            ^                 ^
[INFO] [stderr]     |
[INFO] [stderr] help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr] 589 -         if (condition == true) {
[INFO] [stderr] 589 +         if condition == true  {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]    --> src/cpu/mod.rs:602:12
[INFO] [stderr]     |
[INFO] [stderr] 602 |         if (condition == true) {
[INFO] [stderr]     |            ^                 ^
[INFO] [stderr]     |
[INFO] [stderr] help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr] 602 -         if (condition == true) {
[INFO] [stderr] 602 +         if condition == true  {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around assigned value
[INFO] [stderr]    --> src/cpu/mod.rs:830:28
[INFO] [stderr]     |
[INFO] [stderr] 830 |         self.flags.carry = (r1 > 0xff);
[INFO] [stderr]     |                            ^         ^
[INFO] [stderr]     |
[INFO] [stderr] help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr] 830 -         self.flags.carry = (r1 > 0xff);
[INFO] [stderr] 830 +         self.flags.carry = r1 > 0xff ;
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around assigned value
[INFO] [stderr]    --> src/cpu/mod.rs:844:28
[INFO] [stderr]     |
[INFO] [stderr] 844 |         self.flags.carry = (r1 > 0xff);
[INFO] [stderr]     |                            ^         ^
[INFO] [stderr]     |
[INFO] [stderr] help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr] 844 -         self.flags.carry = (r1 > 0xff);
[INFO] [stderr] 844 +         self.flags.carry = r1 > 0xff ;
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around assigned value
[INFO] [stderr]    --> src/cpu/mod.rs:856:28
[INFO] [stderr]     |
[INFO] [stderr] 856 |         self.flags.carry = (r1 > 0xff);
[INFO] [stderr]     |                            ^         ^
[INFO] [stderr]     |
[INFO] [stderr] help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr] 856 -         self.flags.carry = (r1 > 0xff);
[INFO] [stderr] 856 +         self.flags.carry = r1 > 0xff ;
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around assigned value
[INFO] [stderr]    --> src/cpu/mod.rs:885:28
[INFO] [stderr]     |
[INFO] [stderr] 885 |         self.flags.carry = (self.regs.a < val as u8);
[INFO] [stderr]     |                            ^                       ^
[INFO] [stderr]     |
[INFO] [stderr] help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr] 885 -         self.flags.carry = (self.regs.a < val as u8);
[INFO] [stderr] 885 +         self.flags.carry = self.regs.a < val as u8 ;
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `args`
[INFO] [stderr]   --> src/platform/mod.rs:20:21
[INFO] [stderr]    |
[INFO] [stderr] 20 |                 let args: Vec<String> = env::args().collect();
[INFO] [stderr]    |                     ^^^^ help: if this is intentional, prefix it with an underscore: `_args`
[INFO] [stderr]    |
[INFO] [stderr]    = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `res`
[INFO] [stderr]   --> src/cpu/flags.rs:46:31
[INFO] [stderr]    |
[INFO] [stderr] 46 |     pub fn calc_sub_cy(&self, res: u16) -> bool {
[INFO] [stderr]    |                               ^^^
[INFO] [stderr]    |
[INFO] [stderr] help: if this is intentional, prefix it with an underscore
[INFO] [stderr]    |
[INFO] [stderr] 46 |     pub fn calc_sub_cy(&self, _res: u16) -> bool {
[INFO] [stderr]    |                               +
[INFO] [stderr] help: you might have meant to pattern match on the similarly named constant `BDOS`
[INFO] [stderr]    |
[INFO] [stderr] 46 -     pub fn calc_sub_cy(&self, res: u16) -> bool {
[INFO] [stderr] 46 +     pub fn calc_sub_cy(&self, cpu::Cpu::cpm_call::BDOS: u16) -> bool {
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: variable `num_of_on_bits` is assigned to, but never used
[INFO] [stderr]   --> src/cpu/flags.rs:54:17
[INFO] [stderr]    |
[INFO] [stderr] 54 |         let mut num_of_on_bits: u8 = 0;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: consider using `_num_of_on_bits` instead
[INFO] [stderr] help: you might have meant to pattern match on the similarly named constant `WRITESTR`
[INFO] [stderr]    |
[INFO] [stderr] 54 -         let mut num_of_on_bits: u8 = 0;
[INFO] [stderr] 54 +         let mut cpu::Cpu::cpm_call::WRITESTR: u8 = 0;
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `de32`
[INFO] [stderr]    --> src/cpu/mod.rs:310:21
[INFO] [stderr]     |
[INFO] [stderr] 310 |                 let de32: u32 = self.cmb_be(self.regs.b, self.regs.c).into();
[INFO] [stderr]     |                     ^^^^ help: if this is intentional, prefix it with an underscore: `_de32`
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `i`
[INFO] [stderr]    --> src/cpu/mod.rs:983:13
[INFO] [stderr]     |
[INFO] [stderr] 983 |         for i in 0..2 {
[INFO] [stderr]     |             ^ help: if this is intentional, prefix it with an underscore: `_i`
[INFO] [stderr] 
[INFO] [stderr] warning: method `get_frame` is never used
[INFO] [stderr]   --> src/platform/mod.rs:44:12
[INFO] [stderr]    |
[INFO] [stderr] 10 | impl InvadersCabinet {
[INFO] [stderr]    | -------------------- method in this implementation
[INFO] [stderr] ...
[INFO] [stderr] 44 |     pub fn get_frame(&self) -> Vec<u8> {
[INFO] [stderr]    |            ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method `cpu_read` is never used
[INFO] [stderr]   --> src/platform/io.rs:20:12
[INFO] [stderr]    |
[INFO] [stderr] 10 | impl IO {
[INFO] [stderr]    | ------- method in this implementation
[INFO] [stderr] ...
[INFO] [stderr] 20 |     pub fn cpu_read(&self, port: u8) -> u8 {
[INFO] [stderr]    |            ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field `output` is never read
[INFO] [stderr]   --> src/cpu/mod.rs:77:9
[INFO] [stderr]    |
[INFO] [stderr] 60 | pub struct Cpu {
[INFO] [stderr]    |            --- field in this struct
[INFO] [stderr] ...
[INFO] [stderr] 77 |     pub output: String,
[INFO] [stderr]    |         ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: methods `debug`, `cpm_call`, `get_add`, `get_sub`, and `get_regs` are never used
[INFO] [stderr]    --> src/cpu/mod.rs:565:12
[INFO] [stderr]     |
[INFO] [stderr]  80 | impl Cpu {
[INFO] [stderr]     | -------- methods in this implementation
[INFO] [stderr] ...
[INFO] [stderr] 565 |     pub fn debug(&self) {
[INFO] [stderr]     |            ^^^^^
[INFO] [stderr] ...
[INFO] [stderr] 671 |     fn cpm_call(&mut self, advance: *mut u16) {
[INFO] [stderr]     |        ^^^^^^^^
[INFO] [stderr] ...
[INFO] [stderr] 814 |     fn get_add(&mut self, val: u16) -> u8 {
[INFO] [stderr]     |        ^^^^^^^
[INFO] [stderr] ...
[INFO] [stderr] 839 |     fn get_sub(&mut self, val: u8) -> u8 {
[INFO] [stderr]     |        ^^^^^^^
[INFO] [stderr] ...
[INFO] [stderr] 892 |     pub fn get_regs(&self) -> ([&str; 9], [u8; 7], [u16; 2]) {
[INFO] [stderr]     |            ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: methods `calc_sub_cy` and `set_all_flags` are never used
[INFO] [stderr]   --> src/cpu/flags.rs:46:12
[INFO] [stderr]    |
[INFO] [stderr] 28 | impl Flags {
[INFO] [stderr]    | ---------- methods in this implementation
[INFO] [stderr] ...
[INFO] [stderr] 46 |     pub fn calc_sub_cy(&self, res: u16) -> bool {
[INFO] [stderr]    |            ^^^^^^^^^^^
[INFO] [stderr] ...
[INFO] [stderr] 82 |     pub fn set_all_flags(&mut self, res: u8) {
[INFO] [stderr]    |            ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused `Result` that must be used
[INFO] [stderr]    --> src/cpu/mod.rs:119:9
[INFO] [stderr]     |
[INFO] [stderr] 119 |         c.load_into_memory(program, pc as usize);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr]     = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default
[INFO] [stderr] help: use `let _ = ...` to ignore the resulting value
[INFO] [stderr]     |
[INFO] [stderr] 119 |         let _ = c.load_into_memory(program, pc as usize);
[INFO] [stderr]     |         +++++++
[INFO] [stderr] 
[INFO] [stderr] warning: constant `parity_table` should have an upper case name
[INFO] [stderr]  --> src/cpu/flags.rs:1:7
[INFO] [stderr]   |
[INFO] [stderr] 1 | const parity_table: [u8; 256] = [
[INFO] [stderr]   |       ^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: `#[warn(non_upper_case_globals)]` (part of `#[warn(nonstandard_style)]`) on by default
[INFO] [stderr] help: convert the identifier to upper case
[INFO] [stderr]   |
[INFO] [stderr] 1 - const parity_table: [u8; 256] = [
[INFO] [stderr] 1 + const PARITY_TABLE: [u8; 256] = [
[INFO] [stderr]   |
[INFO] [stderr] 
[INFO] [stderr] warning: `space_invaders` (bin "space_invaders" test) generated 24 warnings (run `cargo fix --bin "space_invaders" --tests` to apply 15 suggestions)
[INFO] [stderr]     Finished `test` profile [unoptimized + debuginfo] target(s) in 0.01s
[INFO] [stderr]      Running unittests src/main.rs (/opt/rustwide/target/debug/deps/space_invaders-c0aef1c7507a4707)
[INFO] [stdout] 
[INFO] [stdout] running 7 tests
[INFO] [stdout] test cpu::cpu_test::lxi_de ... ok
[INFO] [stdout] test cpu::cpu_test::lxi_hl ... ok
[INFO] [stdout] test cpu::cpu_test::lxi_bc ... ok
[INFO] [stdout] test cpu::cpu_test::set_and_read_m ... ok
[INFO] [stdout] test platform::io::io_test::cpu_read_port_1 ... ok
[INFO] [stdout] test platform::io::io_test::cpu_write_port_4 ... ok
[INFO] [stdout] test platform::test::framebuffer_test ... ok
[INFO] [stdout] 
[INFO] [stdout] test result: ok. 7 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
[INFO] [stdout] 
[INFO] running `Command { std: "docker" "inspect" "319ee7e0fc9bd2cbd78af1687057e515ae6fc90729da7093416424b9e609c576", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "319ee7e0fc9bd2cbd78af1687057e515ae6fc90729da7093416424b9e609c576", kill_on_drop: false }`
[INFO] [stdout] 319ee7e0fc9bd2cbd78af1687057e515ae6fc90729da7093416424b9e609c576