[INFO] fetching crate tellirc 0.1.6... [INFO] testing tellirc-0.1.6 against master#caccb4d0368bd918ef6668af8e13834d07040417 for pr-146098-1 [INFO] extracting crate tellirc 0.1.6 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate tellirc 0.1.6 [INFO] finished tweaking crates.io crate tellirc 0.1.6 [INFO] tweaked toml for crates.io crate tellirc 0.1.6 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate tellirc 0.1.6 on toolchain caccb4d0368bd918ef6668af8e13834d07040417 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+caccb4d0368bd918ef6668af8e13834d07040417" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+caccb4d0368bd918ef6668af8e13834d07040417" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 153 packages to latest compatible versions [INFO] [stderr] Adding irc v0.13.6 (available: v1.1.0) [INFO] [stderr] Adding rusqlite v0.18.0 (available: v0.37.0) [INFO] [stderr] Adding wasi v0.10.0+wasi-snapshot-preview1 (available: v0.10.2+wasi-snapshot-preview1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+caccb4d0368bd918ef6668af8e13834d07040417" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded tokio-tls v0.2.1 [INFO] [stderr] Downloaded tokio-timer v0.1.2 [INFO] [stderr] Downloaded rusqlite v0.18.0 [INFO] [stderr] Downloaded libsqlite3-sys v0.14.0 [INFO] [stderr] Downloaded tokio-mockstream v1.1.0 [INFO] [stderr] Downloaded irc v0.13.6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:e90291280db7d1fac5b66fc6dad9f9662629e7365a55743daf9bdf73ebc4ea79" "/opt/rustwide/cargo-home/bin/cargo" "+caccb4d0368bd918ef6668af8e13834d07040417" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 861fabb1d024ea7da7f9049d8a39d10dc9c89c5ce519e8ccd780d13b6475e40b [INFO] running `Command { std: "docker" "start" "-a" "861fabb1d024ea7da7f9049d8a39d10dc9c89c5ce519e8ccd780d13b6475e40b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "861fabb1d024ea7da7f9049d8a39d10dc9c89c5ce519e8ccd780d13b6475e40b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "861fabb1d024ea7da7f9049d8a39d10dc9c89c5ce519e8ccd780d13b6475e40b", kill_on_drop: false }` [INFO] [stdout] 861fabb1d024ea7da7f9049d8a39d10dc9c89c5ce519e8ccd780d13b6475e40b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:e90291280db7d1fac5b66fc6dad9f9662629e7365a55743daf9bdf73ebc4ea79" "/opt/rustwide/cargo-home/bin/cargo" "+caccb4d0368bd918ef6668af8e13834d07040417" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9c30765b6ef4586b62076863ff7a7b4183adac079e8cb42b975920144f8ae0e5 [INFO] running `Command { std: "docker" "start" "-a" "9c30765b6ef4586b62076863ff7a7b4183adac079e8cb42b975920144f8ae0e5", kill_on_drop: false }` [INFO] [stderr] Compiling bytes v0.4.12 [INFO] [stderr] Compiling mio v0.6.23 [INFO] [stderr] Compiling encoding_index_tests v0.1.4 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling tokio-threadpool v0.1.18 [INFO] [stderr] Compiling object v0.37.3 [INFO] [stderr] Compiling libsqlite3-sys v0.14.0 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling slab v0.3.0 [INFO] [stderr] Compiling chrono v0.4.42 [INFO] [stderr] Compiling scoped-tls v0.1.2 [INFO] [stderr] Compiling lru-cache v0.1.2 [INFO] [stderr] Compiling fallible-streaming-iterator v0.1.9 [INFO] [stderr] Compiling bufstream v0.1.4 [INFO] [stderr] Compiling fallible-iterator v0.2.0 [INFO] [stderr] Compiling encoding-index-singlebyte v1.20141219.5 [INFO] [stderr] Compiling encoding-index-tradchinese v1.20141219.5 [INFO] [stderr] Compiling encoding-index-japanese v1.20141219.5 [INFO] [stderr] Compiling encoding-index-simpchinese v1.20141219.5 [INFO] [stderr] Compiling encoding-index-korean v1.20141219.5 [INFO] [stderr] Compiling tokio-timer v0.1.2 [INFO] [stderr] Compiling tokio-io v0.1.13 [INFO] [stderr] Compiling openssl v0.10.73 [INFO] [stderr] Compiling encoding v0.2.33 [INFO] [stderr] Compiling tokio-codec v0.1.2 [INFO] [stderr] Compiling tokio-fs v0.1.7 [INFO] [stderr] Compiling tokio-mockstream v1.1.0 [INFO] [stderr] Compiling tokio-reactor v0.1.12 [INFO] [stderr] Compiling mio-uds v0.6.8 [INFO] [stderr] Compiling toml v0.4.10 [INFO] [stderr] Compiling tokio-udp v0.1.6 [INFO] [stderr] Compiling tokio-tcp v0.1.4 [INFO] [stderr] Compiling tokio-uds v0.2.7 [INFO] [stderr] Compiling tokio v0.1.22 [INFO] [stderr] Compiling tokio-core v0.1.18 [INFO] [stderr] Compiling rusqlite v0.18.0 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Compiling tokio-tls v0.2.1 [INFO] [stderr] Compiling backtrace v0.3.76 [INFO] [stderr] Compiling failure v0.1.8 [INFO] [stderr] Compiling irc v0.13.6 [INFO] [stderr] Compiling tellirc v0.1.6 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/lib.rs:230:45 [INFO] [stdout] | [INFO] [stdout] 230 | pub fn make_handler_fn(dao: Dao) -> impl (FnMut(&IrcClient, Message) -> Result<(), U>) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 230 - pub fn make_handler_fn(dao: Dao) -> impl (FnMut(&IrcClient, Message) -> Result<(), U>) { [INFO] [stdout] 230 + pub fn make_handler_fn(dao: Dao) -> impl FnMut(&IrcClient, Message) -> Result<(), U> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:68:46 [INFO] [stdout] | [INFO] [stdout] 68 | let iter = stmt.query_map(&[&who as &ToSql, &in_chan as &ToSql], |row| Ok(MessageCacheRow { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 68 | let iter = stmt.query_map(&[&who as &dyn ToSql, &in_chan as &ToSql], |row| Ok(MessageCacheRow { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:68:66 [INFO] [stdout] | [INFO] [stdout] 68 | let iter = stmt.query_map(&[&who as &ToSql, &in_chan as &ToSql], |row| Ok(MessageCacheRow { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 68 | let iter = stmt.query_map(&[&who as &ToSql, &in_chan as &dyn ToSql], |row| Ok(MessageCacheRow { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:100:24 [INFO] [stdout] | [INFO] [stdout] 100 | &[&who as &ToSql, &what as &ToSql, chan, &from as &ToSql, &now]); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 100 | &[&who as &dyn ToSql, &what as &ToSql, chan, &from as &ToSql, &now]); [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:100:41 [INFO] [stdout] | [INFO] [stdout] 100 | &[&who as &ToSql, &what as &ToSql, chan, &from as &ToSql, &now]); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 100 | &[&who as &ToSql, &what as &dyn ToSql, chan, &from as &ToSql, &now]); [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:100:64 [INFO] [stdout] | [INFO] [stdout] 100 | &[&who as &ToSql, &what as &ToSql, chan, &from as &ToSql, &now]); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 100 | &[&who as &ToSql, &what as &ToSql, chan, &from as &dyn ToSql, &now]); [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:233:60 [INFO] [stdout] | [INFO] [stdout] 233 | let target = message.response_target().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:234:60 [INFO] [stdout] | [INFO] [stdout] 234 | let sender = message.source_nickname().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:298:60 [INFO] [stdout] | [INFO] [stdout] 298 | let target = message.response_target().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 10.28s [INFO] running `Command { std: "docker" "inspect" "9c30765b6ef4586b62076863ff7a7b4183adac079e8cb42b975920144f8ae0e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9c30765b6ef4586b62076863ff7a7b4183adac079e8cb42b975920144f8ae0e5", kill_on_drop: false }` [INFO] [stdout] 9c30765b6ef4586b62076863ff7a7b4183adac079e8cb42b975920144f8ae0e5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:e90291280db7d1fac5b66fc6dad9f9662629e7365a55743daf9bdf73ebc4ea79" "/opt/rustwide/cargo-home/bin/cargo" "+caccb4d0368bd918ef6668af8e13834d07040417" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8f64a4b1530f89d9963d79c1672bc403183fd316fd52e1ad2f569a41f92663e8 [INFO] running `Command { std: "docker" "start" "-a" "8f64a4b1530f89d9963d79c1672bc403183fd316fd52e1ad2f569a41f92663e8", kill_on_drop: false }` [INFO] [stderr] Compiling tellirc v0.1.6 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/lib.rs:230:45 [INFO] [stdout] | [INFO] [stdout] 230 | pub fn make_handler_fn(dao: Dao) -> impl (FnMut(&IrcClient, Message) -> Result<(), U>) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 230 - pub fn make_handler_fn(dao: Dao) -> impl (FnMut(&IrcClient, Message) -> Result<(), U>) { [INFO] [stdout] 230 + pub fn make_handler_fn(dao: Dao) -> impl FnMut(&IrcClient, Message) -> Result<(), U> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:68:46 [INFO] [stdout] | [INFO] [stdout] 68 | let iter = stmt.query_map(&[&who as &ToSql, &in_chan as &ToSql], |row| Ok(MessageCacheRow { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 68 | let iter = stmt.query_map(&[&who as &dyn ToSql, &in_chan as &ToSql], |row| Ok(MessageCacheRow { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:68:66 [INFO] [stdout] | [INFO] [stdout] 68 | let iter = stmt.query_map(&[&who as &ToSql, &in_chan as &ToSql], |row| Ok(MessageCacheRow { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 68 | let iter = stmt.query_map(&[&who as &ToSql, &in_chan as &dyn ToSql], |row| Ok(MessageCacheRow { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:100:24 [INFO] [stdout] | [INFO] [stdout] 100 | &[&who as &ToSql, &what as &ToSql, chan, &from as &ToSql, &now]); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 100 | &[&who as &dyn ToSql, &what as &ToSql, chan, &from as &ToSql, &now]); [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:100:41 [INFO] [stdout] | [INFO] [stdout] 100 | &[&who as &ToSql, &what as &ToSql, chan, &from as &ToSql, &now]); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 100 | &[&who as &ToSql, &what as &dyn ToSql, chan, &from as &ToSql, &now]); [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:100:64 [INFO] [stdout] | [INFO] [stdout] 100 | &[&who as &ToSql, &what as &ToSql, chan, &from as &ToSql, &now]); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 100 | &[&who as &ToSql, &what as &ToSql, chan, &from as &dyn ToSql, &now]); [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:233:60 [INFO] [stdout] | [INFO] [stdout] 233 | let target = message.response_target().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:234:60 [INFO] [stdout] | [INFO] [stdout] 234 | let sender = message.source_nickname().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:298:60 [INFO] [stdout] | [INFO] [stdout] 298 | let target = message.response_target().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/lib.rs:230:45 [INFO] [stdout] | [INFO] [stdout] 230 | pub fn make_handler_fn(dao: Dao) -> impl (FnMut(&IrcClient, Message) -> Result<(), U>) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 230 - pub fn make_handler_fn(dao: Dao) -> impl (FnMut(&IrcClient, Message) -> Result<(), U>) { [INFO] [stdout] 230 + pub fn make_handler_fn(dao: Dao) -> impl FnMut(&IrcClient, Message) -> Result<(), U> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:68:46 [INFO] [stdout] | [INFO] [stdout] 68 | let iter = stmt.query_map(&[&who as &ToSql, &in_chan as &ToSql], |row| Ok(MessageCacheRow { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 68 | let iter = stmt.query_map(&[&who as &dyn ToSql, &in_chan as &ToSql], |row| Ok(MessageCacheRow { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:68:66 [INFO] [stdout] | [INFO] [stdout] 68 | let iter = stmt.query_map(&[&who as &ToSql, &in_chan as &ToSql], |row| Ok(MessageCacheRow { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 68 | let iter = stmt.query_map(&[&who as &ToSql, &in_chan as &dyn ToSql], |row| Ok(MessageCacheRow { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:100:24 [INFO] [stdout] | [INFO] [stdout] 100 | &[&who as &ToSql, &what as &ToSql, chan, &from as &ToSql, &now]); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 100 | &[&who as &dyn ToSql, &what as &ToSql, chan, &from as &ToSql, &now]); [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:100:41 [INFO] [stdout] | [INFO] [stdout] 100 | &[&who as &ToSql, &what as &ToSql, chan, &from as &ToSql, &now]); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 100 | &[&who as &ToSql, &what as &dyn ToSql, chan, &from as &ToSql, &now]); [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:100:64 [INFO] [stdout] | [INFO] [stdout] 100 | &[&who as &ToSql, &what as &ToSql, chan, &from as &ToSql, &now]); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 100 | &[&who as &ToSql, &what as &ToSql, chan, &from as &dyn ToSql, &now]); [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:233:60 [INFO] [stdout] | [INFO] [stdout] 233 | let target = message.response_target().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:234:60 [INFO] [stdout] | [INFO] [stdout] 234 | let sender = message.source_nickname().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:298:60 [INFO] [stdout] | [INFO] [stdout] 298 | let target = message.response_target().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `test` profile [unoptimized + debuginfo] target(s) in 0.49s [INFO] running `Command { std: "docker" "inspect" "8f64a4b1530f89d9963d79c1672bc403183fd316fd52e1ad2f569a41f92663e8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8f64a4b1530f89d9963d79c1672bc403183fd316fd52e1ad2f569a41f92663e8", kill_on_drop: false }` [INFO] [stdout] 8f64a4b1530f89d9963d79c1672bc403183fd316fd52e1ad2f569a41f92663e8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:e90291280db7d1fac5b66fc6dad9f9662629e7365a55743daf9bdf73ebc4ea79" "/opt/rustwide/cargo-home/bin/cargo" "+caccb4d0368bd918ef6668af8e13834d07040417" "test" "--frozen", kill_on_drop: false }` [INFO] [stdout] d9be72e39f68cfa56fbbe00f9e3e4bc578b902f13d108e2bb5c6299aeb6d8afb [INFO] running `Command { std: "docker" "start" "-a" "d9be72e39f68cfa56fbbe00f9e3e4bc578b902f13d108e2bb5c6299aeb6d8afb", kill_on_drop: false }` [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/lib.rs:230:45 [INFO] [stderr] | [INFO] [stderr] 230 | pub fn make_handler_fn(dao: Dao) -> impl (FnMut(&IrcClient, Message) -> Result<(), U>) { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 230 - pub fn make_handler_fn(dao: Dao) -> impl (FnMut(&IrcClient, Message) -> Result<(), U>) { [INFO] [stderr] 230 + pub fn make_handler_fn(dao: Dao) -> impl FnMut(&IrcClient, Message) -> Result<(), U> { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/lib.rs:68:46 [INFO] [stderr] | [INFO] [stderr] 68 | let iter = stmt.query_map(&[&who as &ToSql, &in_chan as &ToSql], |row| Ok(MessageCacheRow { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stderr] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stderr] | [INFO] [stderr] 68 | let iter = stmt.query_map(&[&who as &dyn ToSql, &in_chan as &ToSql], |row| Ok(MessageCacheRow { [INFO] [stderr] | +++ [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/lib.rs:68:66 [INFO] [stderr] | [INFO] [stderr] 68 | let iter = stmt.query_map(&[&who as &ToSql, &in_chan as &ToSql], |row| Ok(MessageCacheRow { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stderr] | [INFO] [stderr] 68 | let iter = stmt.query_map(&[&who as &ToSql, &in_chan as &dyn ToSql], |row| Ok(MessageCacheRow { [INFO] [stderr] | +++ [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/lib.rs:100:24 [INFO] [stderr] | [INFO] [stderr] 100 | &[&who as &ToSql, &what as &ToSql, chan, &from as &ToSql, &now]); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stderr] | [INFO] [stderr] 100 | &[&who as &dyn ToSql, &what as &ToSql, chan, &from as &ToSql, &now]); [INFO] [stderr] | +++ [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/lib.rs:100:41 [INFO] [stderr] | [INFO] [stderr] 100 | &[&who as &ToSql, &what as &ToSql, chan, &from as &ToSql, &now]); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stderr] | [INFO] [stderr] 100 | &[&who as &ToSql, &what as &dyn ToSql, chan, &from as &ToSql, &now]); [INFO] [stderr] | +++ [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/lib.rs:100:64 [INFO] [stderr] | [INFO] [stderr] 100 | &[&who as &ToSql, &what as &ToSql, chan, &from as &ToSql, &now]); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stderr] | [INFO] [stderr] 100 | &[&who as &ToSql, &what as &ToSql, chan, &from as &dyn ToSql, &now]); [INFO] [stderr] | +++ [INFO] [stderr] [INFO] [stderr] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stderr] --> src/lib.rs:233:60 [INFO] [stderr] | [INFO] [stderr] 233 | let target = message.response_target().unwrap().clone(); [INFO] [stderr] | ^^^^^^^^ help: remove this redundant call [INFO] [stderr] | [INFO] [stderr] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stderr] = note: `#[warn(noop_method_call)]` on by default [INFO] [stderr] [INFO] [stderr] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stderr] --> src/lib.rs:234:60 [INFO] [stderr] | [INFO] [stderr] 234 | let sender = message.source_nickname().unwrap().clone(); [INFO] [stderr] | ^^^^^^^^ help: remove this redundant call [INFO] [stderr] | [INFO] [stderr] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stderr] [INFO] [stderr] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stderr] --> src/lib.rs:298:60 [INFO] [stderr] | [INFO] [stderr] 298 | let target = message.response_target().unwrap().clone(); [INFO] [stderr] | ^^^^^^^^ help: remove this redundant call [INFO] [stderr] | [INFO] [stderr] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stderr] [INFO] [stderr] warning: `tellirc` (lib) generated 9 warnings (run `cargo fix --lib -p tellirc` to apply 9 suggestions) [INFO] [stderr] warning: `tellirc` (lib test) generated 9 warnings (9 duplicates) [INFO] [stderr] Finished `test` profile [unoptimized + debuginfo] target(s) in 0.12s [INFO] [stderr] Running unittests src/lib.rs (/opt/rustwide/target/debug/deps/tellirc-951ff20caf0dc09e) [INFO] [stdout] [INFO] [stdout] running 0 tests [INFO] [stdout] [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s [INFO] [stdout] [INFO] [stderr] Running unittests src/main.rs (/opt/rustwide/target/debug/deps/tellirc-20651c50424f9414) [INFO] [stdout] [INFO] [stdout] running 0 tests [INFO] [stdout] [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s [INFO] [stdout] [INFO] [stderr] Doc-tests tellirc [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/lib.rs:230:45 [INFO] [stderr] | [INFO] [stderr] 230 | pub fn make_handler_fn(dao: Dao) -> impl (FnMut(&IrcClient, Message) -> Result<(), U>) { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 230 - pub fn make_handler_fn(dao: Dao) -> impl (FnMut(&IrcClient, Message) -> Result<(), U>) { [INFO] [stderr] 230 + pub fn make_handler_fn(dao: Dao) -> impl FnMut(&IrcClient, Message) -> Result<(), U> { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: 1 warning emitted [INFO] [stderr] [INFO] [stdout] [INFO] [stdout] running 0 tests [INFO] [stdout] [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "d9be72e39f68cfa56fbbe00f9e3e4bc578b902f13d108e2bb5c6299aeb6d8afb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d9be72e39f68cfa56fbbe00f9e3e4bc578b902f13d108e2bb5c6299aeb6d8afb", kill_on_drop: false }` [INFO] [stdout] d9be72e39f68cfa56fbbe00f9e3e4bc578b902f13d108e2bb5c6299aeb6d8afb