[INFO] fetching crate comms 0.1.4... [INFO] testing comms-0.1.4 against try#b83b707f97d809763b7861afa7638871f3339a33 for pr-145838-1 [INFO] extracting crate comms 0.1.4 into /workspace/builds/worker-3-tc2/source [INFO] started tweaking crates.io crate comms 0.1.4 [INFO] finished tweaking crates.io crate comms 0.1.4 [INFO] tweaked toml for crates.io crate comms 0.1.4 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] validating manifest of crates.io crate comms 0.1.4 on toolchain b83b707f97d809763b7861afa7638871f3339a33 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+b83b707f97d809763b7861afa7638871f3339a33" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+b83b707f97d809763b7861afa7638871f3339a33" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 43 packages to latest compatible versions [INFO] [stderr] Adding futures v0.1.31 (available: v0.3.31) [INFO] [stderr] Adding quickcheck v0.2.27 (available: v1.0.3) [INFO] [stderr] Adding tokio-timer v0.1.2 (available: v0.2.13) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+b83b707f97d809763b7861afa7638871f3339a33" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+b83b707f97d809763b7861afa7638871f3339a33" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7974a2cce88fc613ea37efc0b4f7c97ccbc0b5234c090996d861cb58bf6a9a77 [INFO] running `Command { std: "docker" "start" "-a" "7974a2cce88fc613ea37efc0b4f7c97ccbc0b5234c090996d861cb58bf6a9a77", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7974a2cce88fc613ea37efc0b4f7c97ccbc0b5234c090996d861cb58bf6a9a77", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7974a2cce88fc613ea37efc0b4f7c97ccbc0b5234c090996d861cb58bf6a9a77", kill_on_drop: false }` [INFO] [stdout] 7974a2cce88fc613ea37efc0b4f7c97ccbc0b5234c090996d861cb58bf6a9a77 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+b83b707f97d809763b7861afa7638871f3339a33" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 34240804cbef092e9c333d1de2973f91677d9058ddba8b61540714f624a96177 [INFO] running `Command { std: "docker" "start" "-a" "34240804cbef092e9c333d1de2973f91677d9058ddba8b61540714f624a96177", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] [stderr] Compiling futures v0.1.31 [INFO] [stderr] Compiling slab v0.3.0 [INFO] [stderr] Compiling tokio-timer v0.1.2 [INFO] [stderr] Compiling comms v0.1.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `self::transmit::*` [INFO] [stdout] --> src/room/mod.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub use self::transmit::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/client/mod.rs:126:39 [INFO] [stdout] | [INFO] [stdout] 126 | pub fn update_status(self) -> Box, Self), Error = Self>> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 126 | pub fn update_status(self) -> Box, Self), Error = Self>> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.27s [INFO] running `Command { std: "docker" "inspect" "34240804cbef092e9c333d1de2973f91677d9058ddba8b61540714f624a96177", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "34240804cbef092e9c333d1de2973f91677d9058ddba8b61540714f624a96177", kill_on_drop: false }` [INFO] [stdout] 34240804cbef092e9c333d1de2973f91677d9058ddba8b61540714f624a96177 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+b83b707f97d809763b7861afa7638871f3339a33" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c972e4c538d7ab4fe552b5e3a53b1491d987ea022a32ce3185bb5980765d658b [INFO] running `Command { std: "docker" "start" "-a" "c972e4c538d7ab4fe552b5e3a53b1491d987ea022a32ce3185bb5980765d658b", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] [stderr] Compiling winapi-build v0.1.1 [INFO] [stderr] Compiling winapi v0.2.8 [INFO] [stderr] Compiling memchr v0.1.11 [INFO] [stderr] Compiling regex-syntax v0.3.9 [INFO] [stderr] Compiling utf8-ranges v0.1.3 [INFO] [stderr] Compiling log v0.3.9 [INFO] [stdout] warning: unused import: `self::transmit::*` [INFO] [stdout] --> src/room/mod.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub use self::transmit::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/client/mod.rs:126:39 [INFO] [stdout] | [INFO] [stdout] 126 | pub fn update_status(self) -> Box, Self), Error = Self>> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 126 | pub fn update_status(self) -> Box, Self), Error = Self>> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling aho-corasick v0.5.3 [INFO] [stderr] Compiling kernel32-sys v0.2.2 [INFO] [stderr] Compiling thread-id v2.0.0 [INFO] [stderr] Compiling thread_local v0.2.7 [INFO] [stderr] Compiling regex v0.1.80 [INFO] [stderr] Compiling env_logger v0.3.5 [INFO] [stderr] Compiling quickcheck v0.2.27 [INFO] [stderr] Compiling comms v0.1.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `self::transmit::*` [INFO] [stdout] --> src/room/mod.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub use self::transmit::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated trait `futures::task::Unpark`: recommended to use `Notify` instead [INFO] [stdout] --> src/lib.rs:56:43 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn unpark_noop() -> Arc { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated trait `futures::task::Unpark`: recommended to use `Notify` instead [INFO] [stdout] --> src/lib.rs:59:24 [INFO] [stdout] | [INFO] [stdout] 59 | impl executor::Unpark for Foo { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/client/mod.rs:126:39 [INFO] [stdout] | [INFO] [stdout] 126 | pub fn update_status(self) -> Box, Self), Error = Self>> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 126 | pub fn update_status(self) -> Box, Self), Error = Self>> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:56:33 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn unpark_noop() -> Arc { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 56 | pub fn unpark_noop() -> Arc { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `futures::task_impl::std::>::poll_future`: recommended to use `poll_future_notify` instead [INFO] [stdout] --> src/client/mod.rs:391:49 [INFO] [stdout] | [INFO] [stdout] 391 | if let Ok(Async::NotReady) = future.poll_future(unpark_noop()) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `futures::task_impl::std::>::poll_future`: recommended to use `poll_future_notify` instead [INFO] [stdout] --> src/room/mod.rs:294:24 [INFO] [stdout] | [INFO] [stdout] 294 | assert!(future.poll_future(unpark_noop()).unwrap().is_not_ready()); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/client/mod.rs:336:53 [INFO] [stdout] | [INFO] [stdout] 336 | let (_, _, client0) = mock_client(client0_id.clone(), 1); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/client/mod.rs:338:53 [INFO] [stdout] | [INFO] [stdout] 338 | let (_, _, client1) = mock_client(client1_id.clone(), 1); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `test` profile [unoptimized + debuginfo] target(s) in 6.00s [INFO] running `Command { std: "docker" "inspect" "c972e4c538d7ab4fe552b5e3a53b1491d987ea022a32ce3185bb5980765d658b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c972e4c538d7ab4fe552b5e3a53b1491d987ea022a32ce3185bb5980765d658b", kill_on_drop: false }` [INFO] [stdout] c972e4c538d7ab4fe552b5e3a53b1491d987ea022a32ce3185bb5980765d658b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+b83b707f97d809763b7861afa7638871f3339a33" "test" "--frozen", kill_on_drop: false }` [INFO] [stdout] c28b4b61786f9bc176e3d86c25e5cd77c6702cd81bbe91664807b8f3c2657f59 [INFO] running `Command { std: "docker" "start" "-a" "c28b4b61786f9bc176e3d86c25e5cd77c6702cd81bbe91664807b8f3c2657f59", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] [stderr] warning: unused import: `self::transmit::*` [INFO] [stderr] --> src/room/mod.rs:7:9 [INFO] [stderr] | [INFO] [stderr] 7 | pub use self::transmit::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/client/mod.rs:126:39 [INFO] [stderr] | [INFO] [stderr] 126 | pub fn update_status(self) -> Box, Self), Error = Self>> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stderr] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stderr] | [INFO] [stderr] 126 | pub fn update_status(self) -> Box, Self), Error = Self>> { [INFO] [stderr] | +++ [INFO] [stderr] [INFO] [stderr] warning: `comms` (lib) generated 2 warnings (run `cargo fix --lib -p comms` to apply 2 suggestions) [INFO] [stderr] warning: use of deprecated trait `futures::task::Unpark`: recommended to use `Notify` instead [INFO] [stderr] --> src/lib.rs:56:43 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn unpark_noop() -> Arc { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(deprecated)]` on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated trait `futures::task::Unpark`: recommended to use `Notify` instead [INFO] [stderr] --> src/lib.rs:59:24 [INFO] [stderr] | [INFO] [stderr] 59 | impl executor::Unpark for Foo { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/lib.rs:56:33 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn unpark_noop() -> Arc { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stderr] | [INFO] [stderr] 56 | pub fn unpark_noop() -> Arc { [INFO] [stderr] | +++ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated method `futures::task_impl::std::>::poll_future`: recommended to use `poll_future_notify` instead [INFO] [stderr] --> src/client/mod.rs:391:49 [INFO] [stderr] | [INFO] [stderr] 391 | if let Ok(Async::NotReady) = future.poll_future(unpark_noop()) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated method `futures::task_impl::std::>::poll_future`: recommended to use `poll_future_notify` instead [INFO] [stderr] --> src/room/mod.rs:294:24 [INFO] [stderr] | [INFO] [stderr] 294 | assert!(future.poll_future(unpark_noop()).unwrap().is_not_ready()); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stderr] --> src/client/mod.rs:336:53 [INFO] [stderr] | [INFO] [stderr] 336 | let (_, _, client0) = mock_client(client0_id.clone(), 1); [INFO] [stderr] | ^^^^^^^^ help: remove this redundant call [INFO] [stderr] | [INFO] [stderr] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stderr] = note: `#[warn(noop_method_call)]` on by default [INFO] [stderr] [INFO] [stderr] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stderr] --> src/client/mod.rs:338:53 [INFO] [stderr] | [INFO] [stderr] 338 | let (_, _, client1) = mock_client(client1_id.clone(), 1); [INFO] [stderr] | ^^^^^^^^ help: remove this redundant call [INFO] [stderr] | [INFO] [stderr] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stderr] [INFO] [stderr] warning: `comms` (lib test) generated 9 warnings (2 duplicates) (run `cargo fix --lib -p comms --tests` to apply 3 suggestions) [INFO] [stderr] Finished `test` profile [unoptimized + debuginfo] target(s) in 0.07s [INFO] [stderr] Running unittests src/lib.rs (/opt/rustwide/target/debug/deps/comms-0ca4187cddab107c) [INFO] [stdout] [INFO] [stdout] running 22 tests [INFO] [stdout] test client::receive::tests::can_hard_receive_an_error ... ok [INFO] [stdout] test client::receive::tests::can_hard_receive_in_time ... ok [INFO] [stdout] test client::receive::tests::can_receive_an_error ... ok [INFO] [stdout] test client::receive::tests::can_receive ... ok [INFO] [stdout] test client::receive::tests::can_receive_well_behaved ... ok [INFO] [stdout] test client::tests::can_join_room ... ok [INFO] [stdout] test client::tests::can_transmit ... ok [INFO] [stdout] test client::tests::can_close ... ok [INFO] [stdout] test client::tests::can_receive ... ok [INFO] [stdout] test client::tests::can_status ... ok [INFO] [stdout] test room::tests::can_broadcast_all ... ok [INFO] [stdout] test room::tests::can_statuses ... ok [INFO] [stdout] test client::receive::tests::can_soft_receive_an_error ... ok [INFO] [stdout] test room::tests::can_transmit ... ok [INFO] [stdout] test client::receive::tests::can_soft_receive_in_time ... ok [INFO] [stdout] test room::tests::can_receive_all ... ok [INFO] [stdout] test client::tests::stream_and_sink_separate ... FAILED [INFO] [stdout] test client::receive::tests::can_receive_for_3_seconds ... ok [INFO] [stdout] test client::receive::tests::can_soft_receive_a_timeout ... ok [INFO] [stdout] test client::receive::tests::can_hard_receive_a_timeout ... ok [INFO] [stdout] test client::receive::tests::can_receive_with_soft_timeout_well_behaved ... ok [INFO] [stdout] test client::receive::tests::can_receive_with_hard_timeout_well_behaved ... ok [INFO] [stdout] [INFO] [stdout] failures: [INFO] [stdout] [INFO] [stdout] ---- client::tests::stream_and_sink_separate stdout ---- [INFO] [stdout] [INFO] [stdout] thread 'client::tests::stream_and_sink_separate' (48) panicked at src/client/mod.rs:442:17: [INFO] [stdout] assertion `left == right` failed [INFO] [stdout] left: Ok(NotReady) [INFO] [stdout] right: Ok(Ready(())) [INFO] [stdout] stack backtrace: [INFO] [stdout] 0: 0x5777cbbc1982 - std::backtrace_rs::backtrace::libunwind::trace::h589a96ef7638b383 [INFO] [stdout] at /rustc/b83b707f97d809763b7861afa7638871f3339a33/library/std/src/../../backtrace/src/backtrace/libunwind.rs:117:9 [INFO] [stdout] 1: 0x5777cbbc1982 - std::backtrace_rs::backtrace::trace_unsynchronized::h23a30a7548c40de4 [INFO] [stdout] at /rustc/b83b707f97d809763b7861afa7638871f3339a33/library/std/src/../../backtrace/src/backtrace/mod.rs:66:14 [INFO] [stdout] 2: 0x5777cbbc1982 - std::sys::backtrace::_print_fmt::h87dabd6535c8c07a [INFO] [stdout] at /rustc/b83b707f97d809763b7861afa7638871f3339a33/library/std/src/sys/backtrace.rs:66:9 [INFO] [stdout] 3: 0x5777cbbc1982 - ::fmt::hffd20ad4e5eca8ab [INFO] [stdout] at /rustc/b83b707f97d809763b7861afa7638871f3339a33/library/std/src/sys/backtrace.rs:39:26 [INFO] [stdout] 4: 0x5777cbbd1bff - core::fmt::rt::Argument::fmt::h75c83e3fd5ce2419 [INFO] [stdout] at /rustc/b83b707f97d809763b7861afa7638871f3339a33/library/core/src/fmt/rt.rs:173:76 [INFO] [stdout] 5: 0x5777cbbd1bff - core::fmt::write::h6d9d3a7cfd7b84f5 [INFO] [stdout] at /rustc/b83b707f97d809763b7861afa7638871f3339a33/library/core/src/fmt/mod.rs:1468:25 [INFO] [stdout] 6: 0x5777cbb8ee13 - std::io::default_write_fmt::he11a713685e2464d [INFO] [stdout] at /rustc/b83b707f97d809763b7861afa7638871f3339a33/library/std/src/io/mod.rs:639:11 [INFO] [stdout] 7: 0x5777cbb8ee13 - std::io::Write::write_fmt::h9d08f7e050bd2612 [INFO] [stdout] at /rustc/b83b707f97d809763b7861afa7638871f3339a33/library/std/src/io/mod.rs:1954:13 [INFO] [stdout] 8: 0x5777cbb9acb2 - std::sys::backtrace::BacktraceLock::print::hb28797143397220e [INFO] [stdout] at /rustc/b83b707f97d809763b7861afa7638871f3339a33/library/std/src/sys/backtrace.rs:42:9 [INFO] [stdout] 9: 0x5777cbb9f9af - std::panicking::default_hook::{{closure}}::h7555113b62983743 [INFO] [stdout] at /rustc/b83b707f97d809763b7861afa7638871f3339a33/library/std/src/panicking.rs:301:27 [INFO] [stdout] 10: 0x5777cbb9f841 - std::panicking::default_hook::h2714b564abe8d914 [INFO] [stdout] at /rustc/b83b707f97d809763b7861afa7638871f3339a33/library/std/src/panicking.rs:325:9 [INFO] [stdout] 11: 0x5777cbb3e05e - as core::ops::function::Fn>::call::h0e9de8cceb22406e [INFO] [stdout] at /rustc/b83b707f97d809763b7861afa7638871f3339a33/library/alloc/src/boxed.rs:1999:9 [INFO] [stdout] 12: 0x5777cbb3e05e - test::test_main_with_exit_callback::{{closure}}::h8125bd66cf4739d0 [INFO] [stdout] at /rustc/b83b707f97d809763b7861afa7638871f3339a33/library/test/src/lib.rs:145:21 [INFO] [stdout] 13: 0x5777cbba004e - as core::ops::function::Fn>::call::h1fd0a0802eaec16b [INFO] [stdout] at /rustc/b83b707f97d809763b7861afa7638871f3339a33/library/alloc/src/boxed.rs:1999:9 [INFO] [stdout] 14: 0x5777cbba004e - std::panicking::panic_with_hook::h190dc82263685ec5 [INFO] [stdout] at /rustc/b83b707f97d809763b7861afa7638871f3339a33/library/std/src/panicking.rs:842:13 [INFO] [stdout] 15: 0x5777cbb9fe1a - std::panicking::panic_handler::{{closure}}::h8b036a1b366643ac [INFO] [stdout] at /rustc/b83b707f97d809763b7861afa7638871f3339a33/library/std/src/panicking.rs:707:13 [INFO] [stdout] 16: 0x5777cbb9ade9 - std::sys::backtrace::__rust_end_short_backtrace::h45affcfc0c830da8 [INFO] [stdout] at /rustc/b83b707f97d809763b7861afa7638871f3339a33/library/std/src/sys/backtrace.rs:174:18 [INFO] [stdout] 17: 0x5777cbb8307d - __rustc[9b67c8562bba447b]::rust_begin_unwind [INFO] [stdout] at /rustc/b83b707f97d809763b7861afa7638871f3339a33/library/std/src/panicking.rs:698:5 [INFO] [stdout] 18: 0x5777cbbd9b70 - core::panicking::panic_fmt::hc084f85b1e76c16d [INFO] [stdout] at /rustc/b83b707f97d809763b7861afa7638871f3339a33/library/core/src/panicking.rs:75:14 [INFO] [stdout] 19: 0x5777cbbd9973 - core::panicking::assert_failed_inner::h1215dc8d5a90adff [INFO] [stdout] at /rustc/b83b707f97d809763b7861afa7638871f3339a33/library/core/src/panicking.rs:439:17 [INFO] [stdout] 20: 0x5777cbaef210 - core::panicking::assert_failed::h336f1f3b6e193ed3 [INFO] [stdout] at /rustc/b83b707f97d809763b7861afa7638871f3339a33/library/core/src/panicking.rs:394:5 [INFO] [stdout] 21: 0x5777cbb091cf - comms::client::tests::stream_and_sink_separate::{{closure}}::h8490e26f5a94a032 [INFO] [stdout] at /opt/rustwide/workdir/src/client/mod.rs:442:17 [INFO] [stdout] 22: 0x5777cbaf88d3 - futures::future::lazy::Lazy::get::h80b871b246e9b1fd [INFO] [stdout] at /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/futures-0.1.31/src/future/lazy.rs:64:59 [INFO] [stdout] 23: 0x5777cbafa4ca - as futures::future::Future>::poll::h81bb1652a1ab3c02 [INFO] [stdout] at /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/futures-0.1.31/src/future/lazy.rs:82:14 [INFO] [stdout] 24: 0x5777cbad967e - futures::task_impl::Spawn::poll_future_notify::{{closure}}::h8ed1eee387214f68 [INFO] [stdout] at /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/futures-0.1.31/src/task_impl/mod.rs:329:47 [INFO] [stdout] 25: 0x5777cbadaf0d - futures::task_impl::Spawn::enter::{{closure}}::he2f0ae24db262f0c [INFO] [stdout] at /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/futures-0.1.31/src/task_impl/mod.rs:399:27 [INFO] [stdout] 26: 0x5777cbae116e - futures::task_impl::std::set::h95c70fc74a07dc98 [INFO] [stdout] at /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/futures-0.1.31/src/task_impl/std/mod.rs:86:13 [INFO] [stdout] 27: 0x5777cbada1e1 - futures::task_impl::Spawn::enter::h5c00b6c49cd691eb [INFO] [stdout] at /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/futures-0.1.31/src/task_impl/mod.rs:399:9 [INFO] [stdout] 28: 0x5777cbad8f24 - futures::task_impl::Spawn::poll_fn_notify::hf655902b2d8c8f69 [INFO] [stdout] at /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/futures-0.1.31/src/task_impl/mod.rs:291:14 [INFO] [stdout] 29: 0x5777cbad9307 - futures::task_impl::Spawn::poll_future_notify::h1e4ddb9fbf817b16 [INFO] [stdout] at /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/futures-0.1.31/src/task_impl/mod.rs:329:14 [INFO] [stdout] 30: 0x5777cbae345e - futures::task_impl::std::>::wait_future::{{closure}}::hedcd771e9db53a3a [INFO] [stdout] at /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/futures-0.1.31/src/task_impl/std/mod.rs:239:28 [INFO] [stdout] 31: 0x5777cbadf3a3 - futures::task_impl::std::ThreadNotify::with_current::{{closure}}::h203ee22a2fdc77b0 [INFO] [stdout] at /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/futures-0.1.31/src/task_impl/std/mod.rs:486:45 [INFO] [stdout] 32: 0x5777cbaf12a8 - std::thread::local::LocalKey::try_with::hb3a7a8585a9df6aa [INFO] [stdout] at /rustc/b83b707f97d809763b7861afa7638871f3339a33/library/std/src/thread/local.rs:315:12 [INFO] [stdout] 33: 0x5777cbaf0213 - std::thread::local::LocalKey::with::h1ae98590be935d41 [INFO] [stdout] at /rustc/b83b707f97d809763b7861afa7638871f3339a33/library/std/src/thread/local.rs:279:20 [INFO] [stdout] 34: 0x5777cbadf184 - futures::task_impl::std::ThreadNotify::with_current::h882a8f807694f252 [INFO] [stdout] at /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/futures-0.1.31/src/task_impl/std/mod.rs:486:31 [INFO] [stdout] 35: 0x5777cbadb2ed - futures::task_impl::std::>::wait_future::h9a6612a1733e6492 [INFO] [stdout] at /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/futures-0.1.31/src/task_impl/std/mod.rs:236:9 [INFO] [stdout] 36: 0x5777cbaf9cf1 - futures::future::Future::wait::h57aac06a754bf51a [INFO] [stdout] at /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/futures-0.1.31/src/future/mod.rs:300:33 [INFO] [stdout] 37: 0x5777cbb085c5 - comms::client::tests::stream_and_sink_separate::h2dc8d90631acff1b [INFO] [stdout] at /opt/rustwide/workdir/src/client/mod.rs:463:14 [INFO] [stdout] 38: 0x5777cbb086d7 - comms::client::tests::stream_and_sink_separate::{{closure}}::h5578020cf2646e75 [INFO] [stdout] at /opt/rustwide/workdir/src/client/mod.rs:412:34 [INFO] [stdout] 39: 0x5777cbaea086 - core::ops::function::FnOnce::call_once::h3275b908c6591a0e [INFO] [stdout] at /rustc/b83b707f97d809763b7861afa7638871f3339a33/library/core/src/ops/function.rs:253:5 [INFO] [stdout] 40: 0x5777cbb3de1b - core::ops::function::FnOnce::call_once::hdbf42be2a49fb464 [INFO] [stdout] at /rustc/b83b707f97d809763b7861afa7638871f3339a33/library/core/src/ops/function.rs:253:5 [INFO] [stdout] 41: 0x5777cbb3de1b - test::__rust_begin_short_backtrace::h8ae08814d38cb356 [INFO] [stdout] at /rustc/b83b707f97d809763b7861afa7638871f3339a33/library/test/src/lib.rs:663:18 [INFO] [stdout] 42: 0x5777cbb53905 - test::run_test_in_process::{{closure}}::h54574ee4f414d690 [INFO] [stdout] at /rustc/b83b707f97d809763b7861afa7638871f3339a33/library/test/src/lib.rs:686:74 [INFO] [stdout] 43: 0x5777cbb53905 - as core::ops::function::FnOnce<()>>::call_once::h01a0b7e7aad1a501 [INFO] [stdout] at /rustc/b83b707f97d809763b7861afa7638871f3339a33/library/core/src/panic/unwind_safe.rs:272:9 [INFO] [stdout] 44: 0x5777cbb53905 - std::panicking::catch_unwind::do_call::h23820e817c5612cd [INFO] [stdout] at /rustc/b83b707f97d809763b7861afa7638871f3339a33/library/std/src/panicking.rs:590:40 [INFO] [stdout] 45: 0x5777cbb53905 - std::panicking::catch_unwind::h89c73a1febce5587 [INFO] [stdout] at /rustc/b83b707f97d809763b7861afa7638871f3339a33/library/std/src/panicking.rs:553:19 [INFO] [stdout] 46: 0x5777cbb53905 - std::panic::catch_unwind::h6f55caf410861914 [INFO] [stdout] at /rustc/b83b707f97d809763b7861afa7638871f3339a33/library/std/src/panic.rs:359:14 [INFO] [stdout] 47: 0x5777cbb53905 - test::run_test_in_process::h4db851878e5d3983 [INFO] [stdout] at /rustc/b83b707f97d809763b7861afa7638871f3339a33/library/test/src/lib.rs:686:27 [INFO] [stdout] 48: 0x5777cbb53905 - test::run_test::{{closure}}::h57e8c5acaceacd24 [INFO] [stdout] at /rustc/b83b707f97d809763b7861afa7638871f3339a33/library/test/src/lib.rs:607:43 [INFO] [stdout] 49: 0x5777cbb2a2f4 - test::run_test::{{closure}}::he775ccc3a9d3b97e [INFO] [stdout] at /rustc/b83b707f97d809763b7861afa7638871f3339a33/library/test/src/lib.rs:637:41 [INFO] [stdout] 50: 0x5777cbb2a2f4 - std::sys::backtrace::__rust_begin_short_backtrace::hcd94d85d7765225a [INFO] [stdout] at /rustc/b83b707f97d809763b7861afa7638871f3339a33/library/std/src/sys/backtrace.rs:158:18 [INFO] [stdout] 51: 0x5777cbb2db3a - std::thread::Builder::spawn_unchecked_::{{closure}}::{{closure}}::ha814de8393f07830 [INFO] [stdout] at /rustc/b83b707f97d809763b7861afa7638871f3339a33/library/std/src/thread/mod.rs:559:17 [INFO] [stdout] 52: 0x5777cbb2db3a - as core::ops::function::FnOnce<()>>::call_once::h8deb00af0abdeaf1 [INFO] [stdout] at /rustc/b83b707f97d809763b7861afa7638871f3339a33/library/core/src/panic/unwind_safe.rs:272:9 [INFO] [stdout] 53: 0x5777cbb2db3a - std::panicking::catch_unwind::do_call::h1917979b0c279ea2 [INFO] [stdout] at /rustc/b83b707f97d809763b7861afa7638871f3339a33/library/std/src/panicking.rs:590:40 [INFO] [stdout] 54: 0x5777cbb2db3a - std::panicking::catch_unwind::h791ad91fee6ce34e [INFO] [stdout] at /rustc/b83b707f97d809763b7861afa7638871f3339a33/library/std/src/panicking.rs:553:19 [INFO] [stdout] 55: 0x5777cbb2db3a - std::panic::catch_unwind::h982b8f40ed9c3cce [INFO] [stdout] at /rustc/b83b707f97d809763b7861afa7638871f3339a33/library/std/src/panic.rs:359:14 [INFO] [stdout] 56: 0x5777cbb2db3a - std::thread::Builder::spawn_unchecked_::{{closure}}::h545e54700c945db4 [INFO] [stdout] at /rustc/b83b707f97d809763b7861afa7638871f3339a33/library/std/src/thread/mod.rs:557:30 [INFO] [stdout] 57: 0x5777cbb2db3a - core::ops::function::FnOnce::call_once{{vtable.shim}}::hb427481a5227d78a [INFO] [stdout] at /rustc/b83b707f97d809763b7861afa7638871f3339a33/library/core/src/ops/function.rs:253:5 [INFO] [stdout] 58: 0x5777cbb94f8f - as core::ops::function::FnOnce>::call_once::h1d452951a81e9d0a [INFO] [stdout] at /rustc/b83b707f97d809763b7861afa7638871f3339a33/library/alloc/src/boxed.rs:1985:9 [INFO] [stdout] 59: 0x5777cbb94f8f - std::sys::pal::unix::thread::Thread::new::thread_start::h29c84e109630689a [INFO] [stdout] at /rustc/b83b707f97d809763b7861afa7638871f3339a33/library/std/src/sys/pal/unix/thread.rs:118:17 [INFO] [stdout] 60: 0x735315587aa4 - [INFO] [stdout] 61: 0x735315614a34 - clone [INFO] [stdout] 62: 0x0 - [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] failures: [INFO] [stdout] client::tests::stream_and_sink_separate [INFO] [stdout] [INFO] [stdout] test result: FAILED. 21 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 11.54s [INFO] [stdout] [INFO] [stderr] error: test failed, to rerun pass `--lib` [INFO] running `Command { std: "docker" "inspect" "c28b4b61786f9bc176e3d86c25e5cd77c6702cd81bbe91664807b8f3c2657f59", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c28b4b61786f9bc176e3d86c25e5cd77c6702cd81bbe91664807b8f3c2657f59", kill_on_drop: false }` [INFO] [stdout] c28b4b61786f9bc176e3d86c25e5cd77c6702cd81bbe91664807b8f3c2657f59