[INFO] cloning repository https://github.com/missingdays/rust-clippy-test [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/missingdays/rust-clippy-test" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmissingdays%2Frust-clippy-test", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmissingdays%2Frust-clippy-test'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3ee7844a9752a6d42efc1207abc4f2ca1c648a8e [INFO] testing missingdays/rust-clippy-test against try#b83b707f97d809763b7861afa7638871f3339a33 for pr-145838-1 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmissingdays%2Frust-clippy-test" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/missingdays/rust-clippy-test [INFO] finished tweaking git repo https://github.com/missingdays/rust-clippy-test [INFO] tweaked toml for git repo https://github.com/missingdays/rust-clippy-test written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/missingdays/rust-clippy-test on toolchain b83b707f97d809763b7861afa7638871f3339a33 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+b83b707f97d809763b7861afa7638871f3339a33" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/missingdays/rust-clippy-test already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+b83b707f97d809763b7861afa7638871f3339a33" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+b83b707f97d809763b7861afa7638871f3339a33" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7009a00f425bcf2978602c9e9263c54b8324a7808c4f4a08b366378b1741c265 [INFO] running `Command { std: "docker" "start" "-a" "7009a00f425bcf2978602c9e9263c54b8324a7808c4f4a08b366378b1741c265", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7009a00f425bcf2978602c9e9263c54b8324a7808c4f4a08b366378b1741c265", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7009a00f425bcf2978602c9e9263c54b8324a7808c4f4a08b366378b1741c265", kill_on_drop: false }` [INFO] [stdout] 7009a00f425bcf2978602c9e9263c54b8324a7808c4f4a08b366378b1741c265 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+b83b707f97d809763b7861afa7638871f3339a33" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1e1b247843eb9bf23326a4574c31ca8dc062be73d4f97ccc95d910e578f577a1 [INFO] running `Command { std: "docker" "start" "-a" "1e1b247843eb9bf23326a4574c31ca8dc062be73d4f97ccc95d910e578f577a1", kill_on_drop: false }` [INFO] [stderr] Compiling clippy2 v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::cell::RefCell` [INFO] [stdout] --> clippy2.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use std::cell::RefCell; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y` [INFO] [stdout] --> clippy2.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | let y = 1_f64 / x; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_y` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> clippy2.rs:11:14 [INFO] [stdout] | [INFO] [stdout] 11 | for x in option { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 11 - for x in option { [INFO] [stdout] 11 + while let Some(x) = option { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 11 - for x in option { [INFO] [stdout] 11 + if let Some(x) = option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.60s [INFO] running `Command { std: "docker" "inspect" "1e1b247843eb9bf23326a4574c31ca8dc062be73d4f97ccc95d910e578f577a1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1e1b247843eb9bf23326a4574c31ca8dc062be73d4f97ccc95d910e578f577a1", kill_on_drop: false }` [INFO] [stdout] 1e1b247843eb9bf23326a4574c31ca8dc062be73d4f97ccc95d910e578f577a1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+b83b707f97d809763b7861afa7638871f3339a33" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d09a523816ed5c2e6229971a8e5ab82edef912e68baede731f3ecd2c5bd105c2 [INFO] running `Command { std: "docker" "start" "-a" "d09a523816ed5c2e6229971a8e5ab82edef912e68baede731f3ecd2c5bd105c2", kill_on_drop: false }` [INFO] [stderr] Compiling clippy2 v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::cell::RefCell` [INFO] [stdout] --> clippy2.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use std::cell::RefCell; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y` [INFO] [stdout] --> clippy2.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | let y = 1_f64 / x; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_y` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> clippy2.rs:11:14 [INFO] [stdout] | [INFO] [stdout] 11 | for x in option { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 11 - for x in option { [INFO] [stdout] 11 + while let Some(x) = option { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 11 - for x in option { [INFO] [stdout] 11 + if let Some(x) = option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `test` profile [unoptimized + debuginfo] target(s) in 0.36s [INFO] running `Command { std: "docker" "inspect" "d09a523816ed5c2e6229971a8e5ab82edef912e68baede731f3ecd2c5bd105c2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d09a523816ed5c2e6229971a8e5ab82edef912e68baede731f3ecd2c5bd105c2", kill_on_drop: false }` [INFO] [stdout] d09a523816ed5c2e6229971a8e5ab82edef912e68baede731f3ecd2c5bd105c2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+b83b707f97d809763b7861afa7638871f3339a33" "test" "--frozen", kill_on_drop: false }` [INFO] [stdout] 900906193af799406c59b8b3f965588ee420acf69aa5abc18fc8a3cbb7c72a47 [INFO] running `Command { std: "docker" "start" "-a" "900906193af799406c59b8b3f965588ee420acf69aa5abc18fc8a3cbb7c72a47", kill_on_drop: false }` [INFO] [stderr] warning: unused import: `std::cell::RefCell` [INFO] [stderr] --> clippy2.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::cell::RefCell; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y` [INFO] [stderr] --> clippy2.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | let y = 1_f64 / x; [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_y` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stderr] [INFO] [stderr] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stderr] --> clippy2.rs:11:14 [INFO] [stderr] | [INFO] [stderr] 11 | for x in option { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stderr] help: to check pattern in a loop use `while let` [INFO] [stderr] | [INFO] [stderr] 11 - for x in option { [INFO] [stderr] 11 + while let Some(x) = option { [INFO] [stderr] | [INFO] [stderr] help: consider using `if let` to clear intent [INFO] [stderr] | [INFO] [stderr] 11 - for x in option { [INFO] [stderr] 11 + if let Some(x) = option { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `clippy2` (bin "clippy2" test) generated 3 warnings (run `cargo fix --bin "clippy2" --tests` to apply 1 suggestion) [INFO] [stderr] Finished `test` profile [unoptimized + debuginfo] target(s) in 0.05s [INFO] [stderr] Running unittests clippy2.rs (/opt/rustwide/target/debug/deps/clippy2-16c0aec0be6b826e) [INFO] [stdout] [INFO] [stdout] running 0 tests [INFO] [stdout] [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "900906193af799406c59b8b3f965588ee420acf69aa5abc18fc8a3cbb7c72a47", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "900906193af799406c59b8b3f965588ee420acf69aa5abc18fc8a3cbb7c72a47", kill_on_drop: false }` [INFO] [stdout] 900906193af799406c59b8b3f965588ee420acf69aa5abc18fc8a3cbb7c72a47