[INFO] fetching crate hammersbald 3.0.1... [INFO] testing hammersbald-3.0.1 against master#cdb45c87e2cd43495379f7e867e3cc15dcee9f93 for pr-145838-1 [INFO] extracting crate hammersbald 3.0.1 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate hammersbald 3.0.1 [INFO] finished tweaking crates.io crate hammersbald 3.0.1 [INFO] tweaked toml for crates.io crate hammersbald 3.0.1 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate hammersbald 3.0.1 on toolchain cdb45c87e2cd43495379f7e867e3cc15dcee9f93 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+cdb45c87e2cd43495379f7e867e3cc15dcee9f93" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+cdb45c87e2cd43495379f7e867e3cc15dcee9f93" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 28 packages to latest compatible versions [INFO] [stderr] Adding bitcoin v0.26.2 (available: v0.32.7) [INFO] [stderr] Adding bitcoin_hashes v0.9.7 (available: v0.16.0) [INFO] [stderr] Adding hex v0.3.2 (available: v0.4.3) [INFO] [stderr] Adding rand v0.7.3 (available: v0.9.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+cdb45c87e2cd43495379f7e867e3cc15dcee9f93" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded bitcoin v0.26.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+cdb45c87e2cd43495379f7e867e3cc15dcee9f93" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a9f98bb2ec7dcd6324e9028e735d27773fd6b0a40d4db7b2a98104835f10f5d2 [INFO] running `Command { std: "docker" "start" "-a" "a9f98bb2ec7dcd6324e9028e735d27773fd6b0a40d4db7b2a98104835f10f5d2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a9f98bb2ec7dcd6324e9028e735d27773fd6b0a40d4db7b2a98104835f10f5d2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a9f98bb2ec7dcd6324e9028e735d27773fd6b0a40d4db7b2a98104835f10f5d2", kill_on_drop: false }` [INFO] [stdout] a9f98bb2ec7dcd6324e9028e735d27773fd6b0a40d4db7b2a98104835f10f5d2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+cdb45c87e2cd43495379f7e867e3cc15dcee9f93" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 15b08911cf3fd715235a28f6fe9e212adb22e491677248485044fc162e331d34 [INFO] running `Command { std: "docker" "start" "-a" "15b08911cf3fd715235a28f6fe9e212adb22e491677248485044fc162e331d34", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] [stderr] Compiling bitcoin_hashes v0.9.7 [INFO] [stderr] Compiling hammersbald v3.0.1 (/opt/rustwide/workdir) [INFO] [stdout] error: variable does not need to be mutable [INFO] [stdout] --> src/memtable.rs:190:29 [INFO] [stdout] | [INFO] [stdout] 190 | if let Some(mut bucket) = self.buckets.write().unwrap().get_mut(bucket_number) { [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | #![deny(unused_mut)] [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `PagedFileRead` is never used [INFO] [stdout] --> src/pagedfile.rs:47:11 [INFO] [stdout] | [INFO] [stdout] 47 | pub trait PagedFileRead { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `PagedFileWrite` is never used [INFO] [stdout] --> src/pagedfile.rs:52:11 [INFO] [stdout] | [INFO] [stdout] 52 | pub trait PagedFileWrite { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/pagedfile.rs:171:59 [INFO] [stdout] | [INFO] [stdout] 171 | pub fn new(file: &'file dyn PagedFile, pref: PRef) -> PagedFileIterator { [INFO] [stdout] | ----- the lifetime is named here ^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: consistently use `'file` [INFO] [stdout] | [INFO] [stdout] 171 | pub fn new(file: &'file dyn PagedFile, pref: PRef) -> PagedFileIterator<'file> { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/logfile.rs:51:22 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn page_iter(&self) -> PagedFileIterator { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 51 | pub fn page_iter(&self) -> PagedFileIterator<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/rolledfile.rs:63:58 [INFO] [stdout] | [INFO] [stdout] 63 | ... let ni = Path::new(name_index.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `OsStr` does not implement `Clone`, so calling `clone` on `&OsStr` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 63 - let ni = Path::new(name_index.clone()); [INFO] [stdout] 63 + let ni = Path::new(name_index); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/format.rs:84:51 [INFO] [stdout] | [INFO] [stdout] 84 | pub fn deserialize(slice: &'e [u8]) -> Result { [INFO] [stdout] | -- ^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is named here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: consistently use `'e` [INFO] [stdout] | [INFO] [stdout] 84 | pub fn deserialize(slice: &'e [u8]) -> Result, Error> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/format.rs:115:44 [INFO] [stdout] | [INFO] [stdout] 115 | pub fn deserialize(slice: &'e [u8]) -> Data { [INFO] [stdout] | -- ^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is named here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: consistently use `'e` [INFO] [stdout] | [INFO] [stdout] 115 | pub fn deserialize(slice: &'e [u8]) -> Data<'e> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/api.rs:84:13 [INFO] [stdout] | [INFO] [stdout] 84 | fn iter(&self) -> HammersbaldIterator; [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 84 | fn iter(&self) -> HammersbaldIterator<'_>; [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/api.rs:241:13 [INFO] [stdout] | [INFO] [stdout] 241 | fn iter(&self) -> HammersbaldIterator { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 241 | fn iter(&self) -> HammersbaldIterator<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hammersbald` (lib) due to 1 previous error; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "15b08911cf3fd715235a28f6fe9e212adb22e491677248485044fc162e331d34", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "15b08911cf3fd715235a28f6fe9e212adb22e491677248485044fc162e331d34", kill_on_drop: false }` [INFO] [stdout] 15b08911cf3fd715235a28f6fe9e212adb22e491677248485044fc162e331d34