[INFO] fetching crate git_rs 0.1.0... [INFO] testing git_rs-0.1.0 against master#cdb45c87e2cd43495379f7e867e3cc15dcee9f93 for pr-145838-1 [INFO] extracting crate git_rs 0.1.0 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate git_rs 0.1.0 [INFO] finished tweaking crates.io crate git_rs 0.1.0 [INFO] tweaked toml for crates.io crate git_rs 0.1.0 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate git_rs 0.1.0 on toolchain cdb45c87e2cd43495379f7e867e3cc15dcee9f93 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+cdb45c87e2cd43495379f7e867e3cc15dcee9f93" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+cdb45c87e2cd43495379f7e867e3cc15dcee9f93" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 80 packages to latest compatible versions [INFO] [stderr] Adding crc v1.8.1 (available: v3.3.0) [INFO] [stderr] Adding hex v0.3.2 (available: v0.4.3) [INFO] [stderr] Adding lru v0.1.17 (available: v0.16.0) [INFO] [stderr] Adding wasi v0.10.0+wasi-snapshot-preview1 (available: v0.10.2+wasi-snapshot-preview1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+cdb45c87e2cd43495379f7e867e3cc15dcee9f93" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded build_const v0.2.2 [INFO] [stderr] Downloaded lru v0.1.17 [INFO] [stderr] Downloaded hashbrown v0.5.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+cdb45c87e2cd43495379f7e867e3cc15dcee9f93" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 25ac2fb46c158677cfbe5297135a042fa2a01907193d2480e50fd5a22b7ac381 [INFO] running `Command { std: "docker" "start" "-a" "25ac2fb46c158677cfbe5297135a042fa2a01907193d2480e50fd5a22b7ac381", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "25ac2fb46c158677cfbe5297135a042fa2a01907193d2480e50fd5a22b7ac381", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "25ac2fb46c158677cfbe5297135a042fa2a01907193d2480e50fd5a22b7ac381", kill_on_drop: false }` [INFO] [stdout] 25ac2fb46c158677cfbe5297135a042fa2a01907193d2480e50fd5a22b7ac381 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+cdb45c87e2cd43495379f7e867e3cc15dcee9f93" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fb38bd69a33b0fa00a37a62df826bcd0601067302f483f30347fbe3889652941 [INFO] running `Command { std: "docker" "start" "-a" "fb38bd69a33b0fa00a37a62df826bcd0601067302f483f30347fbe3889652941", kill_on_drop: false }` [INFO] [stderr] Compiling gcc v0.3.55 [INFO] [stderr] Compiling build_const v0.2.2 [INFO] [stderr] Compiling hashbrown v0.5.0 [INFO] [stderr] Compiling rustc-serialize v0.3.25 [INFO] [stderr] Compiling error-chain v0.12.4 [INFO] [stderr] Compiling time v0.1.45 [INFO] [stderr] Compiling memmap v0.7.0 [INFO] [stderr] Compiling hex v0.3.2 [INFO] [stderr] Compiling backtrace v0.3.75 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling crc v1.8.1 [INFO] [stderr] Compiling lru v0.1.17 [INFO] [stderr] Compiling rust-crypto v0.2.36 [INFO] [stderr] Compiling chrono v0.4.41 [INFO] [stderr] Compiling git_rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/id.rs:21:10 [INFO] [stdout] | [INFO] [stdout] 21 | 0...9 => (inp + 48) as char, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(ellipsis_inclusive_range_patterns)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/id.rs:22:11 [INFO] [stdout] | [INFO] [stdout] 22 | 10...16 => (inp + 87) as char, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/id.rs:45:20 [INFO] [stdout] | [INFO] [stdout] 45 | 48 ... 57 => xs - 48, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/id.rs:46:20 [INFO] [stdout] | [INFO] [stdout] 46 | 97 ... 102 => xs - 97 + 10, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/id.rs:47:20 [INFO] [stdout] | [INFO] [stdout] 47 | 65 ... 70 => xs - 65 + 10, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `has_error_description_deprecated` [INFO] [stdout] --> src/errors.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / error_chain! { [INFO] [stdout] 2 | | foreign_links { [INFO] [stdout] 3 | | Io(::std::io::Error); [INFO] [stdout] 4 | | Encoding(::std::str::Utf8Error); [INFO] [stdout] ... | [INFO] [stdout] 20 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `docsrs`, `feature`, and `test` and 31 more [INFO] [stdout] = note: using a cfg inside a macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `impl_error_chain_processed` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the macro `impl_error_chain_processed` may come from an old version of the `error_chain` crate, try updating your dependency with `cargo update -p error_chain` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] = note: this warning originates in the macro `impl_error_chain_processed` which comes from the expansion of the macro `error_chain` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/stores/loose.rs:52:10 [INFO] [stdout] | [INFO] [stdout] 52 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/objects/commit.rs:59:10 [INFO] [stdout] | [INFO] [stdout] 59 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Cursor` [INFO] [stdout] --> src/pack/index.rs:4:16 [INFO] [stdout] | [INFO] [stdout] 4 | use std::io::{ Cursor, SeekFrom }; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/pack/index.rs:168:8 [INFO] [stdout] | [INFO] [stdout] 168 | if (&magic != b"\xfftOc") { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 168 - if (&magic != b"\xfftOc") { [INFO] [stdout] 168 + if &magic != b"\xfftOc" { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/pack/index.rs:172:8 [INFO] [stdout] | [INFO] [stdout] 172 | if (version != unsafe { std::mem::transmute::(2u32.to_be()) }) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 172 - if (version != unsafe { std::mem::transmute::(2u32.to_be()) }) { [INFO] [stdout] 172 + if version != unsafe { std::mem::transmute::(2u32.to_be()) } { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/pack/read.rs:35:10 [INFO] [stdout] | [INFO] [stdout] 35 | 0...4 => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/stores/loose.rs:10:15 [INFO] [stdout] | [INFO] [stdout] 10 | type Reader = Fn(&Id) -> Result>> + Send + Sync; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 10 | type Reader = dyn Fn(&Id) -> Result>> + Send + Sync; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/stores/loose.rs:10:44 [INFO] [stdout] | [INFO] [stdout] 10 | type Reader = Fn(&Id) -> Result>> + Send + Sync; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 10 | type Reader = Fn(&Id) -> Result>> + Send + Sync; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/pack/any.rs:15:15 [INFO] [stdout] | [INFO] [stdout] 15 | read: Box Result>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 15 | read: Box Result>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/pack/any.rs:12:22 [INFO] [stdout] | [INFO] [stdout] 12 | pub type GetObject = Fn(&Id) -> Result)>>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 12 | pub type GetObject = dyn Fn(&Id) -> Result)>>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/pack/any.rs:12:58 [INFO] [stdout] | [INFO] [stdout] 12 | pub type GetObject = Fn(&Id) -> Result)>>; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 12 | pub type GetObject = Fn(&Id) -> Result)>>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/stores/loose.rs:19:47 [INFO] [stdout] | [INFO] [stdout] 19 | where C: Fn(&Id) -> Result>> + 'static + Send + Sync { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 19 | where C: Fn(&Id) -> Result>> + 'static + Send + Sync { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDateTime::from_timestamp_opt`: use `DateTime::from_timestamp` instead [INFO] [stdout] --> src/identity.rs:95:46 [INFO] [stdout] | [INFO] [stdout] 95 | let naive = match NaiveDateTime::from_timestamp_opt(timestamp, 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::DateTime::::from_utc`: Use TimeZone::from_utc_datetime() or DateTime::from_naive_utc_and_offset instead [INFO] [stdout] --> src/identity.rs:100:39 [INFO] [stdout] | [INFO] [stdout] 100 | let dt = DateTime::::from_utc(naive, Utc); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `mode` [INFO] [stdout] --> src/stores/loose.rs:53:17 [INFO] [stdout] | [INFO] [stdout] 53 | let mut mode = Mode::FindSpace; [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_mode` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/stores/loose.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | let mut mode = Mode::FindSpace; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `id` [INFO] [stdout] --> src/stores/mod.rs:20:43 [INFO] [stdout] | [INFO] [stdout] 20 | fn get(&self, id: &Id, _output: &mut W, _backends: &StorageSet) -> Result> { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `end` [INFO] [stdout] --> src/pack/any.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | end: u64, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_end` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `size` is assigned to, but never used [INFO] [stdout] --> src/pack/read.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | let mut size = (byte[0] & 0xf) as u64; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_size` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `FindNull` is never constructed [INFO] [stdout] --> src/stores/loose.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 49 | enum Mode { [INFO] [stdout] | ---- variant in this enum [INFO] [stdout] 50 | FindSpace, [INFO] [stdout] 51 | FindNull [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `author` is never read [INFO] [stdout] --> src/objects/commit.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct Commit { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 11 | author: Option, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Commit` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `next` is never read [INFO] [stdout] --> src/pack/mod.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 17 | pub struct IndexEntry { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 21 | next: usize [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `IndexEntry` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/pack/mod.rs:38:20 [INFO] [stdout] | [INFO] [stdout] 38 | pub struct Fanout ([u32; 256]); [INFO] [stdout] | ------ ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `crcs` is never read [INFO] [stdout] --> src/pack/index.rs:237:5 [INFO] [stdout] | [INFO] [stdout] 232 | pub struct Index { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 237 | crcs: Vec, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `storage_set` is never read [INFO] [stdout] --> src/pack/iter.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct PackfileIterator<'a, R: BufRead + Seek + std::fmt::Debug, S: Queryable> { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 16 | storage_set: Option<&'a StorageSet> [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `kind` is never read [INFO] [stdout] --> src/refs.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 23 | pub struct Ref { [INFO] [stdout] | --- field in this struct [INFO] [stdout] 24 | kind: Kind, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Ref` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name`, `email`, and `offset` are never read [INFO] [stdout] --> src/identity.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct Identity { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 5 | name: Vec, [INFO] [stdout] | ^^^^ [INFO] [stdout] 6 | email: Vec, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 7 | at: DateTime, [INFO] [stdout] 8 | offset: FixedOffset [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Identity` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/stores/mod.rs:70:20 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn commits(&self, id: &Id, seen: Option>) -> CommitIterator { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 70 | pub fn commits(&self, id: &Id, seen: Option>) -> CommitIterator<'_, Q> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/stores/mod.rs:74:17 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn tree(&self, id: &Id) -> TreeIterator { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 74 | pub fn tree(&self, id: &Id) -> TreeIterator<'_, Q> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/stores/loose.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | reader.read_until(0x20, &mut type_vec); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 55 | let _ = reader.read_until(0x20, &mut type_vec); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/stores/loose.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | reader.read_until(0, &mut size_vec); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 56 | let _ = reader.read_until(0, &mut size_vec); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary transmute [INFO] [stdout] --> src/pack/index.rs:116:34 [INFO] [stdout] | [INFO] [stdout] 116 | let version_bytes = unsafe { std::mem::transmute::(2u32.to_be()) }; [INFO] [stdout] | -----------------------------------^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace this with: `u32::to_ne_bytes` [INFO] [stdout] | [INFO] [stdout] = help: there's also `to_le_bytes` and `to_be_bytes` if you expect a particular byte order [INFO] [stdout] = note: `#[warn(unnecessary_transmutes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary transmute [INFO] [stdout] --> src/pack/index.rs:131:34 [INFO] [stdout] | [INFO] [stdout] 131 | let crc_bytes = unsafe { std::mem::transmute::(crc) }; [INFO] [stdout] | -----------------------------------^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace this with: `u32::to_ne_bytes` [INFO] [stdout] | [INFO] [stdout] = help: there's also `to_le_bytes` and `to_be_bytes` if you expect a particular byte order [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary transmute [INFO] [stdout] --> src/pack/index.rs:137:37 [INFO] [stdout] | [INFO] [stdout] 137 | let offset_bytes = unsafe { std::mem::transmute::(offset) }; [INFO] [stdout] | -----------------------------------^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace this with: `u32::to_ne_bytes` [INFO] [stdout] | [INFO] [stdout] = help: there's also `to_le_bytes` and `to_be_bytes` if you expect a particular byte order [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary transmute [INFO] [stdout] --> src/pack/index.rs:143:43 [INFO] [stdout] | [INFO] [stdout] 143 | let large_offset_bytes = unsafe { std::mem::transmute::(large_offset) }; [INFO] [stdout] | -----------------------------------^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace this with: `u64::to_ne_bytes` [INFO] [stdout] | [INFO] [stdout] = help: there's also `to_le_bytes` and `to_be_bytes` if you expect a particular byte order [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary transmute [INFO] [stdout] --> src/pack/index.rs:172:29 [INFO] [stdout] | [INFO] [stdout] 172 | if (version != unsafe { std::mem::transmute::(2u32.to_be()) }) { [INFO] [stdout] | -----------------------------------^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace this with: `u32::to_ne_bytes` [INFO] [stdout] | [INFO] [stdout] = help: there's also `to_le_bytes` and `to_be_bytes` if you expect a particular byte order [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/walk/tree.rs:18:94 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(storage_set: &'a StorageSet, layers: Vec, TreeEntry>>) -> TreeIterator { [INFO] [stdout] | -- the lifetime is named here ^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(storage_set: &'a StorageSet, layers: Vec, TreeEntry>>) -> TreeIterator<'a, S> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/bin/index_pack.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | write(cursor, &mut io::stdout(), Some(&storage_set)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 24 | let _ = write(cursor, &mut io::stdout(), Some(&storage_set)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.04s [INFO] running `Command { std: "docker" "inspect" "fb38bd69a33b0fa00a37a62df826bcd0601067302f483f30347fbe3889652941", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fb38bd69a33b0fa00a37a62df826bcd0601067302f483f30347fbe3889652941", kill_on_drop: false }` [INFO] [stdout] fb38bd69a33b0fa00a37a62df826bcd0601067302f483f30347fbe3889652941 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+cdb45c87e2cd43495379f7e867e3cc15dcee9f93" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d6f97a47849d1ff35b40845255296b260c66c8eb63817954cfac14a09b268ea6 [INFO] running `Command { std: "docker" "start" "-a" "d6f97a47849d1ff35b40845255296b260c66c8eb63817954cfac14a09b268ea6", kill_on_drop: false }` [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/id.rs:21:10 [INFO] [stdout] | [INFO] [stdout] 21 | 0...9 => (inp + 48) as char, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(ellipsis_inclusive_range_patterns)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/id.rs:22:11 [INFO] [stdout] | [INFO] [stdout] 22 | 10...16 => (inp + 87) as char, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/id.rs:45:20 [INFO] [stdout] | [INFO] [stdout] 45 | 48 ... 57 => xs - 48, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/id.rs:46:20 [INFO] [stdout] | [INFO] [stdout] 46 | 97 ... 102 => xs - 97 + 10, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/id.rs:47:20 [INFO] [stdout] | [INFO] [stdout] 47 | 65 ... 70 => xs - 65 + 10, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `has_error_description_deprecated` [INFO] [stdout] --> src/errors.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / error_chain! { [INFO] [stdout] 2 | | foreign_links { [INFO] [stdout] 3 | | Io(::std::io::Error); [INFO] [stdout] 4 | | Encoding(::std::str::Utf8Error); [INFO] [stdout] ... | [INFO] [stdout] 20 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `docsrs`, `feature`, and `test` and 31 more [INFO] [stdout] = note: using a cfg inside a macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `impl_error_chain_processed` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the macro `impl_error_chain_processed` may come from an old version of the `error_chain` crate, try updating your dependency with `cargo update -p error_chain` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] = note: this warning originates in the macro `impl_error_chain_processed` which comes from the expansion of the macro `error_chain` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/stores/loose.rs:52:10 [INFO] [stdout] | [INFO] [stdout] 52 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/objects/commit.rs:59:10 [INFO] [stdout] | [INFO] [stdout] 59 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Cursor` [INFO] [stdout] --> src/pack/index.rs:4:16 [INFO] [stdout] | [INFO] [stdout] 4 | use std::io::{ Cursor, SeekFrom }; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/pack/index.rs:168:8 [INFO] [stdout] | [INFO] [stdout] 168 | if (&magic != b"\xfftOc") { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 168 - if (&magic != b"\xfftOc") { [INFO] [stdout] 168 + if &magic != b"\xfftOc" { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/pack/index.rs:172:8 [INFO] [stdout] | [INFO] [stdout] 172 | if (version != unsafe { std::mem::transmute::(2u32.to_be()) }) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 172 - if (version != unsafe { std::mem::transmute::(2u32.to_be()) }) { [INFO] [stdout] 172 + if version != unsafe { std::mem::transmute::(2u32.to_be()) } { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/pack/read.rs:35:10 [INFO] [stdout] | [INFO] [stdout] 35 | 0...4 => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/stores/loose.rs:10:15 [INFO] [stdout] | [INFO] [stdout] 10 | type Reader = Fn(&Id) -> Result>> + Send + Sync; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 10 | type Reader = dyn Fn(&Id) -> Result>> + Send + Sync; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/stores/loose.rs:10:44 [INFO] [stdout] | [INFO] [stdout] 10 | type Reader = Fn(&Id) -> Result>> + Send + Sync; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 10 | type Reader = Fn(&Id) -> Result>> + Send + Sync; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling git_rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/pack/any.rs:15:15 [INFO] [stdout] | [INFO] [stdout] 15 | read: Box Result>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 15 | read: Box Result>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/pack/any.rs:12:22 [INFO] [stdout] | [INFO] [stdout] 12 | pub type GetObject = Fn(&Id) -> Result)>>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 12 | pub type GetObject = dyn Fn(&Id) -> Result)>>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/pack/any.rs:12:58 [INFO] [stdout] | [INFO] [stdout] 12 | pub type GetObject = Fn(&Id) -> Result)>>; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 12 | pub type GetObject = Fn(&Id) -> Result)>>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/stores/loose.rs:19:47 [INFO] [stdout] | [INFO] [stdout] 19 | where C: Fn(&Id) -> Result>> + 'static + Send + Sync { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 19 | where C: Fn(&Id) -> Result>> + 'static + Send + Sync { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDateTime::from_timestamp_opt`: use `DateTime::from_timestamp` instead [INFO] [stdout] --> src/identity.rs:95:46 [INFO] [stdout] | [INFO] [stdout] 95 | let naive = match NaiveDateTime::from_timestamp_opt(timestamp, 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::DateTime::::from_utc`: Use TimeZone::from_utc_datetime() or DateTime::from_naive_utc_and_offset instead [INFO] [stdout] --> src/identity.rs:100:39 [INFO] [stdout] | [INFO] [stdout] 100 | let dt = DateTime::::from_utc(naive, Utc); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `mode` [INFO] [stdout] --> src/stores/loose.rs:53:17 [INFO] [stdout] | [INFO] [stdout] 53 | let mut mode = Mode::FindSpace; [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_mode` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/stores/loose.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | let mut mode = Mode::FindSpace; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `id` [INFO] [stdout] --> src/stores/mod.rs:20:43 [INFO] [stdout] | [INFO] [stdout] 20 | fn get(&self, id: &Id, _output: &mut W, _backends: &StorageSet) -> Result> { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `end` [INFO] [stdout] --> src/pack/any.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | end: u64, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_end` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `size` is assigned to, but never used [INFO] [stdout] --> src/pack/read.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | let mut size = (byte[0] & 0xf) as u64; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_size` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `FindNull` is never constructed [INFO] [stdout] --> src/stores/loose.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 49 | enum Mode { [INFO] [stdout] | ---- variant in this enum [INFO] [stdout] 50 | FindSpace, [INFO] [stdout] 51 | FindNull [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `author` is never read [INFO] [stdout] --> src/objects/commit.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct Commit { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 11 | author: Option, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Commit` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `next` is never read [INFO] [stdout] --> src/pack/mod.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 17 | pub struct IndexEntry { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 21 | next: usize [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `IndexEntry` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/pack/mod.rs:38:20 [INFO] [stdout] | [INFO] [stdout] 38 | pub struct Fanout ([u32; 256]); [INFO] [stdout] | ------ ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `crcs` is never read [INFO] [stdout] --> src/pack/index.rs:237:5 [INFO] [stdout] | [INFO] [stdout] 232 | pub struct Index { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 237 | crcs: Vec, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `storage_set` is never read [INFO] [stdout] --> src/pack/iter.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct PackfileIterator<'a, R: BufRead + Seek + std::fmt::Debug, S: Queryable> { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 16 | storage_set: Option<&'a StorageSet> [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `kind` is never read [INFO] [stdout] --> src/refs.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 23 | pub struct Ref { [INFO] [stdout] | --- field in this struct [INFO] [stdout] 24 | kind: Kind, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Ref` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name`, `email`, and `offset` are never read [INFO] [stdout] --> src/identity.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct Identity { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 5 | name: Vec, [INFO] [stdout] | ^^^^ [INFO] [stdout] 6 | email: Vec, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 7 | at: DateTime, [INFO] [stdout] 8 | offset: FixedOffset [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Identity` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/stores/mod.rs:70:20 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn commits(&self, id: &Id, seen: Option>) -> CommitIterator { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 70 | pub fn commits(&self, id: &Id, seen: Option>) -> CommitIterator<'_, Q> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/stores/mod.rs:74:17 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn tree(&self, id: &Id) -> TreeIterator { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 74 | pub fn tree(&self, id: &Id) -> TreeIterator<'_, Q> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/stores/loose.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | reader.read_until(0x20, &mut type_vec); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 55 | let _ = reader.read_until(0x20, &mut type_vec); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/stores/loose.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | reader.read_until(0, &mut size_vec); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 56 | let _ = reader.read_until(0, &mut size_vec); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary transmute [INFO] [stdout] --> src/pack/index.rs:116:34 [INFO] [stdout] | [INFO] [stdout] 116 | let version_bytes = unsafe { std::mem::transmute::(2u32.to_be()) }; [INFO] [stdout] | -----------------------------------^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace this with: `u32::to_ne_bytes` [INFO] [stdout] | [INFO] [stdout] = help: there's also `to_le_bytes` and `to_be_bytes` if you expect a particular byte order [INFO] [stdout] = note: `#[warn(unnecessary_transmutes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary transmute [INFO] [stdout] --> src/pack/index.rs:131:34 [INFO] [stdout] | [INFO] [stdout] 131 | let crc_bytes = unsafe { std::mem::transmute::(crc) }; [INFO] [stdout] | -----------------------------------^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace this with: `u32::to_ne_bytes` [INFO] [stdout] | [INFO] [stdout] = help: there's also `to_le_bytes` and `to_be_bytes` if you expect a particular byte order [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary transmute [INFO] [stdout] --> src/pack/index.rs:137:37 [INFO] [stdout] | [INFO] [stdout] 137 | let offset_bytes = unsafe { std::mem::transmute::(offset) }; [INFO] [stdout] | -----------------------------------^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace this with: `u32::to_ne_bytes` [INFO] [stdout] | [INFO] [stdout] = help: there's also `to_le_bytes` and `to_be_bytes` if you expect a particular byte order [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary transmute [INFO] [stdout] --> src/pack/index.rs:143:43 [INFO] [stdout] | [INFO] [stdout] 143 | let large_offset_bytes = unsafe { std::mem::transmute::(large_offset) }; [INFO] [stdout] | -----------------------------------^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace this with: `u64::to_ne_bytes` [INFO] [stdout] | [INFO] [stdout] = help: there's also `to_le_bytes` and `to_be_bytes` if you expect a particular byte order [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary transmute [INFO] [stdout] --> src/pack/index.rs:172:29 [INFO] [stdout] | [INFO] [stdout] 172 | if (version != unsafe { std::mem::transmute::(2u32.to_be()) }) { [INFO] [stdout] | -----------------------------------^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace this with: `u32::to_ne_bytes` [INFO] [stdout] | [INFO] [stdout] = help: there's also `to_le_bytes` and `to_be_bytes` if you expect a particular byte order [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/walk/tree.rs:18:94 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(storage_set: &'a StorageSet, layers: Vec, TreeEntry>>) -> TreeIterator { [INFO] [stdout] | -- the lifetime is named here ^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(storage_set: &'a StorageSet, layers: Vec, TreeEntry>>) -> TreeIterator<'a, S> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/bin/index_pack.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | write(cursor, &mut io::stdout(), Some(&storage_set)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 24 | let _ = write(cursor, &mut io::stdout(), Some(&storage_set)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/id.rs:21:10 [INFO] [stdout] | [INFO] [stdout] 21 | 0...9 => (inp + 48) as char, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(ellipsis_inclusive_range_patterns)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/id.rs:22:11 [INFO] [stdout] | [INFO] [stdout] 22 | 10...16 => (inp + 87) as char, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/id.rs:45:20 [INFO] [stdout] | [INFO] [stdout] 45 | 48 ... 57 => xs - 48, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/id.rs:46:20 [INFO] [stdout] | [INFO] [stdout] 46 | 97 ... 102 => xs - 97 + 10, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/id.rs:47:20 [INFO] [stdout] | [INFO] [stdout] 47 | 65 ... 70 => xs - 65 + 10, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `has_error_description_deprecated` [INFO] [stdout] --> src/errors.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / error_chain! { [INFO] [stdout] 2 | | foreign_links { [INFO] [stdout] 3 | | Io(::std::io::Error); [INFO] [stdout] 4 | | Encoding(::std::str::Utf8Error); [INFO] [stdout] ... | [INFO] [stdout] 20 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `docsrs`, `feature`, and `test` and 31 more [INFO] [stdout] = note: using a cfg inside a macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `impl_error_chain_processed` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the macro `impl_error_chain_processed` may come from an old version of the `error_chain` crate, try updating your dependency with `cargo update -p error_chain` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] = note: this warning originates in the macro `impl_error_chain_processed` which comes from the expansion of the macro `error_chain` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/stores/loose.rs:52:10 [INFO] [stdout] | [INFO] [stdout] 52 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/objects/commit.rs:59:10 [INFO] [stdout] | [INFO] [stdout] 59 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Cursor` [INFO] [stdout] --> src/pack/index.rs:4:16 [INFO] [stdout] | [INFO] [stdout] 4 | use std::io::{ Cursor, SeekFrom }; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/pack/index.rs:168:8 [INFO] [stdout] | [INFO] [stdout] 168 | if (&magic != b"\xfftOc") { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 168 - if (&magic != b"\xfftOc") { [INFO] [stdout] 168 + if &magic != b"\xfftOc" { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/pack/index.rs:172:8 [INFO] [stdout] | [INFO] [stdout] 172 | if (version != unsafe { std::mem::transmute::(2u32.to_be()) }) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 172 - if (version != unsafe { std::mem::transmute::(2u32.to_be()) }) { [INFO] [stdout] 172 + if version != unsafe { std::mem::transmute::(2u32.to_be()) } { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Read` [INFO] [stdout] --> src/pack/iter.rs:99:20 [INFO] [stdout] | [INFO] [stdout] 99 | use std::io::{ Read, Cursor }; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/pack/read.rs:35:10 [INFO] [stdout] | [INFO] [stdout] 35 | 0...4 => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/stores/loose.rs:10:15 [INFO] [stdout] | [INFO] [stdout] 10 | type Reader = Fn(&Id) -> Result>> + Send + Sync; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 10 | type Reader = dyn Fn(&Id) -> Result>> + Send + Sync; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/stores/loose.rs:10:44 [INFO] [stdout] | [INFO] [stdout] 10 | type Reader = Fn(&Id) -> Result>> + Send + Sync; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 10 | type Reader = Fn(&Id) -> Result>> + Send + Sync; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/pack/any.rs:15:15 [INFO] [stdout] | [INFO] [stdout] 15 | read: Box Result>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 15 | read: Box Result>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/pack/any.rs:12:22 [INFO] [stdout] | [INFO] [stdout] 12 | pub type GetObject = Fn(&Id) -> Result)>>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 12 | pub type GetObject = dyn Fn(&Id) -> Result)>>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/pack/any.rs:12:58 [INFO] [stdout] | [INFO] [stdout] 12 | pub type GetObject = Fn(&Id) -> Result)>>; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 12 | pub type GetObject = Fn(&Id) -> Result)>>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/stores/loose.rs:19:47 [INFO] [stdout] | [INFO] [stdout] 19 | where C: Fn(&Id) -> Result>> + 'static + Send + Sync { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 19 | where C: Fn(&Id) -> Result>> + 'static + Send + Sync { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDateTime::from_timestamp_opt`: use `DateTime::from_timestamp` instead [INFO] [stdout] --> src/identity.rs:95:46 [INFO] [stdout] | [INFO] [stdout] 95 | let naive = match NaiveDateTime::from_timestamp_opt(timestamp, 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::DateTime::::from_utc`: Use TimeZone::from_utc_datetime() or DateTime::from_naive_utc_and_offset instead [INFO] [stdout] --> src/identity.rs:100:39 [INFO] [stdout] | [INFO] [stdout] 100 | let dt = DateTime::::from_utc(naive, Utc); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `mode` [INFO] [stdout] --> src/stores/loose.rs:53:17 [INFO] [stdout] | [INFO] [stdout] 53 | let mut mode = Mode::FindSpace; [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_mode` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/stores/loose.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | let mut mode = Mode::FindSpace; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `id` [INFO] [stdout] --> src/stores/mod.rs:20:43 [INFO] [stdout] | [INFO] [stdout] 20 | fn get(&self, id: &Id, _output: &mut W, _backends: &StorageSet) -> Result> { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `end` [INFO] [stdout] --> src/pack/any.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | end: u64, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_end` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `size` is assigned to, but never used [INFO] [stdout] --> src/pack/read.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | let mut size = (byte[0] & 0xf) as u64; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_size` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `FindNull` is never constructed [INFO] [stdout] --> src/stores/loose.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 49 | enum Mode { [INFO] [stdout] | ---- variant in this enum [INFO] [stdout] 50 | FindSpace, [INFO] [stdout] 51 | FindNull [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `author` is never read [INFO] [stdout] --> src/objects/commit.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct Commit { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 11 | author: Option, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Commit` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `next` is never read [INFO] [stdout] --> src/pack/mod.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 17 | pub struct IndexEntry { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 21 | next: usize [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `IndexEntry` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/pack/mod.rs:38:20 [INFO] [stdout] | [INFO] [stdout] 38 | pub struct Fanout ([u32; 256]); [INFO] [stdout] | ------ ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `crcs` is never read [INFO] [stdout] --> src/pack/index.rs:237:5 [INFO] [stdout] | [INFO] [stdout] 232 | pub struct Index { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 237 | crcs: Vec, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `storage_set` is never read [INFO] [stdout] --> src/pack/iter.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct PackfileIterator<'a, R: BufRead + Seek + std::fmt::Debug, S: Queryable> { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 16 | storage_set: Option<&'a StorageSet> [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `kind` is never read [INFO] [stdout] --> src/refs.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 23 | pub struct Ref { [INFO] [stdout] | --- field in this struct [INFO] [stdout] 24 | kind: Kind, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Ref` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name`, `email`, and `offset` are never read [INFO] [stdout] --> src/identity.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct Identity { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 5 | name: Vec, [INFO] [stdout] | ^^^^ [INFO] [stdout] 6 | email: Vec, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 7 | at: DateTime, [INFO] [stdout] 8 | offset: FixedOffset [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Identity` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/stores/mod.rs:70:20 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn commits(&self, id: &Id, seen: Option>) -> CommitIterator { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 70 | pub fn commits(&self, id: &Id, seen: Option>) -> CommitIterator<'_, Q> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/stores/mod.rs:74:17 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn tree(&self, id: &Id) -> TreeIterator { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 74 | pub fn tree(&self, id: &Id) -> TreeIterator<'_, Q> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/stores/loose.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | reader.read_until(0x20, &mut type_vec); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 55 | let _ = reader.read_until(0x20, &mut type_vec); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/stores/loose.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | reader.read_until(0, &mut size_vec); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 56 | let _ = reader.read_until(0, &mut size_vec); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary transmute [INFO] [stdout] --> src/pack/index.rs:116:34 [INFO] [stdout] | [INFO] [stdout] 116 | let version_bytes = unsafe { std::mem::transmute::(2u32.to_be()) }; [INFO] [stdout] | -----------------------------------^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace this with: `u32::to_ne_bytes` [INFO] [stdout] | [INFO] [stdout] = help: there's also `to_le_bytes` and `to_be_bytes` if you expect a particular byte order [INFO] [stdout] = note: `#[warn(unnecessary_transmutes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary transmute [INFO] [stdout] --> src/pack/index.rs:131:34 [INFO] [stdout] | [INFO] [stdout] 131 | let crc_bytes = unsafe { std::mem::transmute::(crc) }; [INFO] [stdout] | -----------------------------------^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace this with: `u32::to_ne_bytes` [INFO] [stdout] | [INFO] [stdout] = help: there's also `to_le_bytes` and `to_be_bytes` if you expect a particular byte order [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary transmute [INFO] [stdout] --> src/pack/index.rs:137:37 [INFO] [stdout] | [INFO] [stdout] 137 | let offset_bytes = unsafe { std::mem::transmute::(offset) }; [INFO] [stdout] | -----------------------------------^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace this with: `u32::to_ne_bytes` [INFO] [stdout] | [INFO] [stdout] = help: there's also `to_le_bytes` and `to_be_bytes` if you expect a particular byte order [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary transmute [INFO] [stdout] --> src/pack/index.rs:143:43 [INFO] [stdout] | [INFO] [stdout] 143 | let large_offset_bytes = unsafe { std::mem::transmute::(large_offset) }; [INFO] [stdout] | -----------------------------------^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace this with: `u64::to_ne_bytes` [INFO] [stdout] | [INFO] [stdout] = help: there's also `to_le_bytes` and `to_be_bytes` if you expect a particular byte order [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary transmute [INFO] [stdout] --> src/pack/index.rs:172:29 [INFO] [stdout] | [INFO] [stdout] 172 | if (version != unsafe { std::mem::transmute::(2u32.to_be()) }) { [INFO] [stdout] | -----------------------------------^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace this with: `u32::to_ne_bytes` [INFO] [stdout] | [INFO] [stdout] = help: there's also `to_le_bytes` and `to_be_bytes` if you expect a particular byte order [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/walk/tree.rs:18:94 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(storage_set: &'a StorageSet, layers: Vec, TreeEntry>>) -> TreeIterator { [INFO] [stdout] | -- the lifetime is named here ^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(storage_set: &'a StorageSet, layers: Vec, TreeEntry>>) -> TreeIterator<'a, S> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `test` profile [unoptimized + debuginfo] target(s) in 1.71s [INFO] running `Command { std: "docker" "inspect" "d6f97a47849d1ff35b40845255296b260c66c8eb63817954cfac14a09b268ea6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d6f97a47849d1ff35b40845255296b260c66c8eb63817954cfac14a09b268ea6", kill_on_drop: false }` [INFO] [stdout] d6f97a47849d1ff35b40845255296b260c66c8eb63817954cfac14a09b268ea6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+cdb45c87e2cd43495379f7e867e3cc15dcee9f93" "test" "--frozen", kill_on_drop: false }` [INFO] [stdout] beebb04e993de4bfd176645fef0364a6f7831a90dc780a1e8909b0287f46b336 [INFO] running `Command { std: "docker" "start" "-a" "beebb04e993de4bfd176645fef0364a6f7831a90dc780a1e8909b0287f46b336", kill_on_drop: false }` [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/id.rs:21:10 [INFO] [stderr] | [INFO] [stderr] 21 | 0...9 => (inp + 48) as char, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] = note: `#[warn(ellipsis_inclusive_range_patterns)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/id.rs:22:11 [INFO] [stderr] | [INFO] [stderr] 22 | 10...16 => (inp + 87) as char, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/id.rs:45:20 [INFO] [stderr] | [INFO] [stderr] 45 | 48 ... 57 => xs - 48, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/id.rs:46:20 [INFO] [stderr] | [INFO] [stderr] 46 | 97 ... 102 => xs - 97 + 10, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/id.rs:47:20 [INFO] [stderr] | [INFO] [stderr] 47 | 65 ... 70 => xs - 65 + 10, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] [INFO] [stderr] warning: unexpected `cfg` condition name: `has_error_description_deprecated` [INFO] [stderr] --> src/errors.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | / error_chain! { [INFO] [stderr] 2 | | foreign_links { [INFO] [stderr] 3 | | Io(::std::io::Error); [INFO] [stderr] 4 | | Encoding(::std::str::Utf8Error); [INFO] [stderr] ... | [INFO] [stderr] 20 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: expected names are: `docsrs`, `feature`, and `test` and 31 more [INFO] [stderr] = note: using a cfg inside a macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stderr] = help: try referring to `impl_error_chain_processed` crate for guidance on how handle this unexpected cfg [INFO] [stderr] = help: the macro `impl_error_chain_processed` may come from an old version of the `error_chain` crate, try updating your dependency with `cargo update -p error_chain` [INFO] [stderr] = note: see for more information about checking conditional configuration [INFO] [stderr] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stderr] = note: this warning originates in the macro `impl_error_chain_processed` which comes from the expansion of the macro `error_chain` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unnecessary trailing semicolon [INFO] [stderr] --> src/stores/loose.rs:52:10 [INFO] [stderr] | [INFO] [stderr] 52 | }; [INFO] [stderr] | ^ help: remove this semicolon [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(redundant_semicolons)]` (part of `#[warn(unused)]`) on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary trailing semicolon [INFO] [stderr] --> src/objects/commit.rs:59:10 [INFO] [stderr] | [INFO] [stderr] 59 | }; [INFO] [stderr] | ^ help: remove this semicolon [INFO] [stderr] [INFO] [stderr] warning: unused import: `Cursor` [INFO] [stderr] --> src/pack/index.rs:4:16 [INFO] [stderr] | [INFO] [stderr] 4 | use std::io::{ Cursor, SeekFrom }; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/pack/index.rs:168:8 [INFO] [stderr] | [INFO] [stderr] 168 | if (&magic != b"\xfftOc") { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 168 - if (&magic != b"\xfftOc") { [INFO] [stderr] 168 + if &magic != b"\xfftOc" { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/pack/index.rs:172:8 [INFO] [stderr] | [INFO] [stderr] 172 | if (version != unsafe { std::mem::transmute::(2u32.to_be()) }) { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 172 - if (version != unsafe { std::mem::transmute::(2u32.to_be()) }) { [INFO] [stderr] 172 + if version != unsafe { std::mem::transmute::(2u32.to_be()) } { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/pack/read.rs:35:10 [INFO] [stderr] | [INFO] [stderr] 35 | 0...4 => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/stores/loose.rs:10:15 [INFO] [stderr] | [INFO] [stderr] 10 | type Reader = Fn(&Id) -> Result>> + Send + Sync; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stderr] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stderr] | [INFO] [stderr] 10 | type Reader = dyn Fn(&Id) -> Result>> + Send + Sync; [INFO] [stderr] | +++ [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/stores/loose.rs:10:44 [INFO] [stderr] | [INFO] [stderr] 10 | type Reader = Fn(&Id) -> Result>> + Send + Sync; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stderr] | [INFO] [stderr] 10 | type Reader = Fn(&Id) -> Result>> + Send + Sync; [INFO] [stderr] | +++ [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/pack/any.rs:15:15 [INFO] [stderr] | [INFO] [stderr] 15 | read: Box Result>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stderr] | [INFO] [stderr] 15 | read: Box Result>, [INFO] [stderr] | +++ [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/pack/any.rs:12:22 [INFO] [stderr] | [INFO] [stderr] 12 | pub type GetObject = Fn(&Id) -> Result)>>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stderr] | [INFO] [stderr] 12 | pub type GetObject = dyn Fn(&Id) -> Result)>>; [INFO] [stderr] | +++ [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/pack/any.rs:12:58 [INFO] [stderr] | [INFO] [stderr] 12 | pub type GetObject = Fn(&Id) -> Result)>>; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stderr] | [INFO] [stderr] 12 | pub type GetObject = Fn(&Id) -> Result)>>; [INFO] [stderr] | +++ [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/stores/loose.rs:19:47 [INFO] [stderr] | [INFO] [stderr] 19 | where C: Fn(&Id) -> Result>> + 'static + Send + Sync { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stderr] | [INFO] [stderr] 19 | where C: Fn(&Id) -> Result>> + 'static + Send + Sync { [INFO] [stderr] | +++ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated associated function `chrono::NaiveDateTime::from_timestamp_opt`: use `DateTime::from_timestamp` instead [INFO] [stderr] --> src/identity.rs:95:46 [INFO] [stderr] | [INFO] [stderr] 95 | let naive = match NaiveDateTime::from_timestamp_opt(timestamp, 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(deprecated)]` on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated associated function `chrono::DateTime::::from_utc`: Use TimeZone::from_utc_datetime() or DateTime::from_naive_utc_and_offset instead [INFO] [stderr] --> src/identity.rs:100:39 [INFO] [stderr] | [INFO] [stderr] 100 | let dt = DateTime::::from_utc(naive, Utc); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `mode` [INFO] [stderr] --> src/stores/loose.rs:53:17 [INFO] [stderr] | [INFO] [stderr] 53 | let mut mode = Mode::FindSpace; [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_mode` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/stores/loose.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | let mut mode = Mode::FindSpace; [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `id` [INFO] [stderr] --> src/stores/mod.rs:20:43 [INFO] [stderr] | [INFO] [stderr] 20 | fn get(&self, id: &Id, _output: &mut W, _backends: &StorageSet) -> Result> { [INFO] [stderr] | ^^ help: if this is intentional, prefix it with an underscore: `_id` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `end` [INFO] [stderr] --> src/pack/any.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | end: u64, [INFO] [stderr] | ^^^ help: if this is intentional, prefix it with an underscore: `_end` [INFO] [stderr] [INFO] [stderr] warning: variable `size` is assigned to, but never used [INFO] [stderr] --> src/pack/read.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | let mut size = (byte[0] & 0xf) as u64; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: consider using `_size` instead [INFO] [stderr] [INFO] [stderr] warning: variant `FindNull` is never constructed [INFO] [stderr] --> src/stores/loose.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 49 | enum Mode { [INFO] [stderr] | ---- variant in this enum [INFO] [stderr] 50 | FindSpace, [INFO] [stderr] 51 | FindNull [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stderr] [INFO] [stderr] warning: field `author` is never read [INFO] [stderr] --> src/objects/commit.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 8 | pub struct Commit { [INFO] [stderr] | ------ field in this struct [INFO] [stderr] ... [INFO] [stderr] 11 | author: Option, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `Commit` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stderr] [INFO] [stderr] warning: field `next` is never read [INFO] [stderr] --> src/pack/mod.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 17 | pub struct IndexEntry { [INFO] [stderr] | ---------- field in this struct [INFO] [stderr] ... [INFO] [stderr] 21 | next: usize [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `IndexEntry` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stderr] [INFO] [stderr] warning: field `0` is never read [INFO] [stderr] --> src/pack/mod.rs:38:20 [INFO] [stderr] | [INFO] [stderr] 38 | pub struct Fanout ([u32; 256]); [INFO] [stderr] | ------ ^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | field in this struct [INFO] [stderr] | [INFO] [stderr] = help: consider removing this field [INFO] [stderr] [INFO] [stderr] warning: field `crcs` is never read [INFO] [stderr] --> src/pack/index.rs:237:5 [INFO] [stderr] | [INFO] [stderr] 232 | pub struct Index { [INFO] [stderr] | ----- field in this struct [INFO] [stderr] ... [INFO] [stderr] 237 | crcs: Vec, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: field `storage_set` is never read [INFO] [stderr] --> src/pack/iter.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 9 | pub struct PackfileIterator<'a, R: BufRead + Seek + std::fmt::Debug, S: Queryable> { [INFO] [stderr] | ---------------- field in this struct [INFO] [stderr] ... [INFO] [stderr] 16 | storage_set: Option<&'a StorageSet> [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field `kind` is never read [INFO] [stderr] --> src/refs.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 23 | pub struct Ref { [INFO] [stderr] | --- field in this struct [INFO] [stderr] 24 | kind: Kind, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `Ref` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stderr] [INFO] [stderr] warning: fields `name`, `email`, and `offset` are never read [INFO] [stderr] --> src/identity.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 4 | pub struct Identity { [INFO] [stderr] | -------- fields in this struct [INFO] [stderr] 5 | name: Vec, [INFO] [stderr] | ^^^^ [INFO] [stderr] 6 | email: Vec, [INFO] [stderr] | ^^^^^ [INFO] [stderr] 7 | at: DateTime, [INFO] [stderr] 8 | offset: FixedOffset [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `Identity` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stderr] [INFO] [stderr] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stderr] --> src/stores/mod.rs:70:20 [INFO] [stderr] | [INFO] [stderr] 70 | pub fn commits(&self, id: &Id, seen: Option>) -> CommitIterator { [INFO] [stderr] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stderr] | [INFO] [stderr] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stderr] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stderr] help: use `'_` for type paths [INFO] [stderr] | [INFO] [stderr] 70 | pub fn commits(&self, id: &Id, seen: Option>) -> CommitIterator<'_, Q> { [INFO] [stderr] | +++ [INFO] [stderr] [INFO] [stderr] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stderr] --> src/stores/mod.rs:74:17 [INFO] [stderr] | [INFO] [stderr] 74 | pub fn tree(&self, id: &Id) -> TreeIterator { [INFO] [stderr] | ^^^^^ ^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stderr] | | [INFO] [stderr] | the lifetime is elided here [INFO] [stderr] | [INFO] [stderr] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stderr] help: use `'_` for type paths [INFO] [stderr] | [INFO] [stderr] 74 | pub fn tree(&self, id: &Id) -> TreeIterator<'_, Q> { [INFO] [stderr] | +++ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/stores/loose.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | reader.read_until(0x20, &mut type_vec); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stderr] help: use `let _ = ...` to ignore the resulting value [INFO] [stderr] | [INFO] [stderr] 55 | let _ = reader.read_until(0x20, &mut type_vec); [INFO] [stderr] | +++++++ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/stores/loose.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | reader.read_until(0, &mut size_vec); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] help: use `let _ = ...` to ignore the resulting value [INFO] [stderr] | [INFO] [stderr] 56 | let _ = reader.read_until(0, &mut size_vec); [INFO] [stderr] | +++++++ [INFO] [stderr] [INFO] [stderr] warning: unnecessary transmute [INFO] [stderr] --> src/pack/index.rs:116:34 [INFO] [stderr] | [INFO] [stderr] 116 | let version_bytes = unsafe { std::mem::transmute::(2u32.to_be()) }; [INFO] [stderr] | -----------------------------------^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: replace this with: `u32::to_ne_bytes` [INFO] [stderr] | [INFO] [stderr] = help: there's also `to_le_bytes` and `to_be_bytes` if you expect a particular byte order [INFO] [stderr] = note: `#[warn(unnecessary_transmutes)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary transmute [INFO] [stderr] --> src/pack/index.rs:131:34 [INFO] [stderr] | [INFO] [stderr] 131 | let crc_bytes = unsafe { std::mem::transmute::(crc) }; [INFO] [stderr] | -----------------------------------^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: replace this with: `u32::to_ne_bytes` [INFO] [stderr] | [INFO] [stderr] = help: there's also `to_le_bytes` and `to_be_bytes` if you expect a particular byte order [INFO] [stderr] [INFO] [stderr] warning: unnecessary transmute [INFO] [stderr] --> src/pack/index.rs:137:37 [INFO] [stderr] | [INFO] [stderr] 137 | let offset_bytes = unsafe { std::mem::transmute::(offset) }; [INFO] [stderr] | -----------------------------------^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: replace this with: `u32::to_ne_bytes` [INFO] [stderr] | [INFO] [stderr] = help: there's also `to_le_bytes` and `to_be_bytes` if you expect a particular byte order [INFO] [stderr] [INFO] [stderr] warning: unnecessary transmute [INFO] [stderr] --> src/pack/index.rs:143:43 [INFO] [stderr] | [INFO] [stderr] 143 | let large_offset_bytes = unsafe { std::mem::transmute::(large_offset) }; [INFO] [stderr] | -----------------------------------^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: replace this with: `u64::to_ne_bytes` [INFO] [stderr] | [INFO] [stderr] = help: there's also `to_le_bytes` and `to_be_bytes` if you expect a particular byte order [INFO] [stderr] [INFO] [stderr] warning: unnecessary transmute [INFO] [stderr] --> src/pack/index.rs:172:29 [INFO] [stderr] | [INFO] [stderr] 172 | if (version != unsafe { std::mem::transmute::(2u32.to_be()) }) { [INFO] [stderr] | -----------------------------------^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: replace this with: `u32::to_ne_bytes` [INFO] [stderr] | [INFO] [stderr] = help: there's also `to_le_bytes` and `to_be_bytes` if you expect a particular byte order [INFO] [stderr] [INFO] [stderr] warning: hiding a lifetime that's named elsewhere is confusing [INFO] [stderr] --> src/walk/tree.rs:18:94 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn new(storage_set: &'a StorageSet, layers: Vec, TreeEntry>>) -> TreeIterator { [INFO] [stderr] | -- the lifetime is named here ^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stderr] | [INFO] [stderr] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stderr] help: consistently use `'a` [INFO] [stderr] | [INFO] [stderr] 18 | pub fn new(storage_set: &'a StorageSet, layers: Vec, TreeEntry>>) -> TreeIterator<'a, S> { [INFO] [stderr] | +++ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Read` [INFO] [stderr] --> src/pack/iter.rs:99:20 [INFO] [stderr] | [INFO] [stderr] 99 | use std::io::{ Read, Cursor }; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: `git_rs` (lib) generated 43 warnings (run `cargo fix --lib -p git_rs` to apply 24 suggestions) [INFO] [stderr] warning: `git_rs` (lib test) generated 44 warnings (43 duplicates) (run `cargo fix --lib -p git_rs --tests` to apply 1 suggestion) [INFO] [stderr] warning: unused `Result` that must be used [INFO] [stderr] --> src/bin/index_pack.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | write(cursor, &mut io::stdout(), Some(&storage_set)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stderr] help: use `let _ = ...` to ignore the resulting value [INFO] [stderr] | [INFO] [stderr] 24 | let _ = write(cursor, &mut io::stdout(), Some(&storage_set)); [INFO] [stderr] | +++++++ [INFO] [stderr] [INFO] [stderr] warning: `git_rs` (bin "git_rs_index_pack" test) generated 1 warning [INFO] [stderr] Finished `test` profile [unoptimized + debuginfo] target(s) in 0.08s [INFO] [stderr] Running unittests src/lib.rs (/opt/rustwide/target/debug/deps/git_rs-e60b83d3aa159d2d) [INFO] [stdout] [INFO] [stdout] running 17 tests [INFO] [stdout] test id::tests::id_default_works ... ok [INFO] [stdout] test delta::tests::can_read ... ok [INFO] [stdout] test id::tests::id_fails_on_bad_chars ... ok [INFO] [stdout] test id::tests::id_from_hash_works_with_lowercase ... ok [INFO] [stdout] test id::tests::id_fails_on_bad_length ... ok [INFO] [stdout] test delta::tests::can_load ... ok [INFO] [stdout] test identity::tests::read_identity ... ok [INFO] [stdout] test id::tests::id_from_hash_works_with_uppercase ... ok [INFO] [stdout] test objects::commit::tests::commit_read_works ... ok [INFO] [stdout] test stores::loose::tests::handles_idtoreadable_misses ... ok [INFO] [stdout] test stores::loose::tests::read_commit_works ... ok [INFO] [stdout] test objects::tree::tests::tree_complex_read_works ... ok [INFO] [stdout] test tests::it_works ... ok [INFO] [stdout] test stores::loose::tests::read_tree_works ... ok [INFO] [stdout] test objects::tree::tests::tree_read_works ... ok [INFO] [stdout] test pack::iter::tests::does_it_blend ... ok [INFO] [stdout] test stores::loose::tests::handles_idtoreadable_failures ... ok [INFO] [stdout] [INFO] [stdout] test result: ok. 17 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s [INFO] [stdout] [INFO] [stderr] Running unittests src/bin/index_pack.rs (/opt/rustwide/target/debug/deps/git_rs_index_pack-9e49343cb9dda4c1) [INFO] [stdout] [INFO] [stdout] running 0 tests [INFO] [stdout] [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s [INFO] [stdout] [INFO] [stderr] Running unittests src/bin/log.rs (/opt/rustwide/target/debug/deps/git_rs_log-49c5a72250036064) [INFO] [stdout] [INFO] [stdout] running 0 tests [INFO] [stdout] [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s [INFO] [stdout] [INFO] [stderr] Running unittests src/bin/read_tree.rs (/opt/rustwide/target/debug/deps/git_rs_read_tree-ed29809bfbe01d04) [INFO] [stdout] [INFO] [stdout] running 0 tests [INFO] [stdout] [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s [INFO] [stdout] [INFO] [stderr] Doc-tests git_rs [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/id.rs:21:10 [INFO] [stderr] | [INFO] [stderr] 21 | 0...9 => (inp + 48) as char, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] = note: `#[warn(ellipsis_inclusive_range_patterns)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/id.rs:22:11 [INFO] [stderr] | [INFO] [stderr] 22 | 10...16 => (inp + 87) as char, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/id.rs:45:20 [INFO] [stderr] | [INFO] [stderr] 45 | 48 ... 57 => xs - 48, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/id.rs:46:20 [INFO] [stderr] | [INFO] [stderr] 46 | 97 ... 102 => xs - 97 + 10, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/id.rs:47:20 [INFO] [stderr] | [INFO] [stderr] 47 | 65 ... 70 => xs - 65 + 10, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] [INFO] [stderr] warning: unnecessary trailing semicolon [INFO] [stderr] --> src/stores/loose.rs:52:10 [INFO] [stderr] | [INFO] [stderr] 52 | }; [INFO] [stderr] | ^ help: remove this semicolon [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(redundant_semicolons)]` (part of `#[warn(unused)]`) on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary trailing semicolon [INFO] [stderr] --> src/objects/commit.rs:59:10 [INFO] [stderr] | [INFO] [stderr] 59 | }; [INFO] [stderr] | ^ help: remove this semicolon [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/pack/index.rs:168:8 [INFO] [stderr] | [INFO] [stderr] 168 | if (&magic != b"\xfftOc") { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 168 - if (&magic != b"\xfftOc") { [INFO] [stderr] 168 + if &magic != b"\xfftOc" { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/pack/index.rs:172:8 [INFO] [stderr] | [INFO] [stderr] 172 | if (version != unsafe { std::mem::transmute::(2u32.to_be()) }) { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 172 - if (version != unsafe { std::mem::transmute::(2u32.to_be()) }) { [INFO] [stderr] 172 + if version != unsafe { std::mem::transmute::(2u32.to_be()) } { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/pack/read.rs:35:10 [INFO] [stderr] | [INFO] [stderr] 35 | 0...4 => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] [INFO] [stderr] warning: 10 warnings emitted [INFO] [stderr] [INFO] [stdout] [INFO] [stdout] running 0 tests [INFO] [stdout] [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "beebb04e993de4bfd176645fef0364a6f7831a90dc780a1e8909b0287f46b336", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "beebb04e993de4bfd176645fef0364a6f7831a90dc780a1e8909b0287f46b336", kill_on_drop: false }` [INFO] [stdout] beebb04e993de4bfd176645fef0364a6f7831a90dc780a1e8909b0287f46b336