[INFO] cloning repository https://github.com/tlehman/advent-2020 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/tlehman/advent-2020" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftlehman%2Fadvent-2020", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftlehman%2Fadvent-2020'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 93ddb4a8718d387cf216c41952def74abb8e41be [INFO] testing tlehman/advent-2020 against master#cdb45c87e2cd43495379f7e867e3cc15dcee9f93 for pr-145838-1 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftlehman%2Fadvent-2020" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/tlehman/advent-2020 [INFO] finished tweaking git repo https://github.com/tlehman/advent-2020 [INFO] tweaked toml for git repo https://github.com/tlehman/advent-2020 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/tlehman/advent-2020 on toolchain cdb45c87e2cd43495379f7e867e3cc15dcee9f93 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+cdb45c87e2cd43495379f7e867e3cc15dcee9f93" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/tlehman/advent-2020 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+cdb45c87e2cd43495379f7e867e3cc15dcee9f93" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+cdb45c87e2cd43495379f7e867e3cc15dcee9f93" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4d55ac887f3b00e8798430849fe8abc8f992d596f2130c534bd92a5cfa9735eb [INFO] running `Command { std: "docker" "start" "-a" "4d55ac887f3b00e8798430849fe8abc8f992d596f2130c534bd92a5cfa9735eb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4d55ac887f3b00e8798430849fe8abc8f992d596f2130c534bd92a5cfa9735eb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4d55ac887f3b00e8798430849fe8abc8f992d596f2130c534bd92a5cfa9735eb", kill_on_drop: false }` [INFO] [stdout] 4d55ac887f3b00e8798430849fe8abc8f992d596f2130c534bd92a5cfa9735eb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+cdb45c87e2cd43495379f7e867e3cc15dcee9f93" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4a542f4609c0c781772f4a4f3c047950383a14b1dad809238f4a636369f7e34c [INFO] running `Command { std: "docker" "start" "-a" "4a542f4609c0c781772f4a4f3c047950383a14b1dad809238f4a636369f7e34c", kill_on_drop: false }` [INFO] [stderr] Compiling advent-2020 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/day03.rs:82:13 [INFO] [stdout] | [INFO] [stdout] 82 | let mut toboggan_map = TobogganMap { rows: lines, width: w }; [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `col` [INFO] [stdout] --> src/day03.rs:107:17 [INFO] [stdout] | [INFO] [stdout] 107 | for col in 0..6 { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_col` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `valid_password` is never used [INFO] [stdout] --> src/day02.rs:81:4 [INFO] [stdout] | [INFO] [stdout] 81 | fn valid_password(raw_rule: &str, password: &str) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `valid_password_part2` is never used [INFO] [stdout] --> src/day02.rs:133:8 [INFO] [stdout] | [INFO] [stdout] 133 | pub fn valid_password_part2(raw_rule: &str, password: &str) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static `empty` is never used [INFO] [stdout] --> src/day03.rs:71:8 [INFO] [stdout] | [INFO] [stdout] 71 | static empty: char = '.'; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `print_rows` is never used [INFO] [stdout] --> src/day03.rs:105:12 [INFO] [stdout] | [INFO] [stdout] 79 | impl TobogganMap { [INFO] [stdout] | ---------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 105 | pub fn print_rows(self: &TobogganMap) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Passport` is never constructed [INFO] [stdout] --> src/day04.rs:65:8 [INFO] [stdout] | [INFO] [stdout] 65 | struct Passport { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `from_vector` and `valid` are never used [INFO] [stdout] --> src/day04.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 76 | impl Passport { [INFO] [stdout] | ------------- associated items in this implementation [INFO] [stdout] 77 | pub fn from_vector(v: Vec) -> Passport { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 112 | pub fn valid(self: &Passport) -> bool { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse_batch_passports` is never used [INFO] [stdout] --> src/day04.rs:166:8 [INFO] [stdout] | [INFO] [stdout] 166 | pub fn parse_batch_passports(batch_passports: &[&str]) -> Vec> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static variable `empty` should have an upper case name [INFO] [stdout] --> src/day03.rs:71:8 [INFO] [stdout] | [INFO] [stdout] 71 | static empty: char = '.'; [INFO] [stdout] | ^^^^^ help: convert the identifier to upper case: `EMPTY` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static variable `tree` should have an upper case name [INFO] [stdout] --> src/day03.rs:72:8 [INFO] [stdout] | [INFO] [stdout] 72 | static tree: char = '#'; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] help: convert the identifier to upper case [INFO] [stdout] | [INFO] [stdout] 72 - static tree: char = '#'; [INFO] [stdout] 72 + static TREE: char = '#'; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.57s [INFO] running `Command { std: "docker" "inspect" "4a542f4609c0c781772f4a4f3c047950383a14b1dad809238f4a636369f7e34c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4a542f4609c0c781772f4a4f3c047950383a14b1dad809238f4a636369f7e34c", kill_on_drop: false }` [INFO] [stdout] 4a542f4609c0c781772f4a4f3c047950383a14b1dad809238f4a636369f7e34c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+cdb45c87e2cd43495379f7e867e3cc15dcee9f93" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e9b4064dd9b76339a8da259c0a7d1b1278923906a0866dcd34aa6d0f60fd4cda [INFO] running `Command { std: "docker" "start" "-a" "e9b4064dd9b76339a8da259c0a7d1b1278923906a0866dcd34aa6d0f60fd4cda", kill_on_drop: false }` [INFO] [stderr] Compiling advent-2020 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/day03.rs:82:13 [INFO] [stdout] | [INFO] [stdout] 82 | let mut toboggan_map = TobogganMap { rows: lines, width: w }; [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `col` [INFO] [stdout] --> src/day03.rs:107:17 [INFO] [stdout] | [INFO] [stdout] 107 | for col in 0..6 { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_col` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static `empty` is never used [INFO] [stdout] --> src/day03.rs:71:8 [INFO] [stdout] | [INFO] [stdout] 71 | static empty: char = '.'; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `print_rows` is never used [INFO] [stdout] --> src/day03.rs:105:12 [INFO] [stdout] | [INFO] [stdout] 79 | impl TobogganMap { [INFO] [stdout] | ---------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 105 | pub fn print_rows(self: &TobogganMap) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `cid` is never read [INFO] [stdout] --> src/day04.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 65 | struct Passport { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 73 | cid: Option // (Country ID) [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static variable `empty` should have an upper case name [INFO] [stdout] --> src/day03.rs:71:8 [INFO] [stdout] | [INFO] [stdout] 71 | static empty: char = '.'; [INFO] [stdout] | ^^^^^ help: convert the identifier to upper case: `EMPTY` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static variable `tree` should have an upper case name [INFO] [stdout] --> src/day03.rs:72:8 [INFO] [stdout] | [INFO] [stdout] 72 | static tree: char = '#'; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] help: convert the identifier to upper case [INFO] [stdout] | [INFO] [stdout] 72 - static tree: char = '#'; [INFO] [stdout] 72 + static TREE: char = '#'; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/day03.rs:132:45 [INFO] [stdout] | [INFO] [stdout] 132 | lines.push(String::from(raw_lines[i].clone())); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/day03.rs:177:45 [INFO] [stdout] | [INFO] [stdout] 177 | lines.push(String::from(raw_lines[i].clone())); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `test` profile [unoptimized + debuginfo] target(s) in 0.59s [INFO] running `Command { std: "docker" "inspect" "e9b4064dd9b76339a8da259c0a7d1b1278923906a0866dcd34aa6d0f60fd4cda", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e9b4064dd9b76339a8da259c0a7d1b1278923906a0866dcd34aa6d0f60fd4cda", kill_on_drop: false }` [INFO] [stdout] e9b4064dd9b76339a8da259c0a7d1b1278923906a0866dcd34aa6d0f60fd4cda [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+cdb45c87e2cd43495379f7e867e3cc15dcee9f93" "test" "--frozen", kill_on_drop: false }` [INFO] [stdout] 1adc0803565939437de11c05d60d868eb805b7bf938ac5f27e7804fb27f5b1b1 [INFO] running `Command { std: "docker" "start" "-a" "1adc0803565939437de11c05d60d868eb805b7bf938ac5f27e7804fb27f5b1b1", kill_on_drop: false }` [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/day03.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | let mut toboggan_map = TobogganMap { rows: lines, width: w }; [INFO] [stderr] | ----^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `col` [INFO] [stderr] --> src/day03.rs:107:17 [INFO] [stderr] | [INFO] [stderr] 107 | for col in 0..6 { [INFO] [stderr] | ^^^ help: if this is intentional, prefix it with an underscore: `_col` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stderr] [INFO] [stderr] warning: static `empty` is never used [INFO] [stderr] --> src/day03.rs:71:8 [INFO] [stderr] | [INFO] [stderr] 71 | static empty: char = '.'; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stderr] [INFO] [stderr] warning: method `print_rows` is never used [INFO] [stderr] --> src/day03.rs:105:12 [INFO] [stderr] | [INFO] [stderr] 79 | impl TobogganMap { [INFO] [stderr] | ---------------- method in this implementation [INFO] [stderr] ... [INFO] [stderr] 105 | pub fn print_rows(self: &TobogganMap) { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field `cid` is never read [INFO] [stderr] --> src/day04.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 65 | struct Passport { [INFO] [stderr] | -------- field in this struct [INFO] [stderr] ... [INFO] [stderr] 73 | cid: Option // (Country ID) [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: static variable `empty` should have an upper case name [INFO] [stderr] --> src/day03.rs:71:8 [INFO] [stderr] | [INFO] [stderr] 71 | static empty: char = '.'; [INFO] [stderr] | ^^^^^ help: convert the identifier to upper case: `EMPTY` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_upper_case_globals)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stderr] [INFO] [stderr] warning: static variable `tree` should have an upper case name [INFO] [stderr] --> src/day03.rs:72:8 [INFO] [stderr] | [INFO] [stderr] 72 | static tree: char = '#'; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] help: convert the identifier to upper case [INFO] [stderr] | [INFO] [stderr] 72 - static tree: char = '#'; [INFO] [stderr] 72 + static TREE: char = '#'; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stderr] --> src/day03.rs:132:45 [INFO] [stderr] | [INFO] [stderr] 132 | lines.push(String::from(raw_lines[i].clone())); [INFO] [stderr] | ^^^^^^^^ help: remove this redundant call [INFO] [stderr] | [INFO] [stderr] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stderr] = note: `#[warn(noop_method_call)]` on by default [INFO] [stderr] [INFO] [stderr] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stderr] --> src/day03.rs:177:45 [INFO] [stderr] | [INFO] [stderr] 177 | lines.push(String::from(raw_lines[i].clone())); [INFO] [stderr] | ^^^^^^^^ help: remove this redundant call [INFO] [stderr] | [INFO] [stderr] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stderr] [INFO] [stderr] warning: `advent-2020` (bin "advent-2020" test) generated 9 warnings (run `cargo fix --bin "advent-2020" --tests` to apply 5 suggestions) [INFO] [stderr] Finished `test` profile [unoptimized + debuginfo] target(s) in 0.02s [INFO] [stderr] Running unittests src/main.rs (/opt/rustwide/target/debug/deps/advent_2020-3d76e668aba85ed3) [INFO] [stdout] [INFO] [stdout] running 12 tests [INFO] [stdout] test day01::sum2_to_2020_mult_test ... ok [INFO] [stdout] test day02::parse_rule_test ... ok [INFO] [stdout] test day01::sum3_to_2020_mult_test ... ok [INFO] [stdout] test day02::valid_password_test ... ok [INFO] [stdout] test day03::test_part1 ... ok [INFO] [stdout] test day03::test_parse_lines ... ok [INFO] [stdout] test day04::batch_passports_parser_test ... ok [INFO] [stdout] test day04::invalid_passport_test ... ok [INFO] [stdout] test day04::valid_northpole_credential_test ... ok [INFO] [stdout] test day04::valid_passport_test ... ok [INFO] [stdout] test day04::passport_from_vector_test ... ok [INFO] [stdout] test day02::valid_password_part_2_test ... ok [INFO] [stdout] [INFO] [stdout] test result: ok. 12 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "1adc0803565939437de11c05d60d868eb805b7bf938ac5f27e7804fb27f5b1b1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1adc0803565939437de11c05d60d868eb805b7bf938ac5f27e7804fb27f5b1b1", kill_on_drop: false }` [INFO] [stdout] 1adc0803565939437de11c05d60d868eb805b7bf938ac5f27e7804fb27f5b1b1