[INFO] fetching crate weev 0.4.3... [INFO] checking weev-0.4.3 against master#8c32e313cccf7df531e2d49ffb8227bb92304aee for pr-145608-1 [INFO] extracting crate weev 0.4.3 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate weev 0.4.3 [INFO] finished tweaking crates.io crate weev 0.4.3 [INFO] tweaked toml for crates.io crate weev 0.4.3 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate weev 0.4.3 on toolchain 8c32e313cccf7df531e2d49ffb8227bb92304aee [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+8c32e313cccf7df531e2d49ffb8227bb92304aee" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate weev 0.4.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+8c32e313cccf7df531e2d49ffb8227bb92304aee" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded embedded-io-async v0.6.1 [INFO] [stderr] Downloaded once_map v0.4.19 [INFO] [stderr] Downloaded whisk v0.13.0 [INFO] [stderr] Downloaded mutex_trait2 v0.4.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+8c32e313cccf7df531e2d49ffb8227bb92304aee" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5d2a81d1cb7a33e112521b8d1477a1fbeb0a5929ee1252b787ab2bde4ce82292 [INFO] running `Command { std: "docker" "start" "-a" "5d2a81d1cb7a33e112521b8d1477a1fbeb0a5929ee1252b787ab2bde4ce82292", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5d2a81d1cb7a33e112521b8d1477a1fbeb0a5929ee1252b787ab2bde4ce82292", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5d2a81d1cb7a33e112521b8d1477a1fbeb0a5929ee1252b787ab2bde4ce82292", kill_on_drop: false }` [INFO] [stdout] 5d2a81d1cb7a33e112521b8d1477a1fbeb0a5929ee1252b787ab2bde4ce82292 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+8c32e313cccf7df531e2d49ffb8227bb92304aee" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b7d123d456b2fb2166405d2102c1a3bad0663374e32c2cab468a20e151407d9c [INFO] running `Command { std: "docker" "start" "-a" "b7d123d456b2fb2166405d2102c1a3bad0663374e32c2cab468a20e151407d9c", kill_on_drop: false }` [INFO] [stderr] Compiling embedded-io-async v0.6.1 [INFO] [stderr] Checking embedded-io v0.6.1 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking mutex_trait2 v0.4.3 [INFO] [stderr] Checking futures-lite v2.3.0 [INFO] [stderr] Checking weev v0.4.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `DerefMut`, `Deref`, and `iter` [INFO] [stdout] --> src/lib.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | iter, [INFO] [stdout] | ^^^^ [INFO] [stdout] 5 | ops::{Deref, DerefMut}, [INFO] [stdout] | ^^^^^ ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `AsyncMutex` and `Mutex` [INFO] [stdout] --> src/lib.rs:11:20 [INFO] [stdout] | [INFO] [stdout] 11 | use mutex_trait2::{AsyncMutex, Mutex}; [INFO] [stdout] | ^^^^^^^^^^ ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | let mut lock = self; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 44 | let mut lock = self; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:147:13 [INFO] [stdout] | [INFO] [stdout] 147 | let mut lock = &mut self.queue; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `embedded_io::Write` [INFO] [stdout] --> src/lib.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 61 | use embedded_io::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `embedded_io::Read` [INFO] [stdout] --> src/lib.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 72 | use embedded_io::Read; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:62:13 [INFO] [stdout] | [INFO] [stdout] 62 | let mut lock = self; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:73:13 [INFO] [stdout] | [INFO] [stdout] 73 | let mut lock = self; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:198:13 [INFO] [stdout] | [INFO] [stdout] 198 | let mut lock = &mut self.queue; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `async fn` in public traits is discouraged as auto trait bounds cannot be specified [INFO] [stdout] --> src/lib.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | async fn send_packet(&mut self, s: Sid, x: &[u8]) -> Result<(), Self::Error>; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: you can suppress this lint if you plan to use the trait only in your own code, or do not care about auto traits like `Send` on the `Future` [INFO] [stdout] = note: `#[warn(async_fn_in_trait)]` on by default [INFO] [stdout] help: you can alternatively desugar to a normal `fn` that returns `impl Future` and add any desired bounds such as `Send`, but these cannot be relaxed without a breaking API change [INFO] [stdout] | [INFO] [stdout] 21 - async fn send_packet(&mut self, s: Sid, x: &[u8]) -> Result<(), Self::Error>; [INFO] [stdout] 21 + fn send_packet(&mut self, s: Sid, x: &[u8]) -> impl std::future::Future> + Send; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `async fn` in public traits is discouraged as auto trait bounds cannot be specified [INFO] [stdout] --> src/lib.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | async fn recv_packet( [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: you can suppress this lint if you plan to use the trait only in your own code, or do not care about auto traits like `Send` on the `Future` [INFO] [stdout] help: you can alternatively desugar to a normal `fn` that returns `impl Future` and add any desired bounds such as `Send`, but these cannot be relaxed without a breaking API change [INFO] [stdout] | [INFO] [stdout] 22 ~ fn recv_packet( [INFO] [stdout] 23 | &mut self, [INFO] [stdout] 24 | b: &mut [u8], [INFO] [stdout] 25 ~ ) -> impl std::future::Future>> + Send; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `async fn` in public traits is discouraged as auto trait bounds cannot be specified [INFO] [stdout] --> src/lib.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 90 | async fn push(&self, s: Sid, a: &[u8]); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: you can suppress this lint if you plan to use the trait only in your own code, or do not care about auto traits like `Send` on the `Future` [INFO] [stdout] help: you can alternatively desugar to a normal `fn` that returns `impl Future` and add any desired bounds such as `Send`, but these cannot be relaxed without a breaking API change [INFO] [stdout] | [INFO] [stdout] 90 - async fn push(&self, s: Sid, a: &[u8]); [INFO] [stdout] 90 + fn push(&self, s: Sid, a: &[u8]) -> impl std::future::Future + Send; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `async fn` in public traits is discouraged as auto trait bounds cannot be specified [INFO] [stdout] --> src/lib.rs:91:5 [INFO] [stdout] | [INFO] [stdout] 91 | async fn pop(&self, s: Sid, len: usize) -> impl futures_lite::Stream; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: you can suppress this lint if you plan to use the trait only in your own code, or do not care about auto traits like `Send` on the `Future` [INFO] [stdout] help: you can alternatively desugar to a normal `fn` that returns `impl Future` and add any desired bounds such as `Send`, but these cannot be relaxed without a breaking API change [INFO] [stdout] | [INFO] [stdout] 91 - async fn pop(&self, s: Sid, len: usize) -> impl futures_lite::Stream; [INFO] [stdout] 91 + fn pop(&self, s: Sid, len: usize) -> impl std::future::Future> + Send; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `DerefMut`, `Deref`, and `iter` [INFO] [stdout] --> src/lib.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | iter, [INFO] [stdout] | ^^^^ [INFO] [stdout] 5 | ops::{Deref, DerefMut}, [INFO] [stdout] | ^^^^^ ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `AsyncMutex` and `Mutex` [INFO] [stdout] --> src/lib.rs:11:20 [INFO] [stdout] | [INFO] [stdout] 11 | use mutex_trait2::{AsyncMutex, Mutex}; [INFO] [stdout] | ^^^^^^^^^^ ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | let mut lock = self; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 44 | let mut lock = self; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:147:13 [INFO] [stdout] | [INFO] [stdout] 147 | let mut lock = &mut self.queue; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `embedded_io::Write` [INFO] [stdout] --> src/lib.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 61 | use embedded_io::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `embedded_io::Read` [INFO] [stdout] --> src/lib.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 72 | use embedded_io::Read; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:62:13 [INFO] [stdout] | [INFO] [stdout] 62 | let mut lock = self; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:73:13 [INFO] [stdout] | [INFO] [stdout] 73 | let mut lock = self; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:198:13 [INFO] [stdout] | [INFO] [stdout] 198 | let mut lock = &mut self.queue; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `async fn` in public traits is discouraged as auto trait bounds cannot be specified [INFO] [stdout] --> src/lib.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | async fn send_packet(&mut self, s: Sid, x: &[u8]) -> Result<(), Self::Error>; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: you can suppress this lint if you plan to use the trait only in your own code, or do not care about auto traits like `Send` on the `Future` [INFO] [stdout] = note: `#[warn(async_fn_in_trait)]` on by default [INFO] [stdout] help: you can alternatively desugar to a normal `fn` that returns `impl Future` and add any desired bounds such as `Send`, but these cannot be relaxed without a breaking API change [INFO] [stdout] | [INFO] [stdout] 21 - async fn send_packet(&mut self, s: Sid, x: &[u8]) -> Result<(), Self::Error>; [INFO] [stdout] 21 + fn send_packet(&mut self, s: Sid, x: &[u8]) -> impl std::future::Future> + Send; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `async fn` in public traits is discouraged as auto trait bounds cannot be specified [INFO] [stdout] --> src/lib.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | async fn recv_packet( [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: you can suppress this lint if you plan to use the trait only in your own code, or do not care about auto traits like `Send` on the `Future` [INFO] [stdout] help: you can alternatively desugar to a normal `fn` that returns `impl Future` and add any desired bounds such as `Send`, but these cannot be relaxed without a breaking API change [INFO] [stdout] | [INFO] [stdout] 22 ~ fn recv_packet( [INFO] [stdout] 23 | &mut self, [INFO] [stdout] 24 | b: &mut [u8], [INFO] [stdout] 25 ~ ) -> impl std::future::Future>> + Send; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `async fn` in public traits is discouraged as auto trait bounds cannot be specified [INFO] [stdout] --> src/lib.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 90 | async fn push(&self, s: Sid, a: &[u8]); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: you can suppress this lint if you plan to use the trait only in your own code, or do not care about auto traits like `Send` on the `Future` [INFO] [stdout] help: you can alternatively desugar to a normal `fn` that returns `impl Future` and add any desired bounds such as `Send`, but these cannot be relaxed without a breaking API change [INFO] [stdout] | [INFO] [stdout] 90 - async fn push(&self, s: Sid, a: &[u8]); [INFO] [stdout] 90 + fn push(&self, s: Sid, a: &[u8]) -> impl std::future::Future + Send; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `async fn` in public traits is discouraged as auto trait bounds cannot be specified [INFO] [stdout] --> src/lib.rs:91:5 [INFO] [stdout] | [INFO] [stdout] 91 | async fn pop(&self, s: Sid, len: usize) -> impl futures_lite::Stream; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: you can suppress this lint if you plan to use the trait only in your own code, or do not care about auto traits like `Send` on the `Future` [INFO] [stdout] help: you can alternatively desugar to a normal `fn` that returns `impl Future` and add any desired bounds such as `Send`, but these cannot be relaxed without a breaking API change [INFO] [stdout] | [INFO] [stdout] 91 - async fn pop(&self, s: Sid, len: usize) -> impl futures_lite::Stream; [INFO] [stdout] 91 + fn pop(&self, s: Sid, len: usize) -> impl std::future::Future> + Send; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.24s [INFO] running `Command { std: "docker" "inspect" "b7d123d456b2fb2166405d2102c1a3bad0663374e32c2cab468a20e151407d9c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b7d123d456b2fb2166405d2102c1a3bad0663374e32c2cab468a20e151407d9c", kill_on_drop: false }` [INFO] [stdout] b7d123d456b2fb2166405d2102c1a3bad0663374e32c2cab468a20e151407d9c