[INFO] fetching crate timer 0.2.0... [INFO] checking timer-0.2.0 against master#8c32e313cccf7df531e2d49ffb8227bb92304aee for pr-145608-1 [INFO] extracting crate timer 0.2.0 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate timer 0.2.0 [INFO] finished tweaking crates.io crate timer 0.2.0 [INFO] tweaked toml for crates.io crate timer 0.2.0 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate timer 0.2.0 on toolchain 8c32e313cccf7df531e2d49ffb8227bb92304aee [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+8c32e313cccf7df531e2d49ffb8227bb92304aee" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+8c32e313cccf7df531e2d49ffb8227bb92304aee" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 33 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+8c32e313cccf7df531e2d49ffb8227bb92304aee" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+8c32e313cccf7df531e2d49ffb8227bb92304aee" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9f806b0d9d8e2ea357e3f3d95a9795a16f80c01712e88d9a4c88424d5c789aca [INFO] running `Command { std: "docker" "start" "-a" "9f806b0d9d8e2ea357e3f3d95a9795a16f80c01712e88d9a4c88424d5c789aca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9f806b0d9d8e2ea357e3f3d95a9795a16f80c01712e88d9a4c88424d5c789aca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9f806b0d9d8e2ea357e3f3d95a9795a16f80c01712e88d9a4c88424d5c789aca", kill_on_drop: false }` [INFO] [stdout] 9f806b0d9d8e2ea357e3f3d95a9795a16f80c01712e88d9a4c88424d5c789aca [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+8c32e313cccf7df531e2d49ffb8227bb92304aee" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] af7509f8fa535e6b2f8f9ed48f178bafb5827f2c0ab68c5a0a461bbc6e1cf9f1 [INFO] running `Command { std: "docker" "start" "-a" "af7509f8fa535e6b2f8f9ed48f178bafb5827f2c0ab68c5a0a461bbc6e1cf9f1", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] [stderr] Checking chrono v0.4.41 [INFO] [stderr] Checking timer v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:337:25 [INFO] [stdout] | [INFO] [stdout] 337 | base: TimerBase> [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 337 | base: TimerBase> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:105:19 [INFO] [stdout] | [INFO] [stdout] 105 | impl Executor> for CallbackExecutor { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 105 | impl Executor> for CallbackExecutor { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:106:42 [INFO] [stdout] | [INFO] [stdout] 106 | fn execute(&mut self, mut data : Box) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 106 | fn execute(&mut self, mut data : Box) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:110:48 [INFO] [stdout] | [INFO] [stdout] 110 | fn execute_clone(&mut self, mut data : Box) -> Box { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 110 | fn execute_clone(&mut self, mut data : Box) -> Box { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:110:72 [INFO] [stdout] | [INFO] [stdout] 110 | fn execute_clone(&mut self, mut data : Box) -> Box { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 110 | fn execute_clone(&mut self, mut data : Box) -> Box { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:337:25 [INFO] [stdout] | [INFO] [stdout] 337 | base: TimerBase> [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 337 | base: TimerBase> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: non-binding let on a synchronization lock [INFO] [stdout] --> src/lib.rs:217:25 [INFO] [stdout] | [INFO] [stdout] 217 | let _ = waiter.condvar.wait(lock); [INFO] [stdout] | ^ this lock is not assigned to a binding and is immediately dropped [INFO] [stdout] | [INFO] [stdout] = note: `#[deny(let_underscore_lock)]` on by default [INFO] [stdout] help: consider binding to an unused variable to avoid immediately dropping the value [INFO] [stdout] | [INFO] [stdout] 217 | let _unused = waiter.condvar.wait(lock); [INFO] [stdout] | ++++++ [INFO] [stdout] help: consider immediately dropping the value [INFO] [stdout] | [INFO] [stdout] 217 - let _ = waiter.condvar.wait(lock); [INFO] [stdout] 217 + drop(waiter.condvar.wait(lock)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:105:19 [INFO] [stdout] | [INFO] [stdout] 105 | impl Executor> for CallbackExecutor { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 105 | impl Executor> for CallbackExecutor { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:106:42 [INFO] [stdout] | [INFO] [stdout] 106 | fn execute(&mut self, mut data : Box) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 106 | fn execute(&mut self, mut data : Box) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:110:48 [INFO] [stdout] | [INFO] [stdout] 110 | fn execute_clone(&mut self, mut data : Box) -> Box { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 110 | fn execute_clone(&mut self, mut data : Box) -> Box { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:110:72 [INFO] [stdout] | [INFO] [stdout] 110 | fn execute_clone(&mut self, mut data : Box) -> Box { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 110 | fn execute_clone(&mut self, mut data : Box) -> Box { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `timer` (lib) due to 1 previous error; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: non-binding let on a synchronization lock [INFO] [stdout] --> src/lib.rs:217:25 [INFO] [stdout] | [INFO] [stdout] 217 | let _ = waiter.condvar.wait(lock); [INFO] [stdout] | ^ this lock is not assigned to a binding and is immediately dropped [INFO] [stdout] | [INFO] [stdout] = note: `#[deny(let_underscore_lock)]` on by default [INFO] [stdout] help: consider binding to an unused variable to avoid immediately dropping the value [INFO] [stdout] | [INFO] [stdout] 217 | let _unused = waiter.condvar.wait(lock); [INFO] [stdout] | ++++++ [INFO] [stdout] help: consider immediately dropping the value [INFO] [stdout] | [INFO] [stdout] 217 - let _ = waiter.condvar.wait(lock); [INFO] [stdout] 217 + drop(waiter.condvar.wait(lock)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `timer` (lib test) due to 1 previous error; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "af7509f8fa535e6b2f8f9ed48f178bafb5827f2c0ab68c5a0a461bbc6e1cf9f1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "af7509f8fa535e6b2f8f9ed48f178bafb5827f2c0ab68c5a0a461bbc6e1cf9f1", kill_on_drop: false }` [INFO] [stdout] af7509f8fa535e6b2f8f9ed48f178bafb5827f2c0ab68c5a0a461bbc6e1cf9f1