[INFO] fetching crate go-types 0.1.5... [INFO] checking go-types-0.1.5 against master#8c32e313cccf7df531e2d49ffb8227bb92304aee for pr-145608-1 [INFO] extracting crate go-types 0.1.5 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate go-types 0.1.5 [INFO] finished tweaking crates.io crate go-types 0.1.5 [INFO] tweaked toml for crates.io crate go-types 0.1.5 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate go-types 0.1.5 on toolchain 8c32e313cccf7df531e2d49ffb8227bb92304aee [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+8c32e313cccf7df531e2d49ffb8227bb92304aee" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+8c32e313cccf7df531e2d49ffb8227bb92304aee" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 12 packages to latest compatible versions [INFO] [stderr] Adding ordered-float v3.9.2 (available: v5.0.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+8c32e313cccf7df531e2d49ffb8227bb92304aee" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded go-parser v0.1.5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+8c32e313cccf7df531e2d49ffb8227bb92304aee" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1ca1f96b241f1c8da760d1e00d5894f4caa907db2bf832cf8368d46207f4edd5 [INFO] running `Command { std: "docker" "start" "-a" "1ca1f96b241f1c8da760d1e00d5894f4caa907db2bf832cf8368d46207f4edd5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1ca1f96b241f1c8da760d1e00d5894f4caa907db2bf832cf8368d46207f4edd5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1ca1f96b241f1c8da760d1e00d5894f4caa907db2bf832cf8368d46207f4edd5", kill_on_drop: false }` [INFO] [stdout] 1ca1f96b241f1c8da760d1e00d5894f4caa907db2bf832cf8368d46207f4edd5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+8c32e313cccf7df531e2d49ffb8227bb92304aee" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 53b7324c08e9a1cc9479e5e2205f2cc9cae744842cab1b466091af8487467d30 [INFO] running `Command { std: "docker" "start" "-a" "53b7324c08e9a1cc9479e5e2205f2cc9cae744842cab1b466091af8487467d30", kill_on_drop: false }` [INFO] [stderr] Checking regex-syntax v0.8.6 [INFO] [stderr] Checking go-parser v0.1.5 [INFO] [stderr] Checking ordered-float v3.9.2 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking go-types v0.1.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/constant.rs:234:19 [INFO] [stdout] | [INFO] [stdout] 234 | pub fn to_int(&self) -> Cow { [INFO] [stdout] | ^^^^^ ---------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 234 | pub fn to_int(&self) -> Cow<'_, Value> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/obj.rs:352:15 [INFO] [stdout] | [INFO] [stdout] 352 | pub fn id(&self, objs: &TCObjects) -> Cow { [INFO] [stdout] | ^^^^^ -------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 352 | pub fn id(&self, objs: &TCObjects) -> Cow<'_, str> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/objects.rs:49:29 [INFO] [stdout] | [INFO] [stdout] 49 | fn default_fmt_qualifier(p: &Package) -> Cow { [INFO] [stdout] | ^^^^^^^^ -------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 49 | fn default_fmt_qualifier(p: &Package) -> Cow<'_, str> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/typ.rs:763:24 [INFO] [stdout] | [INFO] [stdout] 763 | pub fn all_methods(&self) -> Ref>> { [INFO] [stdout] | ^^^^^ ------------------------ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 763 | pub fn all_methods(&self) -> Ref<'_, Option>> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/typ.rs:767:28 [INFO] [stdout] | [INFO] [stdout] 767 | pub fn all_methods_mut(&self) -> RefMut>> { [INFO] [stdout] | ^^^^^ --------------------------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 767 | pub fn all_methods_mut(&self) -> RefMut<'_, Option>> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/check/check.rs:466:25 [INFO] [stdout] | [INFO] [stdout] 466 | pub fn new_importer(&mut self, pos: Pos) -> Importer { [INFO] [stdout] | ^^^^^^^^^ ----------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 466 | pub fn new_importer(&mut self, pos: Pos) -> Importer<'_, S> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/check/typexpr.rs:632:61 [INFO] [stdout] | [INFO] [stdout] 632 | if info.is_none() || info.as_ref().unwrap().as_ref().borrow().is_empty() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `IfaceInfo` does not implement `Borrow`, so calling `borrow` on `&IfaceInfo` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 632 - if info.is_none() || info.as_ref().unwrap().as_ref().borrow().is_empty() { [INFO] [stdout] 632 + if info.is_none() || info.as_ref().unwrap().as_ref().is_empty() { [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `IfaceInfo`, implement `Clone` for it [INFO] [stdout] --> src/check/interface.rs:143:1 [INFO] [stdout] | [INFO] [stdout] 143 + #[derive(Clone)] [INFO] [stdout] 144 | pub struct IfaceInfo { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/check/typexpr.rs:654:55 [INFO] [stdout] | [INFO] [stdout] 654 | let info_ref = info.as_ref().unwrap().as_ref().borrow(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `IfaceInfo` does not implement `Borrow`, so calling `borrow` on `&IfaceInfo` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 654 - let info_ref = info.as_ref().unwrap().as_ref().borrow(); [INFO] [stdout] 654 + let info_ref = info.as_ref().unwrap().as_ref(); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `IfaceInfo`, implement `Clone` for it [INFO] [stdout] --> src/check/interface.rs:143:1 [INFO] [stdout] | [INFO] [stdout] 143 + #[derive(Clone)] [INFO] [stdout] 144 | pub struct IfaceInfo { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking regex-automata v0.4.10 [INFO] [stderr] Checking regex v1.11.2 [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/constant.rs:234:19 [INFO] [stdout] | [INFO] [stdout] 234 | pub fn to_int(&self) -> Cow { [INFO] [stdout] | ^^^^^ ---------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 234 | pub fn to_int(&self) -> Cow<'_, Value> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/obj.rs:352:15 [INFO] [stdout] | [INFO] [stdout] 352 | pub fn id(&self, objs: &TCObjects) -> Cow { [INFO] [stdout] | ^^^^^ -------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 352 | pub fn id(&self, objs: &TCObjects) -> Cow<'_, str> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/objects.rs:49:29 [INFO] [stdout] | [INFO] [stdout] 49 | fn default_fmt_qualifier(p: &Package) -> Cow { [INFO] [stdout] | ^^^^^^^^ -------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 49 | fn default_fmt_qualifier(p: &Package) -> Cow<'_, str> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/typ.rs:763:24 [INFO] [stdout] | [INFO] [stdout] 763 | pub fn all_methods(&self) -> Ref>> { [INFO] [stdout] | ^^^^^ ------------------------ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 763 | pub fn all_methods(&self) -> Ref<'_, Option>> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/typ.rs:767:28 [INFO] [stdout] | [INFO] [stdout] 767 | pub fn all_methods_mut(&self) -> RefMut>> { [INFO] [stdout] | ^^^^^ --------------------------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 767 | pub fn all_methods_mut(&self) -> RefMut<'_, Option>> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/check/check.rs:466:25 [INFO] [stdout] | [INFO] [stdout] 466 | pub fn new_importer(&mut self, pos: Pos) -> Importer { [INFO] [stdout] | ^^^^^^^^^ ----------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 466 | pub fn new_importer(&mut self, pos: Pos) -> Importer<'_, S> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/check/typexpr.rs:632:61 [INFO] [stdout] | [INFO] [stdout] 632 | if info.is_none() || info.as_ref().unwrap().as_ref().borrow().is_empty() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `IfaceInfo` does not implement `Borrow`, so calling `borrow` on `&IfaceInfo` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 632 - if info.is_none() || info.as_ref().unwrap().as_ref().borrow().is_empty() { [INFO] [stdout] 632 + if info.is_none() || info.as_ref().unwrap().as_ref().is_empty() { [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `IfaceInfo`, implement `Clone` for it [INFO] [stdout] --> src/check/interface.rs:143:1 [INFO] [stdout] | [INFO] [stdout] 143 + #[derive(Clone)] [INFO] [stdout] 144 | pub struct IfaceInfo { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/check/typexpr.rs:654:55 [INFO] [stdout] | [INFO] [stdout] 654 | let info_ref = info.as_ref().unwrap().as_ref().borrow(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `IfaceInfo` does not implement `Borrow`, so calling `borrow` on `&IfaceInfo` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 654 - let info_ref = info.as_ref().unwrap().as_ref().borrow(); [INFO] [stdout] 654 + let info_ref = info.as_ref().unwrap().as_ref(); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `IfaceInfo`, implement `Clone` for it [INFO] [stdout] --> src/check/interface.rs:143:1 [INFO] [stdout] | [INFO] [stdout] 143 + #[derive(Clone)] [INFO] [stdout] 144 | pub struct IfaceInfo { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.19s [INFO] running `Command { std: "docker" "inspect" "53b7324c08e9a1cc9479e5e2205f2cc9cae744842cab1b466091af8487467d30", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "53b7324c08e9a1cc9479e5e2205f2cc9cae744842cab1b466091af8487467d30", kill_on_drop: false }` [INFO] [stdout] 53b7324c08e9a1cc9479e5e2205f2cc9cae744842cab1b466091af8487467d30