[INFO] fetching crate gavle 0.1.1... [INFO] checking gavle-0.1.1 against try#a4980311fb7bb9e7893708e6bd3fbbfb2819fd3d for pr-145342-1 [INFO] extracting crate gavle 0.1.1 into /workspace/builds/worker-4-tc2/source [INFO] started tweaking crates.io crate gavle 0.1.1 [INFO] finished tweaking crates.io crate gavle 0.1.1 [INFO] tweaked toml for crates.io crate gavle 0.1.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] validating manifest of crates.io crate gavle 0.1.1 on toolchain a4980311fb7bb9e7893708e6bd3fbbfb2819fd3d [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a4980311fb7bb9e7893708e6bd3fbbfb2819fd3d" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a4980311fb7bb9e7893708e6bd3fbbfb2819fd3d" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 35 packages to latest compatible versions [INFO] [stderr] Adding arrayvec v0.6.1 (available: v0.7.6) [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.9.3) [INFO] [stderr] Adding glow v0.11.2 (available: v0.16.0) [INFO] [stderr] Adding image v0.23.14 (available: v0.25.6) [INFO] [stderr] Adding thiserror v1.0.69 (available: v2.0.16) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a4980311fb7bb9e7893708e6bd3fbbfb2819fd3d" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+a4980311fb7bb9e7893708e6bd3fbbfb2819fd3d" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 89dd1a3e8a22968e06be54ce6f80c192a943a72391ecb8d4293a97f9723b74e7 [INFO] running `Command { std: "docker" "start" "-a" "89dd1a3e8a22968e06be54ce6f80c192a943a72391ecb8d4293a97f9723b74e7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "89dd1a3e8a22968e06be54ce6f80c192a943a72391ecb8d4293a97f9723b74e7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "89dd1a3e8a22968e06be54ce6f80c192a943a72391ecb8d4293a97f9723b74e7", kill_on_drop: false }` [INFO] [stdout] 89dd1a3e8a22968e06be54ce6f80c192a943a72391ecb8d4293a97f9723b74e7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+a4980311fb7bb9e7893708e6bd3fbbfb2819fd3d" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 27904cc301a6d911ac34db179334b3fd5b04141fe36733620b24574c9f5272b1 [INFO] running `Command { std: "docker" "start" "-a" "27904cc301a6d911ac34db179334b3fd5b04141fe36733620b24574c9f5272b1", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.101 [INFO] [stderr] Compiling unicode-ident v1.0.18 [INFO] [stderr] Compiling thiserror v1.0.69 [INFO] [stderr] Checking cfg-if v1.0.3 [INFO] [stderr] Checking glow v0.11.2 [INFO] [stderr] Checking arrayvec v0.6.1 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking log v0.4.27 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking tinyvec v1.10.0 [INFO] [stderr] Checking generational-arena v0.2.9 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking gavle v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `write_locks` is never used [INFO] [stdout] --> src/access.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 33 | pub trait AccessLock { [INFO] [stdout] | ---------- method in this trait [INFO] [stdout] 34 | /** The current number of active read locks on this object. */ [INFO] [stdout] 35 | fn write_locks(&self) -> usize; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/lib.rs:402:19 [INFO] [stdout] | [INFO] [stdout] 402 | for texture in attachments { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 402 - for texture in attachments { [INFO] [stdout] 402 + while let Some(texture) = attachments { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 402 - for texture in attachments { [INFO] [stdout] 402 + if let Some(texture) = attachments { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:954:48 [INFO] [stdout] | [INFO] [stdout] 954 | let vertex_shader = descriptor.vertex.shader.clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `shader::VertexShader` does not implement `Clone`, so calling `clone` on `&shader::VertexShader` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 954 - let vertex_shader = descriptor.vertex.shader.clone(); [INFO] [stdout] 954 + let vertex_shader = descriptor.vertex.shader; [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `shader::VertexShader`, implement `Clone` for it [INFO] [stdout] --> src/shader.rs:61:3 [INFO] [stdout] | [INFO] [stdout] 61 + #[derive(Clone)] [INFO] [stdout] 62 | pub struct $name { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:959:49 [INFO] [stdout] | [INFO] [stdout] 959 | let fragment_shader = fragment_state.shader.clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `shader::FragmentShader` does not implement `Clone`, so calling `clone` on `&shader::FragmentShader` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 959 - let fragment_shader = fragment_state.shader.clone(); [INFO] [stdout] 959 + let fragment_shader = fragment_state.shader; [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `shader::FragmentShader`, implement `Clone` for it [INFO] [stdout] --> src/shader.rs:61:3 [INFO] [stdout] | [INFO] [stdout] 61 + #[derive(Clone)] [INFO] [stdout] 62 | pub struct $name { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/buffer.rs:84:14 [INFO] [stdout] | [INFO] [stdout] 84 | fn slice(&self, range: R) -> BufferSlice [INFO] [stdout] | ^^^^^ ----------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 84 | fn slice(&self, range: R) -> BufferSlice<'_> [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/buffer.rs:117:16 [INFO] [stdout] | [INFO] [stdout] 117 | fn slice(&self, range: R) -> BufferSlice [INFO] [stdout] | ^^^^^ ----------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] ... [INFO] [stdout] 195 | / instance_buffers! { [INFO] [stdout] 196 | | #[derive(Debug)] [INFO] [stdout] 197 | | #[doc = "A buffer type that may be used for vertex storage."] [INFO] [stdout] 198 | | pub struct VertexBuffer: glow::ARRAY_BUFFER; [INFO] [stdout] ... | [INFO] [stdout] 204 | | pub struct UniformBuffer: glow::UNIFORM_BUFFER; [INFO] [stdout] 205 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: this warning originates in the macro `instance_buffers` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 117 | fn slice(&self, range: R) -> BufferSlice<'_> [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/buffer.rs:269:17 [INFO] [stdout] | [INFO] [stdout] 269 | pub fn try_map(&self) -> Result { [INFO] [stdout] | ^^^^^ ---------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 269 | pub fn try_map(&self) -> Result, BufferRemap> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/buffer.rs:350:3 [INFO] [stdout] | [INFO] [stdout] 350 | &self, [INFO] [stdout] | ^^^^^ the lifetime is elided here [INFO] [stdout] 351 | op: BufferLoadOp) -> Result { [INFO] [stdout] | ------------- the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 351 | op: BufferLoadOp) -> Result, BufferRemap> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/pipeline.rs:254:19 [INFO] [stdout] | [INFO] [stdout] 254 | for texture in &fb.depth_stencil { texture.acquire_write() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 254 - for texture in &fb.depth_stencil { texture.acquire_write() } [INFO] [stdout] 254 + while let Some(texture) = &fb.depth_stencil { texture.acquire_write() } [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 254 - for texture in &fb.depth_stencil { texture.acquire_write() } [INFO] [stdout] 254 + if let Some(texture) = &fb.depth_stencil { texture.acquire_write() } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/pipeline.rs:256:19 [INFO] [stdout] | [INFO] [stdout] 256 | for texture in &fb.depth_stencil { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 256 - for texture in &fb.depth_stencil { [INFO] [stdout] 256 + while let Some(texture) = &fb.depth_stencil { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 256 - for texture in &fb.depth_stencil { [INFO] [stdout] 256 + if let Some(texture) = &fb.depth_stencil { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/pipeline.rs:292:19 [INFO] [stdout] | [INFO] [stdout] 292 | for texture in &fb.depth_stencil { texture.release_write() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 292 - for texture in &fb.depth_stencil { texture.release_write() } [INFO] [stdout] 292 + while let Some(texture) = &fb.depth_stencil { texture.release_write() } [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 292 - for texture in &fb.depth_stencil { texture.release_write() } [INFO] [stdout] 292 + if let Some(texture) = &fb.depth_stencil { texture.release_write() } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/pipeline.rs:294:19 [INFO] [stdout] | [INFO] [stdout] 294 | for texture in &fb.depth_stencil { texture.release_read() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 294 - for texture in &fb.depth_stencil { texture.release_read() } [INFO] [stdout] 294 + while let Some(texture) = &fb.depth_stencil { texture.release_read() } [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 294 - for texture in &fb.depth_stencil { texture.release_read() } [INFO] [stdout] 294 + if let Some(texture) = &fb.depth_stencil { texture.release_read() } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/access.rs:84:27 [INFO] [stdout] | [INFO] [stdout] 84 | fn acquire_write_guarded(&self) -> WriteGuard [INFO] [stdout] | ^^^^^ ---------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 84 | fn acquire_write_guarded(&self) -> WriteGuard<'_> [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/access.rs:93:26 [INFO] [stdout] | [INFO] [stdout] 93 | fn acquire_read_guarded(&self) -> ReadGuard [INFO] [stdout] | ^^^^^ --------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 93 | fn acquire_read_guarded(&self) -> ReadGuard<'_> [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/framebuffer.rs:31:18 [INFO] [stdout] | [INFO] [stdout] 31 | for texture in &self.depth_stencil { assert_eq!(texture.write_locks(), a) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 31 - for texture in &self.depth_stencil { assert_eq!(texture.write_locks(), a) } [INFO] [stdout] 31 + while let Some(texture) = &self.depth_stencil { assert_eq!(texture.write_locks(), a) } [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 31 - for texture in &self.depth_stencil { assert_eq!(texture.write_locks(), a) } [INFO] [stdout] 31 + if let Some(texture) = &self.depth_stencil { assert_eq!(texture.write_locks(), a) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/framebuffer.rs:38:18 [INFO] [stdout] | [INFO] [stdout] 38 | for texture in &self.depth_stencil { assert_eq!(texture.read_locks(), a) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 38 - for texture in &self.depth_stencil { assert_eq!(texture.read_locks(), a) } [INFO] [stdout] 38 + while let Some(texture) = &self.depth_stencil { assert_eq!(texture.read_locks(), a) } [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 38 - for texture in &self.depth_stencil { assert_eq!(texture.read_locks(), a) } [INFO] [stdout] 38 + if let Some(texture) = &self.depth_stencil { assert_eq!(texture.read_locks(), a) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/framebuffer.rs:45:18 [INFO] [stdout] | [INFO] [stdout] 45 | for texture in &self.depth_stencil { texture.acquire_write(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 45 - for texture in &self.depth_stencil { texture.acquire_write(); } [INFO] [stdout] 45 + while let Some(texture) = &self.depth_stencil { texture.acquire_write(); } [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 45 - for texture in &self.depth_stencil { texture.acquire_write(); } [INFO] [stdout] 45 + if let Some(texture) = &self.depth_stencil { texture.acquire_write(); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/framebuffer.rs:50:18 [INFO] [stdout] | [INFO] [stdout] 50 | for texture in &self.depth_stencil { texture.release_write(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 50 - for texture in &self.depth_stencil { texture.release_write(); } [INFO] [stdout] 50 + while let Some(texture) = &self.depth_stencil { texture.release_write(); } [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 50 - for texture in &self.depth_stencil { texture.release_write(); } [INFO] [stdout] 50 + if let Some(texture) = &self.depth_stencil { texture.release_write(); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/framebuffer.rs:55:18 [INFO] [stdout] | [INFO] [stdout] 55 | for texture in &self.depth_stencil { texture.acquire_read(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 55 - for texture in &self.depth_stencil { texture.acquire_read(); } [INFO] [stdout] 55 + while let Some(texture) = &self.depth_stencil { texture.acquire_read(); } [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 55 - for texture in &self.depth_stencil { texture.acquire_read(); } [INFO] [stdout] 55 + if let Some(texture) = &self.depth_stencil { texture.acquire_read(); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/framebuffer.rs:60:18 [INFO] [stdout] | [INFO] [stdout] 60 | for texture in &self.depth_stencil { texture.release_read(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 60 - for texture in &self.depth_stencil { texture.release_read(); } [INFO] [stdout] 60 + while let Some(texture) = &self.depth_stencil { texture.release_read(); } [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 60 - for texture in &self.depth_stencil { texture.release_read(); } [INFO] [stdout] 60 + if let Some(texture) = &self.depth_stencil { texture.release_read(); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `write_locks` is never used [INFO] [stdout] --> src/access.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 33 | pub trait AccessLock { [INFO] [stdout] | ---------- method in this trait [INFO] [stdout] 34 | /** The current number of active read locks on this object. */ [INFO] [stdout] 35 | fn write_locks(&self) -> usize; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/lib.rs:402:19 [INFO] [stdout] | [INFO] [stdout] 402 | for texture in attachments { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 402 - for texture in attachments { [INFO] [stdout] 402 + while let Some(texture) = attachments { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 402 - for texture in attachments { [INFO] [stdout] 402 + if let Some(texture) = attachments { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:954:48 [INFO] [stdout] | [INFO] [stdout] 954 | let vertex_shader = descriptor.vertex.shader.clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `shader::VertexShader` does not implement `Clone`, so calling `clone` on `&shader::VertexShader` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 954 - let vertex_shader = descriptor.vertex.shader.clone(); [INFO] [stdout] 954 + let vertex_shader = descriptor.vertex.shader; [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `shader::VertexShader`, implement `Clone` for it [INFO] [stdout] --> src/shader.rs:61:3 [INFO] [stdout] | [INFO] [stdout] 61 + #[derive(Clone)] [INFO] [stdout] 62 | pub struct $name { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:959:49 [INFO] [stdout] | [INFO] [stdout] 959 | let fragment_shader = fragment_state.shader.clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `shader::FragmentShader` does not implement `Clone`, so calling `clone` on `&shader::FragmentShader` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 959 - let fragment_shader = fragment_state.shader.clone(); [INFO] [stdout] 959 + let fragment_shader = fragment_state.shader; [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `shader::FragmentShader`, implement `Clone` for it [INFO] [stdout] --> src/shader.rs:61:3 [INFO] [stdout] | [INFO] [stdout] 61 + #[derive(Clone)] [INFO] [stdout] 62 | pub struct $name { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/buffer.rs:84:14 [INFO] [stdout] | [INFO] [stdout] 84 | fn slice(&self, range: R) -> BufferSlice [INFO] [stdout] | ^^^^^ ----------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 84 | fn slice(&self, range: R) -> BufferSlice<'_> [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/buffer.rs:117:16 [INFO] [stdout] | [INFO] [stdout] 117 | fn slice(&self, range: R) -> BufferSlice [INFO] [stdout] | ^^^^^ ----------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] ... [INFO] [stdout] 195 | / instance_buffers! { [INFO] [stdout] 196 | | #[derive(Debug)] [INFO] [stdout] 197 | | #[doc = "A buffer type that may be used for vertex storage."] [INFO] [stdout] 198 | | pub struct VertexBuffer: glow::ARRAY_BUFFER; [INFO] [stdout] ... | [INFO] [stdout] 204 | | pub struct UniformBuffer: glow::UNIFORM_BUFFER; [INFO] [stdout] 205 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: this warning originates in the macro `instance_buffers` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 117 | fn slice(&self, range: R) -> BufferSlice<'_> [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/buffer.rs:269:17 [INFO] [stdout] | [INFO] [stdout] 269 | pub fn try_map(&self) -> Result { [INFO] [stdout] | ^^^^^ ---------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 269 | pub fn try_map(&self) -> Result, BufferRemap> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/buffer.rs:350:3 [INFO] [stdout] | [INFO] [stdout] 350 | &self, [INFO] [stdout] | ^^^^^ the lifetime is elided here [INFO] [stdout] 351 | op: BufferLoadOp) -> Result { [INFO] [stdout] | ------------- the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 351 | op: BufferLoadOp) -> Result, BufferRemap> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/pipeline.rs:254:19 [INFO] [stdout] | [INFO] [stdout] 254 | for texture in &fb.depth_stencil { texture.acquire_write() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 254 - for texture in &fb.depth_stencil { texture.acquire_write() } [INFO] [stdout] 254 + while let Some(texture) = &fb.depth_stencil { texture.acquire_write() } [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 254 - for texture in &fb.depth_stencil { texture.acquire_write() } [INFO] [stdout] 254 + if let Some(texture) = &fb.depth_stencil { texture.acquire_write() } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/pipeline.rs:256:19 [INFO] [stdout] | [INFO] [stdout] 256 | for texture in &fb.depth_stencil { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 256 - for texture in &fb.depth_stencil { [INFO] [stdout] 256 + while let Some(texture) = &fb.depth_stencil { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 256 - for texture in &fb.depth_stencil { [INFO] [stdout] 256 + if let Some(texture) = &fb.depth_stencil { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/pipeline.rs:292:19 [INFO] [stdout] | [INFO] [stdout] 292 | for texture in &fb.depth_stencil { texture.release_write() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 292 - for texture in &fb.depth_stencil { texture.release_write() } [INFO] [stdout] 292 + while let Some(texture) = &fb.depth_stencil { texture.release_write() } [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 292 - for texture in &fb.depth_stencil { texture.release_write() } [INFO] [stdout] 292 + if let Some(texture) = &fb.depth_stencil { texture.release_write() } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/pipeline.rs:294:19 [INFO] [stdout] | [INFO] [stdout] 294 | for texture in &fb.depth_stencil { texture.release_read() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 294 - for texture in &fb.depth_stencil { texture.release_read() } [INFO] [stdout] 294 + while let Some(texture) = &fb.depth_stencil { texture.release_read() } [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 294 - for texture in &fb.depth_stencil { texture.release_read() } [INFO] [stdout] 294 + if let Some(texture) = &fb.depth_stencil { texture.release_read() } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/access.rs:84:27 [INFO] [stdout] | [INFO] [stdout] 84 | fn acquire_write_guarded(&self) -> WriteGuard [INFO] [stdout] | ^^^^^ ---------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 84 | fn acquire_write_guarded(&self) -> WriteGuard<'_> [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/access.rs:93:26 [INFO] [stdout] | [INFO] [stdout] 93 | fn acquire_read_guarded(&self) -> ReadGuard [INFO] [stdout] | ^^^^^ --------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 93 | fn acquire_read_guarded(&self) -> ReadGuard<'_> [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/framebuffer.rs:31:18 [INFO] [stdout] | [INFO] [stdout] 31 | for texture in &self.depth_stencil { assert_eq!(texture.write_locks(), a) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 31 - for texture in &self.depth_stencil { assert_eq!(texture.write_locks(), a) } [INFO] [stdout] 31 + while let Some(texture) = &self.depth_stencil { assert_eq!(texture.write_locks(), a) } [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 31 - for texture in &self.depth_stencil { assert_eq!(texture.write_locks(), a) } [INFO] [stdout] 31 + if let Some(texture) = &self.depth_stencil { assert_eq!(texture.write_locks(), a) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/framebuffer.rs:38:18 [INFO] [stdout] | [INFO] [stdout] 38 | for texture in &self.depth_stencil { assert_eq!(texture.read_locks(), a) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 38 - for texture in &self.depth_stencil { assert_eq!(texture.read_locks(), a) } [INFO] [stdout] 38 + while let Some(texture) = &self.depth_stencil { assert_eq!(texture.read_locks(), a) } [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 38 - for texture in &self.depth_stencil { assert_eq!(texture.read_locks(), a) } [INFO] [stdout] 38 + if let Some(texture) = &self.depth_stencil { assert_eq!(texture.read_locks(), a) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/framebuffer.rs:45:18 [INFO] [stdout] | [INFO] [stdout] 45 | for texture in &self.depth_stencil { texture.acquire_write(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 45 - for texture in &self.depth_stencil { texture.acquire_write(); } [INFO] [stdout] 45 + while let Some(texture) = &self.depth_stencil { texture.acquire_write(); } [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 45 - for texture in &self.depth_stencil { texture.acquire_write(); } [INFO] [stdout] 45 + if let Some(texture) = &self.depth_stencil { texture.acquire_write(); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/framebuffer.rs:50:18 [INFO] [stdout] | [INFO] [stdout] 50 | for texture in &self.depth_stencil { texture.release_write(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 50 - for texture in &self.depth_stencil { texture.release_write(); } [INFO] [stdout] 50 + while let Some(texture) = &self.depth_stencil { texture.release_write(); } [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 50 - for texture in &self.depth_stencil { texture.release_write(); } [INFO] [stdout] 50 + if let Some(texture) = &self.depth_stencil { texture.release_write(); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/framebuffer.rs:55:18 [INFO] [stdout] | [INFO] [stdout] 55 | for texture in &self.depth_stencil { texture.acquire_read(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 55 - for texture in &self.depth_stencil { texture.acquire_read(); } [INFO] [stdout] 55 + while let Some(texture) = &self.depth_stencil { texture.acquire_read(); } [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 55 - for texture in &self.depth_stencil { texture.acquire_read(); } [INFO] [stdout] 55 + if let Some(texture) = &self.depth_stencil { texture.acquire_read(); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/framebuffer.rs:60:18 [INFO] [stdout] | [INFO] [stdout] 60 | for texture in &self.depth_stencil { texture.release_read(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 60 - for texture in &self.depth_stencil { texture.release_read(); } [INFO] [stdout] 60 + while let Some(texture) = &self.depth_stencil { texture.release_read(); } [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 60 - for texture in &self.depth_stencil { texture.release_read(); } [INFO] [stdout] 60 + if let Some(texture) = &self.depth_stencil { texture.release_read(); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.22s [INFO] running `Command { std: "docker" "inspect" "27904cc301a6d911ac34db179334b3fd5b04141fe36733620b24574c9f5272b1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "27904cc301a6d911ac34db179334b3fd5b04141fe36733620b24574c9f5272b1", kill_on_drop: false }` [INFO] [stdout] 27904cc301a6d911ac34db179334b3fd5b04141fe36733620b24574c9f5272b1