[INFO] fetching crate astro 2.0.0... [INFO] checking astro-2.0.0 against try#a4980311fb7bb9e7893708e6bd3fbbfb2819fd3d for pr-145342-1 [INFO] extracting crate astro 2.0.0 into /workspace/builds/worker-5-tc2/source [INFO] started tweaking crates.io crate astro 2.0.0 [INFO] finished tweaking crates.io crate astro 2.0.0 [INFO] tweaked toml for crates.io crate astro 2.0.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] validating manifest of crates.io crate astro 2.0.0 on toolchain a4980311fb7bb9e7893708e6bd3fbbfb2819fd3d [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a4980311fb7bb9e7893708e6bd3fbbfb2819fd3d" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a4980311fb7bb9e7893708e6bd3fbbfb2819fd3d" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a4980311fb7bb9e7893708e6bd3fbbfb2819fd3d" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+a4980311fb7bb9e7893708e6bd3fbbfb2819fd3d" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4d821edb6609dc5fb5fe8f67ea3a785bcd6ae6de7bfde2fbf87f8d0227484f01 [INFO] running `Command { std: "docker" "start" "-a" "4d821edb6609dc5fb5fe8f67ea3a785bcd6ae6de7bfde2fbf87f8d0227484f01", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4d821edb6609dc5fb5fe8f67ea3a785bcd6ae6de7bfde2fbf87f8d0227484f01", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4d821edb6609dc5fb5fe8f67ea3a785bcd6ae6de7bfde2fbf87f8d0227484f01", kill_on_drop: false }` [INFO] [stdout] 4d821edb6609dc5fb5fe8f67ea3a785bcd6ae6de7bfde2fbf87f8d0227484f01 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+a4980311fb7bb9e7893708e6bd3fbbfb2819fd3d" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 77aef4d7460d38b19406e6e420f6e7b0e41db6d9a6d4273adefd8fb0520464c4 [INFO] running `Command { std: "docker" "start" "-a" "77aef4d7460d38b19406e6e420f6e7b0e41db6d9a6d4273adefd8fb0520464c4", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] [stderr] Checking astro v2.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/ecliptic.rs:45:35 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn mn_oblq_laskar(JD: f64) -> (f64) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 45 - pub fn mn_oblq_laskar(JD: f64) -> (f64) { [INFO] [stdout] 45 + pub fn mn_oblq_laskar(JD: f64) -> f64 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/ecliptic.rs:82:32 [INFO] [stdout] | [INFO] [stdout] 82 | pub fn mn_oblq_IAU(JD: f64) -> (f64) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 82 - pub fn mn_oblq_IAU(JD: f64) -> (f64) { [INFO] [stdout] 82 + pub fn mn_oblq_IAU(JD: f64) -> f64 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/lunar.rs:955:5 [INFO] [stdout] | [INFO] [stdout] 955 | / ( [INFO] [stdout] 956 | | 2451565.1619 [INFO] [stdout] | |________^ [INFO] [stdout] ... [INFO] [stdout] 985 | ) [INFO] [stdout] | __________^ [INFO] [stdout] 986 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 955 ~ 2451565.1619 [INFO] [stdout] 956 | + 27.212220817 * k [INFO] [stdout] ... [INFO] [stdout] 983 | + P.sin() [INFO] [stdout] 984 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/planet/jupiter/moon.rs:114:28 [INFO] [stdout] | [INFO] [stdout] 114 | &Moon::Io => (5.9057 - 0.0244*(2.0*(u1 - u2)).cos()), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 114 - &Moon::Io => (5.9057 - 0.0244*(2.0*(u1 - u2)).cos()), [INFO] [stdout] 114 + &Moon::Io => 5.9057 - 0.0244*(2.0*(u1 - u2)).cos(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/planet/jupiter/moon.rs:115:28 [INFO] [stdout] | [INFO] [stdout] 115 | &Moon::Europa => (9.3966 - 0.0882*(2.0*(u2 - u3)).cos()), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 115 - &Moon::Europa => (9.3966 - 0.0882*(2.0*(u2 - u3)).cos()), [INFO] [stdout] 115 + &Moon::Europa => 9.3966 - 0.0882*(2.0*(u2 - u3)).cos(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/planet/jupiter/moon.rs:116:28 [INFO] [stdout] | [INFO] [stdout] 116 | &Moon::Ganymede => (14.9883 - 0.0216*G.cos()), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 116 - &Moon::Ganymede => (14.9883 - 0.0216*G.cos()), [INFO] [stdout] 116 + &Moon::Ganymede => 14.9883 - 0.0216*G.cos(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/planet/jupiter/moon.rs:117:28 [INFO] [stdout] | [INFO] [stdout] 117 | &Moon::Callisto => (26.3627 - 0.1939*H.cos()), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 117 - &Moon::Callisto => (26.3627 - 0.1939*H.cos()), [INFO] [stdout] 117 + &Moon::Callisto => 26.3627 - 0.1939*H.cos(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/time.rs:130:55 [INFO] [stdout] | [INFO] [stdout] 130 | pub fn is_leap_year(year: i16, cal_type: &CalType) -> (bool) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 130 - pub fn is_leap_year(year: i16, cal_type: &CalType) -> (bool) { [INFO] [stdout] 130 + pub fn is_leap_year(year: i16, cal_type: &CalType) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/ecliptic.rs:45:35 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn mn_oblq_laskar(JD: f64) -> (f64) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 45 - pub fn mn_oblq_laskar(JD: f64) -> (f64) { [INFO] [stdout] 45 + pub fn mn_oblq_laskar(JD: f64) -> f64 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/ecliptic.rs:82:32 [INFO] [stdout] | [INFO] [stdout] 82 | pub fn mn_oblq_IAU(JD: f64) -> (f64) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 82 - pub fn mn_oblq_IAU(JD: f64) -> (f64) { [INFO] [stdout] 82 + pub fn mn_oblq_IAU(JD: f64) -> f64 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/lunar.rs:955:5 [INFO] [stdout] | [INFO] [stdout] 955 | / ( [INFO] [stdout] 956 | | 2451565.1619 [INFO] [stdout] | |________^ [INFO] [stdout] ... [INFO] [stdout] 985 | ) [INFO] [stdout] | __________^ [INFO] [stdout] 986 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 955 ~ 2451565.1619 [INFO] [stdout] 956 | + 27.212220817 * k [INFO] [stdout] ... [INFO] [stdout] 983 | + P.sin() [INFO] [stdout] 984 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/planet/jupiter/moon.rs:114:28 [INFO] [stdout] | [INFO] [stdout] 114 | &Moon::Io => (5.9057 - 0.0244*(2.0*(u1 - u2)).cos()), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 114 - &Moon::Io => (5.9057 - 0.0244*(2.0*(u1 - u2)).cos()), [INFO] [stdout] 114 + &Moon::Io => 5.9057 - 0.0244*(2.0*(u1 - u2)).cos(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/planet/jupiter/moon.rs:115:28 [INFO] [stdout] | [INFO] [stdout] 115 | &Moon::Europa => (9.3966 - 0.0882*(2.0*(u2 - u3)).cos()), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 115 - &Moon::Europa => (9.3966 - 0.0882*(2.0*(u2 - u3)).cos()), [INFO] [stdout] 115 + &Moon::Europa => 9.3966 - 0.0882*(2.0*(u2 - u3)).cos(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/planet/jupiter/moon.rs:116:28 [INFO] [stdout] | [INFO] [stdout] 116 | &Moon::Ganymede => (14.9883 - 0.0216*G.cos()), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 116 - &Moon::Ganymede => (14.9883 - 0.0216*G.cos()), [INFO] [stdout] 116 + &Moon::Ganymede => 14.9883 - 0.0216*G.cos(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/planet/jupiter/moon.rs:117:28 [INFO] [stdout] | [INFO] [stdout] 117 | &Moon::Callisto => (26.3627 - 0.1939*H.cos()), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 117 - &Moon::Callisto => (26.3627 - 0.1939*H.cos()), [INFO] [stdout] 117 + &Moon::Callisto => 26.3627 - 0.1939*H.cos(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/time.rs:130:55 [INFO] [stdout] | [INFO] [stdout] 130 | pub fn is_leap_year(year: i16, cal_type: &CalType) -> (bool) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 130 - pub fn is_leap_year(year: i16, cal_type: &CalType) -> (bool) { [INFO] [stdout] 130 + pub fn is_leap_year(year: i16, cal_type: &CalType) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused arithmetic operation that must be used [INFO] [stdout] --> src/lunar.rs:1117:11 [INFO] [stdout] | [INFO] [stdout] 1117 | - 0.00002 * ((M1 - M).cos() - (M1 + M).cos() - (2.0 * F).cos()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the arithmetic operation produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 1117 | let _ = - 0.00002 * ((M1 - M).cos() - (M1 + M).cos() - (2.0 * F).cos()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused arithmetic operation that must be used [INFO] [stdout] --> src/lunar.rs:1117:11 [INFO] [stdout] | [INFO] [stdout] 1117 | - 0.00002 * ((M1 - M).cos() - (M1 + M).cos() - (2.0 * F).cos()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the arithmetic operation produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 1117 | let _ = - 0.00002 * ((M1 - M).cos() - (M1 + M).cos() - (2.0 * F).cos()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> tests/parabolic.rs:70:40 [INFO] [stdout] | [INFO] [stdout] 70 | assert_eq!(util::round_upto_digits((T - ascen), 2), 4354.65); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 70 - assert_eq!(util::round_upto_digits((T - ascen), 2), 4354.65); [INFO] [stdout] 70 + assert_eq!(util::round_upto_digits(T - ascen, 2), 4354.65); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> tests/parabolic.rs:76:40 [INFO] [stdout] | [INFO] [stdout] 76 | assert_eq!(util::round_upto_digits((T - descend), 4), -28.3454); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 76 - assert_eq!(util::round_upto_digits((T - descend), 4), -28.3454); [INFO] [stdout] 76 + assert_eq!(util::round_upto_digits(T - descend, 4), -28.3454); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `#[macro_use]` import [INFO] [stdout] --> tests/time.rs:25:1 [INFO] [stdout] | [INFO] [stdout] 25 | #[macro_use] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `#[macro_use]` import [INFO] [stdout] --> tests/planet.rs:25:1 [INFO] [stdout] | [INFO] [stdout] 25 | #[macro_use] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> tests/elliptic.rs:70:40 [INFO] [stdout] | [INFO] [stdout] 70 | assert_eq!(util::round_upto_digits((T - ascen), 4), 92.2998); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 70 - assert_eq!(util::round_upto_digits((T - ascen), 4), 92.2998); [INFO] [stdout] 70 + assert_eq!(util::round_upto_digits(T - ascen, 4), 92.2998); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> tests/elliptic.rs:76:40 [INFO] [stdout] | [INFO] [stdout] 76 | assert_eq!(util::round_upto_digits((T - descend), 4), -28.9105); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 76 - assert_eq!(util::round_upto_digits((T - descend), 4), -28.9105); [INFO] [stdout] 76 + assert_eq!(util::round_upto_digits(T - descend, 4), -28.9105); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.43s [INFO] running `Command { std: "docker" "inspect" "77aef4d7460d38b19406e6e420f6e7b0e41db6d9a6d4273adefd8fb0520464c4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "77aef4d7460d38b19406e6e420f6e7b0e41db6d9a6d4273adefd8fb0520464c4", kill_on_drop: false }` [INFO] [stdout] 77aef4d7460d38b19406e6e420f6e7b0e41db6d9a6d4273adefd8fb0520464c4