[INFO] fetching crate reups 0.3.0... [INFO] checking reups-0.3.0 against master#350d0ef0ec0493e6d21cfb265cb8211a0e74d766 for pr-145342-1 [INFO] extracting crate reups 0.3.0 into /workspace/builds/worker-5-tc1/source [INFO] started tweaking crates.io crate reups 0.3.0 [INFO] finished tweaking crates.io crate reups 0.3.0 [INFO] tweaked toml for crates.io crate reups 0.3.0 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate reups 0.3.0 on toolchain 350d0ef0ec0493e6d21cfb265cb8211a0e74d766 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+350d0ef0ec0493e6d21cfb265cb8211a0e74d766" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+350d0ef0ec0493e6d21cfb265cb8211a0e74d766" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 59 packages to latest compatible versions [INFO] [stderr] Adding clap v2.34.0 (available: v4.5.45) [INFO] [stderr] Adding dirs v1.0.5 (available: v6.0.0) [INFO] [stderr] Adding petgraph v0.4.13 (available: v0.8.2) [INFO] [stderr] Adding preferences v1.1.0 (available: v2.0.0) [INFO] [stderr] Adding regex v0.2.11 (available: v1.11.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+350d0ef0ec0493e6d21cfb265cb8211a0e74d766" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded preferences v1.1.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+350d0ef0ec0493e6d21cfb265cb8211a0e74d766" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3b978607f2536869819249dea643492386f51cf4d4858b55e240085584116bf8 [INFO] running `Command { std: "docker" "start" "-a" "3b978607f2536869819249dea643492386f51cf4d4858b55e240085584116bf8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3b978607f2536869819249dea643492386f51cf4d4858b55e240085584116bf8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3b978607f2536869819249dea643492386f51cf4d4858b55e240085584116bf8", kill_on_drop: false }` [INFO] [stdout] 3b978607f2536869819249dea643492386f51cf4d4858b55e240085584116bf8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+350d0ef0ec0493e6d21cfb265cb8211a0e74d766" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 674d426a58b32986250b9b42b28404917af67c8af12cd4d123774772c3e8cdfa [INFO] running `Command { std: "docker" "start" "-a" "674d426a58b32986250b9b42b28404917af67c8af12cd4d123774772c3e8cdfa", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.5.0 [INFO] [stderr] Compiling libc v0.2.175 [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Checking dtoa v0.4.8 [INFO] [stderr] Checking ucd-util v0.1.10 [INFO] [stderr] Checking xdg v2.5.2 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking serde v0.9.15 [INFO] [stderr] Checking unicode-width v0.1.14 [INFO] [stderr] Checking memchr v2.7.5 [INFO] [stderr] Compiling regex v0.2.11 [INFO] [stderr] Checking itoa v0.3.4 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking fixedbitset v0.1.9 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking ordermap v0.3.5 [INFO] [stderr] Checking utf8-ranges v1.0.5 [INFO] [stderr] Checking regex-syntax v0.5.6 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking app_dirs v1.2.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking petgraph v0.4.13 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking aho-corasick v0.6.10 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking serde_json v0.9.10 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking dirs v1.0.5 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking preferences v1.1.0 [INFO] [stderr] Checking log v0.4.27 [INFO] [stderr] Checking reups v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `clap` [INFO] [stdout] --> src/lib.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use clap; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `dirs` [INFO] [stdout] --> src/lib.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use dirs; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `fnv` [INFO] [stdout] --> src/lib.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | use fnv; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `lazy_static` [INFO] [stdout] --> src/lib.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | use lazy_static; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `error` [INFO] [stdout] --> src/lib.rs:19:18 [INFO] [stdout] | [INFO] [stdout] 19 | use log::{debug, error, info, warn}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `preferences` [INFO] [stdout] --> src/lib.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | use preferences; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `regex` [INFO] [stdout] --> src/lib.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | use regex; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/db/table.rs:14:1 [INFO] [stdout] | [INFO] [stdout] 14 | / /**! [INFO] [stdout] 15 | | A Table object is the in memory representation of a products table file. [INFO] [stdout] 16 | | */ [INFO] [stdout] | |__^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] = note: `#[warn(unused_doc_comments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `clap` [INFO] [stdout] --> src/lib.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use clap; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `dirs` [INFO] [stdout] --> src/lib.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use dirs; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `fnv` [INFO] [stdout] --> src/lib.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | use fnv; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `lazy_static` [INFO] [stdout] --> src/lib.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | use lazy_static; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `error` [INFO] [stdout] --> src/lib.rs:19:18 [INFO] [stdout] | [INFO] [stdout] 19 | use log::{debug, error, info, warn}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `preferences` [INFO] [stdout] --> src/lib.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | use preferences; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `regex` [INFO] [stdout] --> src/lib.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | use regex; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/db/table.rs:14:1 [INFO] [stdout] | [INFO] [stdout] 14 | / /**! [INFO] [stdout] 15 | | A Table object is the in memory representation of a products table file. [INFO] [stdout] 16 | | */ [INFO] [stdout] | |__^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] = note: `#[warn(unused_doc_comments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `core::str::::trim_right_matches`: superseded by `trim_end_matches` [INFO] [stdout] --> src/list.rs:142:43 [INFO] [stdout] | [INFO] [stdout] 142 | println!("{}", self.output_string.trim_right_matches("\n\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] help: replace the use of the deprecated method [INFO] [stdout] | [INFO] [stdout] 142 - println!("{}", self.output_string.trim_right_matches("\n\n")); [INFO] [stdout] 142 + println!("{}", self.output_string.trim_end_matches("\n\n")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `core::str::::trim_right_matches`: superseded by `trim_end_matches` [INFO] [stdout] --> src/list.rs:205:34 [INFO] [stdout] | [INFO] [stdout] 205 | ... .trim_right_matches(", ") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace the use of the deprecated method [INFO] [stdout] | [INFO] [stdout] 205 - .trim_right_matches(", ") [INFO] [stdout] 205 + .trim_end_matches(", ") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `core::str::::trim_right_matches`: superseded by `trim_end_matches` [INFO] [stdout] --> src/list.rs:232:30 [INFO] [stdout] | [INFO] [stdout] 232 | ... .trim_right_matches(", ") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace the use of the deprecated method [INFO] [stdout] | [INFO] [stdout] 232 - .trim_right_matches(", ") [INFO] [stdout] 232 + .trim_end_matches(", ") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `core::str::::trim_right_matches`: superseded by `trim_end_matches` [INFO] [stdout] --> src/list.rs:142:43 [INFO] [stdout] | [INFO] [stdout] 142 | println!("{}", self.output_string.trim_right_matches("\n\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] help: replace the use of the deprecated method [INFO] [stdout] | [INFO] [stdout] 142 - println!("{}", self.output_string.trim_right_matches("\n\n")); [INFO] [stdout] 142 + println!("{}", self.output_string.trim_end_matches("\n\n")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `core::str::::trim_right_matches`: superseded by `trim_end_matches` [INFO] [stdout] --> src/list.rs:205:34 [INFO] [stdout] | [INFO] [stdout] 205 | ... .trim_right_matches(", ") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace the use of the deprecated method [INFO] [stdout] | [INFO] [stdout] 205 - .trim_right_matches(", ") [INFO] [stdout] 205 + .trim_end_matches(", ") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `core::str::::trim_right_matches`: superseded by `trim_end_matches` [INFO] [stdout] --> src/list.rs:232:30 [INFO] [stdout] | [INFO] [stdout] 232 | ... .trim_right_matches(", ") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace the use of the deprecated method [INFO] [stdout] | [INFO] [stdout] 232 - .trim_right_matches(", ") [INFO] [stdout] 232 + .trim_end_matches(", ") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&String` instead of cloning the inner type [INFO] [stdout] --> src/db/mod.rs:306:57 [INFO] [stdout] | [INFO] [stdout] 306 | if db.tag_to_product_info.contains_key(t.clone()) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&String` instead of cloning the inner type [INFO] [stdout] --> src/db/mod.rs:307:63 [INFO] [stdout] | [INFO] [stdout] 307 | let ref tag_map = db.tag_to_product_info[t.clone()]; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/db/graph.rs:52:21 [INFO] [stdout] | [INFO] [stdout] 52 | pub fn new(db: &'a DB) -> Graph { [INFO] [stdout] | ^^ ----- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is named here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 52 | pub fn new(db: &'a DB) -> Graph<'a> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&String` instead of cloning the inner type [INFO] [stdout] --> src/setup.rs:394:73 [INFO] [stdout] | [INFO] [stdout] 394 | let mut largest_version = versions.iter().max().unwrap().clone().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&String` instead of cloning the inner type [INFO] [stdout] --> src/db/mod.rs:306:57 [INFO] [stdout] | [INFO] [stdout] 306 | if db.tag_to_product_info.contains_key(t.clone()) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&String` instead of cloning the inner type [INFO] [stdout] --> src/db/mod.rs:307:63 [INFO] [stdout] | [INFO] [stdout] 307 | let ref tag_map = db.tag_to_product_info[t.clone()]; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/db/graph.rs:52:21 [INFO] [stdout] | [INFO] [stdout] 52 | pub fn new(db: &'a DB) -> Graph { [INFO] [stdout] | ^^ ----- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is named here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 52 | pub fn new(db: &'a DB) -> Graph<'a> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&String` instead of cloning the inner type [INFO] [stdout] --> src/setup.rs:394:73 [INFO] [stdout] | [INFO] [stdout] 394 | let mut largest_version = versions.iter().max().unwrap().clone().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.81s [INFO] running `Command { std: "docker" "inspect" "674d426a58b32986250b9b42b28404917af67c8af12cd4d123774772c3e8cdfa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "674d426a58b32986250b9b42b28404917af67c8af12cd4d123774772c3e8cdfa", kill_on_drop: false }` [INFO] [stdout] 674d426a58b32986250b9b42b28404917af67c8af12cd4d123774772c3e8cdfa