[INFO] fetching crate rate_my_professor_api_rs 0.1.5... [INFO] checking rate_my_professor_api_rs-0.1.5 against master#350d0ef0ec0493e6d21cfb265cb8211a0e74d766 for pr-145342-1 [INFO] extracting crate rate_my_professor_api_rs 0.1.5 into /workspace/builds/worker-3-tc1/source [INFO] started tweaking crates.io crate rate_my_professor_api_rs 0.1.5 [INFO] finished tweaking crates.io crate rate_my_professor_api_rs 0.1.5 [INFO] tweaked toml for crates.io crate rate_my_professor_api_rs 0.1.5 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate rate_my_professor_api_rs 0.1.5 on toolchain 350d0ef0ec0493e6d21cfb265cb8211a0e74d766 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+350d0ef0ec0493e6d21cfb265cb8211a0e74d766" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate rate_my_professor_api_rs 0.1.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+350d0ef0ec0493e6d21cfb265cb8211a0e74d766" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded filepath v0.2.0 [INFO] [stderr] Downloaded awc v3.5.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+350d0ef0ec0493e6d21cfb265cb8211a0e74d766" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7bee9faac25d973cee7f8dacec48a4c5cc13b43463b67754af5c636983ae93e5 [INFO] running `Command { std: "docker" "start" "-a" "7bee9faac25d973cee7f8dacec48a4c5cc13b43463b67754af5c636983ae93e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7bee9faac25d973cee7f8dacec48a4c5cc13b43463b67754af5c636983ae93e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7bee9faac25d973cee7f8dacec48a4c5cc13b43463b67754af5c636983ae93e5", kill_on_drop: false }` [INFO] [stdout] 7bee9faac25d973cee7f8dacec48a4c5cc13b43463b67754af5c636983ae93e5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+350d0ef0ec0493e6d21cfb265cb8211a0e74d766" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b172aad8ca4d3f36baad83c0f8fb61348b1f4c84587d29eaa6b9706a24ca6628 [INFO] running `Command { std: "docker" "start" "-a" "b172aad8ca4d3f36baad83c0f8fb61348b1f4c84587d29eaa6b9706a24ca6628", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.92 [INFO] [stderr] Compiling unicode-ident v1.0.14 [INFO] [stderr] Compiling libc v0.2.169 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling autocfg v1.4.0 [INFO] [stderr] Checking pin-project-lite v0.2.16 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking bytes v1.9.0 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling pkg-config v0.3.31 [INFO] [stderr] Checking futures-core v0.3.31 [INFO] [stderr] Checking once_cell v1.20.2 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking itoa v1.0.14 [INFO] [stderr] Checking futures-sink v0.3.31 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking tracing-core v0.1.33 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Checking futures-task v0.3.31 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Checking hashbrown v0.15.2 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking litemap v0.7.4 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking writeable v0.5.5 [INFO] [stderr] Checking http v1.2.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Compiling httparse v1.9.5 [INFO] [stderr] Compiling openssl v0.10.68 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling serde v1.0.217 [INFO] [stderr] Checking indexmap v2.7.0 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking icu_locid_transform_data v1.5.0 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Checking local-waker v0.1.4 [INFO] [stderr] Checking icu_properties_data v1.5.0 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking alloc-no-stdlib v2.0.4 [INFO] [stderr] Checking icu_normalizer_data v1.5.0 [INFO] [stderr] Checking write16 v1.0.0 [INFO] [stderr] Compiling zstd-safe v7.2.1 [INFO] [stderr] Checking utf16_iter v1.0.5 [INFO] [stderr] Checking utf8_iter v1.0.4 [INFO] [stderr] Checking alloc-stdlib v0.2.2 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking actix-utils v3.0.1 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Compiling quote v1.0.38 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking mio v1.0.3 [INFO] [stderr] Checking socket2 v0.5.8 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Compiling syn v2.0.95 [INFO] [stderr] Checking regex-syntax v0.8.5 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Compiling serde_json v1.0.135 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking miniz_oxide v0.8.2 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking brotli-decompressor v4.0.1 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling time-macros v0.2.19 [INFO] [stderr] Checking bytestring v1.4.0 [INFO] [stderr] Compiling cookie v0.16.2 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking encoding_rs v0.8.35 [INFO] [stderr] Checking actix-service v2.0.2 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Checking tower-service v0.3.3 [INFO] [stderr] Compiling tokio-openssl v0.6.5 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking cpufeatures v0.2.16 [INFO] [stderr] Checking flate2 v1.0.35 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking local-channel v0.1.5 [INFO] [stderr] Checking language-tags v0.3.2 [INFO] [stderr] Checking brotli v6.0.0 [INFO] [stderr] Compiling cc v1.2.7 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking impl-more v0.1.9 [INFO] [stderr] Compiling regex-lite v0.1.6 [INFO] [stderr] Checking sync_wrapper v1.0.2 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking rustls-pki-types v1.10.1 [INFO] [stderr] Compiling anyhow v1.0.95 [INFO] [stderr] Checking tower-layer v0.3.3 [INFO] [stderr] Checking predicates-core v1.0.9 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Checking ipnet v2.10.1 [INFO] [stderr] Checking anstyle v1.0.10 [INFO] [stderr] Checking filepath v0.2.0 [INFO] [stderr] Checking rustls-pemfile v2.2.0 [INFO] [stderr] Checking crossbeam-channel v0.5.14 [INFO] [stderr] Checking time v0.3.37 [INFO] [stderr] Checking float-cmp v0.10.0 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Compiling openssl-sys v0.9.104 [INFO] [stderr] Compiling zstd-sys v2.0.13+zstd.1.5.6 [INFO] [stderr] Compiling actix-router v0.5.3 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking predicates v3.1.3 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling actix-macros v0.2.4 [INFO] [stderr] Compiling serde_derive v1.0.217 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Compiling actix-web-codegen v4.3.0 [INFO] [stderr] Compiling actix_derive v0.6.2 [INFO] [stderr] Compiling zerofrom-derive v0.1.5 [INFO] [stderr] Compiling yoke-derive v0.7.5 [INFO] [stderr] Checking tokio v1.43.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking zerofrom v0.1.5 [INFO] [stderr] Checking yoke v0.7.5 [INFO] [stderr] Checking zerovec v0.10.4 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking zstd v0.13.2 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Checking icu_properties v1.5.1 [INFO] [stderr] Checking tokio-util v0.7.13 [INFO] [stderr] Checking actix-rt v2.10.0 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking actix-server v2.5.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking h2 v0.4.7 [INFO] [stderr] Checking actix-codec v0.5.2 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking actix-tls v3.4.0 [INFO] [stderr] Checking actix v0.13.5 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking hyper v1.5.2 [INFO] [stderr] Checking actix-http v3.9.0 [INFO] [stderr] Checking hyper-util v0.1.10 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking awc v3.5.1 [INFO] [stderr] Checking actix-web v4.9.0 [INFO] [stderr] Checking reqwest v0.12.12 [INFO] [stderr] Checking rate_my_professor_api_rs v0.1.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::any::type_name` [INFO] [stdout] --> src/features.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use std::any::type_name; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `core::cmp::Ord` [INFO] [stdout] --> src/features.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use core::cmp::Ord; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/features.rs:727:5 [INFO] [stdout] | [INFO] [stdout] 727 | / /** [INFO] [stdout] 728 | | * for "variables", it would be the same as writting [INFO] [stdout] 729 | | * "variables" : "query" : { "text" : school_name } [INFO] [stdout] 730 | | */ [INFO] [stdout] | |_______^ [INFO] [stdout] 731 | / let body = serde_json::json!({ [INFO] [stdout] 732 | | "query": SCHOOL_BODY_QUERY, [INFO] [stdout] 733 | | "variables": variables [INFO] [stdout] 734 | | }); [INFO] [stdout] | |_______- rustdoc does not generate documentation for statements [INFO] [stdout] | [INFO] [stdout] = help: use `/* */` for a plain comment [INFO] [stdout] = note: `#[warn(unused_doc_comments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `predicates::prelude::*` [INFO] [stdout] --> src/methods.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use predicates::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::any::type_name` [INFO] [stdout] --> src/features.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use std::any::type_name; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `core::cmp::Ord` [INFO] [stdout] --> src/features.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use core::cmp::Ord; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/features.rs:727:5 [INFO] [stdout] | [INFO] [stdout] 727 | / /** [INFO] [stdout] 728 | | * for "variables", it would be the same as writting [INFO] [stdout] 729 | | * "variables" : "query" : { "text" : school_name } [INFO] [stdout] 730 | | */ [INFO] [stdout] | |_______^ [INFO] [stdout] 731 | / let body = serde_json::json!({ [INFO] [stdout] 732 | | "query": SCHOOL_BODY_QUERY, [INFO] [stdout] 733 | | "variables": variables [INFO] [stdout] 734 | | }); [INFO] [stdout] | |_______- rustdoc does not generate documentation for statements [INFO] [stdout] | [INFO] [stdout] = help: use `/* */` for a plain comment [INFO] [stdout] = note: `#[warn(unused_doc_comments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `predicates::prelude::*` [INFO] [stdout] --> src/methods.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use predicates::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `comments_data` [INFO] [stdout] --> src/features.rs:188:9 [INFO] [stdout] | [INFO] [stdout] 188 | let comments_data : String = serde_json::from_str(&comments_subsection[index]["node"]["comment"].to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_comments_data` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `would_take_again` [INFO] [stdout] --> src/features.rs:190:9 [INFO] [stdout] | [INFO] [stdout] 190 | let would_take_again : &serde_json::Value = &comments_subsection[index]["node"]["wouldTakeAgain"]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_would_take_again` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/features.rs:180:7 [INFO] [stdout] | [INFO] [stdout] 180 | let mut comments_data : serde_json::Value = response.json().await.unwrap(); [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/features.rs:181:7 [INFO] [stdout] | [INFO] [stdout] 181 | let mut comments_subsection = comments_data["data"]["node"]["ratings"]["edges"].clone(); [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `comments_data` [INFO] [stdout] --> src/features.rs:188:9 [INFO] [stdout] | [INFO] [stdout] 188 | let comments_data : String = serde_json::from_str(&comments_subsection[index]["node"]["comment"].to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_comments_data` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `would_take_again` [INFO] [stdout] --> src/features.rs:190:9 [INFO] [stdout] | [INFO] [stdout] 190 | let would_take_again : &serde_json::Value = &comments_subsection[index]["node"]["wouldTakeAgain"]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_would_take_again` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/features.rs:180:7 [INFO] [stdout] | [INFO] [stdout] 180 | let mut comments_data : serde_json::Value = response.json().await.unwrap(); [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/features.rs:181:7 [INFO] [stdout] | [INFO] [stdout] 181 | let mut comments_subsection = comments_data["data"]["node"]["ratings"]["edges"].clone(); [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `school_id` [INFO] [stdout] --> src/features.rs:758:9 [INFO] [stdout] | [INFO] [stdout] 758 | let school_id : String = serde_json::from_str(&edges[0]["cursor"].clone().to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_school_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `file_path` [INFO] [stdout] --> src/features.rs:769:34 [INFO] [stdout] | [INFO] [stdout] 769 | let (all_search_result_file, file_path) = create_file("all_search_result.json").await; [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_file_path` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `file_path` [INFO] [stdout] --> src/features.rs:770:28 [INFO] [stdout] | [INFO] [stdout] 770 | let (school_name_file, file_path) = create_file(&(school_name.clone().to_owned() + ".json")).await; [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_file_path` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `index` [INFO] [stdout] --> src/features.rs:773:10 [INFO] [stdout] | [INFO] [stdout] 773 | for (index, data) in results.clone().into_iter().enumerate() { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_index` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/features.rs:811:7 [INFO] [stdout] | [INFO] [stdout] 811 | let mut file = fs::File::create(fileName).unwrap(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/features.rs:874:7 [INFO] [stdout] | [INFO] [stdout] 874 | let mut professor_list_raw : serde_json::Value = response.json().await?; [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `school_id` [INFO] [stdout] --> src/features.rs:758:9 [INFO] [stdout] | [INFO] [stdout] 758 | let school_id : String = serde_json::from_str(&edges[0]["cursor"].clone().to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_school_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `file_path` [INFO] [stdout] --> src/features.rs:769:34 [INFO] [stdout] | [INFO] [stdout] 769 | let (all_search_result_file, file_path) = create_file("all_search_result.json").await; [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_file_path` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `file_path` [INFO] [stdout] --> src/features.rs:770:28 [INFO] [stdout] | [INFO] [stdout] 770 | let (school_name_file, file_path) = create_file(&(school_name.clone().to_owned() + ".json")).await; [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_file_path` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `index` [INFO] [stdout] --> src/features.rs:773:10 [INFO] [stdout] | [INFO] [stdout] 773 | for (index, data) in results.clone().into_iter().enumerate() { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_index` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `file_path` [INFO] [stdout] --> src/methods.rs:249:20 [INFO] [stdout] | [INFO] [stdout] 249 | let (file, file_path) = create_file(file_name).await; [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_file_path` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/features.rs:811:7 [INFO] [stdout] | [INFO] [stdout] 811 | let mut file = fs::File::create(fileName).unwrap(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/features.rs:874:7 [INFO] [stdout] | [INFO] [stdout] 874 | let mut professor_list_raw : serde_json::Value = response.json().await?; [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `file_path` [INFO] [stdout] --> src/methods.rs:249:20 [INFO] [stdout] | [INFO] [stdout] 249 | let (file, file_path) = create_file(file_name).await; [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_file_path` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `professor_list_returned` [INFO] [stdout] --> src/features.rs:626:13 [INFO] [stdout] | [INFO] [stdout] 626 | let professor_list_returned = get_professor_list_by_school(school_id).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_professor_list_returned` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `professor_list_returned` [INFO] [stdout] --> src/features.rs:626:13 [INFO] [stdout] | [INFO] [stdout] 626 | let professor_list_returned = get_professor_list_by_school(school_id).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_professor_list_returned` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `main` is never used [INFO] [stdout] --> src/features.rs:610:10 [INFO] [stdout] | [INFO] [stdout] 610 | async fn main() -> Result<()> { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `print_type_of` is never used [INFO] [stdout] --> src/features.rs:792:4 [INFO] [stdout] | [INFO] [stdout] 792 | fn print_type_of(_ : &T) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: crate `rateMyProfessorApi_rs` should have a snake case name [INFO] [stdout] | [INFO] [stdout] = help: convert the identifier to snake case: `rate_my_professor_api_rs` [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `professorID` should have a snake case name [INFO] [stdout] --> src/features.rs:165:40 [INFO] [stdout] | [INFO] [stdout] 165 | pub async fn search_professor_comments(professorID : ProfessorId) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `professor_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `ProfessorCommentsVector` should have a snake case name [INFO] [stdout] --> src/features.rs:183:11 [INFO] [stdout] | [INFO] [stdout] 183 | let mut ProfessorCommentsVector : Vec = Vec::with_capacity(length.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `professor_comments_vector` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Id` should have a snake case name [INFO] [stdout] --> src/features.rs:235:7 [INFO] [stdout] | [INFO] [stdout] 235 | pub Id : String [INFO] [stdout] | ^^ help: convert the identifier to snake case (notice the capitalization): `id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/features.rs:770:66 [INFO] [stdout] | [INFO] [stdout] 770 | let (school_name_file, file_path) = create_file(&(school_name.clone().to_owned() + ".json")).await; [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `fileName` should have a snake case name [INFO] [stdout] --> src/features.rs:810:26 [INFO] [stdout] | [INFO] [stdout] 810 | pub async fn create_file(fileName : &str) -> (fs::File, PathBuf) { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `file_name` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `filePath` should have a snake case name [INFO] [stdout] --> src/features.rs:812:7 [INFO] [stdout] | [INFO] [stdout] 812 | let filePath = file.path().unwrap(); // Ok("/path/to/file") -> "/path/to/file" [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `file_path` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `CollegeName` should have a snake case name [INFO] [stdout] --> src/methods.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub CollegeName : String, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `college_name` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `ProfessorName` should have a snake case name [INFO] [stdout] --> src/methods.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | pub ProfessorName : Option [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `professor_name` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `main` is never used [INFO] [stdout] --> src/features.rs:610:10 [INFO] [stdout] | [INFO] [stdout] 610 | async fn main() -> Result<()> { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `print_type_of` is never used [INFO] [stdout] --> src/features.rs:792:4 [INFO] [stdout] | [INFO] [stdout] 792 | fn print_type_of(_ : &T) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `professorID` should have a snake case name [INFO] [stdout] --> src/features.rs:165:40 [INFO] [stdout] | [INFO] [stdout] 165 | pub async fn search_professor_comments(professorID : ProfessorId) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `professor_id` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `ProfessorCommentsVector` should have a snake case name [INFO] [stdout] --> src/features.rs:183:11 [INFO] [stdout] | [INFO] [stdout] 183 | let mut ProfessorCommentsVector : Vec = Vec::with_capacity(length.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `professor_comments_vector` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Id` should have a snake case name [INFO] [stdout] --> src/features.rs:235:7 [INFO] [stdout] | [INFO] [stdout] 235 | pub Id : String [INFO] [stdout] | ^^ help: convert the identifier to snake case (notice the capitalization): `id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/features.rs:770:66 [INFO] [stdout] | [INFO] [stdout] 770 | let (school_name_file, file_path) = create_file(&(school_name.clone().to_owned() + ".json")).await; [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `fileName` should have a snake case name [INFO] [stdout] --> src/features.rs:810:26 [INFO] [stdout] | [INFO] [stdout] 810 | pub async fn create_file(fileName : &str) -> (fs::File, PathBuf) { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `file_name` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `filePath` should have a snake case name [INFO] [stdout] --> src/features.rs:812:7 [INFO] [stdout] | [INFO] [stdout] 812 | let filePath = file.path().unwrap(); // Ok("/path/to/file") -> "/path/to/file" [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `file_path` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `CollegeName` should have a snake case name [INFO] [stdout] --> src/methods.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub CollegeName : String, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `college_name` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `ProfessorName` should have a snake case name [INFO] [stdout] --> src/methods.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | pub ProfessorName : Option [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `professor_name` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Deserialize` and `Serialize` [INFO] [stdout] --> src/bin/execute_methods.rs:4:13 [INFO] [stdout] | [INFO] [stdout] 4 | use serde::{Deserialize, Serialize}; [INFO] [stdout] | ^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `predicates::prelude::*` [INFO] [stdout] --> src/bin/execute_methods.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use predicates::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Deserialize` and `Serialize` [INFO] [stdout] --> src/bin/execute_methods.rs:4:13 [INFO] [stdout] | [INFO] [stdout] 4 | use serde::{Deserialize, Serialize}; [INFO] [stdout] | ^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `predicates::prelude::*` [INFO] [stdout] --> src/bin/execute_methods.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use predicates::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/execute_methods.rs:100:9 [INFO] [stdout] | [INFO] [stdout] 100 | let mut rate_my_professor_instance = RateMyProfessor::construct_college("Queens College"); [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/execute_methods.rs:111:9 [INFO] [stdout] | [INFO] [stdout] 111 | let mut rate_my_professor_instance_version2 = RateMyProfessor::construct_college_and_professor("City College of New York", "Douglas T... [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/execute_methods.rs:100:9 [INFO] [stdout] | [INFO] [stdout] 100 | let mut rate_my_professor_instance = RateMyProfessor::construct_college("Queens College"); [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/execute_methods.rs:111:9 [INFO] [stdout] | [INFO] [stdout] 111 | let mut rate_my_professor_instance_version2 = RateMyProfessor::construct_college_and_professor("City College of New York", "Douglas T... [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Deserialize` and `Serialize` [INFO] [stdout] --> src/bin/execute_features.rs:3:13 [INFO] [stdout] | [INFO] [stdout] 3 | use serde::{Deserialize, Serialize}; [INFO] [stdout] | ^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Deserialize` and `Serialize` [INFO] [stdout] --> src/bin/execute_features.rs:3:13 [INFO] [stdout] | [INFO] [stdout] 3 | use serde::{Deserialize, Serialize}; [INFO] [stdout] | ^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `predicates::prelude` [INFO] [stdout] --> src/bin/execute_features.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use predicates::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `professor_list_returned` [INFO] [stdout] --> src/bin/execute_features.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | let professor_list_returned = get_professor_list_by_school(school_id).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_professor_list_returned` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `predicates::prelude` [INFO] [stdout] --> src/bin/execute_features.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use predicates::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/bin/execute_methods.rs:119:5 [INFO] [stdout] | [INFO] [stdout] 119 | test_constructor_methods().await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 119 | let _ = test_constructor_methods().await; [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `professor_list_returned` [INFO] [stdout] --> src/bin/execute_features.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | let professor_list_returned = get_professor_list_by_school(school_id).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_professor_list_returned` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_constructor_methods` is never used [INFO] [stdout] --> src/bin/execute_methods.rs:98:10 [INFO] [stdout] | [INFO] [stdout] 98 | async fn test_constructor_methods() -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 45.12s [INFO] running `Command { std: "docker" "inspect" "b172aad8ca4d3f36baad83c0f8fb61348b1f4c84587d29eaa6b9706a24ca6628", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b172aad8ca4d3f36baad83c0f8fb61348b1f4c84587d29eaa6b9706a24ca6628", kill_on_drop: false }` [INFO] [stdout] b172aad8ca4d3f36baad83c0f8fb61348b1f4c84587d29eaa6b9706a24ca6628