[INFO] fetching crate libreda-lefdef 0.0.5... [INFO] checking libreda-lefdef-0.0.5 against master#350d0ef0ec0493e6d21cfb265cb8211a0e74d766 for pr-145342-1 [INFO] extracting crate libreda-lefdef 0.0.5 into /workspace/builds/worker-3-tc1/source [INFO] started tweaking crates.io crate libreda-lefdef 0.0.5 [INFO] finished tweaking crates.io crate libreda-lefdef 0.0.5 [INFO] tweaked toml for crates.io crate libreda-lefdef 0.0.5 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate libreda-lefdef 0.0.5 on toolchain 350d0ef0ec0493e6d21cfb265cb8211a0e74d766 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+350d0ef0ec0493e6d21cfb265cb8211a0e74d766" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+350d0ef0ec0493e6d21cfb265cb8211a0e74d766" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 51 packages to latest compatible versions [INFO] [stderr] Adding itertools v0.13.0 (available: v0.14.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+350d0ef0ec0493e6d21cfb265cb8211a0e74d766" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+350d0ef0ec0493e6d21cfb265cb8211a0e74d766" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fadcf46530832df37836d967bf441c0a92cda2ff81fde85ea096a9ce89e8368a [INFO] running `Command { std: "docker" "start" "-a" "fadcf46530832df37836d967bf441c0a92cda2ff81fde85ea096a9ce89e8368a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fadcf46530832df37836d967bf441c0a92cda2ff81fde85ea096a9ce89e8368a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fadcf46530832df37836d967bf441c0a92cda2ff81fde85ea096a9ce89e8368a", kill_on_drop: false }` [INFO] [stdout] fadcf46530832df37836d967bf441c0a92cda2ff81fde85ea096a9ce89e8368a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+350d0ef0ec0493e6d21cfb265cb8211a0e74d766" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a4e0621dff8bc932ebcd430ef7e6ca07f10b1019258c5fdb9888f9494a4894c6 [INFO] running `Command { std: "docker" "start" "-a" "a4e0621dff8bc932ebcd430ef7e6ca07f10b1019258c5fdb9888f9494a4894c6", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.5.0 [INFO] [stderr] Compiling proc-macro2 v1.0.101 [INFO] [stderr] Compiling unicode-ident v1.0.18 [INFO] [stderr] Compiling libm v0.2.15 [INFO] [stderr] Compiling libc v0.2.175 [INFO] [stderr] Compiling zerocopy v0.8.26 [INFO] [stderr] Compiling semver v1.0.26 [INFO] [stderr] Compiling cfg-if v1.0.3 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking libreda-splay v0.1.1 [INFO] [stderr] Checking log v0.4.27 [INFO] [stderr] Compiling itertools v0.10.5 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking hash32 v0.2.1 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling lock_api v0.4.13 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Compiling heapless v0.7.17 [INFO] [stderr] Compiling getrandom v0.2.16 [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking rstar v0.9.3 [INFO] [stderr] Checking libreda-stream-parser v0.2.0 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Compiling ppv-lite86 v0.2.21 [INFO] [stderr] Compiling num-derive v0.3.3 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Compiling portrait-framework v0.2.1 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling portrait-codegen v0.2.3 [INFO] [stderr] Checking portrait v0.2.3 [INFO] [stderr] Checking iron-shapes v0.1.1 [INFO] [stderr] Checking iron-shapes-booleanop v0.1.0 [INFO] [stderr] Checking libreda-db v0.0.12 [INFO] [stderr] Checking libreda-lefdef v0.0.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/def_writer.rs:65:14 [INFO] [stdout] | [INFO] [stdout] 65 | for v in &def.version { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 65 - for v in &def.version { [INFO] [stdout] 65 + while let Some(v) = &def.version { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 65 - for v in &def.version { [INFO] [stdout] 65 + if let Some(v) = &def.version { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/def_writer.rs:83:14 [INFO] [stdout] | [INFO] [stdout] 83 | for n in &def.design_name { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 83 - for n in &def.design_name { [INFO] [stdout] 83 + while let Some(n) = &def.design_name { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 83 - for n in &def.design_name { [INFO] [stdout] 83 + if let Some(n) = &def.design_name { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/def_writer.rs:88:14 [INFO] [stdout] | [INFO] [stdout] 88 | for n in &def.technology { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 88 - for n in &def.technology { [INFO] [stdout] 88 + while let Some(n) = &def.technology { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 88 - for n in &def.technology { [INFO] [stdout] 88 + if let Some(n) = &def.technology { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/def_writer.rs:204:32 [INFO] [stdout] | [INFO] [stdout] 204 | for region_type in ®ion.region_type { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 204 - for region_type in ®ion.region_type { [INFO] [stdout] 204 + while let Some(region_type) = ®ion.region_type { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 204 - for region_type in ®ion.region_type { [INFO] [stdout] 204 + if let Some(region_type) = ®ion.region_type { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/def_writer.rs:223:22 [INFO] [stdout] | [INFO] [stdout] 223 | for m in &comp.eeq_master { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 223 - for m in &comp.eeq_master { [INFO] [stdout] 223 + while let Some(m) = &comp.eeq_master { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 223 - for m in &comp.eeq_master { [INFO] [stdout] 223 + if let Some(m) = &comp.eeq_master { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/def_writer.rs:242:53 [INFO] [stdout] | [INFO] [stdout] 242 | for (soft, left, bottom, right, top) in &comp.halo { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 242 - for (soft, left, bottom, right, top) in &comp.halo { [INFO] [stdout] 242 + while let Some((soft, left, bottom, right, top)) = &comp.halo { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 242 - for (soft, left, bottom, right, top) in &comp.halo { [INFO] [stdout] 242 + if let Some((soft, left, bottom, right, top)) = &comp.halo { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/def_writer.rs:250:49 [INFO] [stdout] | [INFO] [stdout] 250 | for (dist, min_layer, max_layer) in &comp.route_halo { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 250 - for (dist, min_layer, max_layer) in &comp.route_halo { [INFO] [stdout] 250 + while let Some((dist, min_layer, max_layer)) = &comp.route_halo { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 250 - for (dist, min_layer, max_layer) in &comp.route_halo { [INFO] [stdout] 250 + if let Some((dist, min_layer, max_layer)) = &comp.route_halo { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/def_writer.rs:260:22 [INFO] [stdout] | [INFO] [stdout] 260 | for r in &comp.region { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 260 - for r in &comp.region { [INFO] [stdout] 260 + while let Some(r) = &comp.region { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 260 - for r in &comp.region { [INFO] [stdout] 260 + if let Some(r) = &comp.region { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/def_writer.rs:65:14 [INFO] [stdout] | [INFO] [stdout] 65 | for v in &def.version { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 65 - for v in &def.version { [INFO] [stdout] 65 + while let Some(v) = &def.version { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 65 - for v in &def.version { [INFO] [stdout] 65 + if let Some(v) = &def.version { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/def_writer.rs:83:14 [INFO] [stdout] | [INFO] [stdout] 83 | for n in &def.design_name { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 83 - for n in &def.design_name { [INFO] [stdout] 83 + while let Some(n) = &def.design_name { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 83 - for n in &def.design_name { [INFO] [stdout] 83 + if let Some(n) = &def.design_name { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/def_writer.rs:88:14 [INFO] [stdout] | [INFO] [stdout] 88 | for n in &def.technology { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 88 - for n in &def.technology { [INFO] [stdout] 88 + while let Some(n) = &def.technology { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 88 - for n in &def.technology { [INFO] [stdout] 88 + if let Some(n) = &def.technology { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/def_writer.rs:204:32 [INFO] [stdout] | [INFO] [stdout] 204 | for region_type in ®ion.region_type { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 204 - for region_type in ®ion.region_type { [INFO] [stdout] 204 + while let Some(region_type) = ®ion.region_type { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 204 - for region_type in ®ion.region_type { [INFO] [stdout] 204 + if let Some(region_type) = ®ion.region_type { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/def_writer.rs:223:22 [INFO] [stdout] | [INFO] [stdout] 223 | for m in &comp.eeq_master { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 223 - for m in &comp.eeq_master { [INFO] [stdout] 223 + while let Some(m) = &comp.eeq_master { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 223 - for m in &comp.eeq_master { [INFO] [stdout] 223 + if let Some(m) = &comp.eeq_master { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/def_writer.rs:242:53 [INFO] [stdout] | [INFO] [stdout] 242 | for (soft, left, bottom, right, top) in &comp.halo { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 242 - for (soft, left, bottom, right, top) in &comp.halo { [INFO] [stdout] 242 + while let Some((soft, left, bottom, right, top)) = &comp.halo { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 242 - for (soft, left, bottom, right, top) in &comp.halo { [INFO] [stdout] 242 + if let Some((soft, left, bottom, right, top)) = &comp.halo { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/def_writer.rs:250:49 [INFO] [stdout] | [INFO] [stdout] 250 | for (dist, min_layer, max_layer) in &comp.route_halo { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 250 - for (dist, min_layer, max_layer) in &comp.route_halo { [INFO] [stdout] 250 + while let Some((dist, min_layer, max_layer)) = &comp.route_halo { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 250 - for (dist, min_layer, max_layer) in &comp.route_halo { [INFO] [stdout] 250 + if let Some((dist, min_layer, max_layer)) = &comp.route_halo { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/def_writer.rs:260:22 [INFO] [stdout] | [INFO] [stdout] 260 | for r in &comp.region { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 260 - for r in &comp.region { [INFO] [stdout] 260 + while let Some(r) = &comp.region { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 260 - for r in &comp.region { [INFO] [stdout] 260 + if let Some(r) = &comp.region { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 23.10s [INFO] running `Command { std: "docker" "inspect" "a4e0621dff8bc932ebcd430ef7e6ca07f10b1019258c5fdb9888f9494a4894c6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a4e0621dff8bc932ebcd430ef7e6ca07f10b1019258c5fdb9888f9494a4894c6", kill_on_drop: false }` [INFO] [stdout] a4e0621dff8bc932ebcd430ef7e6ca07f10b1019258c5fdb9888f9494a4894c6