[INFO] fetching crate juju 1.0.0... [INFO] checking juju-1.0.0 against master#350d0ef0ec0493e6d21cfb265cb8211a0e74d766 for pr-145342-1 [INFO] extracting crate juju 1.0.0 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate juju 1.0.0 [INFO] finished tweaking crates.io crate juju 1.0.0 [INFO] tweaked toml for crates.io crate juju 1.0.0 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate juju 1.0.0 on toolchain 350d0ef0ec0493e6d21cfb265cb8211a0e74d766 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+350d0ef0ec0493e6d21cfb265cb8211a0e74d766" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+350d0ef0ec0493e6d21cfb265cb8211a0e74d766" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 59 packages to latest compatible versions [INFO] [stderr] Adding log v0.3.9 (available: v0.4.27) [INFO] [stderr] Adding memchr v1.0.2 (available: v2.7.5) [INFO] [stderr] Adding rusqlite v0.14.0 (available: v0.37.0) [INFO] [stderr] Adding serde v0.9.15 (available: v1.0.219) [INFO] [stderr] Adding serde_derive v0.9.15 (available: v1.0.219) [INFO] [stderr] Adding serde_json v0.9.10 (available: v1.0.143) [INFO] [stderr] Adding wasi v0.10.0+wasi-snapshot-preview1 (available: v0.10.2+wasi-snapshot-preview1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+350d0ef0ec0493e6d21cfb265cb8211a0e74d766" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded serde v0.9.15 [INFO] [stderr] Downloaded charmhelpers v0.1.3 [INFO] [stderr] Downloaded serde_codegen_internals v0.14.2 [INFO] [stderr] Downloaded juju v0.3.1 [INFO] [stderr] Downloaded serde_derive v0.9.15 [INFO] [stderr] Downloaded serde_json v0.9.10 [INFO] [stderr] Downloaded rusqlite v0.14.0 [INFO] [stderr] Downloaded libsqlite3-sys v0.9.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+350d0ef0ec0493e6d21cfb265cb8211a0e74d766" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cd806d114a7d92c00cd2051ad7193bd4fe98ad9ad8202bb2001a65bddf78ff1e [INFO] running `Command { std: "docker" "start" "-a" "cd806d114a7d92c00cd2051ad7193bd4fe98ad9ad8202bb2001a65bddf78ff1e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cd806d114a7d92c00cd2051ad7193bd4fe98ad9ad8202bb2001a65bddf78ff1e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cd806d114a7d92c00cd2051ad7193bd4fe98ad9ad8202bb2001a65bddf78ff1e", kill_on_drop: false }` [INFO] [stdout] cd806d114a7d92c00cd2051ad7193bd4fe98ad9ad8202bb2001a65bddf78ff1e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+350d0ef0ec0493e6d21cfb265cb8211a0e74d766" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 192862c36359540ea32e2ba1955b2af77762996f34975e0a090b8c1864911fe5 [INFO] running `Command { std: "docker" "start" "-a" "192862c36359540ea32e2ba1955b2af77762996f34975e0a090b8c1864911fe5", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] [stderr] Compiling autocfg v1.5.0 [INFO] [stderr] Compiling libc v0.2.175 [INFO] [stderr] Compiling pkg-config v0.3.32 [INFO] [stderr] Compiling unicode-xid v0.0.4 [INFO] [stderr] Compiling quote v0.3.15 [INFO] [stderr] Checking log v0.4.27 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking iana-time-zone v0.1.63 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking juju v0.3.1 [INFO] [stderr] Checking dtoa v0.4.8 [INFO] [stderr] Checking serde v0.9.15 [INFO] [stderr] Checking itoa v0.3.4 [INFO] [stderr] Compiling synom v0.11.3 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking charmhelpers v0.1.3 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking lru-cache v0.1.2 [INFO] [stderr] Compiling libsqlite3-sys v0.9.4 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking chrono v0.4.41 [INFO] [stderr] Compiling serde_codegen_internals v0.14.2 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking serde_json v0.9.10 [INFO] [stderr] Compiling serde_derive v0.9.15 [INFO] [stderr] Checking rusqlite v0.14.0 [INFO] [stderr] Checking juju v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:123:32 [INFO] [stdout] | [INFO] [stdout] 123 | fn cause(&self) -> Option<&Error> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 123 | fn cause(&self) -> Option<&dyn Error> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:123:32 [INFO] [stdout] | [INFO] [stdout] 123 | fn cause(&self) -> Option<&Error> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 123 | fn cause(&self) -> Option<&dyn Error> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `core::str::::trim_left_matches`: superseded by `trim_start_matches` [INFO] [stdout] --> src/unitdata.rs:113:34 [INFO] [stdout] | [INFO] [stdout] 113 | results.insert(k.trim_left_matches(&key_prefix).to_string(), value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] help: replace the use of the deprecated method [INFO] [stdout] | [INFO] [stdout] 113 - results.insert(k.trim_left_matches(&key_prefix).to_string(), value); [INFO] [stdout] 113 + results.insert(k.trim_start_matches(&key_prefix).to_string(), value); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/unitdata.rs:165:38 [INFO] [stdout] | [INFO] [stdout] 165 | let mut values: Vec<&rusqlite::types::ToSql> = Vec::new(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 165 | let mut values: Vec<&dyn rusqlite::types::ToSql> = Vec::new(); [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/unitdata.rs:180:42 [INFO] [stdout] | [INFO] [stdout] 180 | let mut values: Vec<&rusqlite::types::ToSql> = Vec::new(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 180 | let mut values: Vec<&dyn rusqlite::types::ToSql> = Vec::new(); [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:95:55 [INFO] [stdout] | [INFO] [stdout] 95 | JujuError::AddrParseError(ref err) => err.description().to_string(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:96:54 [INFO] [stdout] | [INFO] [stdout] 96 | JujuError::FromUtf8Error(ref err) => err.description().to_string(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:97:48 [INFO] [stdout] | [INFO] [stdout] 97 | JujuError::IoError(ref err) => err.description().to_string(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:98:54 [INFO] [stdout] | [INFO] [stdout] 98 | JujuError::ParseIntError(ref err) => err.description().to_string(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:99:54 [INFO] [stdout] | [INFO] [stdout] 99 | JujuError::RusqliteError(ref err) => err.description().to_string(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:100:51 [INFO] [stdout] | [INFO] [stdout] 100 | JujuError::SerdeError(ref err) => err.description().to_string(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:101:49 [INFO] [stdout] | [INFO] [stdout] 101 | JujuError::VarError(ref err) => err.description().to_string(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:107:26 [INFO] [stdout] | [INFO] [stdout] 107 | f.write_str(self.description()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:114:55 [INFO] [stdout] | [INFO] [stdout] 114 | JujuError::AddrParseError(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:115:54 [INFO] [stdout] | [INFO] [stdout] 115 | JujuError::FromUtf8Error(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:116:48 [INFO] [stdout] | [INFO] [stdout] 116 | JujuError::IoError(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:117:54 [INFO] [stdout] | [INFO] [stdout] 117 | JujuError::ParseIntError(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:118:54 [INFO] [stdout] | [INFO] [stdout] 118 | JujuError::RusqliteError(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:119:51 [INFO] [stdout] | [INFO] [stdout] 119 | JujuError::SerdeError(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:120:49 [INFO] [stdout] | [INFO] [stdout] 120 | JujuError::VarError(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::cause`: replaced by Error::source, which can support downcasting [INFO] [stdout] --> src/lib.rs:125:55 [INFO] [stdout] | [INFO] [stdout] 125 | JujuError::AddrParseError(ref err) => err.cause(), [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::cause`: replaced by Error::source, which can support downcasting [INFO] [stdout] --> src/lib.rs:126:54 [INFO] [stdout] | [INFO] [stdout] 126 | JujuError::FromUtf8Error(ref err) => err.cause(), [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::cause`: replaced by Error::source, which can support downcasting [INFO] [stdout] --> src/lib.rs:127:48 [INFO] [stdout] | [INFO] [stdout] 127 | JujuError::IoError(ref err) => err.cause(), [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::cause`: replaced by Error::source, which can support downcasting [INFO] [stdout] --> src/lib.rs:128:54 [INFO] [stdout] | [INFO] [stdout] 128 | JujuError::ParseIntError(ref err) => err.cause(), [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::cause`: replaced by Error::source, which can support downcasting [INFO] [stdout] --> src/lib.rs:129:51 [INFO] [stdout] | [INFO] [stdout] 129 | JujuError::SerdeError(ref err) => err.cause(), [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::cause`: replaced by Error::source, which can support downcasting [INFO] [stdout] --> src/lib.rs:130:54 [INFO] [stdout] | [INFO] [stdout] 130 | JujuError::RusqliteError(ref err) => err.cause(), [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::cause`: replaced by Error::source, which can support downcasting [INFO] [stdout] --> src/lib.rs:131:49 [INFO] [stdout] | [INFO] [stdout] 131 | JujuError::VarError(ref err) => err.cause(), [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `slots` is never read [INFO] [stdout] --> src/unitdata.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 28 | pub struct Record { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 29 | slots: HashMap, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Record` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `data`, `date`, `hook`, `key`, and `revision` are never read [INFO] [stdout] --> src/unitdata.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 33 | pub struct History { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 34 | data: Value, [INFO] [stdout] | ^^^^ [INFO] [stdout] 35 | date: DateTime, [INFO] [stdout] | ^^^^ [INFO] [stdout] 36 | hook: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 37 | key: String, [INFO] [stdout] | ^^^ [INFO] [stdout] 38 | revision: u32, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `History` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function pointer comparisons do not produce meaningful results since their addresses are not guaranteed to be unique [INFO] [stdout] --> src/lib.rs:390:5 [INFO] [stdout] | [INFO] [stdout] 382 | #[derive(Debug,PartialEq)] [INFO] [stdout] | --------- in this derive macro expansion [INFO] [stdout] ... [INFO] [stdout] 390 | pub callback: fn() -> Result<(), String>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the address of the same function can vary between different codegen units [INFO] [stdout] = note: furthermore, different functions could have the same address after being merged together [INFO] [stdout] = note: for more information visit [INFO] [stdout] = note: `#[warn(unpredictable_function_pointer_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:650:35 [INFO] [stdout] | [INFO] [stdout] 650 | let arg = format!("{}={}", key.clone(), value); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/unitdata.rs:27:17 [INFO] [stdout] | [INFO] [stdout] 27 | #[derive(Debug, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `Record` is not local [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_Record` [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> tests/test_unitdata.rs:36:53 [INFO] [stdout] | [INFO] [stdout] 36 | assert_eq!(results.get("foo3").unwrap(), "bar");; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> tests/test_unitdata.rs:42:52 [INFO] [stdout] | [INFO] [stdout] 42 | assert_eq!(results_2.get("3").unwrap(), "bar");; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `core::str::::trim_left_matches`: superseded by `trim_start_matches` [INFO] [stdout] --> src/unitdata.rs:113:34 [INFO] [stdout] | [INFO] [stdout] 113 | results.insert(k.trim_left_matches(&key_prefix).to_string(), value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] help: replace the use of the deprecated method [INFO] [stdout] | [INFO] [stdout] 113 - results.insert(k.trim_left_matches(&key_prefix).to_string(), value); [INFO] [stdout] 113 + results.insert(k.trim_start_matches(&key_prefix).to_string(), value); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/unitdata.rs:165:38 [INFO] [stdout] | [INFO] [stdout] 165 | let mut values: Vec<&rusqlite::types::ToSql> = Vec::new(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 165 | let mut values: Vec<&dyn rusqlite::types::ToSql> = Vec::new(); [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/unitdata.rs:180:42 [INFO] [stdout] | [INFO] [stdout] 180 | let mut values: Vec<&rusqlite::types::ToSql> = Vec::new(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 180 | let mut values: Vec<&dyn rusqlite::types::ToSql> = Vec::new(); [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:95:55 [INFO] [stdout] | [INFO] [stdout] 95 | JujuError::AddrParseError(ref err) => err.description().to_string(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:96:54 [INFO] [stdout] | [INFO] [stdout] 96 | JujuError::FromUtf8Error(ref err) => err.description().to_string(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:97:48 [INFO] [stdout] | [INFO] [stdout] 97 | JujuError::IoError(ref err) => err.description().to_string(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:98:54 [INFO] [stdout] | [INFO] [stdout] 98 | JujuError::ParseIntError(ref err) => err.description().to_string(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:99:54 [INFO] [stdout] | [INFO] [stdout] 99 | JujuError::RusqliteError(ref err) => err.description().to_string(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:100:51 [INFO] [stdout] | [INFO] [stdout] 100 | JujuError::SerdeError(ref err) => err.description().to_string(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:101:49 [INFO] [stdout] | [INFO] [stdout] 101 | JujuError::VarError(ref err) => err.description().to_string(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:107:26 [INFO] [stdout] | [INFO] [stdout] 107 | f.write_str(self.description()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:114:55 [INFO] [stdout] | [INFO] [stdout] 114 | JujuError::AddrParseError(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:115:54 [INFO] [stdout] | [INFO] [stdout] 115 | JujuError::FromUtf8Error(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:116:48 [INFO] [stdout] | [INFO] [stdout] 116 | JujuError::IoError(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:117:54 [INFO] [stdout] | [INFO] [stdout] 117 | JujuError::ParseIntError(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:118:54 [INFO] [stdout] | [INFO] [stdout] 118 | JujuError::RusqliteError(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:119:51 [INFO] [stdout] | [INFO] [stdout] 119 | JujuError::SerdeError(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:120:49 [INFO] [stdout] | [INFO] [stdout] 120 | JujuError::VarError(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::cause`: replaced by Error::source, which can support downcasting [INFO] [stdout] --> src/lib.rs:125:55 [INFO] [stdout] | [INFO] [stdout] 125 | JujuError::AddrParseError(ref err) => err.cause(), [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::cause`: replaced by Error::source, which can support downcasting [INFO] [stdout] --> src/lib.rs:126:54 [INFO] [stdout] | [INFO] [stdout] 126 | JujuError::FromUtf8Error(ref err) => err.cause(), [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::cause`: replaced by Error::source, which can support downcasting [INFO] [stdout] --> src/lib.rs:127:48 [INFO] [stdout] | [INFO] [stdout] 127 | JujuError::IoError(ref err) => err.cause(), [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::cause`: replaced by Error::source, which can support downcasting [INFO] [stdout] --> src/lib.rs:128:54 [INFO] [stdout] | [INFO] [stdout] 128 | JujuError::ParseIntError(ref err) => err.cause(), [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::cause`: replaced by Error::source, which can support downcasting [INFO] [stdout] --> src/lib.rs:129:51 [INFO] [stdout] | [INFO] [stdout] 129 | JujuError::SerdeError(ref err) => err.cause(), [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::cause`: replaced by Error::source, which can support downcasting [INFO] [stdout] --> src/lib.rs:130:54 [INFO] [stdout] | [INFO] [stdout] 130 | JujuError::RusqliteError(ref err) => err.cause(), [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::cause`: replaced by Error::source, which can support downcasting [INFO] [stdout] --> src/lib.rs:131:49 [INFO] [stdout] | [INFO] [stdout] 131 | JujuError::VarError(ref err) => err.cause(), [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `slots` is never read [INFO] [stdout] --> src/unitdata.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 28 | pub struct Record { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 29 | slots: HashMap, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Record` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `data`, `date`, `hook`, `key`, and `revision` are never read [INFO] [stdout] --> src/unitdata.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 33 | pub struct History { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 34 | data: Value, [INFO] [stdout] | ^^^^ [INFO] [stdout] 35 | date: DateTime, [INFO] [stdout] | ^^^^ [INFO] [stdout] 36 | hook: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 37 | key: String, [INFO] [stdout] | ^^^ [INFO] [stdout] 38 | revision: u32, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `History` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function pointer comparisons do not produce meaningful results since their addresses are not guaranteed to be unique [INFO] [stdout] --> src/lib.rs:390:5 [INFO] [stdout] | [INFO] [stdout] 382 | #[derive(Debug,PartialEq)] [INFO] [stdout] | --------- in this derive macro expansion [INFO] [stdout] ... [INFO] [stdout] 390 | pub callback: fn() -> Result<(), String>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the address of the same function can vary between different codegen units [INFO] [stdout] = note: furthermore, different functions could have the same address after being merged together [INFO] [stdout] = note: for more information visit [INFO] [stdout] = note: `#[warn(unpredictable_function_pointer_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:650:35 [INFO] [stdout] | [INFO] [stdout] 650 | let arg = format!("{}={}", key.clone(), value); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/unitdata.rs:27:17 [INFO] [stdout] | [INFO] [stdout] 27 | #[derive(Debug, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `Record` is not local [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_Record` [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.35s [INFO] running `Command { std: "docker" "inspect" "192862c36359540ea32e2ba1955b2af77762996f34975e0a090b8c1864911fe5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "192862c36359540ea32e2ba1955b2af77762996f34975e0a090b8c1864911fe5", kill_on_drop: false }` [INFO] [stdout] 192862c36359540ea32e2ba1955b2af77762996f34975e0a090b8c1864911fe5