[INFO] fetching crate homoglyph-core 0.1.0... [INFO] checking homoglyph-core-0.1.0 against master#350d0ef0ec0493e6d21cfb265cb8211a0e74d766 for pr-145342-1 [INFO] extracting crate homoglyph-core 0.1.0 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate homoglyph-core 0.1.0 [INFO] finished tweaking crates.io crate homoglyph-core 0.1.0 [INFO] tweaked toml for crates.io crate homoglyph-core 0.1.0 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate homoglyph-core 0.1.0 on toolchain 350d0ef0ec0493e6d21cfb265cb8211a0e74d766 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+350d0ef0ec0493e6d21cfb265cb8211a0e74d766" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+350d0ef0ec0493e6d21cfb265cb8211a0e74d766" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 9 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+350d0ef0ec0493e6d21cfb265cb8211a0e74d766" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded permutator v0.4.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+350d0ef0ec0493e6d21cfb265cb8211a0e74d766" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 89a60a11c86331a71abede2e49089074dda576abf59b5ec142c5d9dcfcef0dfc [INFO] running `Command { std: "docker" "start" "-a" "89a60a11c86331a71abede2e49089074dda576abf59b5ec142c5d9dcfcef0dfc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "89a60a11c86331a71abede2e49089074dda576abf59b5ec142c5d9dcfcef0dfc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "89a60a11c86331a71abede2e49089074dda576abf59b5ec142c5d9dcfcef0dfc", kill_on_drop: false }` [INFO] [stdout] 89a60a11c86331a71abede2e49089074dda576abf59b5ec142c5d9dcfcef0dfc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+350d0ef0ec0493e6d21cfb265cb8211a0e74d766" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ef2ab06ef4b06f1224c8fa35ce99b0ffeb4b55d43739046a0f72fa79ffdbd32a [INFO] running `Command { std: "docker" "start" "-a" "ef2ab06ef4b06f1224c8fa35ce99b0ffeb4b55d43739046a0f72fa79ffdbd32a", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.5.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling num-bigint v0.2.6 [INFO] [stderr] Compiling num-complex v0.2.4 [INFO] [stderr] Compiling num-rational v0.2.4 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking num v0.2.1 [INFO] [stderr] Checking permutator v0.4.3 [INFO] [stderr] Checking homoglyph-core v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/domain.rs:61:32 [INFO] [stdout] | [INFO] [stdout] 61 | for permutation in cart_take.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to iterate over `cart_take` remove the call to `next` [INFO] [stdout] | [INFO] [stdout] 61 - for permutation in cart_take.next() { [INFO] [stdout] 61 + for permutation in cart_take.by_ref() { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 61 - for permutation in cart_take.next() { [INFO] [stdout] 61 + if let Some(permutation) = cart_take.next() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/domain.rs:79:17 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn iter(&self) -> Iter { [INFO] [stdout] | ^^^^^ ----------------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 79 | pub fn iter(&self) -> Iter<'_, EncodedWord> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/domain.rs:103:17 [INFO] [stdout] | [INFO] [stdout] 103 | pub fn iter(&self) -> Iter { [INFO] [stdout] | ^^^^^ ---------------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 103 | pub fn iter(&self) -> Iter<'_, WordDomain> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/homoglyph.rs:16:17 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn iter(&self) -> Iter { [INFO] [stdout] | ^^^^^ ----------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 16 | pub fn iter(&self) -> Iter<'_, Glyph> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/sentence.rs:19:17 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn iter(&mut self) -> Iter { [INFO] [stdout] | ^^^^^^^^^ ---------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 19 | pub fn iter(&mut self) -> Iter<'_, Word> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/sentence.rs:72:17 [INFO] [stdout] | [INFO] [stdout] 72 | pub fn iter(&mut self) -> Iter { [INFO] [stdout] | ^^^^^^^^^ ----------------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 72 | pub fn iter(&mut self) -> Iter<'_, EncodedWord> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/word.rs:19:17 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn iter(&self) -> Iter { [INFO] [stdout] | ^^^^^ ----------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 19 | pub fn iter(&self) -> Iter<'_, Glyph> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/word.rs:78:17 [INFO] [stdout] | [INFO] [stdout] 78 | pub fn iter(&self) -> Iter { [INFO] [stdout] | ^^^^^ ------------------ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 78 | pub fn iter(&self) -> Iter<'_, EncodedGlyph> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.32s [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/domain.rs:61:32 [INFO] [stdout] | [INFO] [stdout] 61 | for permutation in cart_take.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to iterate over `cart_take` remove the call to `next` [INFO] [stdout] | [INFO] [stdout] 61 - for permutation in cart_take.next() { [INFO] [stdout] 61 + for permutation in cart_take.by_ref() { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 61 - for permutation in cart_take.next() { [INFO] [stdout] 61 + if let Some(permutation) = cart_take.next() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/domain.rs:79:17 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn iter(&self) -> Iter { [INFO] [stdout] | ^^^^^ ----------------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 79 | pub fn iter(&self) -> Iter<'_, EncodedWord> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/domain.rs:103:17 [INFO] [stdout] | [INFO] [stdout] 103 | pub fn iter(&self) -> Iter { [INFO] [stdout] | ^^^^^ ---------------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 103 | pub fn iter(&self) -> Iter<'_, WordDomain> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/homoglyph.rs:16:17 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn iter(&self) -> Iter { [INFO] [stdout] | ^^^^^ ----------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 16 | pub fn iter(&self) -> Iter<'_, Glyph> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/sentence.rs:19:17 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn iter(&mut self) -> Iter { [INFO] [stdout] | ^^^^^^^^^ ---------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 19 | pub fn iter(&mut self) -> Iter<'_, Word> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/sentence.rs:72:17 [INFO] [stdout] | [INFO] [stdout] 72 | pub fn iter(&mut self) -> Iter { [INFO] [stdout] | ^^^^^^^^^ ----------------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 72 | pub fn iter(&mut self) -> Iter<'_, EncodedWord> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/word.rs:19:17 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn iter(&self) -> Iter { [INFO] [stdout] | ^^^^^ ----------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 19 | pub fn iter(&self) -> Iter<'_, Glyph> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/word.rs:78:17 [INFO] [stdout] | [INFO] [stdout] 78 | pub fn iter(&self) -> Iter { [INFO] [stdout] | ^^^^^ ------------------ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 78 | pub fn iter(&self) -> Iter<'_, EncodedGlyph> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "ef2ab06ef4b06f1224c8fa35ce99b0ffeb4b55d43739046a0f72fa79ffdbd32a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ef2ab06ef4b06f1224c8fa35ce99b0ffeb4b55d43739046a0f72fa79ffdbd32a", kill_on_drop: false }` [INFO] [stdout] ef2ab06ef4b06f1224c8fa35ce99b0ffeb4b55d43739046a0f72fa79ffdbd32a