[INFO] fetching crate goscript-parser 0.1.0... [INFO] checking goscript-parser-0.1.0 against master#350d0ef0ec0493e6d21cfb265cb8211a0e74d766 for pr-145342-1 [INFO] extracting crate goscript-parser 0.1.0 into /workspace/builds/worker-3-tc1/source [INFO] started tweaking crates.io crate goscript-parser 0.1.0 [INFO] finished tweaking crates.io crate goscript-parser 0.1.0 [INFO] tweaked toml for crates.io crate goscript-parser 0.1.0 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate goscript-parser 0.1.0 on toolchain 350d0ef0ec0493e6d21cfb265cb8211a0e74d766 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+350d0ef0ec0493e6d21cfb265cb8211a0e74d766" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+350d0ef0ec0493e6d21cfb265cb8211a0e74d766" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 1 package to latest compatible version [INFO] [stderr] Adding slotmap v0.4.3 (available: v1.0.7) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+350d0ef0ec0493e6d21cfb265cb8211a0e74d766" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded slotmap v0.4.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+350d0ef0ec0493e6d21cfb265cb8211a0e74d766" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 45b6346ba4e463adc85477cea98ad693507037dd55865690baa477a1fc17425d [INFO] running `Command { std: "docker" "start" "-a" "45b6346ba4e463adc85477cea98ad693507037dd55865690baa477a1fc17425d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "45b6346ba4e463adc85477cea98ad693507037dd55865690baa477a1fc17425d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "45b6346ba4e463adc85477cea98ad693507037dd55865690baa477a1fc17425d", kill_on_drop: false }` [INFO] [stdout] 45b6346ba4e463adc85477cea98ad693507037dd55865690baa477a1fc17425d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+350d0ef0ec0493e6d21cfb265cb8211a0e74d766" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] eecb9e9b73ef36378e384291576931cbcfc40d64ec73910b5ca1ed79189c82d2 [INFO] running `Command { std: "docker" "start" "-a" "eecb9e9b73ef36378e384291576931cbcfc40d64ec73910b5ca1ed79189c82d2", kill_on_drop: false }` [INFO] [stderr] Checking slotmap v0.4.3 [INFO] [stderr] Checking goscript-parser v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/errors.rs:75:19 [INFO] [stdout] | [INFO] [stdout] 75 | pub fn borrow(&self) -> Ref> { [INFO] [stdout] | ^^^^^ --------------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 75 | pub fn borrow(&self) -> Ref<'_, Vec> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/position.rs:190:17 [INFO] [stdout] | [INFO] [stdout] 190 | pub fn iter(&self) -> FileSetIter { [INFO] [stdout] | ^^^^^ ----------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 190 | pub fn iter(&self) -> FileSetIter<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/position.rs:197:30 [INFO] [stdout] | [INFO] [stdout] 197 | return Some(f.borrow()); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `position::File` does not implement `Borrow`, so calling `borrow` on `&position::File` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 197 - return Some(f.borrow()); [INFO] [stdout] 197 + return Some(f); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `position::File`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 42 + #[derive(Clone)] [INFO] [stdout] 43 | pub struct File { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/errors.rs:75:19 [INFO] [stdout] | [INFO] [stdout] 75 | pub fn borrow(&self) -> Ref> { [INFO] [stdout] | ^^^^^ --------------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 75 | pub fn borrow(&self) -> Ref<'_, Vec> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/position.rs:190:17 [INFO] [stdout] | [INFO] [stdout] 190 | pub fn iter(&self) -> FileSetIter { [INFO] [stdout] | ^^^^^ ----------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 190 | pub fn iter(&self) -> FileSetIter<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/position.rs:197:30 [INFO] [stdout] | [INFO] [stdout] 197 | return Some(f.borrow()); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `position::File` does not implement `Borrow`, so calling `borrow` on `&position::File` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 197 - return Some(f.borrow()); [INFO] [stdout] 197 + return Some(f); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `position::File`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 42 + #[derive(Clone)] [INFO] [stdout] 43 | pub struct File { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.00s [INFO] running `Command { std: "docker" "inspect" "eecb9e9b73ef36378e384291576931cbcfc40d64ec73910b5ca1ed79189c82d2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eecb9e9b73ef36378e384291576931cbcfc40d64ec73910b5ca1ed79189c82d2", kill_on_drop: false }` [INFO] [stdout] eecb9e9b73ef36378e384291576931cbcfc40d64ec73910b5ca1ed79189c82d2