[INFO] fetching crate asciimusic 0.1.3... [INFO] checking asciimusic-0.1.3 against master#350d0ef0ec0493e6d21cfb265cb8211a0e74d766 for pr-145342-1 [INFO] extracting crate asciimusic 0.1.3 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate asciimusic 0.1.3 [INFO] finished tweaking crates.io crate asciimusic 0.1.3 [INFO] tweaked toml for crates.io crate asciimusic 0.1.3 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate asciimusic 0.1.3 on toolchain 350d0ef0ec0493e6d21cfb265cb8211a0e74d766 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+350d0ef0ec0493e6d21cfb265cb8211a0e74d766" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate asciimusic 0.1.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+350d0ef0ec0493e6d21cfb265cb8211a0e74d766" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+350d0ef0ec0493e6d21cfb265cb8211a0e74d766" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b3c45b3a34ce7602f3ae24747c060170f002328c165a8d3c111b3f7f41cca81a [INFO] running `Command { std: "docker" "start" "-a" "b3c45b3a34ce7602f3ae24747c060170f002328c165a8d3c111b3f7f41cca81a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b3c45b3a34ce7602f3ae24747c060170f002328c165a8d3c111b3f7f41cca81a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b3c45b3a34ce7602f3ae24747c060170f002328c165a8d3c111b3f7f41cca81a", kill_on_drop: false }` [INFO] [stdout] b3c45b3a34ce7602f3ae24747c060170f002328c165a8d3c111b3f7f41cca81a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+350d0ef0ec0493e6d21cfb265cb8211a0e74d766" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 49d757f1f9ab5164162dcf56c25e9956b861e32306429af61d7fd54adf83001d [INFO] running `Command { std: "docker" "start" "-a" "49d757f1f9ab5164162dcf56c25e9956b861e32306429af61d7fd54adf83001d", kill_on_drop: false }` [INFO] [stderr] Checking asciimusic v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/song.rs:105:36 [INFO] [stdout] | [INFO] [stdout] 105 | let instrument = match Instrument::from_id(instrument_id) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 105 | let instrument = match ::from_id(instrument_id) { [INFO] [stdout] | ++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/song.rs:105:36 [INFO] [stdout] | [INFO] [stdout] 105 | let instrument = match Instrument::from_id(instrument_id) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 105 | let instrument = match ::from_id(instrument_id) { [INFO] [stdout] | ++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `ToBase32` is never used [INFO] [stdout] --> src/base32.rs:38:11 [INFO] [stdout] | [INFO] [stdout] 38 | pub trait ToBase32: Sized + fmt::Debug { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `ToBase32` is never used [INFO] [stdout] --> src/base32.rs:38:11 [INFO] [stdout] | [INFO] [stdout] 38 | pub trait ToBase32: Sized + fmt::Debug { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/voice.rs:87:32 [INFO] [stdout] | [INFO] [stdout] 87 | self.instrument.borrow().sample(self.ramp / self.sample_rate) [INFO] [stdout] | ^^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `dyn Instrument` does not implement `Borrow`, so calling `borrow` on `&dyn Instrument` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/voice.rs:87:32 [INFO] [stdout] | [INFO] [stdout] 87 | self.instrument.borrow().sample(self.ramp / self.sample_rate) [INFO] [stdout] | ^^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `dyn Instrument` does not implement `Borrow`, so calling `borrow` on `&dyn Instrument` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/song.rs:185:28 [INFO] [stdout] | [INFO] [stdout] 185 | pub fn voice_iterators(&mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^^ ------------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 185 | pub fn voice_iterators(&mut self) -> Vec> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/song.rs:209:20 [INFO] [stdout] | [INFO] [stdout] 209 | pub fn samples(&mut self) -> SongIterator { [INFO] [stdout] | ^^^^^^^^^ ------------ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 209 | pub fn samples(&mut self) -> SongIterator<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/song.rs:185:28 [INFO] [stdout] | [INFO] [stdout] 185 | pub fn voice_iterators(&mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^^ ------------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 185 | pub fn voice_iterators(&mut self) -> Vec> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/song.rs:209:20 [INFO] [stdout] | [INFO] [stdout] 209 | pub fn samples(&mut self) -> SongIterator { [INFO] [stdout] | ^^^^^^^^^ ------------ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 209 | pub fn samples(&mut self) -> SongIterator<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.35s [INFO] running `Command { std: "docker" "inspect" "49d757f1f9ab5164162dcf56c25e9956b861e32306429af61d7fd54adf83001d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "49d757f1f9ab5164162dcf56c25e9956b861e32306429af61d7fd54adf83001d", kill_on_drop: false }` [INFO] [stdout] 49d757f1f9ab5164162dcf56c25e9956b861e32306429af61d7fd54adf83001d