[INFO] fetching crate arsc 0.1.5... [INFO] checking arsc-0.1.5 against master#350d0ef0ec0493e6d21cfb265cb8211a0e74d766 for pr-145342-1 [INFO] extracting crate arsc 0.1.5 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate arsc 0.1.5 [INFO] finished tweaking crates.io crate arsc 0.1.5 [INFO] tweaked toml for crates.io crate arsc 0.1.5 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate arsc 0.1.5 on toolchain 350d0ef0ec0493e6d21cfb265cb8211a0e74d766 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+350d0ef0ec0493e6d21cfb265cb8211a0e74d766" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+350d0ef0ec0493e6d21cfb265cb8211a0e74d766" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 15 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+350d0ef0ec0493e6d21cfb265cb8211a0e74d766" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+350d0ef0ec0493e6d21cfb265cb8211a0e74d766" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e53bd3abec17f86afb89c7979d172260ccf551cf1c043466ad55d9ee6d5ea358 [INFO] running `Command { std: "docker" "start" "-a" "e53bd3abec17f86afb89c7979d172260ccf551cf1c043466ad55d9ee6d5ea358", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e53bd3abec17f86afb89c7979d172260ccf551cf1c043466ad55d9ee6d5ea358", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e53bd3abec17f86afb89c7979d172260ccf551cf1c043466ad55d9ee6d5ea358", kill_on_drop: false }` [INFO] [stdout] e53bd3abec17f86afb89c7979d172260ccf551cf1c043466ad55d9ee6d5ea358 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+350d0ef0ec0493e6d21cfb265cb8211a0e74d766" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 30874248cc53ac0034342a9fa1b920d35266b0873985d3be02fc15fce2a18ad1 [INFO] running `Command { std: "docker" "start" "-a" "30874248cc53ac0034342a9fa1b920d35266b0873985d3be02fc15fce2a18ad1", kill_on_drop: false }` [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking arsc v0.1.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/writer/components_writing.rs:290:22 [INFO] [stdout] | [INFO] [stdout] 290 | for specs in &self.specs { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 290 - for specs in &self.specs { [INFO] [stdout] 290 + while let Some(specs) = &self.specs { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 290 - for specs in &self.specs { [INFO] [stdout] 290 + if let Some(specs) = &self.specs { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.75s [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/writer/components_writing.rs:290:22 [INFO] [stdout] | [INFO] [stdout] 290 | for specs in &self.specs { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 290 - for specs in &self.specs { [INFO] [stdout] 290 + while let Some(specs) = &self.specs { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 290 - for specs in &self.specs { [INFO] [stdout] 290 + if let Some(specs) = &self.specs { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "30874248cc53ac0034342a9fa1b920d35266b0873985d3be02fc15fce2a18ad1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "30874248cc53ac0034342a9fa1b920d35266b0873985d3be02fc15fce2a18ad1", kill_on_drop: false }` [INFO] [stdout] 30874248cc53ac0034342a9fa1b920d35266b0873985d3be02fc15fce2a18ad1