[INFO] cloning repository https://github.com/angelocarly/RVK [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/angelocarly/RVK" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fangelocarly%2FRVK", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fangelocarly%2FRVK'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a8a72426f1e777041f726dc5a5dae4ac1606dc13 [INFO] checking angelocarly/RVK against master#350d0ef0ec0493e6d21cfb265cb8211a0e74d766 for pr-145342-1 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fangelocarly%2FRVK" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/angelocarly/RVK [INFO] finished tweaking git repo https://github.com/angelocarly/RVK [INFO] tweaked toml for git repo https://github.com/angelocarly/RVK written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/angelocarly/RVK on toolchain 350d0ef0ec0493e6d21cfb265cb8211a0e74d766 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+350d0ef0ec0493e6d21cfb265cb8211a0e74d766" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/angelocarly/RVK already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+350d0ef0ec0493e6d21cfb265cb8211a0e74d766" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded glam v0.23.0 [INFO] [stderr] Downloaded png v0.17.7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+350d0ef0ec0493e6d21cfb265cb8211a0e74d766" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f023f20a6fed3ca926f30e0b7fb133c5564f1f299d56b6d64af84c7daeec5eb2 [INFO] running `Command { std: "docker" "start" "-a" "f023f20a6fed3ca926f30e0b7fb133c5564f1f299d56b6d64af84c7daeec5eb2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f023f20a6fed3ca926f30e0b7fb133c5564f1f299d56b6d64af84c7daeec5eb2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f023f20a6fed3ca926f30e0b7fb133c5564f1f299d56b6d64af84c7daeec5eb2", kill_on_drop: false }` [INFO] [stdout] f023f20a6fed3ca926f30e0b7fb133c5564f1f299d56b6d64af84c7daeec5eb2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7ad1b28ee6f5f7f699f6cf7015098d6ccdd96d6f2d78dd06228f5b4c9faf309c" "/opt/rustwide/cargo-home/bin/cargo" "+350d0ef0ec0493e6d21cfb265cb8211a0e74d766" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 23744e87c59ea0e9b1871941190cd29383032c3d0ba181fd5075c1f0bfc4c7a3 [INFO] running `Command { std: "docker" "start" "-a" "23744e87c59ea0e9b1871941190cd29383032c3d0ba181fd5075c1f0bfc4c7a3", kill_on_drop: false }` [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking glam v0.23.0 [INFO] [stderr] Checking miniz_oxide v0.6.2 [INFO] [stderr] Checking flate2 v1.0.25 [INFO] [stderr] Checking png v0.17.7 [INFO] [stderr] Checking RVK v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/image.rs:108:7 [INFO] [stdout] | [INFO] [stdout] 108 | if( reader.info().color_type != png::ColorType::Rgb ) { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 108 - if( reader.info().color_type != png::ColorType::Rgb ) { [INFO] [stdout] 108 + if reader.info().color_type != png::ColorType::Rgb { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/image.rs:108:7 [INFO] [stdout] | [INFO] [stdout] 108 | if( reader.info().color_type != png::ColorType::Rgb ) { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 108 - if( reader.info().color_type != png::ColorType::Rgb ) { [INFO] [stdout] 108 + if reader.info().color_type != png::ColorType::Rgb { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `miss` [INFO] [stdout] --> src/main.rs:38:37 [INFO] [stdout] | [INFO] [stdout] 38 | rays::CastResult::Miss( miss ) => { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_miss` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `process` is never used [INFO] [stdout] --> src/main.rs:121:4 [INFO] [stdout] | [INFO] [stdout] 121 | fn process( cs: &mut ColorSink ) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `get_width` and `get_height` are never used [INFO] [stdout] --> src/image.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 31 | impl ColorSink { [INFO] [stdout] | -------------- methods in this implementation [INFO] [stdout] 32 | pub fn get_width(&self) -> u32 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 36 | pub fn get_height(&self) -> u32 { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_pixel` is never used [INFO] [stdout] --> src/image.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 41 | impl ColorSink { [INFO] [stdout] | -------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 51 | pub fn get_pixel(&mut self, x: u32, y: u32 ) -> Color { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `read_png_image` is never used [INFO] [stdout] --> src/image.rs:102:8 [INFO] [stdout] | [INFO] [stdout] 102 | pub fn read_png_image( path: &str ) -> ColorSink { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `position`, `distance`, `normal`, `shape`, `bounces`, and `cum_length` are never read [INFO] [stdout] --> src/rays.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct Hit<'a> { [INFO] [stdout] | --- fields in this struct [INFO] [stdout] 5 | pub position: Vec3, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 6 | pub distance: f32, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 7 | pub normal: Vec3, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 8 | pub shape: &'a Box< dyn Hittable >, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 9 | pub bounces: u32, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 10 | pub cum_length: f32, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `position`, `bounces`, `cum_length`, and `weight` are never read [INFO] [stdout] --> src/rays.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct Miss { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 15 | pub position: Vec3, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 16 | pub bounces: u32, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 17 | pub cum_length: f32, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 18 | weight: f32 [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `color` is never read [INFO] [stdout] --> src/rays.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 26 | pub struct Material { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 27 | pub color: Vec3, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/rays.rs:157:18 [INFO] [stdout] | [INFO] [stdout] 157 | pub fn cast( &self, ray: camera::Ray, max_distance: f32 ) -> Option< CastResult > { [INFO] [stdout] | ^^^^^ the lifetime is elided here ---------- the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 157 | pub fn cast( &self, ray: camera::Ray, max_distance: f32 ) -> Option< CastResult<'_> > { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `EPSILON` should have a snake case name [INFO] [stdout] --> src/rays.rs:188:17 [INFO] [stdout] | [INFO] [stdout] 188 | let EPSILON = 0.0001; [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `epsilon` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `miss` [INFO] [stdout] --> src/main.rs:38:37 [INFO] [stdout] | [INFO] [stdout] 38 | rays::CastResult::Miss( miss ) => { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_miss` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `process` is never used [INFO] [stdout] --> src/main.rs:121:4 [INFO] [stdout] | [INFO] [stdout] 121 | fn process( cs: &mut ColorSink ) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `get_width` and `get_height` are never used [INFO] [stdout] --> src/image.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 31 | impl ColorSink { [INFO] [stdout] | -------------- methods in this implementation [INFO] [stdout] 32 | pub fn get_width(&self) -> u32 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 36 | pub fn get_height(&self) -> u32 { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_pixel` is never used [INFO] [stdout] --> src/image.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 41 | impl ColorSink { [INFO] [stdout] | -------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 51 | pub fn get_pixel(&mut self, x: u32, y: u32 ) -> Color { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `read_png_image` is never used [INFO] [stdout] --> src/image.rs:102:8 [INFO] [stdout] | [INFO] [stdout] 102 | pub fn read_png_image( path: &str ) -> ColorSink { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `position`, `distance`, `normal`, `shape`, `bounces`, and `cum_length` are never read [INFO] [stdout] --> src/rays.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct Hit<'a> { [INFO] [stdout] | --- fields in this struct [INFO] [stdout] 5 | pub position: Vec3, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 6 | pub distance: f32, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 7 | pub normal: Vec3, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 8 | pub shape: &'a Box< dyn Hittable >, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 9 | pub bounces: u32, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 10 | pub cum_length: f32, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `position`, `bounces`, `cum_length`, and `weight` are never read [INFO] [stdout] --> src/rays.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct Miss { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 15 | pub position: Vec3, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 16 | pub bounces: u32, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 17 | pub cum_length: f32, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 18 | weight: f32 [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `color` is never read [INFO] [stdout] --> src/rays.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 26 | pub struct Material { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 27 | pub color: Vec3, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/rays.rs:157:18 [INFO] [stdout] | [INFO] [stdout] 157 | pub fn cast( &self, ray: camera::Ray, max_distance: f32 ) -> Option< CastResult > { [INFO] [stdout] | ^^^^^ the lifetime is elided here ---------- the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 157 | pub fn cast( &self, ray: camera::Ray, max_distance: f32 ) -> Option< CastResult<'_> > { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `EPSILON` should have a snake case name [INFO] [stdout] --> src/rays.rs:188:17 [INFO] [stdout] | [INFO] [stdout] 188 | let EPSILON = 0.0001; [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `epsilon` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.63s [INFO] running `Command { std: "docker" "inspect" "23744e87c59ea0e9b1871941190cd29383032c3d0ba181fd5075c1f0bfc4c7a3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "23744e87c59ea0e9b1871941190cd29383032c3d0ba181fd5075c1f0bfc4c7a3", kill_on_drop: false }` [INFO] [stdout] 23744e87c59ea0e9b1871941190cd29383032c3d0ba181fd5075c1f0bfc4c7a3