[INFO] fetching crate dummy_xml 0.1.6... [INFO] testing dummy_xml-0.1.6 against try#b6ae10aa7319b7ebb6c7b3331dd71a9d6c9c5b4b for pr-145330-1 [INFO] extracting crate dummy_xml 0.1.6 into /workspace/builds/worker-3-tc2/source [INFO] started tweaking crates.io crate dummy_xml 0.1.6 [INFO] finished tweaking crates.io crate dummy_xml 0.1.6 [INFO] tweaked toml for crates.io crate dummy_xml 0.1.6 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] validating manifest of crates.io crate dummy_xml 0.1.6 on toolchain b6ae10aa7319b7ebb6c7b3331dd71a9d6c9c5b4b [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+b6ae10aa7319b7ebb6c7b3331dd71a9d6c9c5b4b" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+b6ae10aa7319b7ebb6c7b3331dd71a9d6c9c5b4b" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+b6ae10aa7319b7ebb6c7b3331dd71a9d6c9c5b4b" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:e90291280db7d1fac5b66fc6dad9f9662629e7365a55743daf9bdf73ebc4ea79" "/opt/rustwide/cargo-home/bin/cargo" "+b6ae10aa7319b7ebb6c7b3331dd71a9d6c9c5b4b" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 32d4ea1c608893feed3e2522b89fa5d736e9816d24309fd47d6a69d7067a1642 [INFO] running `Command { std: "docker" "start" "-a" "32d4ea1c608893feed3e2522b89fa5d736e9816d24309fd47d6a69d7067a1642", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "32d4ea1c608893feed3e2522b89fa5d736e9816d24309fd47d6a69d7067a1642", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "32d4ea1c608893feed3e2522b89fa5d736e9816d24309fd47d6a69d7067a1642", kill_on_drop: false }` [INFO] [stdout] 32d4ea1c608893feed3e2522b89fa5d736e9816d24309fd47d6a69d7067a1642 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:e90291280db7d1fac5b66fc6dad9f9662629e7365a55743daf9bdf73ebc4ea79" "/opt/rustwide/cargo-home/bin/cargo" "+b6ae10aa7319b7ebb6c7b3331dd71a9d6c9c5b4b" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9628eca80efaf35095c19d5ff0b766d5c9597e102ada96a34124385bf03b5ab8 [INFO] running `Command { std: "docker" "start" "-a" "9628eca80efaf35095c19d5ff0b766d5c9597e102ada96a34124385bf03b5ab8", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] [stderr] Compiling dummy_xml v0.1.6 (/opt/rustwide/workdir) [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/node.rs:82:52 [INFO] [stdout] | [INFO] [stdout] 82 | unsafe { self.prev.as_ref().map(|attr| attr.borrow()) } [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Attribute` does not implement `Borrow`, so calling `borrow` on `&Attribute` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 82 - unsafe { self.prev.as_ref().map(|attr| attr.borrow()) } [INFO] [stdout] 82 + unsafe { self.prev.as_ref().map(|attr| attr) } [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `Attribute`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 5 + #[derive(Clone)] [INFO] [stdout] 6 | pub struct Attribute { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/node.rs:178:52 [INFO] [stdout] | [INFO] [stdout] 178 | unsafe { self.prev.as_ref().map(|node| node.borrow()) } [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Node<'_>` does not implement `Borrow`, so calling `borrow` on `&Node<'_>` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 178 - unsafe { self.prev.as_ref().map(|node| node.borrow()) } [INFO] [stdout] 178 + unsafe { self.prev.as_ref().map(|node| node) } [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `Node<'_>`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 24 + #[derive(Clone)] [INFO] [stdout] 25 | pub struct Node<'a> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/node.rs:188:54 [INFO] [stdout] | [INFO] [stdout] 188 | unsafe { self.parent.as_ref().map(|node| node.borrow()) } [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Node<'_>` does not implement `Borrow`, so calling `borrow` on `&Node<'_>` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 188 - unsafe { self.parent.as_ref().map(|node| node.borrow()) } [INFO] [stdout] 188 + unsafe { self.parent.as_ref().map(|node| node) } [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `Node<'_>`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 24 + #[derive(Clone)] [INFO] [stdout] 25 | pub struct Node<'a> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/node.rs:208:58 [INFO] [stdout] | [INFO] [stdout] 208 | unsafe { self.last_child.as_ref().map(|node| node.borrow()) } [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Node<'_>` does not implement `Borrow`, so calling `borrow` on `&Node<'_>` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 208 - unsafe { self.last_child.as_ref().map(|node| node.borrow()) } [INFO] [stdout] 208 + unsafe { self.last_child.as_ref().map(|node| node) } [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `Node<'_>`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 24 + #[derive(Clone)] [INFO] [stdout] 25 | pub struct Node<'a> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/node.rs:228:57 [INFO] [stdout] | [INFO] [stdout] 228 | unsafe { self.last_attr.as_ref().map(|node| node.borrow()) } [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Attribute` does not implement `Borrow`, so calling `borrow` on `&Attribute` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 228 - unsafe { self.last_attr.as_ref().map(|node| node.borrow()) } [INFO] [stdout] 228 + unsafe { self.last_attr.as_ref().map(|node| node) } [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `Attribute`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 5 + #[derive(Clone)] [INFO] [stdout] 6 | pub struct Attribute { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/parser.rs:108:28 [INFO] [stdout] | [INFO] [stdout] 108 | pub fn parse_str(contents: &str) -> Result { [INFO] [stdout] | ^^^^ -------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 108 | pub fn parse_str(contents: &str) -> Result, ParseXmlError> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/parser.rs:112:31 [INFO] [stdout] | [INFO] [stdout] 112 | pub fn parse_string(contents: &String) -> Result { [INFO] [stdout] | ^^^^^^^ -------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 112 | pub fn parse_string(contents: &String) -> Result, ParseXmlError> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/parser.rs:116:24 [INFO] [stdout] | [INFO] [stdout] 116 | pub fn parse(contents: &[u8]) -> Result { [INFO] [stdout] | ^^^^^ -------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 116 | pub fn parse(contents: &[u8]) -> Result, ParseXmlError> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.33s [INFO] running `Command { std: "docker" "inspect" "9628eca80efaf35095c19d5ff0b766d5c9597e102ada96a34124385bf03b5ab8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9628eca80efaf35095c19d5ff0b766d5c9597e102ada96a34124385bf03b5ab8", kill_on_drop: false }` [INFO] [stdout] 9628eca80efaf35095c19d5ff0b766d5c9597e102ada96a34124385bf03b5ab8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:e90291280db7d1fac5b66fc6dad9f9662629e7365a55743daf9bdf73ebc4ea79" "/opt/rustwide/cargo-home/bin/cargo" "+b6ae10aa7319b7ebb6c7b3331dd71a9d6c9c5b4b" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ffca6d2beb1234312b16ffebf5c4dddadbded34eaed9c88600b7b79fc935df51 [INFO] running `Command { std: "docker" "start" "-a" "ffca6d2beb1234312b16ffebf5c4dddadbded34eaed9c88600b7b79fc935df51", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/node.rs:82:52 [INFO] [stdout] | [INFO] [stdout] 82 | unsafe { self.prev.as_ref().map(|attr| attr.borrow()) } [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Attribute` does not implement `Borrow`, so calling `borrow` on `&Attribute` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 82 - unsafe { self.prev.as_ref().map(|attr| attr.borrow()) } [INFO] [stdout] 82 + unsafe { self.prev.as_ref().map(|attr| attr) } [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `Attribute`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 5 + #[derive(Clone)] [INFO] [stdout] 6 | pub struct Attribute { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/node.rs:178:52 [INFO] [stdout] | [INFO] [stdout] 178 | unsafe { self.prev.as_ref().map(|node| node.borrow()) } [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Node<'_>` does not implement `Borrow`, so calling `borrow` on `&Node<'_>` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 178 - unsafe { self.prev.as_ref().map(|node| node.borrow()) } [INFO] [stdout] 178 + unsafe { self.prev.as_ref().map(|node| node) } [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `Node<'_>`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 24 + #[derive(Clone)] [INFO] [stdout] 25 | pub struct Node<'a> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/node.rs:188:54 [INFO] [stdout] | [INFO] [stdout] 188 | unsafe { self.parent.as_ref().map(|node| node.borrow()) } [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Node<'_>` does not implement `Borrow`, so calling `borrow` on `&Node<'_>` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 188 - unsafe { self.parent.as_ref().map(|node| node.borrow()) } [INFO] [stdout] 188 + unsafe { self.parent.as_ref().map(|node| node) } [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `Node<'_>`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 24 + #[derive(Clone)] [INFO] [stdout] 25 | pub struct Node<'a> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/node.rs:208:58 [INFO] [stdout] | [INFO] [stdout] 208 | unsafe { self.last_child.as_ref().map(|node| node.borrow()) } [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Node<'_>` does not implement `Borrow`, so calling `borrow` on `&Node<'_>` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 208 - unsafe { self.last_child.as_ref().map(|node| node.borrow()) } [INFO] [stdout] 208 + unsafe { self.last_child.as_ref().map(|node| node) } [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `Node<'_>`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 24 + #[derive(Clone)] [INFO] [stdout] 25 | pub struct Node<'a> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/node.rs:228:57 [INFO] [stdout] | [INFO] [stdout] 228 | unsafe { self.last_attr.as_ref().map(|node| node.borrow()) } [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Attribute` does not implement `Borrow`, so calling `borrow` on `&Attribute` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 228 - unsafe { self.last_attr.as_ref().map(|node| node.borrow()) } [INFO] [stdout] 228 + unsafe { self.last_attr.as_ref().map(|node| node) } [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `Attribute`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 5 + #[derive(Clone)] [INFO] [stdout] 6 | pub struct Attribute { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/parser.rs:108:28 [INFO] [stdout] | [INFO] [stdout] 108 | pub fn parse_str(contents: &str) -> Result { [INFO] [stdout] | ^^^^ -------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 108 | pub fn parse_str(contents: &str) -> Result, ParseXmlError> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling dummy_xml v0.1.6 (/opt/rustwide/workdir) [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/parser.rs:112:31 [INFO] [stdout] | [INFO] [stdout] 112 | pub fn parse_string(contents: &String) -> Result { [INFO] [stdout] | ^^^^^^^ -------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 112 | pub fn parse_string(contents: &String) -> Result, ParseXmlError> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/parser.rs:116:24 [INFO] [stdout] | [INFO] [stdout] 116 | pub fn parse(contents: &[u8]) -> Result { [INFO] [stdout] | ^^^^^ -------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 116 | pub fn parse(contents: &[u8]) -> Result, ParseXmlError> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/node.rs:82:52 [INFO] [stdout] | [INFO] [stdout] 82 | unsafe { self.prev.as_ref().map(|attr| attr.borrow()) } [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `node::Attribute` does not implement `Borrow`, so calling `borrow` on `&node::Attribute` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 82 - unsafe { self.prev.as_ref().map(|attr| attr.borrow()) } [INFO] [stdout] 82 + unsafe { self.prev.as_ref().map(|attr| attr) } [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `node::Attribute`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 5 + #[derive(Clone)] [INFO] [stdout] 6 | pub struct Attribute { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/node.rs:178:52 [INFO] [stdout] | [INFO] [stdout] 178 | unsafe { self.prev.as_ref().map(|node| node.borrow()) } [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `node::Node<'_>` does not implement `Borrow`, so calling `borrow` on `&node::Node<'_>` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 178 - unsafe { self.prev.as_ref().map(|node| node.borrow()) } [INFO] [stdout] 178 + unsafe { self.prev.as_ref().map(|node| node) } [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `node::Node<'_>`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 24 + #[derive(Clone)] [INFO] [stdout] 25 | pub struct Node<'a> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/node.rs:188:54 [INFO] [stdout] | [INFO] [stdout] 188 | unsafe { self.parent.as_ref().map(|node| node.borrow()) } [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `node::Node<'_>` does not implement `Borrow`, so calling `borrow` on `&node::Node<'_>` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 188 - unsafe { self.parent.as_ref().map(|node| node.borrow()) } [INFO] [stdout] 188 + unsafe { self.parent.as_ref().map(|node| node) } [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `node::Node<'_>`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 24 + #[derive(Clone)] [INFO] [stdout] 25 | pub struct Node<'a> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/node.rs:208:58 [INFO] [stdout] | [INFO] [stdout] 208 | unsafe { self.last_child.as_ref().map(|node| node.borrow()) } [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `node::Node<'_>` does not implement `Borrow`, so calling `borrow` on `&node::Node<'_>` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 208 - unsafe { self.last_child.as_ref().map(|node| node.borrow()) } [INFO] [stdout] 208 + unsafe { self.last_child.as_ref().map(|node| node) } [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `node::Node<'_>`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 24 + #[derive(Clone)] [INFO] [stdout] 25 | pub struct Node<'a> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/node.rs:228:57 [INFO] [stdout] | [INFO] [stdout] 228 | unsafe { self.last_attr.as_ref().map(|node| node.borrow()) } [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `node::Attribute` does not implement `Borrow`, so calling `borrow` on `&node::Attribute` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 228 - unsafe { self.last_attr.as_ref().map(|node| node.borrow()) } [INFO] [stdout] 228 + unsafe { self.last_attr.as_ref().map(|node| node) } [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `node::Attribute`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 5 + #[derive(Clone)] [INFO] [stdout] 6 | pub struct Attribute { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/parser.rs:108:28 [INFO] [stdout] | [INFO] [stdout] 108 | pub fn parse_str(contents: &str) -> Result { [INFO] [stdout] | ^^^^ -------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 108 | pub fn parse_str(contents: &str) -> Result, ParseXmlError> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/parser.rs:112:31 [INFO] [stdout] | [INFO] [stdout] 112 | pub fn parse_string(contents: &String) -> Result { [INFO] [stdout] | ^^^^^^^ -------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 112 | pub fn parse_string(contents: &String) -> Result, ParseXmlError> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/parser.rs:116:24 [INFO] [stdout] | [INFO] [stdout] 116 | pub fn parse(contents: &[u8]) -> Result { [INFO] [stdout] | ^^^^^ -------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 116 | pub fn parse(contents: &[u8]) -> Result, ParseXmlError> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `test` profile [unoptimized + debuginfo] target(s) in 1.12s [INFO] running `Command { std: "docker" "inspect" "ffca6d2beb1234312b16ffebf5c4dddadbded34eaed9c88600b7b79fc935df51", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ffca6d2beb1234312b16ffebf5c4dddadbded34eaed9c88600b7b79fc935df51", kill_on_drop: false }` [INFO] [stdout] ffca6d2beb1234312b16ffebf5c4dddadbded34eaed9c88600b7b79fc935df51 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:e90291280db7d1fac5b66fc6dad9f9662629e7365a55743daf9bdf73ebc4ea79" "/opt/rustwide/cargo-home/bin/cargo" "+b6ae10aa7319b7ebb6c7b3331dd71a9d6c9c5b4b" "test" "--frozen", kill_on_drop: false }` [INFO] [stdout] e5471c3a1853154e1666ec3daba50e524841088a4656e702f785b13c5413483b [INFO] running `Command { std: "docker" "start" "-a" "e5471c3a1853154e1666ec3daba50e524841088a4656e702f785b13c5413483b", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] [stderr] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stderr] --> src/node.rs:82:52 [INFO] [stderr] | [INFO] [stderr] 82 | unsafe { self.prev.as_ref().map(|attr| attr.borrow()) } [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: the type `Attribute` does not implement `Borrow`, so calling `borrow` on `&Attribute` copies the reference, which does not do anything and can be removed [INFO] [stderr] = note: `#[warn(noop_method_call)]` on by default [INFO] [stderr] help: remove this redundant call [INFO] [stderr] | [INFO] [stderr] 82 - unsafe { self.prev.as_ref().map(|attr| attr.borrow()) } [INFO] [stderr] 82 + unsafe { self.prev.as_ref().map(|attr| attr) } [INFO] [stderr] | [INFO] [stderr] help: if you meant to clone `Attribute`, implement `Clone` for it [INFO] [stderr] | [INFO] [stderr] 5 + #[derive(Clone)] [INFO] [stderr] 6 | pub struct Attribute { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stderr] --> src/node.rs:178:52 [INFO] [stderr] | [INFO] [stderr] 178 | unsafe { self.prev.as_ref().map(|node| node.borrow()) } [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: the type `Node<'_>` does not implement `Borrow`, so calling `borrow` on `&Node<'_>` copies the reference, which does not do anything and can be removed [INFO] [stderr] help: remove this redundant call [INFO] [stderr] | [INFO] [stderr] 178 - unsafe { self.prev.as_ref().map(|node| node.borrow()) } [INFO] [stderr] 178 + unsafe { self.prev.as_ref().map(|node| node) } [INFO] [stderr] | [INFO] [stderr] help: if you meant to clone `Node<'_>`, implement `Clone` for it [INFO] [stderr] | [INFO] [stderr] 24 + #[derive(Clone)] [INFO] [stderr] 25 | pub struct Node<'a> { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stderr] --> src/node.rs:188:54 [INFO] [stderr] | [INFO] [stderr] 188 | unsafe { self.parent.as_ref().map(|node| node.borrow()) } [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: the type `Node<'_>` does not implement `Borrow`, so calling `borrow` on `&Node<'_>` copies the reference, which does not do anything and can be removed [INFO] [stderr] help: remove this redundant call [INFO] [stdout] [INFO] [stderr] | [INFO] [stdout] running 8 tests [INFO] [stderr] 188 - unsafe { self.parent.as_ref().map(|node| node.borrow()) } [INFO] [stderr] 188 + unsafe { self.parent.as_ref().map(|node| node) } [INFO] [stderr] | [INFO] [stderr] help: if you meant to clone `Node<'_>`, implement `Clone` for it [INFO] [stderr] | [INFO] [stderr] 24 + #[derive(Clone)] [INFO] [stderr] 25 | pub struct Node<'a> { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stderr] --> src/node.rs:208:58 [INFO] [stderr] | [INFO] [stderr] 208 | unsafe { self.last_child.as_ref().map(|node| node.borrow()) } [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: the type `Node<'_>` does not implement `Borrow`, so calling `borrow` on `&Node<'_>` copies the reference, which does not do anything and can be removed [INFO] [stderr] help: remove this redundant call [INFO] [stderr] | [INFO] [stderr] 208 - unsafe { self.last_child.as_ref().map(|node| node.borrow()) } [INFO] [stderr] 208 + unsafe { self.last_child.as_ref().map(|node| node) } [INFO] [stderr] | [INFO] [stderr] help: if you meant to clone `Node<'_>`, implement `Clone` for it [INFO] [stderr] | [INFO] [stderr] 24 + #[derive(Clone)] [INFO] [stderr] 25 | pub struct Node<'a> { [INFO] [stderr] | [INFO] [stderr] [INFO] [stdout] test node::tests::new_attribute_test ... ok [INFO] [stderr] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] test node::tests::function_chain_test ... ok [INFO] [stderr] --> src/node.rs:228:57 [INFO] [stdout] test parser::tests::test_parse ... ok [INFO] [stderr] | [INFO] [stdout] test parser::tests::test_parse_note_xml ... ok [INFO] [stderr] 228 | unsafe { self.last_attr.as_ref().map(|node| node.borrow()) } [INFO] [stdout] test tests::it_works ... ok [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: the type `Attribute` does not implement `Borrow`, so calling `borrow` on `&Attribute` copies the reference, which does not do anything and can be removed [INFO] [stderr] help: remove this redundant call [INFO] [stderr] | [INFO] [stderr] 228 - unsafe { self.last_attr.as_ref().map(|node| node.borrow()) } [INFO] [stderr] 228 + unsafe { self.last_attr.as_ref().map(|node| node) } [INFO] [stderr] | [INFO] [stderr] help: if you meant to clone `Attribute`, implement `Clone` for it [INFO] [stderr] | [INFO] [stderr] 5 + #[derive(Clone)] [INFO] [stdout] test writer::tests::write_test ... ok [INFO] [stderr] 6 | pub struct Attribute { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stderr] --> src/parser.rs:108:28 [INFO] [stderr] | [INFO] [stderr] 108 | pub fn parse_str(contents: &str) -> Result { [INFO] [stderr] | ^^^^ -------- the same lifetime is hidden here [INFO] [stderr] | | [INFO] [stderr] | the lifetime is elided here [INFO] [stderr] | [INFO] [stderr] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stderr] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stderr] help: use `'_` for type paths [INFO] [stderr] | [INFO] [stderr] 108 | pub fn parse_str(contents: &str) -> Result, ParseXmlError> { [INFO] [stderr] | ++++ [INFO] [stderr] [INFO] [stderr] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stderr] --> src/parser.rs:112:31 [INFO] [stderr] | [INFO] [stderr] 112 | pub fn parse_string(contents: &String) -> Result { [INFO] [stderr] | ^^^^^^^ -------- the same lifetime is hidden here [INFO] [stderr] | | [INFO] [stderr] | the lifetime is elided here [INFO] [stderr] | [INFO] [stderr] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stderr] help: use `'_` for type paths [INFO] [stderr] | [INFO] [stderr] 112 | pub fn parse_string(contents: &String) -> Result, ParseXmlError> { [INFO] [stderr] | ++++ [INFO] [stderr] [INFO] [stderr] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stderr] --> src/parser.rs:116:24 [INFO] [stderr] | [INFO] [stderr] 116 | pub fn parse(contents: &[u8]) -> Result { [INFO] [stderr] | ^^^^^ -------- the same lifetime is hidden here [INFO] [stderr] | | [INFO] [stderr] | the lifetime is elided here [INFO] [stderr] | [INFO] [stderr] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] test node::tests::new_node_test ... ok [INFO] [stderr] help: use `'_` for type paths [INFO] [stderr] | [INFO] [stderr] 116 | pub fn parse(contents: &[u8]) -> Result, ParseXmlError> { [INFO] [stderr] | ++++ [INFO] [stderr] [INFO] [stderr] warning: `dummy_xml` (lib) generated 8 warnings (run `cargo fix --lib -p dummy_xml` to apply 8 suggestions) [INFO] [stderr] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] test parser::tests::bench_parse ... ok [INFO] [stderr] --> src/node.rs:82:52 [INFO] [stdout] [INFO] [stderr] | [INFO] [stdout] test result: ok. 8 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.02s [INFO] [stderr] 82 | unsafe { self.prev.as_ref().map(|attr| attr.borrow()) } [INFO] [stdout] [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: the type `node::Attribute` does not implement `Borrow`, so calling `borrow` on `&node::Attribute` copies the reference, which does not do anything and can be removed [INFO] [stderr] = note: `#[warn(noop_method_call)]` on by default [INFO] [stderr] help: remove this redundant call [INFO] [stderr] | [INFO] [stderr] 82 - unsafe { self.prev.as_ref().map(|attr| attr.borrow()) } [INFO] [stderr] 82 + unsafe { self.prev.as_ref().map(|attr| attr) } [INFO] [stderr] | [INFO] [stderr] help: if you meant to clone `node::Attribute`, implement `Clone` for it [INFO] [stderr] | [INFO] [stderr] 5 + #[derive(Clone)] [INFO] [stderr] 6 | pub struct Attribute { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stderr] --> src/node.rs:178:52 [INFO] [stderr] | [INFO] [stderr] 178 | unsafe { self.prev.as_ref().map(|node| node.borrow()) } [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: the type `node::Node<'_>` does not implement `Borrow`, so calling `borrow` on `&node::Node<'_>` copies the reference, which does not do anything and can be removed [INFO] [stderr] help: remove this redundant call [INFO] [stderr] | [INFO] [stderr] 178 - unsafe { self.prev.as_ref().map(|node| node.borrow()) } [INFO] [stderr] 178 + unsafe { self.prev.as_ref().map(|node| node) } [INFO] [stderr] | [INFO] [stderr] help: if you meant to clone `node::Node<'_>`, implement `Clone` for it [INFO] [stderr] | [INFO] [stderr] 24 + #[derive(Clone)] [INFO] [stderr] 25 | pub struct Node<'a> { [INFO] [stderr] | [INFO] [stderr] [INFO] [stdout] [INFO] [stderr] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] running 4 tests [INFO] [stderr] --> src/node.rs:188:54 [INFO] [stderr] | [INFO] [stderr] 188 | unsafe { self.parent.as_ref().map(|node| node.borrow()) } [INFO] [stdout] test sample ... ok [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: the type `node::Node<'_>` does not implement `Borrow`, so calling `borrow` on `&node::Node<'_>` copies the reference, which does not do anything and can be removed [INFO] [stderr] help: remove this redundant call [INFO] [stderr] | [INFO] [stderr] 188 - unsafe { self.parent.as_ref().map(|node| node.borrow()) } [INFO] [stderr] 188 + unsafe { self.parent.as_ref().map(|node| node) } [INFO] [stderr] | [INFO] [stderr] help: if you meant to clone `node::Node<'_>`, implement `Clone` for it [INFO] [stderr] | [INFO] [stderr] 24 + #[derive(Clone)] [INFO] [stderr] 25 | pub struct Node<'a> { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stderr] --> src/node.rs:208:58 [INFO] [stderr] | [INFO] [stderr] 208 | unsafe { self.last_child.as_ref().map(|node| node.borrow()) } [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: the type `node::Node<'_>` does not implement `Borrow`, so calling `borrow` on `&node::Node<'_>` copies the reference, which does not do anything and can be removed [INFO] [stderr] help: remove this redundant call [INFO] [stderr] | [INFO] [stderr] 208 - unsafe { self.last_child.as_ref().map(|node| node.borrow()) } [INFO] [stderr] 208 + unsafe { self.last_child.as_ref().map(|node| node) } [INFO] [stderr] | [INFO] [stderr] help: if you meant to clone `node::Node<'_>`, implement `Clone` for it [INFO] [stderr] | [INFO] [stderr] 24 + #[derive(Clone)] [INFO] [stderr] 25 | pub struct Node<'a> { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stderr] --> src/node.rs:228:57 [INFO] [stderr] | [INFO] [stderr] 228 | unsafe { self.last_attr.as_ref().map(|node| node.borrow()) } [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: the type `node::Attribute` does not implement `Borrow`, so calling `borrow` on `&node::Attribute` copies the reference, which does not do anything and can be removed [INFO] [stderr] help: remove this redundant call [INFO] [stderr] | [INFO] [stderr] 228 - unsafe { self.last_attr.as_ref().map(|node| node.borrow()) } [INFO] [stderr] 228 + unsafe { self.last_attr.as_ref().map(|node| node) } [INFO] [stderr] | [INFO] [stderr] help: if you meant to clone `node::Attribute`, implement `Clone` for it [INFO] [stderr] | [INFO] [stderr] 5 + #[derive(Clone)] [INFO] [stderr] 6 | pub struct Attribute { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `dummy_xml` (lib test) generated 8 warnings (3 duplicates) (run `cargo fix --lib -p dummy_xml --tests` to apply 5 suggestions) [INFO] [stderr] Finished `test` profile [unoptimized + debuginfo] target(s) in 0.03s [INFO] [stderr] Running unittests src/lib.rs (/opt/rustwide/target/debug/deps/dummy_xml-7ef28816e2117c3d) [INFO] [stderr] Running tests/parser_test.rs (/opt/rustwide/target/debug/deps/parser_test-d723edd6c2c74897) [INFO] [stdout] test parse_test ... ok [INFO] [stdout] test parse_negative_1 ... ok [INFO] [stdout] test parse_blank ... ok [INFO] [stdout] [INFO] [stdout] test result: ok. 4 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.04s [INFO] [stdout] [INFO] [stderr] Running tests/writer_test.rs (/opt/rustwide/target/debug/deps/writer_test-b1a4e28f37db4cdf) [INFO] [stdout] [INFO] [stdout] running 1 test [INFO] [stdout] test sample ... ok [INFO] [stdout] [INFO] [stdout] test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s [INFO] [stdout] [INFO] [stderr] Doc-tests dummy_xml [INFO] [stdout] [INFO] [stdout] running 0 tests [INFO] [stdout] [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "e5471c3a1853154e1666ec3daba50e524841088a4656e702f785b13c5413483b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e5471c3a1853154e1666ec3daba50e524841088a4656e702f785b13c5413483b", kill_on_drop: false }` [INFO] [stdout] e5471c3a1853154e1666ec3daba50e524841088a4656e702f785b13c5413483b