[INFO] cloning repository https://github.com/wpovell/img-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/wpovell/img-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwpovell%2Fimg-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwpovell%2Fimg-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 88f0e2751199b6496e26e9fc0f6541017533bb81 [INFO] checking wpovell/img-rs against master#ca77504943887037504c7fc0b9bf06dab3910373 for pr-145181 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwpovell%2Fimg-rs" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/wpovell/img-rs [INFO] finished tweaking git repo https://github.com/wpovell/img-rs [INFO] tweaked toml for git repo https://github.com/wpovell/img-rs written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/wpovell/img-rs on toolchain ca77504943887037504c7fc0b9bf06dab3910373 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ca77504943887037504c7fc0b9bf06dab3910373" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/wpovell/img-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ca77504943887037504c7fc0b9bf06dab3910373" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ae6f63d130afcfff7f91f5ba9fdb2a74d52830289c6a2ea2d23a94dcfb480a0d" "/opt/rustwide/cargo-home/bin/cargo" "+ca77504943887037504c7fc0b9bf06dab3910373" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] eeb03af12d0b8d70aeb5a50b844bcf62f3cfcfcb71b9ba8b111de828208b627d [INFO] running `Command { std: "docker" "start" "-a" "eeb03af12d0b8d70aeb5a50b844bcf62f3cfcfcb71b9ba8b111de828208b627d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "eeb03af12d0b8d70aeb5a50b844bcf62f3cfcfcb71b9ba8b111de828208b627d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eeb03af12d0b8d70aeb5a50b844bcf62f3cfcfcb71b9ba8b111de828208b627d", kill_on_drop: false }` [INFO] [stdout] eeb03af12d0b8d70aeb5a50b844bcf62f3cfcfcb71b9ba8b111de828208b627d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ae6f63d130afcfff7f91f5ba9fdb2a74d52830289c6a2ea2d23a94dcfb480a0d" "/opt/rustwide/cargo-home/bin/cargo" "+ca77504943887037504c7fc0b9bf06dab3910373" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f715cbbe2fc0c99cd93feed1dfa5cab124658f1ede969093f439e673097dd67d [INFO] running `Command { std: "docker" "start" "-a" "f715cbbe2fc0c99cd93feed1dfa5cab124658f1ede969093f439e673097dd67d", kill_on_drop: false }` [INFO] [stderr] Checking byteorder v1.2.7 [INFO] [stderr] Checking img v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/png/crc.rs:27:17 [INFO] [stdout] | [INFO] [stdout] 27 | (v >> 1) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 27 - (v >> 1) [INFO] [stdout] 27 + v >> 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/png/mod.rs:22:21 [INFO] [stdout] | [INFO] [stdout] 22 | chunks: Vec>, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 22 | chunks: Vec>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/png/crc.rs:27:17 [INFO] [stdout] | [INFO] [stdout] 27 | (v >> 1) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 27 - (v >> 1) [INFO] [stdout] 27 + v >> 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/png/chunk/ihdr.rs:11:45 [INFO] [stdout] | [INFO] [stdout] 11 | type Result = std::result::Result>; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 11 | type Result = std::result::Result>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/png/chunk/mod.rs:12:45 [INFO] [stdout] | [INFO] [stdout] 12 | type Result = std::result::Result>; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 12 | type Result = std::result::Result>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/png/chunk/mod.rs:20:40 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn parse(buf: &[u8]) -> Result> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 20 | pub fn parse(buf: &[u8]) -> Result> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/png/mod.rs:22:21 [INFO] [stdout] | [INFO] [stdout] 22 | chunks: Vec>, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 22 | chunks: Vec>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/png/chunk/ihdr.rs:11:45 [INFO] [stdout] | [INFO] [stdout] 11 | type Result = std::result::Result>; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 11 | type Result = std::result::Result>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/png/chunk/mod.rs:12:45 [INFO] [stdout] | [INFO] [stdout] 12 | type Result = std::result::Result>; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 12 | type Result = std::result::Result>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/png/chunk/mod.rs:20:40 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn parse(buf: &[u8]) -> Result> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 20 | pub fn parse(buf: &[u8]) -> Result> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/png/err.rs:38:32 [INFO] [stdout] | [INFO] [stdout] 38 | fn cause(&self) -> Option<&error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 38 | fn cause(&self) -> Option<&dyn error::Error> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/png/mod.rs:15:45 [INFO] [stdout] | [INFO] [stdout] 15 | type Result = std::result::Result>; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 15 | type Result = std::result::Result>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/png/mod.rs:30:24 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn parse(buf: &mut Read) -> Result { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 30 | pub fn parse(buf: &mut dyn Read) -> Result { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/png/err.rs:38:32 [INFO] [stdout] | [INFO] [stdout] 38 | fn cause(&self) -> Option<&error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 38 | fn cause(&self) -> Option<&dyn error::Error> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/png/mod.rs:15:45 [INFO] [stdout] | [INFO] [stdout] 15 | type Result = std::result::Result>; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 15 | type Result = std::result::Result>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/png/mod.rs:30:24 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn parse(buf: &mut Read) -> Result { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 30 | pub fn parse(buf: &mut dyn Read) -> Result { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `width`, `height`, `bit_depth`, `color_type`, and `interlace` are never read [INFO] [stdout] --> src/png/chunk/ihdr.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct IHDR { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 15 | width: u32, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 16 | height: u32, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 17 | bit_depth: u8, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 18 | color_type: ColorType, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 19 | interlace: InterlaceMethod, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `width`, `height`, `bit_depth`, `color_type`, and `interlace` are never read [INFO] [stdout] --> src/png/chunk/ihdr.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct IHDR { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 15 | width: u32, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 16 | height: u32, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 17 | bit_depth: u8, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 18 | color_type: ColorType, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 19 | interlace: InterlaceMethod, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.32s [INFO] running `Command { std: "docker" "inspect" "f715cbbe2fc0c99cd93feed1dfa5cab124658f1ede969093f439e673097dd67d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f715cbbe2fc0c99cd93feed1dfa5cab124658f1ede969093f439e673097dd67d", kill_on_drop: false }` [INFO] [stdout] f715cbbe2fc0c99cd93feed1dfa5cab124658f1ede969093f439e673097dd67d