[INFO] cloning repository https://github.com/natelust/reups [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/natelust/reups" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnatelust%2Freups", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnatelust%2Freups'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 30c3b1b23a6b00436bf4a76948152779185c0462 [INFO] checking natelust/reups against master#0f353363965ebf05e0757f7679c800b39c51a07e for pr-144896 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnatelust%2Freups" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/natelust/reups [INFO] finished tweaking git repo https://github.com/natelust/reups [INFO] tweaked toml for git repo https://github.com/natelust/reups written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/natelust/reups on toolchain 0f353363965ebf05e0757f7679c800b39c51a07e [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+0f353363965ebf05e0757f7679c800b39c51a07e" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/natelust/reups already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+0f353363965ebf05e0757f7679c800b39c51a07e" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded preferences v1.1.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ae6f63d130afcfff7f91f5ba9fdb2a74d52830289c6a2ea2d23a94dcfb480a0d" "/opt/rustwide/cargo-home/bin/cargo" "+0f353363965ebf05e0757f7679c800b39c51a07e" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cc1703b1dc8c75eca594fe4e535832f9b6c7d2544de9522fb493114f26356004 [INFO] running `Command { std: "docker" "start" "-a" "cc1703b1dc8c75eca594fe4e535832f9b6c7d2544de9522fb493114f26356004", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cc1703b1dc8c75eca594fe4e535832f9b6c7d2544de9522fb493114f26356004", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cc1703b1dc8c75eca594fe4e535832f9b6c7d2544de9522fb493114f26356004", kill_on_drop: false }` [INFO] [stdout] cc1703b1dc8c75eca594fe4e535832f9b6c7d2544de9522fb493114f26356004 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ae6f63d130afcfff7f91f5ba9fdb2a74d52830289c6a2ea2d23a94dcfb480a0d" "/opt/rustwide/cargo-home/bin/cargo" "+0f353363965ebf05e0757f7679c800b39c51a07e" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7849d183cdc55b4aac14497d87723a68dc8136ef5513429e4ce74ee24b5aef3d [INFO] running `Command { std: "docker" "start" "-a" "7849d183cdc55b4aac14497d87723a68dc8136ef5513429e4ce74ee24b5aef3d", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling gcc v0.3.55 [INFO] [stderr] Checking dtoa v0.4.8 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking xdg v2.5.2 [INFO] [stderr] Checking ucd-util v0.1.10 [INFO] [stderr] Checking serde v0.9.15 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling regex v0.2.11 [INFO] [stderr] Checking itoa v0.3.4 [INFO] [stderr] Compiling serde_json v1.0.114 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking app_dirs v1.2.1 [INFO] [stderr] Checking regex-syntax v0.5.6 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking utf8-ranges v1.0.5 [INFO] [stderr] Checking ordermap v0.3.5 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking fixedbitset v0.1.9 [INFO] [stderr] Checking rustc-serialize v0.3.25 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking petgraph v0.4.13 [INFO] [stderr] Checking aho-corasick v0.6.10 [INFO] [stderr] Compiling rust-crypto v0.2.36 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking users v0.8.1 [INFO] [stderr] Checking dirs v1.0.5 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Checking serde_json v0.9.10 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking preferences v1.1.0 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Checking reups v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/cogs.rs:142:8 [INFO] [stdout] | [INFO] [stdout] 142 | if (user_path.exists()) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 142 - if (user_path.exists()) { [INFO] [stdout] 142 + if user_path.exists() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: private item shadows public glob re-export [INFO] [stdout] --> src/db/mod.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | use self::db_impl::DBImplDeclare; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the name `DBImplDeclare` in the type namespace is supposed to be publicly re-exported here [INFO] [stdout] --> src/db/mod.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | pub use self::db_impl::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] note: but the private item here shadows it [INFO] [stdout] --> src/db/mod.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | use self::db_impl::DBImplDeclare; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(hidden_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/cogs.rs:142:8 [INFO] [stdout] | [INFO] [stdout] 142 | if (user_path.exists()) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 142 - if (user_path.exists()) { [INFO] [stdout] 142 + if user_path.exists() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: private item shadows public glob re-export [INFO] [stdout] --> src/db/mod.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | use self::db_impl::DBImplDeclare; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the name `DBImplDeclare` in the type namespace is supposed to be publicly re-exported here [INFO] [stdout] --> src/db/mod.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | pub use self::db_impl::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] note: but the private item here shadows it [INFO] [stdout] --> src/db/mod.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | use self::db_impl::DBImplDeclare; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(hidden_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/db/mod.rs:195:52 [INFO] [stdout] | [INFO] [stdout] 195 | let mut db_dict = FnvHashMap::>::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 195 | let mut db_dict = FnvHashMap::>::default(); [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/db/mod.rs:304:31 [INFO] [stdout] | [INFO] [stdout] 304 | let extra_db: Box = [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 304 | let extra_db: Box = [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/db/mod.rs:195:52 [INFO] [stdout] | [INFO] [stdout] 195 | let mut db_dict = FnvHashMap::>::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 195 | let mut db_dict = FnvHashMap::>::default(); [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/db/mod.rs:304:31 [INFO] [stdout] | [INFO] [stdout] 304 | let extra_db: Box = [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 304 | let extra_db: Box = [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/list.rs:133:17 [INFO] [stdout] | [INFO] [stdout] 133 | let mut prods = vec![self.sub_args.value_of("product").unwrap().to_string()]; [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `declare_in_memory` is never used [INFO] [stdout] --> src/db/db_impl/mod.rs:48:8 [INFO] [stdout] | [INFO] [stdout] 46 | pub trait DBImplDeclare: Sized { [INFO] [stdout] | ------------- method in this trait [INFO] [stdout] 47 | fn declare(self, inputs: &Vec) -> Result; [INFO] [stdout] 48 | fn declare_in_memory(self, inputs: &Vec) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/db/mod.rs:40:20 [INFO] [stdout] | [INFO] [stdout] 40 | fn new(inner: &'a DB) -> DBIter { [INFO] [stdout] | ^^ ------ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is named here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 40 | fn new(inner: &'a DB) -> DBIter<'a> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/db/db_impl/posix_db_impl.rs:302:55 [INFO] [stdout] | [INFO] [stdout] 302 | let base = self.location.parent().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 302 - let base = self.location.parent().unwrap().clone(); [INFO] [stdout] 302 + let base = self.location.parent().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&std::string::String` instead of cloning the inner type [INFO] [stdout] --> src/setup.rs:431:73 [INFO] [stdout] | [INFO] [stdout] 431 | let mut largest_version = versions.iter().max().unwrap().clone().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/list.rs:133:17 [INFO] [stdout] | [INFO] [stdout] 133 | let mut prods = vec![self.sub_args.value_of("product").unwrap().to_string()]; [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `declare_in_memory` is never used [INFO] [stdout] --> src/db/db_impl/mod.rs:48:8 [INFO] [stdout] | [INFO] [stdout] 46 | pub trait DBImplDeclare: Sized { [INFO] [stdout] | ------------- method in this trait [INFO] [stdout] 47 | fn declare(self, inputs: &Vec) -> Result; [INFO] [stdout] 48 | fn declare_in_memory(self, inputs: &Vec) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/db/mod.rs:40:20 [INFO] [stdout] | [INFO] [stdout] 40 | fn new(inner: &'a DB) -> DBIter { [INFO] [stdout] | ^^ ------ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is named here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 40 | fn new(inner: &'a DB) -> DBIter<'a> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/db/db_impl/posix_db_impl.rs:302:55 [INFO] [stdout] | [INFO] [stdout] 302 | let base = self.location.parent().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 302 - let base = self.location.parent().unwrap().clone(); [INFO] [stdout] 302 + let base = self.location.parent().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&std::string::String` instead of cloning the inner type [INFO] [stdout] --> src/setup.rs:431:73 [INFO] [stdout] | [INFO] [stdout] 431 | let mut largest_version = versions.iter().max().unwrap().clone().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 12.32s [INFO] running `Command { std: "docker" "inspect" "7849d183cdc55b4aac14497d87723a68dc8136ef5513429e4ce74ee24b5aef3d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7849d183cdc55b4aac14497d87723a68dc8136ef5513429e4ce74ee24b5aef3d", kill_on_drop: false }` [INFO] [stdout] 7849d183cdc55b4aac14497d87723a68dc8136ef5513429e4ce74ee24b5aef3d