[INFO] cloning repository https://github.com/vitekw27/LibraryRust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/vitekw27/LibraryRust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fvitekw27%2FLibraryRust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fvitekw27%2FLibraryRust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 44056382287f5a5b9b0ebd0316a1bb4054adda7e [INFO] checking vitekw27/LibraryRust against try#fafe42c59556a4233f03dd0d900b575a9afeece8 for pr-143764 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fvitekw27%2FLibraryRust" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/vitekw27/LibraryRust [INFO] finished tweaking git repo https://github.com/vitekw27/LibraryRust [INFO] tweaked toml for git repo https://github.com/vitekw27/LibraryRust written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/vitekw27/LibraryRust on toolchain fafe42c59556a4233f03dd0d900b575a9afeece8 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+fafe42c59556a4233f03dd0d900b575a9afeece8" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/vitekw27/LibraryRust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+fafe42c59556a4233f03dd0d900b575a9afeece8" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:90999bfc7ae267e83380e433d8e61a7c072ca6729e92edbae886d3423b3a6f4c" "/opt/rustwide/cargo-home/bin/cargo" "+fafe42c59556a4233f03dd0d900b575a9afeece8" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ab2f6a5d8a4287c78dd8af28f8970997121e36e62dfaab89c81e29cb757851ec [INFO] running `Command { std: "docker" "start" "-a" "ab2f6a5d8a4287c78dd8af28f8970997121e36e62dfaab89c81e29cb757851ec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ab2f6a5d8a4287c78dd8af28f8970997121e36e62dfaab89c81e29cb757851ec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ab2f6a5d8a4287c78dd8af28f8970997121e36e62dfaab89c81e29cb757851ec", kill_on_drop: false }` [INFO] [stdout] ab2f6a5d8a4287c78dd8af28f8970997121e36e62dfaab89c81e29cb757851ec [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:90999bfc7ae267e83380e433d8e61a7c072ca6729e92edbae886d3423b3a6f4c" "/opt/rustwide/cargo-home/bin/cargo" "+fafe42c59556a4233f03dd0d900b575a9afeece8" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f017928011a67ca8cde81c4b543ad6c3fe167d807d2d82b0c6e00557f409b046 [INFO] running `Command { std: "docker" "start" "-a" "f017928011a67ca8cde81c4b543ad6c3fe167d807d2d82b0c6e00557f409b046", kill_on_drop: false }` [INFO] [stderr] Checking BookStore v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:95:15 [INFO] [stdout] | [INFO] [stdout] 95 | if(book.book_name == requested_book_name){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 95 - if(book.book_name == requested_book_name){ [INFO] [stdout] 95 + if book.book_name == requested_book_name { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:95:15 [INFO] [stdout] | [INFO] [stdout] 95 | if(book.book_name == requested_book_name){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 95 - if(book.book_name == requested_book_name){ [INFO] [stdout] 95 + if book.book_name == requested_book_name { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `Library` is more private than the item `init_mockdata` [INFO] [stdout] --> src/main.rs:125:1 [INFO] [stdout] | [INFO] [stdout] 125 | pub fn init_mockdata(lib:&mut Library) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ function `init_mockdata` is reachable at visibility `pub` [INFO] [stdout] | [INFO] [stdout] note: but type `Library` is only usable at visibility `pub(crate)` [INFO] [stdout] --> src/main.rs:54:1 [INFO] [stdout] | [INFO] [stdout] 54 | struct Library{ [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_interfaces)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `change_published`, and `format_writer` are never used [INFO] [stdout] --> src/main.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 12 | impl Book{ [INFO] [stdout] | --------- associated items in this implementation [INFO] [stdout] 13 | pub fn new(id:i32, book_name:String, author_name:(String, String), genre:String) -> Book{ [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 24 | pub fn change_published(&mut self,state:bool){{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 27 | pub fn format_writer(&self) -> String{ [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `id` and `customer_name` are never read [INFO] [stdout] --> src/main.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 32 | struct Customer{ [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 33 | id:i32, [INFO] [stdout] | ^^ [INFO] [stdout] 34 | customer_name:(String, String), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `Library` is more private than the item `init_mockdata` [INFO] [stdout] --> src/main.rs:125:1 [INFO] [stdout] | [INFO] [stdout] 125 | pub fn init_mockdata(lib:&mut Library) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ function `init_mockdata` is reachable at visibility `pub` [INFO] [stdout] | [INFO] [stdout] note: but type `Library` is only usable at visibility `pub(crate)` [INFO] [stdout] --> src/main.rs:54:1 [INFO] [stdout] | [INFO] [stdout] 54 | struct Library{ [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_interfaces)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `list_published_books` and `list_unpublished_books` are never used [INFO] [stdout] --> src/main.rs:68:12 [INFO] [stdout] | [INFO] [stdout] 59 | impl Library{ [INFO] [stdout] | ------------ methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 68 | pub fn list_published_books(&self){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 73 | pub fn list_unpublished_books(&self){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `change_published`, and `format_writer` are never used [INFO] [stdout] --> src/main.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 12 | impl Book{ [INFO] [stdout] | --------- associated items in this implementation [INFO] [stdout] 13 | pub fn new(id:i32, book_name:String, author_name:(String, String), genre:String) -> Book{ [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 24 | pub fn change_published(&mut self,state:bool){{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 27 | pub fn format_writer(&self) -> String{ [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `id` and `customer_name` are never read [INFO] [stdout] --> src/main.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 32 | struct Customer{ [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 33 | id:i32, [INFO] [stdout] | ^^ [INFO] [stdout] 34 | customer_name:(String, String), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `list_published_books` and `list_unpublished_books` are never used [INFO] [stdout] --> src/main.rs:68:12 [INFO] [stdout] | [INFO] [stdout] 59 | impl Library{ [INFO] [stdout] | ------------ methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 68 | pub fn list_published_books(&self){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 73 | pub fn list_unpublished_books(&self){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/main.rs:81:13 [INFO] [stdout] | [INFO] [stdout] 81 | &self.published_books.push(book); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 81 | let _ = &self.published_books.push(book); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/main.rs:83:13 [INFO] [stdout] | [INFO] [stdout] 83 | &self.unpublished_books.push(book); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 83 | let _ = &self.unpublished_books.push(book); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/main.rs:81:13 [INFO] [stdout] | [INFO] [stdout] 81 | &self.published_books.push(book); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 81 | let _ = &self.published_books.push(book); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/main.rs:83:13 [INFO] [stdout] | [INFO] [stdout] 83 | &self.unpublished_books.push(book); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 83 | let _ = &self.unpublished_books.push(book); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.22s [INFO] running `Command { std: "docker" "inspect" "f017928011a67ca8cde81c4b543ad6c3fe167d807d2d82b0c6e00557f409b046", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f017928011a67ca8cde81c4b543ad6c3fe167d807d2d82b0c6e00557f409b046", kill_on_drop: false }` [INFO] [stdout] f017928011a67ca8cde81c4b543ad6c3fe167d807d2d82b0c6e00557f409b046