[INFO] cloning repository https://github.com/weldsorm/welds
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/weldsorm/welds" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fweldsorm%2Fwelds", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fweldsorm%2Fwelds'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] f4ace2f3a8d536b598a08ea2d0c6b13673aa1db4
[INFO] checking weldsorm/welds against try#5ef65a4ed75279dc1b7a26cedc27293a9f4ca8db for pr-143717
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fweldsorm%2Fwelds" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/weldsorm/welds
[INFO] finished tweaking git repo https://github.com/weldsorm/welds
[INFO] tweaked toml for git repo https://github.com/weldsorm/welds written to /workspace/builds/worker-2-tc2/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/weldsorm/welds on toolchain 5ef65a4ed75279dc1b7a26cedc27293a9f4ca8db
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+5ef65a4ed75279dc1b7a26cedc27293a9f4ca8db" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+5ef65a4ed75279dc1b7a26cedc27293a9f4ca8db" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Updating crates.io index
[INFO] [stderr]      Locking 338 packages to latest Rust 1.90.0-nightly compatible versions
[INFO] [stderr]       Adding syn v1.0.109 (available: v2.0.104)
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+5ef65a4ed75279dc1b7a26cedc27293a9f4ca8db" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:90999bfc7ae267e83380e433d8e61a7c072ca6729e92edbae886d3423b3a6f4c" "/opt/rustwide/cargo-home/bin/cargo" "+5ef65a4ed75279dc1b7a26cedc27293a9f4ca8db" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] a1b741e7fab575cccac243e6cba6e6322e4d4b3cbd1edef518a0209afa3399bf
[INFO] running `Command { std: "docker" "start" "-a" "a1b741e7fab575cccac243e6cba6e6322e4d4b3cbd1edef518a0209afa3399bf", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "a1b741e7fab575cccac243e6cba6e6322e4d4b3cbd1edef518a0209afa3399bf", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "a1b741e7fab575cccac243e6cba6e6322e4d4b3cbd1edef518a0209afa3399bf", kill_on_drop: false }`
[INFO] [stdout] a1b741e7fab575cccac243e6cba6e6322e4d4b3cbd1edef518a0209afa3399bf
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:90999bfc7ae267e83380e433d8e61a7c072ca6729e92edbae886d3423b3a6f4c" "/opt/rustwide/cargo-home/bin/cargo" "+5ef65a4ed75279dc1b7a26cedc27293a9f4ca8db" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] c25bca295ac2f40588740d51c983351fe6fed5bcc4c977dd31bf20569b2c0167
[INFO] running `Command { std: "docker" "start" "-a" "c25bca295ac2f40588740d51c983351fe6fed5bcc4c977dd31bf20569b2c0167", kill_on_drop: false }`
[INFO] [stderr]    Compiling libc v0.2.174
[INFO] [stderr]    Compiling autocfg v1.5.0
[INFO] [stderr]    Compiling crossbeam-utils v0.8.21
[INFO] [stderr]     Checking cfg-if v1.0.1
[INFO] [stderr]    Compiling libm v0.2.15
[INFO] [stderr]    Compiling cc v1.2.29
[INFO] [stderr]     Checking memchr v2.7.5
[INFO] [stderr]    Compiling rustix v1.0.7
[INFO] [stderr]     Checking value-bag v1.11.1
[INFO] [stderr]    Compiling syn v2.0.104
[INFO] [stderr]    Compiling zerocopy v0.8.26
[INFO] [stderr]    Compiling parking v2.2.1
[INFO] [stderr]     Checking slab v0.4.10
[INFO] [stderr]    Compiling const-oid v0.9.6
[INFO] [stderr]    Compiling io-lifetimes v1.0.11
[INFO] [stderr]    Compiling zeroize v1.8.1
[INFO] [stderr]    Compiling rustix v0.37.28
[INFO] [stderr]    Compiling digest v0.10.7
[INFO] [stderr]    Compiling rustls v0.23.29
[INFO] [stderr]    Compiling log v0.4.27
[INFO] [stderr]    Compiling syn v1.0.109
[INFO] [stderr]    Compiling lock_api v0.4.13
[INFO] [stderr]    Compiling polling v2.8.0
[INFO] [stderr]    Compiling async-io v1.13.0
[INFO] [stderr]    Compiling num-traits v0.2.19
[INFO] [stderr]    Compiling futures-lite v2.6.0
[INFO] [stderr]     Checking fastrand v2.3.0
[INFO] [stderr]    Compiling linux-raw-sys v0.9.4
[INFO] [stderr]    Compiling rustls-pki-types v1.12.0
[INFO] [stderr]    Compiling atomic-waker v1.1.2
[INFO] [stderr]    Compiling async-task v4.7.1
[INFO] [stderr]    Compiling piper v0.2.4
[INFO] [stderr]     Checking concurrent-queue v2.5.0
[INFO] [stderr]     Checking getrandom v0.2.16
[INFO] [stderr]     Checking mio v1.0.4
[INFO] [stderr]     Checking signal-hook-registry v1.4.5
[INFO] [stderr]     Checking event-listener v5.4.0
[INFO] [stderr]     Checking socket2 v0.5.10
[INFO] [stderr]     Checking event-listener-strategy v0.5.4
[INFO] [stderr]    Compiling base64ct v1.8.0
[INFO] [stderr]    Compiling foldhash v0.1.5
[INFO] [stderr]    Compiling untrusted v0.9.0
[INFO] [stderr]    Compiling num-bigint-dig v0.8.4
[INFO] [stderr]    Compiling hashbrown v0.15.4
[INFO] [stderr]    Compiling async-channel v2.5.0
[INFO] [stderr]    Compiling async-lock v3.4.0
[INFO] [stderr]    Compiling rand_core v0.6.4
[INFO] [stderr]    Compiling pem-rfc7468 v0.7.0
[INFO] [stderr]    Compiling spin v0.9.8
[INFO] [stderr]    Compiling fastrand v1.9.0
[INFO] [stderr]    Compiling blocking v1.6.2
[INFO] [stderr]    Compiling async-executor v1.13.2
[INFO] [stderr]    Compiling waker-fn v1.2.0
[INFO] [stderr]    Compiling linux-raw-sys v0.3.8
[INFO] [stderr]    Compiling bitflags v1.3.2
[INFO] [stderr]    Compiling futures-lite v1.13.0
[INFO] [stderr]    Compiling futures-util v0.3.31
[INFO] [stderr]    Compiling der v0.7.10
[INFO] [stderr]    Compiling socket2 v0.4.10
[INFO] [stderr]    Compiling async-channel v1.9.0
[INFO] [stderr]    Compiling webpki-roots v1.0.1
[INFO] [stderr]    Compiling tokio v1.46.1
[INFO] [stderr]    Compiling async-lock v2.8.0
[INFO] [stderr]    Compiling kv-log-macro v1.0.7
[INFO] [stderr]    Compiling ring v0.17.14
[INFO] [stderr]    Compiling openssl-sys v0.9.109
[INFO] [stderr]    Compiling libsqlite3-sys v0.30.1
[INFO] [stderr]    Compiling hashlink v0.10.0
[INFO] [stderr]    Compiling indexmap v2.10.0
[INFO] [stderr]    Compiling ppv-lite86 v0.2.21
[INFO] [stderr]    Compiling webpki-roots v0.26.11
[INFO] [stderr]    Compiling sha2 v0.10.9
[INFO] [stderr]    Compiling num-integer v0.1.46
[INFO] [stderr]    Compiling spki v0.7.3
[INFO] [stderr]    Compiling crossbeam-queue v0.3.12
[INFO] [stderr]    Compiling base64 v0.22.1
[INFO] [stderr]    Compiling rand_chacha v0.3.1
[INFO] [stderr]    Compiling num-iter v0.1.45
[INFO] [stderr]    Compiling pkcs8 v0.10.2
[INFO] [stderr]    Compiling atoi v2.0.0
[INFO] [stderr]    Compiling lazy_static v1.5.0
[INFO] [stderr]    Compiling rand v0.8.5
[INFO] [stderr]    Compiling hmac v0.12.1
[INFO] [stderr]    Compiling openssl v0.10.73
[INFO] [stderr]    Compiling pkcs1 v0.7.5
[INFO] [stderr]    Compiling hkdf v0.12.4
[INFO] [stderr]    Compiling signature v2.2.0
[INFO] [stderr]    Compiling md-5 v0.10.6
[INFO] [stderr]    Compiling native-tls v0.2.14
[INFO] [stderr]    Compiling futures-executor v0.3.31
[INFO] [stderr]    Compiling sha1 v0.10.6
[INFO] [stderr]    Compiling flume v0.11.1
[INFO] [stderr]     Checking openssl-probe v0.1.6
[INFO] [stderr]    Compiling heck v0.5.0
[INFO] [stderr]     Checking chrono v0.4.41
[INFO] [stderr]     Checking aho-corasick v1.1.3
[INFO] [stderr]     Checking encoding_rs v0.8.35
[INFO] [stderr]     Checking uuid v1.17.0
[INFO] [stderr]    Compiling synstructure v0.13.2
[INFO] [stderr]     Checking connection-string v0.2.0
[INFO] [stderr]     Checking regex-syntax v0.8.5
[INFO] [stderr]     Checking pretty-hex v0.3.0
[INFO] [stderr]     Checking async-mutex v1.4.1
[INFO] [stderr]     Checking is-terminal v0.4.16
[INFO] [stderr]     Checking humantime v2.2.0
[INFO] [stderr]    Compiling anyhow v1.0.98
[INFO] [stderr]     Checking colored v3.0.0
[INFO] [stderr]     Checking unicode-ident v1.0.18
[INFO] [stderr]     Checking proc-macro2 v1.0.95
[INFO] [stderr]     Checking quote v1.0.40
[INFO] [stderr]    Compiling tokio-stream v0.1.17
[INFO] [stderr]    Compiling serde_derive v1.0.219
[INFO] [stderr]    Compiling zerofrom-derive v0.1.6
[INFO] [stderr]    Compiling yoke-derive v0.8.0
[INFO] [stderr]    Compiling zerovec-derive v0.11.1
[INFO] [stderr]    Compiling displaydoc v0.2.5
[INFO] [stderr]    Compiling tracing-attributes v0.1.30
[INFO] [stderr]    Compiling futures-macro v0.3.31
[INFO] [stderr]    Compiling thiserror-impl v2.0.12
[INFO] [stderr]    Compiling tokio-macros v2.5.0
[INFO] [stderr]    Compiling openssl-macros v0.1.1
[INFO] [stderr]    Compiling thiserror-impl v1.0.69
[INFO] [stderr]    Compiling enumflags2_derive v0.7.12
[INFO] [stderr]    Compiling async-trait v0.1.88
[INFO] [stderr]     Checking regex-automata v0.4.9
[INFO] [stderr]     Checking enumflags2 v0.7.12
[INFO] [stderr]    Compiling tracing v0.1.41
[INFO] [stderr]    Compiling thiserror v2.0.12
[INFO] [stderr]     Checking zerofrom v0.1.6
[INFO] [stderr]    Compiling async-attributes v1.1.2
[INFO] [stderr]    Compiling welds-macros v0.4.17 (/opt/rustwide/workdir/welds-macros)
[INFO] [stderr]     Checking yoke v0.8.0
[INFO] [stderr]     Checking thiserror v1.0.69
[INFO] [stderr]     Checking zerovec v0.11.2
[INFO] [stderr]     Checking zerotrie v0.2.2
[INFO] [stderr]    Compiling rustls-webpki v0.103.4
[INFO] [stderr]     Checking serde v1.0.219
[INFO] [stderr]     Checking regex v1.11.1
[INFO] [stderr]     Checking tinystr v0.8.1
[INFO] [stderr]     Checking potential_utf v0.1.2
[INFO] [stderr]     Checking icu_collections v2.0.0
[INFO] [stderr]     Checking env_logger v0.10.2
[INFO] [stderr]     Checking icu_locale_core v2.0.0
[INFO] [stderr]     Checking pretty_env_logger v0.5.0
[INFO] [stderr]     Checking icu_provider v2.0.0
[INFO] [stderr]     Checking asynchronous-codec v0.6.2
[INFO] [stderr]     Checking futures v0.3.31
[INFO] [stderr]     Checking icu_properties v2.0.1
[INFO] [stderr]     Checking smallvec v1.15.1
[INFO] [stderr]     Checking bitflags v2.9.1
[INFO] [stderr]     Checking serde_json v1.0.140
[INFO] [stderr]     Checking either v1.15.0
[INFO] [stderr]     Checking serde_urlencoded v0.7.1
[INFO] [stderr]     Checking parking_lot_core v0.9.11
[INFO] [stderr]     Checking icu_normalizer v2.0.0
[INFO] [stderr]     Checking parking_lot v0.12.4
[INFO] [stderr]     Checking idna_adapter v1.2.1
[INFO] [stderr]     Checking futures-intrusive v0.5.0
[INFO] [stderr]     Checking idna v1.0.3
[INFO] [stderr]     Checking url v2.5.4
[INFO] [stderr]     Checking rsa v0.9.8
[INFO] [stderr]     Checking async-native-tls v0.4.0
[INFO] [stderr]     Checking polling v3.8.0
[INFO] [stderr]     Checking async-io v2.4.1
[INFO] [stderr]     Checking async-global-executor v2.4.1
[INFO] [stderr]     Checking async-std v1.13.1
[INFO] [stderr]     Checking tokio-util v0.7.15
[INFO] [stderr]     Checking bb8 v0.9.0
[INFO] [stderr]     Checking sqlx-core v0.8.6
[INFO] [stderr]     Checking tiberius v0.12.3
[INFO] [stderr]     Checking bb8-tiberius v0.16.0
[INFO] [stderr]     Checking sqlx-postgres v0.8.6
[INFO] [stderr]     Checking sqlx-sqlite v0.8.6
[INFO] [stderr]     Checking sqlx-mysql v0.8.6
[INFO] [stderr]    Compiling sqlx-macros-core v0.8.6
[INFO] [stderr]    Compiling sqlx-macros v0.8.6
[INFO] [stderr]     Checking sqlx v0.8.6
[INFO] [stderr]     Checking welds-connections v0.4.17 (/opt/rustwide/workdir/welds-connections)
[INFO] [stderr]     Checking welds v0.4.17 (/opt/rustwide/workdir/welds)
[INFO] [stdout] warning: unnecessary parentheses around type
[INFO] [stdout]   --> welds/src/migrations/mod.rs:29:26
[INFO] [stdout]    |
[INFO] [stdout] 29 | pub async fn up(client: &(dyn TransactStart), migrations: &[MigrationFn]) -> Result<()> {
[INFO] [stdout]    |                          ^                 ^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_parens)]` on by default
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 29 - pub async fn up(client: &(dyn TransactStart), migrations: &[MigrationFn]) -> Result<()> {
[INFO] [stdout] 29 + pub async fn up(client: &dyn TransactStart, migrations: &[MigrationFn]) -> Result<()> {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around type
[INFO] [stdout]   --> welds/src/migrations/mod.rs:96:33
[INFO] [stdout]    |
[INFO] [stdout] 96 | pub async fn down_last(client: &(dyn TransactStart)) -> Result<Option<String>> {
[INFO] [stdout]    |                                 ^                 ^
[INFO] [stdout]    |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 96 - pub async fn down_last(client: &(dyn TransactStart)) -> Result<Option<String>> {
[INFO] [stdout] 96 + pub async fn down_last(client: &dyn TransactStart) -> Result<Option<String>> {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around type
[INFO] [stdout]    --> welds/src/migrations/mod.rs:132:28
[INFO] [stdout]     |
[INFO] [stdout] 132 | pub async fn down(client: &(dyn TransactStart), name: impl Into<String>) -> Result<Option<String>> {
[INFO] [stdout]     |                            ^                 ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 132 - pub async fn down(client: &(dyn TransactStart), name: impl Into<String>) -> Result<Option<String>> {
[INFO] [stdout] 132 + pub async fn down(client: &dyn TransactStart, name: impl Into<String>) -> Result<Option<String>> {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: associated constant `RowNowFound` should have an upper case name
[INFO] [stdout]   --> welds/src/errors/mod.rs:41:15
[INFO] [stdout]    |
[INFO] [stdout] 41 |     pub const RowNowFound: WeldsError = WeldsError::RowNotFound;
[INFO] [stdout]    |               ^^^^^^^^^^^ help: convert the identifier to upper case: `ROW_NOW_FOUND`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(non_upper_case_globals)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: lifetime flowing from input to output with different syntax can be confusing
[INFO] [stdout]   --> welds/src/dataset/mod.rs:58:17
[INFO] [stdout]    |
[INFO] [stdout] 58 |     pub fn iter(&self) -> DataSetIter<T> {
[INFO] [stdout]    |                 ^^^^^     -------------- the lifetime gets resolved as `'_`
[INFO] [stdout]    |                 |
[INFO] [stdout]    |                 this lifetime flows to the output
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
[INFO] [stdout] help: one option is to remove the lifetime for references and use the anonymous lifetime for paths
[INFO] [stdout]    |
[INFO] [stdout] 58 |     pub fn iter(&self) -> DataSetIter<'_, T> {
[INFO] [stdout]    |                                       +++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: lifetime flowing from input to output with different syntax can be confusing
[INFO] [stdout]   --> welds/src/dataset/mod.rs:95:16
[INFO] [stdout]    |
[INFO] [stdout] 95 |     pub fn get(&self, index: usize) -> Option<DataAccessGuard<T>> {
[INFO] [stdout]    |                ^^^^^                          ------------------ the lifetime gets resolved as `'_`
[INFO] [stdout]    |                |
[INFO] [stdout]    |                this lifetime flows to the output
[INFO] [stdout]    |
[INFO] [stdout] help: one option is to remove the lifetime for references and use the anonymous lifetime for paths
[INFO] [stdout]    |
[INFO] [stdout] 95 |     pub fn get(&self, index: usize) -> Option<DataAccessGuard<'_, T>> {
[INFO] [stdout]    |                                                               +++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]   --> welds/src/query/include/related_query.rs:62:26
[INFO] [stdout]    |
[INFO] [stdout] 62 |             self.inner_tn.clone(),
[INFO] [stdout]    |                          ^^^^^^^^ help: remove this redundant call
[INFO] [stdout]    |
[INFO] [stdout]    = note: the type `[&str]` does not implement `Clone`, so calling `clone` on `&[&str]` copies the reference, which does not do anything and can be removed
[INFO] [stdout]    = note: `#[warn(noop_method_call)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]   --> welds/src/query/include/related_query.rs:82:26
[INFO] [stdout]    |
[INFO] [stdout] 82 |             self.inner_tn.clone(),
[INFO] [stdout]    |                          ^^^^^^^^ help: remove this redundant call
[INFO] [stdout]    |
[INFO] [stdout]    = note: the type `[&str]` does not implement `Clone`, so calling `clone` on `&[&str]` copies the reference, which does not do anything and can be removed
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around type
[INFO] [stdout]   --> welds/examples/transactions.rs:47:38
[INFO] [stdout]    |
[INFO] [stdout] 47 | async fn create_with_errors(client: &(dyn TransactStart)) -> Result<()> {
[INFO] [stdout]    |                                      ^                 ^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_parens)]` on by default
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 47 - async fn create_with_errors(client: &(dyn TransactStart)) -> Result<()> {
[INFO] [stdout] 47 + async fn create_with_errors(client: &dyn TransactStart) -> Result<()> {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around type
[INFO] [stdout]   --> welds/examples/transactions.rs:61:33
[INFO] [stdout]    |
[INFO] [stdout] 61 | async fn create_person(client: &(dyn TransactStart)) -> Result<()> {
[INFO] [stdout]    |                                 ^                 ^
[INFO] [stdout]    |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 61 - async fn create_person(client: &(dyn TransactStart)) -> Result<()> {
[INFO] [stdout] 61 + async fn create_person(client: &dyn TransactStart) -> Result<()> {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around type
[INFO] [stdout]   --> welds/src/migrations/mod.rs:29:26
[INFO] [stdout]    |
[INFO] [stdout] 29 | pub async fn up(client: &(dyn TransactStart), migrations: &[MigrationFn]) -> Result<()> {
[INFO] [stdout]    |                          ^                 ^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_parens)]` on by default
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 29 - pub async fn up(client: &(dyn TransactStart), migrations: &[MigrationFn]) -> Result<()> {
[INFO] [stdout] 29 + pub async fn up(client: &dyn TransactStart, migrations: &[MigrationFn]) -> Result<()> {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around type
[INFO] [stdout]   --> welds/src/migrations/mod.rs:96:33
[INFO] [stdout]    |
[INFO] [stdout] 96 | pub async fn down_last(client: &(dyn TransactStart)) -> Result<Option<String>> {
[INFO] [stdout]    |                                 ^                 ^
[INFO] [stdout]    |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 96 - pub async fn down_last(client: &(dyn TransactStart)) -> Result<Option<String>> {
[INFO] [stdout] 96 + pub async fn down_last(client: &dyn TransactStart) -> Result<Option<String>> {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around type
[INFO] [stdout]    --> welds/src/migrations/mod.rs:132:28
[INFO] [stdout]     |
[INFO] [stdout] 132 | pub async fn down(client: &(dyn TransactStart), name: impl Into<String>) -> Result<Option<String>> {
[INFO] [stdout]     |                            ^                 ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 132 - pub async fn down(client: &(dyn TransactStart), name: impl Into<String>) -> Result<Option<String>> {
[INFO] [stdout] 132 + pub async fn down(client: &dyn TransactStart, name: impl Into<String>) -> Result<Option<String>> {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: fields `team`, `players`, and `city` are never read
[INFO] [stdout]   --> welds/examples/includes.rs:36:5
[INFO] [stdout]    |
[INFO] [stdout] 35 | pub struct TeamWithRelated<'a> {
[INFO] [stdout]    |            --------------- fields in this struct
[INFO] [stdout] 36 |     team: &'a Team,
[INFO] [stdout]    |     ^^^^
[INFO] [stdout] 37 |     players: Vec<&'a Player>,
[INFO] [stdout]    |     ^^^^^^^
[INFO] [stdout] 38 |     city: &'a City,
[INFO] [stdout]    |     ^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `TeamWithRelated` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
[INFO] [stdout]    = note: `#[warn(dead_code)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: fields `city` and `teams` are never read
[INFO] [stdout]   --> welds/examples/includes.rs:44:5
[INFO] [stdout]    |
[INFO] [stdout] 43 | pub struct CityWithTeams {
[INFO] [stdout]    |            ------------- fields in this struct
[INFO] [stdout] 44 |     city: City,
[INFO] [stdout]    |     ^^^^
[INFO] [stdout] 45 |     teams: Vec<Team>,
[INFO] [stdout]    |     ^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `CityWithTeams` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `name` is never read
[INFO] [stdout]   --> welds/src/query/select/tests/basicopt.rs:15:9
[INFO] [stdout]    |
[INFO] [stdout] 14 | struct Product2 {
[INFO] [stdout]    |        -------- field in this struct
[INFO] [stdout] 15 |     pub name: Option<String>,
[INFO] [stdout]    |         ^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(dead_code)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: fields `a` and `b` are never read
[INFO] [stdout]   --> welds/src/query/select/tests/sql_tails.rs:13:9
[INFO] [stdout]    |
[INFO] [stdout] 12 | struct Product {
[INFO] [stdout]    |        ------- fields in this struct
[INFO] [stdout] 13 |     pub a: i32,
[INFO] [stdout]    |         ^
[INFO] [stdout] 14 |     pub b: i32,
[INFO] [stdout]    |         ^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: associated constant `RowNowFound` should have an upper case name
[INFO] [stdout]   --> welds/src/errors/mod.rs:41:15
[INFO] [stdout]    |
[INFO] [stdout] 41 |     pub const RowNowFound: WeldsError = WeldsError::RowNotFound;
[INFO] [stdout]    |               ^^^^^^^^^^^ help: convert the identifier to upper case: `ROW_NOW_FOUND`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(non_upper_case_globals)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: lifetime flowing from input to output with different syntax can be confusing
[INFO] [stdout]   --> welds/src/dataset/mod.rs:58:17
[INFO] [stdout]    |
[INFO] [stdout] 58 |     pub fn iter(&self) -> DataSetIter<T> {
[INFO] [stdout]    |                 ^^^^^     -------------- the lifetime gets resolved as `'_`
[INFO] [stdout]    |                 |
[INFO] [stdout]    |                 this lifetime flows to the output
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
[INFO] [stdout] help: one option is to remove the lifetime for references and use the anonymous lifetime for paths
[INFO] [stdout]    |
[INFO] [stdout] 58 |     pub fn iter(&self) -> DataSetIter<'_, T> {
[INFO] [stdout]    |                                       +++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: lifetime flowing from input to output with different syntax can be confusing
[INFO] [stdout]   --> welds/src/dataset/mod.rs:95:16
[INFO] [stdout]    |
[INFO] [stdout] 95 |     pub fn get(&self, index: usize) -> Option<DataAccessGuard<T>> {
[INFO] [stdout]    |                ^^^^^                          ------------------ the lifetime gets resolved as `'_`
[INFO] [stdout]    |                |
[INFO] [stdout]    |                this lifetime flows to the output
[INFO] [stdout]    |
[INFO] [stdout] help: one option is to remove the lifetime for references and use the anonymous lifetime for paths
[INFO] [stdout]    |
[INFO] [stdout] 95 |     pub fn get(&self, index: usize) -> Option<DataAccessGuard<'_, T>> {
[INFO] [stdout]    |                                                               +++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]   --> welds/src/query/include/related_query.rs:62:26
[INFO] [stdout]    |
[INFO] [stdout] 62 |             self.inner_tn.clone(),
[INFO] [stdout]    |                          ^^^^^^^^ help: remove this redundant call
[INFO] [stdout]    |
[INFO] [stdout]    = note: the type `[&str]` does not implement `Clone`, so calling `clone` on `&[&str]` copies the reference, which does not do anything and can be removed
[INFO] [stdout]    = note: `#[warn(noop_method_call)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]   --> welds/src/query/include/related_query.rs:82:26
[INFO] [stdout]    |
[INFO] [stdout] 82 |             self.inner_tn.clone(),
[INFO] [stdout]    |                          ^^^^^^^^ help: remove this redundant call
[INFO] [stdout]    |
[INFO] [stdout]    = note: the type `[&str]` does not implement `Clone`, so calling `clone` on `&[&str]` copies the reference, which does not do anything and can be removed
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 30s
[INFO] running `Command { std: "docker" "inspect" "c25bca295ac2f40588740d51c983351fe6fed5bcc4c977dd31bf20569b2c0167", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "c25bca295ac2f40588740d51c983351fe6fed5bcc4c977dd31bf20569b2c0167", kill_on_drop: false }`
[INFO] [stdout] c25bca295ac2f40588740d51c983351fe6fed5bcc4c977dd31bf20569b2c0167
