[INFO] fetching crate sodium 0.1.3... [INFO] checking sodium-0.1.3 against master#cf38b8e663f15db10ce49d7bbce02c99fc3dbc0c for pr-143170 [INFO] extracting crate sodium 0.1.3 into /workspace/builds/worker-6-tc1/source [INFO] started tweaking crates.io crate sodium 0.1.3 [INFO] finished tweaking crates.io crate sodium 0.1.3 [INFO] tweaked toml for crates.io crate sodium 0.1.3 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate sodium 0.1.3 on toolchain cf38b8e663f15db10ce49d7bbce02c99fc3dbc0c [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+cf38b8e663f15db10ce49d7bbce02c99fc3dbc0c" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+cf38b8e663f15db10ce49d7bbce02c99fc3dbc0c" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 86 packages to latest compatible versions [INFO] [stderr] Adding criterion v0.4.0 (available: v0.6.0) [INFO] [stderr] Adding env_logger v0.9.3 (available: v0.11.8) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+cf38b8e663f15db10ce49d7bbce02c99fc3dbc0c" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:90999bfc7ae267e83380e433d8e61a7c072ca6729e92edbae886d3423b3a6f4c" "/opt/rustwide/cargo-home/bin/cargo" "+cf38b8e663f15db10ce49d7bbce02c99fc3dbc0c" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f0613ab9e6ffa8c7f6cc6ed0e03ca518f7f87db864736876fd675c6a77e3a27f [INFO] running `Command { std: "docker" "start" "-a" "f0613ab9e6ffa8c7f6cc6ed0e03ca518f7f87db864736876fd675c6a77e3a27f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f0613ab9e6ffa8c7f6cc6ed0e03ca518f7f87db864736876fd675c6a77e3a27f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f0613ab9e6ffa8c7f6cc6ed0e03ca518f7f87db864736876fd675c6a77e3a27f", kill_on_drop: false }` [INFO] [stdout] f0613ab9e6ffa8c7f6cc6ed0e03ca518f7f87db864736876fd675c6a77e3a27f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:90999bfc7ae267e83380e433d8e61a7c072ca6729e92edbae886d3423b3a6f4c" "/opt/rustwide/cargo-home/bin/cargo" "+cf38b8e663f15db10ce49d7bbce02c99fc3dbc0c" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 66446d35caeda2161c7314c01e5280c97e081235f2d3476d2b2341324c29e683 [INFO] running `Command { std: "docker" "start" "-a" "66446d35caeda2161c7314c01e5280c97e081235f2d3476d2b2341324c29e683", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling lock_api v0.4.13 [INFO] [stderr] Compiling parking_lot_core v0.9.11 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking half v2.6.0 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking log v0.4.27 [INFO] [stderr] Checking textwrap v0.16.2 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking humantime v2.2.0 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Checking sodium v0.1.3 (/opt/rustwide/workdir) [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/impl_/stream.rs:531:39 [INFO] [stdout] | [INFO] [stdout] 531 | for firing in &data.firing_op { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 531 - for firing in &data.firing_op { [INFO] [stdout] 531 + while let Some(firing) = &data.firing_op { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 531 - for firing in &data.firing_op { [INFO] [stdout] 531 + if let Some(firing) = &data.firing_op { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking env_logger v0.9.3 [INFO] [stderr] Checking serde_json v1.0.140 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.4.0 [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/impl_/stream.rs:531:39 [INFO] [stdout] | [INFO] [stdout] 531 | for firing in &data.firing_op { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 531 - for firing in &data.firing_op { [INFO] [stdout] 531 + while let Some(firing) = &data.firing_op { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 531 - for firing in &data.firing_op { [INFO] [stdout] 531 + if let Some(firing) = &data.firing_op { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.22s [INFO] running `Command { std: "docker" "inspect" "66446d35caeda2161c7314c01e5280c97e081235f2d3476d2b2341324c29e683", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "66446d35caeda2161c7314c01e5280c97e081235f2d3476d2b2341324c29e683", kill_on_drop: false }` [INFO] [stdout] 66446d35caeda2161c7314c01e5280c97e081235f2d3476d2b2341324c29e683