[INFO] fetching crate sea-canal 0.3.0... [INFO] checking sea-canal-0.3.0 against master#cf38b8e663f15db10ce49d7bbce02c99fc3dbc0c for pr-143170 [INFO] extracting crate sea-canal 0.3.0 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate sea-canal 0.3.0 [INFO] finished tweaking crates.io crate sea-canal 0.3.0 [INFO] tweaked toml for crates.io crate sea-canal 0.3.0 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate sea-canal 0.3.0 on toolchain cf38b8e663f15db10ce49d7bbce02c99fc3dbc0c [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+cf38b8e663f15db10ce49d7bbce02c99fc3dbc0c" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+cf38b8e663f15db10ce49d7bbce02c99fc3dbc0c" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+cf38b8e663f15db10ce49d7bbce02c99fc3dbc0c" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:90999bfc7ae267e83380e433d8e61a7c072ca6729e92edbae886d3423b3a6f4c" "/opt/rustwide/cargo-home/bin/cargo" "+cf38b8e663f15db10ce49d7bbce02c99fc3dbc0c" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5e2d5776b6c02d2f06acb0031ff4cea41138c8280547da60735e660b2561605c [INFO] running `Command { std: "docker" "start" "-a" "5e2d5776b6c02d2f06acb0031ff4cea41138c8280547da60735e660b2561605c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5e2d5776b6c02d2f06acb0031ff4cea41138c8280547da60735e660b2561605c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5e2d5776b6c02d2f06acb0031ff4cea41138c8280547da60735e660b2561605c", kill_on_drop: false }` [INFO] [stdout] 5e2d5776b6c02d2f06acb0031ff4cea41138c8280547da60735e660b2561605c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:90999bfc7ae267e83380e433d8e61a7c072ca6729e92edbae886d3423b3a6f4c" "/opt/rustwide/cargo-home/bin/cargo" "+cf38b8e663f15db10ce49d7bbce02c99fc3dbc0c" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 15c5c1077b7e1260912232a2a1cb0e6440e31842a9949b45c0248b3e7e52a43a [INFO] running `Command { std: "docker" "start" "-a" "15c5c1077b7e1260912232a2a1cb0e6440e31842a9949b45c0248b3e7e52a43a", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] [stderr] Checking sea-canal v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/pattern.rs:166:13 [INFO] [stdout] | [INFO] [stdout] 166 | try!(write!(fmt, "{}", elem)); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/pattern.rs:163:17 [INFO] [stdout] | [INFO] [stdout] 163 | try!(write!(fmt, ", ")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/pattern.rs:166:13 [INFO] [stdout] | [INFO] [stdout] 166 | try!(write!(fmt, "{}", elem)); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/pattern.rs:163:17 [INFO] [stdout] | [INFO] [stdout] 163 | try!(write!(fmt, ", ")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/pattern.rs:68:19 [INFO] [stdout] | [INFO] [stdout] 68 | fn fmt(&self, mut fmt: &mut Formatter) -> Result<(), Error> { [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/pattern.rs:160:19 [INFO] [stdout] | [INFO] [stdout] 160 | fn fmt(&self, mut fmt: &mut Formatter) -> Result<(), Error> { [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function pointer comparisons do not produce meaningful results since their addresses are not guaranteed to be unique [INFO] [stdout] --> src/pattern.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 50 | #[derive(Clone, Debug, PartialEq, Eq, Hash, PartialOrd, Ord)] [INFO] [stdout] | --------- in this derive macro expansion [INFO] [stdout] 51 | pub struct CustomPatternElem { [INFO] [stdout] 52 | check: fn(i32, i32) -> bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the address of the same function can vary between different codegen units [INFO] [stdout] = note: furthermore, different functions could have the same address after being merged together [INFO] [stdout] = note: for more information visit [INFO] [stdout] = note: `#[warn(unpredictable_function_pointer_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function pointer comparisons do not produce meaningful results since their addresses are not guaranteed to be unique [INFO] [stdout] --> src/pattern.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 50 | #[derive(Clone, Debug, PartialEq, Eq, Hash, PartialOrd, Ord)] [INFO] [stdout] | ---------- in this derive macro expansion [INFO] [stdout] 51 | pub struct CustomPatternElem { [INFO] [stdout] 52 | check: fn(i32, i32) -> bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the address of the same function can vary between different codegen units [INFO] [stdout] = note: furthermore, different functions could have the same address after being merged together [INFO] [stdout] = note: for more information visit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function pointer comparisons do not produce meaningful results since their addresses are not guaranteed to be unique [INFO] [stdout] --> src/pattern.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 50 | #[derive(Clone, Debug, PartialEq, Eq, Hash, PartialOrd, Ord)] [INFO] [stdout] | --- in this derive macro expansion [INFO] [stdout] 51 | pub struct CustomPatternElem { [INFO] [stdout] 52 | check: fn(i32, i32) -> bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the address of the same function can vary between different codegen units [INFO] [stdout] = note: furthermore, different functions could have the same address after being merged together [INFO] [stdout] = note: for more information visit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lifetime flowing from input to output with different syntax can be confusing [INFO] [stdout] --> src/pattern.rs:150:17 [INFO] [stdout] | [INFO] [stdout] 150 | pub fn iter(&self) -> Iter { [INFO] [stdout] | ^^^^^ ----------------- the lifetime gets resolved as `'_` [INFO] [stdout] | | [INFO] [stdout] | this lifetime flows to the output [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: one option is to remove the lifetime for references and use the anonymous lifetime for paths [INFO] [stdout] | [INFO] [stdout] 150 | pub fn iter(&self) -> Iter<'_, PatternElem> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/pattern.rs:68:19 [INFO] [stdout] | [INFO] [stdout] 68 | fn fmt(&self, mut fmt: &mut Formatter) -> Result<(), Error> { [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/pattern.rs:160:19 [INFO] [stdout] | [INFO] [stdout] 160 | fn fmt(&self, mut fmt: &mut Formatter) -> Result<(), Error> { [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/bin/scnl.rs:39:16 [INFO] [stdout] | [INFO] [stdout] 39 | for pat in analyzer.find_any_pattern(3) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 39 - for pat in analyzer.find_any_pattern(3) { [INFO] [stdout] 39 + while let Some(pat) = analyzer.find_any_pattern(3) { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 39 - for pat in analyzer.find_any_pattern(3) { [INFO] [stdout] 39 + if let Some(pat) = analyzer.find_any_pattern(3) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/bin/scnl.rs:56:16 [INFO] [stdout] | [INFO] [stdout] 56 | for pat in analyzer.find_any_pattern_of_length(1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 56 - for pat in analyzer.find_any_pattern_of_length(1) { [INFO] [stdout] 56 + while let Some(pat) = analyzer.find_any_pattern_of_length(1) { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 56 - for pat in analyzer.find_any_pattern_of_length(1) { [INFO] [stdout] 56 + if let Some(pat) = analyzer.find_any_pattern_of_length(1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function pointer comparisons do not produce meaningful results since their addresses are not guaranteed to be unique [INFO] [stdout] --> src/pattern.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 50 | #[derive(Clone, Debug, PartialEq, Eq, Hash, PartialOrd, Ord)] [INFO] [stdout] | --------- in this derive macro expansion [INFO] [stdout] 51 | pub struct CustomPatternElem { [INFO] [stdout] 52 | check: fn(i32, i32) -> bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the address of the same function can vary between different codegen units [INFO] [stdout] = note: furthermore, different functions could have the same address after being merged together [INFO] [stdout] = note: for more information visit [INFO] [stdout] = note: `#[warn(unpredictable_function_pointer_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function pointer comparisons do not produce meaningful results since their addresses are not guaranteed to be unique [INFO] [stdout] --> src/pattern.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 50 | #[derive(Clone, Debug, PartialEq, Eq, Hash, PartialOrd, Ord)] [INFO] [stdout] | ---------- in this derive macro expansion [INFO] [stdout] 51 | pub struct CustomPatternElem { [INFO] [stdout] 52 | check: fn(i32, i32) -> bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the address of the same function can vary between different codegen units [INFO] [stdout] = note: furthermore, different functions could have the same address after being merged together [INFO] [stdout] = note: for more information visit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function pointer comparisons do not produce meaningful results since their addresses are not guaranteed to be unique [INFO] [stdout] --> src/pattern.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 50 | #[derive(Clone, Debug, PartialEq, Eq, Hash, PartialOrd, Ord)] [INFO] [stdout] | --- in this derive macro expansion [INFO] [stdout] 51 | pub struct CustomPatternElem { [INFO] [stdout] 52 | check: fn(i32, i32) -> bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the address of the same function can vary between different codegen units [INFO] [stdout] = note: furthermore, different functions could have the same address after being merged together [INFO] [stdout] = note: for more information visit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lifetime flowing from input to output with different syntax can be confusing [INFO] [stdout] --> src/pattern.rs:150:17 [INFO] [stdout] | [INFO] [stdout] 150 | pub fn iter(&self) -> Iter { [INFO] [stdout] | ^^^^^ ----------------- the lifetime gets resolved as `'_` [INFO] [stdout] | | [INFO] [stdout] | this lifetime flows to the output [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: one option is to remove the lifetime for references and use the anonymous lifetime for paths [INFO] [stdout] | [INFO] [stdout] 150 | pub fn iter(&self) -> Iter<'_, PatternElem> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/bin/scnl.rs:39:16 [INFO] [stdout] | [INFO] [stdout] 39 | for pat in analyzer.find_any_pattern(3) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 39 - for pat in analyzer.find_any_pattern(3) { [INFO] [stdout] 39 + while let Some(pat) = analyzer.find_any_pattern(3) { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 39 - for pat in analyzer.find_any_pattern(3) { [INFO] [stdout] 39 + if let Some(pat) = analyzer.find_any_pattern(3) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/bin/scnl.rs:56:16 [INFO] [stdout] | [INFO] [stdout] 56 | for pat in analyzer.find_any_pattern_of_length(1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 56 - for pat in analyzer.find_any_pattern_of_length(1) { [INFO] [stdout] 56 + while let Some(pat) = analyzer.find_any_pattern_of_length(1) { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 56 - for pat in analyzer.find_any_pattern_of_length(1) { [INFO] [stdout] 56 + if let Some(pat) = analyzer.find_any_pattern_of_length(1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.28s [INFO] running `Command { std: "docker" "inspect" "15c5c1077b7e1260912232a2a1cb0e6440e31842a9949b45c0248b3e7e52a43a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "15c5c1077b7e1260912232a2a1cb0e6440e31842a9949b45c0248b3e7e52a43a", kill_on_drop: false }` [INFO] [stdout] 15c5c1077b7e1260912232a2a1cb0e6440e31842a9949b45c0248b3e7e52a43a