[INFO] fetching crate nodes 0.1.0... [INFO] checking nodes-0.1.0 against master#cf38b8e663f15db10ce49d7bbce02c99fc3dbc0c for pr-143170 [INFO] extracting crate nodes 0.1.0 into /workspace/builds/worker-5-tc1/source [INFO] started tweaking crates.io crate nodes 0.1.0 [INFO] finished tweaking crates.io crate nodes 0.1.0 [INFO] tweaked toml for crates.io crate nodes 0.1.0 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate nodes 0.1.0 on toolchain cf38b8e663f15db10ce49d7bbce02c99fc3dbc0c [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+cf38b8e663f15db10ce49d7bbce02c99fc3dbc0c" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+cf38b8e663f15db10ce49d7bbce02c99fc3dbc0c" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 32 packages to latest compatible versions [INFO] [stderr] Adding clap v2.34.0 (available: v4.5.40) [INFO] [stderr] Adding nom v3.2.1 (available: v8.0.0) [INFO] [stderr] Adding regex v0.2.11 (available: v1.11.1) [INFO] [stderr] Adding time v0.1.45 (available: v0.3.41) [INFO] [stderr] Adding toml v0.4.10 (available: v0.8.23) [INFO] [stderr] Adding wasi v0.10.0+wasi-snapshot-preview1 (available: v0.10.2+wasi-snapshot-preview1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+cf38b8e663f15db10ce49d7bbce02c99fc3dbc0c" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:90999bfc7ae267e83380e433d8e61a7c072ca6729e92edbae886d3423b3a6f4c" "/opt/rustwide/cargo-home/bin/cargo" "+cf38b8e663f15db10ce49d7bbce02c99fc3dbc0c" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 66db22a16cc6b8481008727ed40a11b234b84965b7fa96a9f8ef1ef810f67477 [INFO] running `Command { std: "docker" "start" "-a" "66db22a16cc6b8481008727ed40a11b234b84965b7fa96a9f8ef1ef810f67477", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "66db22a16cc6b8481008727ed40a11b234b84965b7fa96a9f8ef1ef810f67477", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "66db22a16cc6b8481008727ed40a11b234b84965b7fa96a9f8ef1ef810f67477", kill_on_drop: false }` [INFO] [stdout] 66db22a16cc6b8481008727ed40a11b234b84965b7fa96a9f8ef1ef810f67477 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:90999bfc7ae267e83380e433d8e61a7c072ca6729e92edbae886d3423b3a6f4c" "/opt/rustwide/cargo-home/bin/cargo" "+cf38b8e663f15db10ce49d7bbce02c99fc3dbc0c" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ae9023acdb9ce2aeff810fdb7ace22f5f97ff198c4d584e29f301143d94ada03 [INFO] running `Command { std: "docker" "start" "-a" "ae9023acdb9ce2aeff810fdb7ace22f5f97ff198c4d584e29f301143d94ada03", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] [stderr] Compiling libc v0.2.174 [INFO] [stderr] Compiling proc-macro2 v1.0.95 [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Checking ucd-util v0.1.10 [INFO] [stderr] Checking memchr v2.7.5 [INFO] [stderr] Compiling regex v0.2.11 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking regex-syntax v0.5.6 [INFO] [stderr] Checking utf8-ranges v1.0.5 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking aho-corasick v0.6.10 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Compiling syn v2.0.104 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking nom v3.2.1 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking toml v0.4.10 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Checking nodes v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/config.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 105 | 'outer: loop { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_labels)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/config.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 105 | 'outer: loop { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_labels)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lifetime flowing from input to output with different syntax can be confusing [INFO] [stdout] --> src/config.rs:80:25 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn load_storage(&self, name: &str) [INFO] [stdout] | ^^^^^ this lifetime flows to the output [INFO] [stdout] 81 | -> Result { [INFO] [stdout] | ---------------- the lifetime gets resolved as `'_` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: one option is to remove the lifetime for references and use the anonymous lifetime for paths [INFO] [stdout] | [INFO] [stdout] 81 | -> Result, storage::LoadStorageError> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lifetime flowing from input to output with different syntax can be confusing [INFO] [stdout] --> src/config.rs:91:33 [INFO] [stdout] | [INFO] [stdout] 91 | pub fn load_default_storage(&self) [INFO] [stdout] | ^^^^^ this lifetime flows to the output [INFO] [stdout] 92 | -> Result { [INFO] [stdout] | ---------------- the lifetime gets resolved as `'_` [INFO] [stdout] | [INFO] [stdout] help: one option is to remove the lifetime for references and use the anonymous lifetime for paths [INFO] [stdout] | [INFO] [stdout] 92 | -> Result, storage::LoadStorageError> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lifetime flowing from input to output with different syntax can be confusing [INFO] [stdout] --> src/config.rs:102:31 [INFO] [stdout] | [INFO] [stdout] 102 | pub fn load_local_storage(&self) [INFO] [stdout] | ^^^^^ this lifetime flows to the output [INFO] [stdout] 103 | -> Result { [INFO] [stdout] | ---------------- the lifetime gets resolved as `'_` [INFO] [stdout] | [INFO] [stdout] help: one option is to remove the lifetime for references and use the anonymous lifetime for paths [INFO] [stdout] | [INFO] [stdout] 103 | -> Result, storage::LoadStorageError> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lifetime flowing from input to output with different syntax can be confusing [INFO] [stdout] --> src/storage.rs:92:18 [INFO] [stdout] | [INFO] [stdout] 92 | pub fn nodes(&self) -> Vec { [INFO] [stdout] | ^^^^^ ---- [INFO] [stdout] | | | [INFO] [stdout] | | the lifetimes get resolved as `'_` [INFO] [stdout] | | the lifetimes get resolved as `'_` [INFO] [stdout] | this lifetime flows to the output [INFO] [stdout] | [INFO] [stdout] help: one option is to remove the lifetime for references and use the anonymous lifetime for paths [INFO] [stdout] | [INFO] [stdout] 92 | pub fn nodes(&self) -> Vec> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lifetime flowing from input to output with different syntax can be confusing [INFO] [stdout] --> src/storage.rs:134:22 [INFO] [stdout] | [INFO] [stdout] 134 | pub fn next_node(&self) -> Node { [INFO] [stdout] | ^^^^^ ---- [INFO] [stdout] | | | [INFO] [stdout] | | the lifetimes get resolved as `'_` [INFO] [stdout] | | the lifetimes get resolved as `'_` [INFO] [stdout] | this lifetime flows to the output [INFO] [stdout] | [INFO] [stdout] help: one option is to remove the lifetime for references and use the anonymous lifetime for paths [INFO] [stdout] | [INFO] [stdout] 134 | pub fn next_node(&self) -> Node<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lifetime flowing from input to output with different syntax can be confusing [INFO] [stdout] --> src/config.rs:80:25 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn load_storage(&self, name: &str) [INFO] [stdout] | ^^^^^ this lifetime flows to the output [INFO] [stdout] 81 | -> Result { [INFO] [stdout] | ---------------- the lifetime gets resolved as `'_` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: one option is to remove the lifetime for references and use the anonymous lifetime for paths [INFO] [stdout] | [INFO] [stdout] 81 | -> Result, storage::LoadStorageError> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lifetime flowing from input to output with different syntax can be confusing [INFO] [stdout] --> src/config.rs:91:33 [INFO] [stdout] | [INFO] [stdout] 91 | pub fn load_default_storage(&self) [INFO] [stdout] | ^^^^^ this lifetime flows to the output [INFO] [stdout] 92 | -> Result { [INFO] [stdout] | ---------------- the lifetime gets resolved as `'_` [INFO] [stdout] | [INFO] [stdout] help: one option is to remove the lifetime for references and use the anonymous lifetime for paths [INFO] [stdout] | [INFO] [stdout] 92 | -> Result, storage::LoadStorageError> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lifetime flowing from input to output with different syntax can be confusing [INFO] [stdout] --> src/config.rs:102:31 [INFO] [stdout] | [INFO] [stdout] 102 | pub fn load_local_storage(&self) [INFO] [stdout] | ^^^^^ this lifetime flows to the output [INFO] [stdout] 103 | -> Result { [INFO] [stdout] | ---------------- the lifetime gets resolved as `'_` [INFO] [stdout] | [INFO] [stdout] help: one option is to remove the lifetime for references and use the anonymous lifetime for paths [INFO] [stdout] | [INFO] [stdout] 103 | -> Result, storage::LoadStorageError> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lifetime flowing from input to output with different syntax can be confusing [INFO] [stdout] --> src/storage.rs:92:18 [INFO] [stdout] | [INFO] [stdout] 92 | pub fn nodes(&self) -> Vec { [INFO] [stdout] | ^^^^^ ---- [INFO] [stdout] | | | [INFO] [stdout] | | the lifetimes get resolved as `'_` [INFO] [stdout] | | the lifetimes get resolved as `'_` [INFO] [stdout] | this lifetime flows to the output [INFO] [stdout] | [INFO] [stdout] help: one option is to remove the lifetime for references and use the anonymous lifetime for paths [INFO] [stdout] | [INFO] [stdout] 92 | pub fn nodes(&self) -> Vec> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lifetime flowing from input to output with different syntax can be confusing [INFO] [stdout] --> src/storage.rs:134:22 [INFO] [stdout] | [INFO] [stdout] 134 | pub fn next_node(&self) -> Node { [INFO] [stdout] | ^^^^^ ---- [INFO] [stdout] | | | [INFO] [stdout] | | the lifetimes get resolved as `'_` [INFO] [stdout] | | the lifetimes get resolved as `'_` [INFO] [stdout] | this lifetime flows to the output [INFO] [stdout] | [INFO] [stdout] help: one option is to remove the lifetime for references and use the anonymous lifetime for paths [INFO] [stdout] | [INFO] [stdout] 134 | pub fn next_node(&self) -> Node<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> cli/commands.rs:33:17 [INFO] [stdout] | [INFO] [stdout] 33 | let mut val = val.replace(";", "\n"); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> cli/commands.rs:119:13 [INFO] [stdout] | [INFO] [stdout] 119 | let mut meta = match node.load_meta() { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> cli/commands.rs:429:29 [INFO] [stdout] | [INFO] [stdout] 429 | let mut reader = BufReader::new(f); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> cli/commands.rs:33:17 [INFO] [stdout] | [INFO] [stdout] 33 | let mut val = val.replace(";", "\n"); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> cli/commands.rs:75:53 [INFO] [stdout] | [INFO] [stdout] 75 | meta.set("type", toml::Value::from(node_type.clone())); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> cli/commands.rs:285:53 [INFO] [stdout] | [INFO] [stdout] 285 | meta.set("type", toml::Value::from(node_type.clone())); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lifetime flowing from input to output with different syntax can be confusing [INFO] [stdout] --> cli/commands.rs:621:29 [INFO] [stdout] | [INFO] [stdout] 621 | fn storage_for_path(config: &nodes::Config, mut path: PathBuf) [INFO] [stdout] | ^^^^^^^^^^^^^^ this lifetime flows to the output [INFO] [stdout] 622 | -> Option { [INFO] [stdout] | -------------- the lifetime gets resolved as `'_` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: one option is to remove the lifetime for references and use the anonymous lifetime for paths [INFO] [stdout] | [INFO] [stdout] 622 | -> Option> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> cli/commands.rs:119:13 [INFO] [stdout] | [INFO] [stdout] 119 | let mut meta = match node.load_meta() { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> cli/commands.rs:429:29 [INFO] [stdout] | [INFO] [stdout] 429 | let mut reader = BufReader::new(f); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> cli/commands.rs:75:53 [INFO] [stdout] | [INFO] [stdout] 75 | meta.set("type", toml::Value::from(node_type.clone())); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> cli/commands.rs:285:53 [INFO] [stdout] | [INFO] [stdout] 285 | meta.set("type", toml::Value::from(node_type.clone())); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lifetime flowing from input to output with different syntax can be confusing [INFO] [stdout] --> cli/commands.rs:621:29 [INFO] [stdout] | [INFO] [stdout] 621 | fn storage_for_path(config: &nodes::Config, mut path: PathBuf) [INFO] [stdout] | ^^^^^^^^^^^^^^ this lifetime flows to the output [INFO] [stdout] 622 | -> Option { [INFO] [stdout] | -------------- the lifetime gets resolved as `'_` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: one option is to remove the lifetime for references and use the anonymous lifetime for paths [INFO] [stdout] | [INFO] [stdout] 622 | -> Option> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 18.77s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: nom v3.2.1 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2` [INFO] running `Command { std: "docker" "inspect" "ae9023acdb9ce2aeff810fdb7ace22f5f97ff198c4d584e29f301143d94ada03", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ae9023acdb9ce2aeff810fdb7ace22f5f97ff198c4d584e29f301143d94ada03", kill_on_drop: false }` [INFO] [stdout] ae9023acdb9ce2aeff810fdb7ace22f5f97ff198c4d584e29f301143d94ada03