[INFO] fetching crate harmony 0.2.1... [INFO] checking harmony-0.2.1 against master#cf38b8e663f15db10ce49d7bbce02c99fc3dbc0c for pr-143170 [INFO] extracting crate harmony 0.2.1 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate harmony 0.2.1 [INFO] finished tweaking crates.io crate harmony 0.2.1 [INFO] tweaked toml for crates.io crate harmony 0.2.1 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate harmony 0.2.1 on toolchain cf38b8e663f15db10ce49d7bbce02c99fc3dbc0c [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+cf38b8e663f15db10ce49d7bbce02c99fc3dbc0c" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+cf38b8e663f15db10ce49d7bbce02c99fc3dbc0c" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 1 package to latest compatible version [INFO] [stderr] Adding itertools v0.4.19 (available: v0.14.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+cf38b8e663f15db10ce49d7bbce02c99fc3dbc0c" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded itertools v0.4.19 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:90999bfc7ae267e83380e433d8e61a7c072ca6729e92edbae886d3423b3a6f4c" "/opt/rustwide/cargo-home/bin/cargo" "+cf38b8e663f15db10ce49d7bbce02c99fc3dbc0c" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 140ddabe3eed0d120b86081c92d3c6e956805582166132bc90d3b2e89d0f32da [INFO] running `Command { std: "docker" "start" "-a" "140ddabe3eed0d120b86081c92d3c6e956805582166132bc90d3b2e89d0f32da", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "140ddabe3eed0d120b86081c92d3c6e956805582166132bc90d3b2e89d0f32da", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "140ddabe3eed0d120b86081c92d3c6e956805582166132bc90d3b2e89d0f32da", kill_on_drop: false }` [INFO] [stdout] 140ddabe3eed0d120b86081c92d3c6e956805582166132bc90d3b2e89d0f32da [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:90999bfc7ae267e83380e433d8e61a7c072ca6729e92edbae886d3423b3a6f4c" "/opt/rustwide/cargo-home/bin/cargo" "+cf38b8e663f15db10ce49d7bbce02c99fc3dbc0c" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e8972864a4719f3cb57df212046f91216be80bb7d83c5a111de5a2daa85da25a [INFO] running `Command { std: "docker" "start" "-a" "e8972864a4719f3cb57df212046f91216be80bb7d83c5a111de5a2daa85da25a", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] [stderr] Checking itertools v0.4.19 [INFO] [stderr] Checking harmony v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:363:13 [INFO] [stdout] | [INFO] [stdout] 363 | let mut stages = [PlayState::Placed, PlayState::Static, PlayState::Moved]; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lifetime flowing from input to output with different syntax can be confusing [INFO] [stdout] --> src/lib.rs:139:26 [INFO] [stdout] | [INFO] [stdout] 139 | pub fn get_harmonies(&self) -> Vec { [INFO] [stdout] | ^^^^^ ------- the lifetime gets resolved as `'_` [INFO] [stdout] | | [INFO] [stdout] | this lifetime flows to the output [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: one option is to remove the lifetime for references and use the anonymous lifetime for paths [INFO] [stdout] | [INFO] [stdout] 139 | pub fn get_harmonies(&self) -> Vec> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `A` should have a snake case name [INFO] [stdout] --> src/lib.rs:199:14 [INFO] [stdout] | [INFO] [stdout] 199 | for (A, B) in harmonies.iter().combinations() { [INFO] [stdout] | ^ help: convert the identifier to snake case: `a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `B` should have a snake case name [INFO] [stdout] --> src/lib.rs:199:17 [INFO] [stdout] | [INFO] [stdout] 199 | for (A, B) in harmonies.iter().combinations() { [INFO] [stdout] | ^ help: convert the identifier to snake case: `b` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `A_lower` should have a snake case name [INFO] [stdout] --> src/lib.rs:204:29 [INFO] [stdout] | [INFO] [stdout] 204 | let A_lower = std::cmp::min(A.start.y, A.end.y); [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `a_lower` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `A_upper` should have a snake case name [INFO] [stdout] --> src/lib.rs:205:29 [INFO] [stdout] | [INFO] [stdout] 205 | let A_upper = std::cmp::max(A.start.y, A.end.y); [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `a_upper` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `B_lower` should have a snake case name [INFO] [stdout] --> src/lib.rs:206:29 [INFO] [stdout] | [INFO] [stdout] 206 | let B_lower = std::cmp::min(B.start.x, B.end.x); [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `b_lower` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `B_upper` should have a snake case name [INFO] [stdout] --> src/lib.rs:207:29 [INFO] [stdout] | [INFO] [stdout] 207 | let B_upper = std::cmp::max(B.start.x, B.end.x); [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `b_upper` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `A_lower` should have a snake case name [INFO] [stdout] --> src/lib.rs:217:29 [INFO] [stdout] | [INFO] [stdout] 217 | let A_lower = std::cmp::min(A.start.x, A.end.x); [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `a_lower` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `A_upper` should have a snake case name [INFO] [stdout] --> src/lib.rs:218:29 [INFO] [stdout] | [INFO] [stdout] 218 | let A_upper = std::cmp::max(A.start.x, A.end.x); [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `a_upper` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `B_lower` should have a snake case name [INFO] [stdout] --> src/lib.rs:219:29 [INFO] [stdout] | [INFO] [stdout] 219 | let B_lower = std::cmp::min(B.start.y, B.end.y); [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `b_lower` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `B_upper` should have a snake case name [INFO] [stdout] --> src/lib.rs:220:29 [INFO] [stdout] | [INFO] [stdout] 220 | let B_upper = std::cmp::max(B.start.y, B.end.y); [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `b_upper` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `A_lower` should have a snake case name [INFO] [stdout] --> src/lib.rs:231:33 [INFO] [stdout] | [INFO] [stdout] 231 | ... let A_lower = std::cmp::min(A.start.y, A.end.y); [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `a_lower` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `A_upper` should have a snake case name [INFO] [stdout] --> src/lib.rs:232:33 [INFO] [stdout] | [INFO] [stdout] 232 | ... let A_upper = std::cmp::max(A.start.y, A.end.y); [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `a_upper` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `B_lower` should have a snake case name [INFO] [stdout] --> src/lib.rs:233:33 [INFO] [stdout] | [INFO] [stdout] 233 | ... let B_lower = std::cmp::min(B.start.y, B.end.y); [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `b_lower` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `B_upper` should have a snake case name [INFO] [stdout] --> src/lib.rs:234:33 [INFO] [stdout] | [INFO] [stdout] 234 | ... let B_upper = std::cmp::max(B.start.y, B.end.y); [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `b_upper` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `A_lower` should have a snake case name [INFO] [stdout] --> src/lib.rs:246:33 [INFO] [stdout] | [INFO] [stdout] 246 | ... let A_lower = std::cmp::min(A.start.x, A.end.x); [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `a_lower` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `A_upper` should have a snake case name [INFO] [stdout] --> src/lib.rs:247:33 [INFO] [stdout] | [INFO] [stdout] 247 | ... let A_upper = std::cmp::max(A.start.x, A.end.x); [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `a_upper` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `B_lower` should have a snake case name [INFO] [stdout] --> src/lib.rs:248:33 [INFO] [stdout] | [INFO] [stdout] 248 | ... let B_lower = std::cmp::min(B.start.x, B.end.x); [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `b_lower` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `B_upper` should have a snake case name [INFO] [stdout] --> src/lib.rs:249:33 [INFO] [stdout] | [INFO] [stdout] 249 | ... let B_upper = std::cmp::max(B.start.x, B.end.x); [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `b_upper` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:363:13 [INFO] [stdout] | [INFO] [stdout] 363 | let mut stages = [PlayState::Placed, PlayState::Static, PlayState::Moved]; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lifetime flowing from input to output with different syntax can be confusing [INFO] [stdout] --> src/lib.rs:139:26 [INFO] [stdout] | [INFO] [stdout] 139 | pub fn get_harmonies(&self) -> Vec { [INFO] [stdout] | ^^^^^ ------- the lifetime gets resolved as `'_` [INFO] [stdout] | | [INFO] [stdout] | this lifetime flows to the output [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: one option is to remove the lifetime for references and use the anonymous lifetime for paths [INFO] [stdout] | [INFO] [stdout] 139 | pub fn get_harmonies(&self) -> Vec> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `A` should have a snake case name [INFO] [stdout] --> src/lib.rs:199:14 [INFO] [stdout] | [INFO] [stdout] 199 | for (A, B) in harmonies.iter().combinations() { [INFO] [stdout] | ^ help: convert the identifier to snake case: `a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `B` should have a snake case name [INFO] [stdout] --> src/lib.rs:199:17 [INFO] [stdout] | [INFO] [stdout] 199 | for (A, B) in harmonies.iter().combinations() { [INFO] [stdout] | ^ help: convert the identifier to snake case: `b` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `A_lower` should have a snake case name [INFO] [stdout] --> src/lib.rs:204:29 [INFO] [stdout] | [INFO] [stdout] 204 | let A_lower = std::cmp::min(A.start.y, A.end.y); [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `a_lower` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `A_upper` should have a snake case name [INFO] [stdout] --> src/lib.rs:205:29 [INFO] [stdout] | [INFO] [stdout] 205 | let A_upper = std::cmp::max(A.start.y, A.end.y); [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `a_upper` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `B_lower` should have a snake case name [INFO] [stdout] --> src/lib.rs:206:29 [INFO] [stdout] | [INFO] [stdout] 206 | let B_lower = std::cmp::min(B.start.x, B.end.x); [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `b_lower` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `B_upper` should have a snake case name [INFO] [stdout] --> src/lib.rs:207:29 [INFO] [stdout] | [INFO] [stdout] 207 | let B_upper = std::cmp::max(B.start.x, B.end.x); [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `b_upper` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `A_lower` should have a snake case name [INFO] [stdout] --> src/lib.rs:217:29 [INFO] [stdout] | [INFO] [stdout] 217 | let A_lower = std::cmp::min(A.start.x, A.end.x); [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `a_lower` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `A_upper` should have a snake case name [INFO] [stdout] --> src/lib.rs:218:29 [INFO] [stdout] | [INFO] [stdout] 218 | let A_upper = std::cmp::max(A.start.x, A.end.x); [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `a_upper` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `B_lower` should have a snake case name [INFO] [stdout] --> src/lib.rs:219:29 [INFO] [stdout] | [INFO] [stdout] 219 | let B_lower = std::cmp::min(B.start.y, B.end.y); [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `b_lower` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `B_upper` should have a snake case name [INFO] [stdout] --> src/lib.rs:220:29 [INFO] [stdout] | [INFO] [stdout] 220 | let B_upper = std::cmp::max(B.start.y, B.end.y); [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `b_upper` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `A_lower` should have a snake case name [INFO] [stdout] --> src/lib.rs:231:33 [INFO] [stdout] | [INFO] [stdout] 231 | ... let A_lower = std::cmp::min(A.start.y, A.end.y); [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `a_lower` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `A_upper` should have a snake case name [INFO] [stdout] --> src/lib.rs:232:33 [INFO] [stdout] | [INFO] [stdout] 232 | ... let A_upper = std::cmp::max(A.start.y, A.end.y); [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `a_upper` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `B_lower` should have a snake case name [INFO] [stdout] --> src/lib.rs:233:33 [INFO] [stdout] | [INFO] [stdout] 233 | ... let B_lower = std::cmp::min(B.start.y, B.end.y); [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `b_lower` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `B_upper` should have a snake case name [INFO] [stdout] --> src/lib.rs:234:33 [INFO] [stdout] | [INFO] [stdout] 234 | ... let B_upper = std::cmp::max(B.start.y, B.end.y); [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `b_upper` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `A_lower` should have a snake case name [INFO] [stdout] --> src/lib.rs:246:33 [INFO] [stdout] | [INFO] [stdout] 246 | ... let A_lower = std::cmp::min(A.start.x, A.end.x); [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `a_lower` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `A_upper` should have a snake case name [INFO] [stdout] --> src/lib.rs:247:33 [INFO] [stdout] | [INFO] [stdout] 247 | ... let A_upper = std::cmp::max(A.start.x, A.end.x); [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `a_upper` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `B_lower` should have a snake case name [INFO] [stdout] --> src/lib.rs:248:33 [INFO] [stdout] | [INFO] [stdout] 248 | ... let B_lower = std::cmp::min(B.start.x, B.end.x); [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `b_lower` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `B_upper` should have a snake case name [INFO] [stdout] --> src/lib.rs:249:33 [INFO] [stdout] | [INFO] [stdout] 249 | ... let B_upper = std::cmp::max(B.start.x, B.end.x); [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `b_upper` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.93s [INFO] running `Command { std: "docker" "inspect" "e8972864a4719f3cb57df212046f91216be80bb7d83c5a111de5a2daa85da25a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e8972864a4719f3cb57df212046f91216be80bb7d83c5a111de5a2daa85da25a", kill_on_drop: false }` [INFO] [stdout] e8972864a4719f3cb57df212046f91216be80bb7d83c5a111de5a2daa85da25a