[INFO] fetching crate derive-visitor 0.4.0... [INFO] checking derive-visitor-0.4.0 against master#cf38b8e663f15db10ce49d7bbce02c99fc3dbc0c for pr-143170 [INFO] extracting crate derive-visitor 0.4.0 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate derive-visitor 0.4.0 [INFO] finished tweaking crates.io crate derive-visitor 0.4.0 [INFO] tweaked toml for crates.io crate derive-visitor 0.4.0 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate derive-visitor 0.4.0 on toolchain cf38b8e663f15db10ce49d7bbce02c99fc3dbc0c [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+cf38b8e663f15db10ce49d7bbce02c99fc3dbc0c" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+cf38b8e663f15db10ce49d7bbce02c99fc3dbc0c" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 8 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+cf38b8e663f15db10ce49d7bbce02c99fc3dbc0c" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded derive-visitor-macros v0.4.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:90999bfc7ae267e83380e433d8e61a7c072ca6729e92edbae886d3423b3a6f4c" "/opt/rustwide/cargo-home/bin/cargo" "+cf38b8e663f15db10ce49d7bbce02c99fc3dbc0c" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5684e79b6cb64482192c5b70eff27de3df5387cbd9c870e3c350b7e20b731d8a [INFO] running `Command { std: "docker" "start" "-a" "5684e79b6cb64482192c5b70eff27de3df5387cbd9c870e3c350b7e20b731d8a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5684e79b6cb64482192c5b70eff27de3df5387cbd9c870e3c350b7e20b731d8a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5684e79b6cb64482192c5b70eff27de3df5387cbd9c870e3c350b7e20b731d8a", kill_on_drop: false }` [INFO] [stdout] 5684e79b6cb64482192c5b70eff27de3df5387cbd9c870e3c350b7e20b731d8a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:90999bfc7ae267e83380e433d8e61a7c072ca6729e92edbae886d3423b3a6f4c" "/opt/rustwide/cargo-home/bin/cargo" "+cf38b8e663f15db10ce49d7bbce02c99fc3dbc0c" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 491e21813ece7b2b5c002d51c22b1f179e17ee28c64faae3c9cd3d3b0c1b31a7 [INFO] running `Command { std: "docker" "start" "-a" "491e21813ece7b2b5c002d51c22b1f179e17ee28c64faae3c9cd3d3b0c1b31a7", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling either v1.15.0 [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Compiling itertools v0.10.5 [INFO] [stderr] Compiling derive-visitor-macros v0.4.0 [INFO] [stderr] Checking derive-visitor v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/lib.rs:572:1 [INFO] [stdout] | [INFO] [stdout] 572 | impl_drive_for_into_iterator! { Option ; T } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 544 - for item in self { [INFO] [stdout] 544 + while let Some() = in self { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 544 - for item in self { [INFO] [stdout] 544 + if let Some() = in self { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&mut Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/lib.rs:572:1 [INFO] [stdout] | [INFO] [stdout] 572 | impl_drive_for_into_iterator! { Option ; T } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 557 - for item in self { [INFO] [stdout] 557 + while let Some() = in self { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 557 - for item in self { [INFO] [stdout] 557 + if let Some() = in self { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/lib.rs:573:1 [INFO] [stdout] | [INFO] [stdout] 573 | impl_drive_for_into_iterator! { Result ; T, U } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 544 - for item in self { [INFO] [stdout] 544 + while let Ok() = in self { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 544 - for item in self { [INFO] [stdout] 544 + if let Ok() = in self { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&mut Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/lib.rs:573:1 [INFO] [stdout] | [INFO] [stdout] 573 | impl_drive_for_into_iterator! { Result ; T, U } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 557 - for item in self { [INFO] [stdout] 557 + while let Ok() = in self { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 557 - for item in self { [INFO] [stdout] 557 + if let Ok() = in self { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/lib.rs:572:1 [INFO] [stdout] | [INFO] [stdout] 572 | impl_drive_for_into_iterator! { Option ; T } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 544 - for item in self { [INFO] [stdout] 544 + while let Some() = in self { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 544 - for item in self { [INFO] [stdout] 544 + if let Some() = in self { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&mut Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/lib.rs:572:1 [INFO] [stdout] | [INFO] [stdout] 572 | impl_drive_for_into_iterator! { Option ; T } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 557 - for item in self { [INFO] [stdout] 557 + while let Some() = in self { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 557 - for item in self { [INFO] [stdout] 557 + if let Some() = in self { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/lib.rs:573:1 [INFO] [stdout] | [INFO] [stdout] 573 | impl_drive_for_into_iterator! { Result ; T, U } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 544 - for item in self { [INFO] [stdout] 544 + while let Ok() = in self { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 544 - for item in self { [INFO] [stdout] 544 + if let Ok() = in self { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&mut Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/lib.rs:573:1 [INFO] [stdout] | [INFO] [stdout] 573 | impl_drive_for_into_iterator! { Result ; T, U } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 557 - for item in self { [INFO] [stdout] 557 + while let Ok() = in self { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 557 - for item in self { [INFO] [stdout] 557 + if let Ok() = in self { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.20s [INFO] running `Command { std: "docker" "inspect" "491e21813ece7b2b5c002d51c22b1f179e17ee28c64faae3c9cd3d3b0c1b31a7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "491e21813ece7b2b5c002d51c22b1f179e17ee28c64faae3c9cd3d3b0c1b31a7", kill_on_drop: false }` [INFO] [stdout] 491e21813ece7b2b5c002d51c22b1f179e17ee28c64faae3c9cd3d3b0c1b31a7