[INFO] fetching crate bytekey2 0.4.5... [INFO] checking bytekey2-0.4.5 against master#cf38b8e663f15db10ce49d7bbce02c99fc3dbc0c for pr-143170 [INFO] extracting crate bytekey2 0.4.5 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate bytekey2 0.4.5 [INFO] finished tweaking crates.io crate bytekey2 0.4.5 [INFO] tweaked toml for crates.io crate bytekey2 0.4.5 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate bytekey2 0.4.5 on toolchain cf38b8e663f15db10ce49d7bbce02c99fc3dbc0c [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+cf38b8e663f15db10ce49d7bbce02c99fc3dbc0c" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+cf38b8e663f15db10ce49d7bbce02c99fc3dbc0c" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 18 packages to latest compatible versions [INFO] [stderr] Adding rand v0.8.5 (available: v0.9.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+cf38b8e663f15db10ce49d7bbce02c99fc3dbc0c" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:90999bfc7ae267e83380e433d8e61a7c072ca6729e92edbae886d3423b3a6f4c" "/opt/rustwide/cargo-home/bin/cargo" "+cf38b8e663f15db10ce49d7bbce02c99fc3dbc0c" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] eaf5f83fc6b08edc0a9f88b17b66c0244f708709693591d4152ef23a09ad7858 [INFO] running `Command { std: "docker" "start" "-a" "eaf5f83fc6b08edc0a9f88b17b66c0244f708709693591d4152ef23a09ad7858", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "eaf5f83fc6b08edc0a9f88b17b66c0244f708709693591d4152ef23a09ad7858", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eaf5f83fc6b08edc0a9f88b17b66c0244f708709693591d4152ef23a09ad7858", kill_on_drop: false }` [INFO] [stdout] eaf5f83fc6b08edc0a9f88b17b66c0244f708709693591d4152ef23a09ad7858 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:90999bfc7ae267e83380e433d8e61a7c072ca6729e92edbae886d3423b3a6f4c" "/opt/rustwide/cargo-home/bin/cargo" "+cf38b8e663f15db10ce49d7bbce02c99fc3dbc0c" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7240e069c7fec287ed5c39070cf2cb9b14d891f7f1c7b6b113dd2e0f0b8927c1 [INFO] running `Command { std: "docker" "start" "-a" "7240e069c7fec287ed5c39070cf2cb9b14d891f7f1c7b6b113dd2e0f0b8927c1", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Checking bytekey2 v0.4.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary transmute [INFO] [stdout] --> src/de.rs:196:31 [INFO] [stdout] | [INFO] [stdout] 196 | let f: f32 = unsafe { transmute(val ^ t) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unnecessary_transmutes)]` on by default [INFO] [stdout] help: replace this with [INFO] [stdout] | [INFO] [stdout] 196 - let f: f32 = unsafe { transmute(val ^ t) }; [INFO] [stdout] 196 + let f: f32 = unsafe { f32::from_bits(i32::cast_unsigned(val ^ t)) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary transmute [INFO] [stdout] --> src/de.rs:206:31 [INFO] [stdout] | [INFO] [stdout] 206 | let f: f64 = unsafe { transmute(val ^ t) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace this with [INFO] [stdout] | [INFO] [stdout] 206 - let f: f64 = unsafe { transmute(val ^ t) }; [INFO] [stdout] 206 + let f: f64 = unsafe { f64::from_bits(i64::cast_unsigned(val ^ t)) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/de.rs:462:9 [INFO] [stdout] | [INFO] [stdout] 453 | / fn deserialize_enum( [INFO] [stdout] 454 | | self, [INFO] [stdout] 455 | | _name: &'static str, [INFO] [stdout] 456 | | _fields: &'static [&'static str], [INFO] [stdout] ... | [INFO] [stdout] 459 | | where [INFO] [stdout] 460 | | V: Visitor<'de>, [INFO] [stdout] | |________________________- move the `impl` block outside of this method `deserialize_enum` [INFO] [stdout] 461 | { [INFO] [stdout] 462 | impl<'de, 'a, R> serde::de::EnumAccess<'de> for &'a mut Deserializer [INFO] [stdout] | ^^^^^^^^^^^^^^^^^---------------------^^^^^^^^^^^^^^^^^^------------^^^ [INFO] [stdout] | | | [INFO] [stdout] | | `Deserializer` is not local [INFO] [stdout] | `EnumAccess` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/de.rs:480:9 [INFO] [stdout] | [INFO] [stdout] 453 | / fn deserialize_enum( [INFO] [stdout] 454 | | self, [INFO] [stdout] 455 | | _name: &'static str, [INFO] [stdout] 456 | | _fields: &'static [&'static str], [INFO] [stdout] ... | [INFO] [stdout] 459 | | where [INFO] [stdout] 460 | | V: Visitor<'de>, [INFO] [stdout] | |________________________- move the `impl` block outside of this method `deserialize_enum` [INFO] [stdout] ... [INFO] [stdout] 480 | impl<'de, 'a, R> serde::de::VariantAccess<'de> for &'a mut Deserializer [INFO] [stdout] | ^^^^^^^^^^^^^^^^^------------------------^^^^^^^^^^^^^^^^^^------------^^^ [INFO] [stdout] | | | [INFO] [stdout] | | `Deserializer` is not local [INFO] [stdout] | `VariantAccess` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary transmute [INFO] [stdout] --> src/ser.rs:454:28 [INFO] [stdout] | [INFO] [stdout] 454 | let val = unsafe { transmute::(v) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace this with [INFO] [stdout] | [INFO] [stdout] 454 - let val = unsafe { transmute::(v) }; [INFO] [stdout] 454 + let val = unsafe { f32::to_bits(v).cast_signed() }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary transmute [INFO] [stdout] --> src/ser.rs:466:28 [INFO] [stdout] | [INFO] [stdout] 466 | let val = unsafe { transmute::(v) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace this with [INFO] [stdout] | [INFO] [stdout] 466 - let val = unsafe { transmute::(v) }; [INFO] [stdout] 466 + let val = unsafe { f64::to_bits(v).cast_signed() }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary transmute [INFO] [stdout] --> src/de.rs:196:31 [INFO] [stdout] | [INFO] [stdout] 196 | let f: f32 = unsafe { transmute(val ^ t) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unnecessary_transmutes)]` on by default [INFO] [stdout] help: replace this with [INFO] [stdout] | [INFO] [stdout] 196 - let f: f32 = unsafe { transmute(val ^ t) }; [INFO] [stdout] 196 + let f: f32 = unsafe { f32::from_bits(i32::cast_unsigned(val ^ t)) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary transmute [INFO] [stdout] --> src/de.rs:206:31 [INFO] [stdout] | [INFO] [stdout] 206 | let f: f64 = unsafe { transmute(val ^ t) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace this with [INFO] [stdout] | [INFO] [stdout] 206 - let f: f64 = unsafe { transmute(val ^ t) }; [INFO] [stdout] 206 + let f: f64 = unsafe { f64::from_bits(i64::cast_unsigned(val ^ t)) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/de.rs:462:9 [INFO] [stdout] | [INFO] [stdout] 453 | / fn deserialize_enum( [INFO] [stdout] 454 | | self, [INFO] [stdout] 455 | | _name: &'static str, [INFO] [stdout] 456 | | _fields: &'static [&'static str], [INFO] [stdout] ... | [INFO] [stdout] 459 | | where [INFO] [stdout] 460 | | V: Visitor<'de>, [INFO] [stdout] | |________________________- move the `impl` block outside of this method `deserialize_enum` [INFO] [stdout] 461 | { [INFO] [stdout] 462 | impl<'de, 'a, R> serde::de::EnumAccess<'de> for &'a mut Deserializer [INFO] [stdout] | ^^^^^^^^^^^^^^^^^---------------------^^^^^^^^^^^^^^^^^^------------^^^ [INFO] [stdout] | | | [INFO] [stdout] | | `Deserializer` is not local [INFO] [stdout] | `EnumAccess` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/de.rs:480:9 [INFO] [stdout] | [INFO] [stdout] 453 | / fn deserialize_enum( [INFO] [stdout] 454 | | self, [INFO] [stdout] 455 | | _name: &'static str, [INFO] [stdout] 456 | | _fields: &'static [&'static str], [INFO] [stdout] ... | [INFO] [stdout] 459 | | where [INFO] [stdout] 460 | | V: Visitor<'de>, [INFO] [stdout] | |________________________- move the `impl` block outside of this method `deserialize_enum` [INFO] [stdout] ... [INFO] [stdout] 480 | impl<'de, 'a, R> serde::de::VariantAccess<'de> for &'a mut Deserializer [INFO] [stdout] | ^^^^^^^^^^^^^^^^^------------------------^^^^^^^^^^^^^^^^^^------------^^^ [INFO] [stdout] | | | [INFO] [stdout] | | `Deserializer` is not local [INFO] [stdout] | `VariantAccess` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary transmute [INFO] [stdout] --> src/ser.rs:454:28 [INFO] [stdout] | [INFO] [stdout] 454 | let val = unsafe { transmute::(v) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace this with [INFO] [stdout] | [INFO] [stdout] 454 - let val = unsafe { transmute::(v) }; [INFO] [stdout] 454 + let val = unsafe { f32::to_bits(v).cast_signed() }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary transmute [INFO] [stdout] --> src/ser.rs:466:28 [INFO] [stdout] | [INFO] [stdout] 466 | let val = unsafe { transmute::(v) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace this with [INFO] [stdout] | [INFO] [stdout] 466 - let val = unsafe { transmute::(v) }; [INFO] [stdout] 466 + let val = unsafe { f64::to_bits(v).cast_signed() }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.72s [INFO] running `Command { std: "docker" "inspect" "7240e069c7fec287ed5c39070cf2cb9b14d891f7f1c7b6b113dd2e0f0b8927c1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7240e069c7fec287ed5c39070cf2cb9b14d891f7f1c7b6b113dd2e0f0b8927c1", kill_on_drop: false }` [INFO] [stdout] 7240e069c7fec287ed5c39070cf2cb9b14d891f7f1c7b6b113dd2e0f0b8927c1