[INFO] cloning repository https://github.com/bendmorris/soupdb [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/bendmorris/soupdb" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbendmorris%2Fsoupdb", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbendmorris%2Fsoupdb'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1d2e2e702a4f7164ad06bf07212e9d54ea2e9b45 [INFO] checking bendmorris/soupdb against master#c720f49c46ec3e70bbc2bbb3e0dd1fe7fc0a47f2 for pr-142712 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbendmorris%2Fsoupdb" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/bendmorris/soupdb [INFO] finished tweaking git repo https://github.com/bendmorris/soupdb [INFO] tweaked toml for git repo https://github.com/bendmorris/soupdb written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/bendmorris/soupdb on toolchain c720f49c46ec3e70bbc2bbb3e0dd1fe7fc0a47f2 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c720f49c46ec3e70bbc2bbb3e0dd1fe7fc0a47f2" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/bendmorris/soupdb already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c720f49c46ec3e70bbc2bbb3e0dd1fe7fc0a47f2" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded nom v3.1.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:90999bfc7ae267e83380e433d8e61a7c072ca6729e92edbae886d3423b3a6f4c" "/opt/rustwide/cargo-home/bin/cargo" "+c720f49c46ec3e70bbc2bbb3e0dd1fe7fc0a47f2" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 099a4ab93fd46481fd8359f9422897c05178e829c29802739817c0b2aacfba9d [INFO] running `Command { std: "docker" "start" "-a" "099a4ab93fd46481fd8359f9422897c05178e829c29802739817c0b2aacfba9d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "099a4ab93fd46481fd8359f9422897c05178e829c29802739817c0b2aacfba9d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "099a4ab93fd46481fd8359f9422897c05178e829c29802739817c0b2aacfba9d", kill_on_drop: false }` [INFO] [stdout] 099a4ab93fd46481fd8359f9422897c05178e829c29802739817c0b2aacfba9d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:90999bfc7ae267e83380e433d8e61a7c072ca6729e92edbae886d3423b3a6f4c" "/opt/rustwide/cargo-home/bin/cargo" "+c720f49c46ec3e70bbc2bbb3e0dd1fe7fc0a47f2" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d021d6eb2969e8634d45008c0667cfc6428ca648d137ef368759ae2a3c40da55 [INFO] running `Command { std: "docker" "start" "-a" "d021d6eb2969e8634d45008c0667cfc6428ca648d137ef368759ae2a3c40da55", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2024 [INFO] [stderr] Checking libc v0.2.26 [INFO] [stderr] Checking linked-hash-map v0.4.2 [INFO] [stderr] Checking byteorder v1.1.0 [INFO] [stderr] Checking glob v0.2.11 [INFO] [stderr] Checking lru-cache v0.1.1 [INFO] [stderr] Checking memchr v1.0.1 [INFO] [stderr] Checking nom v3.1.0 [INFO] [stderr] Checking soupdb v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/ast/command.rs:23:44 [INFO] [stdout] | [INFO] [stdout] 23 | CreateModel {name: String, schema: Box}, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 23 | CreateModel {name: String, schema: Box}, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/model/mod.rs:24:21 [INFO] [stdout] | [INFO] [stdout] 24 | pub schema: Box, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 24 | pub schema: Box, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around function argument [INFO] [stdout] --> src/ast/parse.rs:610:58 [INFO] [stdout] | [INFO] [stdout] 610 | from: Some(vec![("abc".to_string(), Some({"d".to_string()}))]), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_braces)]` on by default [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 610 - from: Some(vec![("abc".to_string(), Some({"d".to_string()}))]), [INFO] [stdout] 610 + from: Some(vec![("abc".to_string(), Some("d".to_string()))]), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around function argument [INFO] [stdout] --> src/ast/parse.rs:623:58 [INFO] [stdout] | [INFO] [stdout] 623 | from: Some(vec![("abc".to_string(), Some({"d".to_string()}))]), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 623 - from: Some(vec![("abc".to_string(), Some({"d".to_string()}))]), [INFO] [stdout] 623 + from: Some(vec![("abc".to_string(), Some("d".to_string()))]), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/ast/parse.rs:443:53 [INFO] [stdout] | [INFO] [stdout] 443 | fn parser_wrapper(parser: &Fn(&str) -> IResult<&str, T, E>, input: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 443 | fn parser_wrapper(parser: &dyn Fn(&str) -> IResult<&str, T, E>, input: &str) -> Result { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/model/mod.rs:28:42 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn new(name: String, schema: Box) -> Self { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 28 | pub fn new(name: String, schema: Box) -> Self { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/model/mod.rs:44:45 [INFO] [stdout] | [INFO] [stdout] 44 | pub fn write_schema(&self, mut to: &mut Write) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 44 | pub fn write_schema(&self, mut to: &mut dyn Write) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/ast/command.rs:23:44 [INFO] [stdout] | [INFO] [stdout] 23 | CreateModel {name: String, schema: Box}, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 23 | CreateModel {name: String, schema: Box}, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/model/mod.rs:24:21 [INFO] [stdout] | [INFO] [stdout] 24 | pub schema: Box, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 24 | pub schema: Box, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/ast/parse.rs:443:53 [INFO] [stdout] | [INFO] [stdout] 443 | fn parser_wrapper(parser: &Fn(&str) -> IResult<&str, T, E>, input: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 443 | fn parser_wrapper(parser: &dyn Fn(&str) -> IResult<&str, T, E>, input: &str) -> Result { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/model/mod.rs:28:42 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn new(name: String, schema: Box) -> Self { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 28 | pub fn new(name: String, schema: Box) -> Self { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/model/mod.rs:44:45 [INFO] [stdout] | [INFO] [stdout] 44 | pub fn write_schema(&self, mut to: &mut Write) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 44 | pub fn write_schema(&self, mut to: &mut dyn Write) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/db.rs:26:22 [INFO] [stdout] | [INFO] [stdout] 26 | for entry in glob(data_dir.join("*.schema").to_str().unwrap()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 26 - for entry in glob(data_dir.join("*.schema").to_str().unwrap()) { [INFO] [stdout] 26 + while let Ok(entry) = glob(data_dir.join("*.schema").to_str().unwrap()) { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 26 - for entry in glob(data_dir.join("*.schema").to_str().unwrap()) { [INFO] [stdout] 26 + if let Ok(entry) = glob(data_dir.join("*.schema").to_str().unwrap()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/db.rs:26:22 [INFO] [stdout] | [INFO] [stdout] 26 | for entry in glob(data_dir.join("*.schema").to_str().unwrap()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 26 - for entry in glob(data_dir.join("*.schema").to_str().unwrap()) { [INFO] [stdout] 26 + while let Ok(entry) = glob(data_dir.join("*.schema").to_str().unwrap()) { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 26 - for entry in glob(data_dir.join("*.schema").to_str().unwrap()) { [INFO] [stdout] 26 + if let Ok(entry) = glob(data_dir.join("*.schema").to_str().unwrap()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.59s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: nom v3.1.0 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1` [INFO] running `Command { std: "docker" "inspect" "d021d6eb2969e8634d45008c0667cfc6428ca648d137ef368759ae2a3c40da55", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d021d6eb2969e8634d45008c0667cfc6428ca648d137ef368759ae2a3c40da55", kill_on_drop: false }` [INFO] [stdout] d021d6eb2969e8634d45008c0667cfc6428ca648d137ef368759ae2a3c40da55